René's URL Explorer Experiment


Title: fix(docs-infra): do not break when cookies are disabled in the browser by ajitsinghkaler · Pull Request #33829 · angular/angular · GitHub

Open Graph Title: fix(docs-infra): do not break when cookies are disabled in the browser by ajitsinghkaler · Pull Request #33829 · angular/angular

X Title: fix(docs-infra): do not break when cookies are disabled in the browser by ajitsinghkaler · Pull Request #33829 · angular/angular

Description: fix(docs-infra): changed window.sessionStorage to default params when cookies disabled Whenever cookies are disabled windows.sessionStorage is not available for the app so If it throws an error I give it a default value PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? In the current scenario whenever the browser is configured not to accept cookies, the angular.io homepage shows a blank page without any content because windows.sessionStorage is not defined Issue Number: #33795 What is the new behavior? In the new behavior whenever window.sessionStorage is not defined I give it a default value Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: fix(docs-infra): changed window.sessionStorage to default params when cookies disabled Whenever cookies are disabled windows.sessionStorage is not available for the app so If it throws an error I g...

X Description: fix(docs-infra): changed window.sessionStorage to default params when cookies disabled Whenever cookies are disabled windows.sessionStorage is not available for the app so If it throws an error I g...

Opengraph URL: https://github.com/angular/angular/pull/33829

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d57d53ac-d801-70dd-7437-599eb7b9909d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE208:2A2834:4AD45:64A10:6B015BEE
html-safe-nonce66282c60f332c70a9df1d6b4c8852c37ca85e348ae6d559b9ddb83824317d257
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjA4OjJBMjgzNDo0QUQ0NTo2NEExMDo2QjAxNUJFRSIsInZpc2l0b3JfaWQiOiI4MTYyNTYzOTQ2MDIxMjE1MjE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca9f63524125f95efa4b097a95c5ab06c22ce4d5a52b4b3fc12f20a6d49b8eb3c
hovercard-subject-tagpull_request:341105569
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/33829/files
twitter:imagehttps://avatars.githubusercontent.com/u/39260684?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/39260684?s=400&v=4
og:image:altfix(docs-infra): changed window.sessionStorage to default params when cookies disabled Whenever cookies are disabled windows.sessionStorage is not available for the app so If it throws an error I g...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33829/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33829%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33829%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33829/files
Reloadhttps://github.com/angular/angular/pull/33829/files
Reloadhttps://github.com/angular/angular/pull/33829/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ajitsinghkalerhttps://github.com/ajitsinghkaler
angular:masterhttps://github.com/angular/angular/tree/master
ajitsinghkaler:session-storage-bughttps://github.com/ajitsinghkaler/angular/tree/session-storage-bug
Conversation 23 https://github.com/angular/angular/pull/33829
Commits 1 https://github.com/angular/angular/pull/33829/commits
Checks 0 https://github.com/angular/angular/pull/33829/checks
Files changed https://github.com/angular/angular/pull/33829/files
Please reload this pagehttps://github.com/angular/angular/pull/33829/files
fix(docs-infra): do not break when cookies are disabled in the browser https://github.com/angular/angular/pull/33829/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/33829/files
6d3b739 fix(docs-infra): do not break when cookies are disabled in the browser ajitsinghkaler Nov 18, 2019 https://github.com/angular/angular/pull/33829/commits/6d3b739186f9d7b9093b1ec490fd9e37f1f065d6
Clear filters https://github.com/angular/angular/pull/33829/files
Please reload this pagehttps://github.com/angular/angular/pull/33829/files
Please reload this pagehttps://github.com/angular/angular/pull/33829/files
scroll.service.spec.ts https://github.com/angular/angular/pull/33829/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
scroll.service.ts https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
aio/src/app/shared/scroll.service.spec.tshttps://github.com/angular/angular/pull/33829/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
View file https://github.com/ajitsinghkaler/angular/blob/6d3b739186f9d7b9093b1ec490fd9e37f1f065d6/aio/src/app/shared/scroll.service.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33829/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33829/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
https://github.com/angular/angular/pull/33829/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
aio/src/app/shared/scroll.service.tshttps://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
View file https://github.com/ajitsinghkaler/angular/blob/6d3b739186f9d7b9093b1ec490fd9e37f1f065d6/aio/src/app/shared/scroll.service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33829/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
Please reload this pagehttps://github.com/angular/angular/pull/33829/files
https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/33829/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.