René's URL Explorer Experiment


Title: fix(ivy): Run ChangeDetection on moved views by mhevery · Pull Request #33644 · angular/angular · GitHub

Open Graph Title: fix(ivy): Run ChangeDetection on moved views by mhevery · Pull Request #33644 · angular/angular

X Title: fix(ivy): Run ChangeDetection on moved views by mhevery · Pull Request #33644 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/33644

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9826d047-3f81-598b-0d8a-15bfa4635893
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF68:1F7384:11DB986:17A01F9:6B011694
html-safe-noncecc8c0a6b90f3b5dd723bd61df13045cefb8baae37b0ec58e835845e550ba2002
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjY4OjFGNzM4NDoxMURCOTg2OjE3QTAxRjk6NkIwMTE2OTQiLCJ2aXNpdG9yX2lkIjoiNjkzMzU1MjM2NzAwNjcxNzU4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfe43d64abfd3011e5109d04cfbb6954b349a8cd2839c4f00c60eb34f01a9b742
hovercard-subject-tagpull_request:337879382
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33644/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7ce59e3f6c45004c7448580825f710e073e04ffc017e5271c8adbdb5542deba4/angular/angular/pull/33644
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7ce59e3f6c45004c7448580825f710e073e04ffc017e5271c8adbdb5542deba4/angular/angular/pull/33644
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhevery
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/33644#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33644
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33644
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33644
Reloadhttps://github.com/angular/angular/pull/33644
Reloadhttps://github.com/angular/angular/pull/33644
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
mheveryhttps://github.com/mhevery
angular:masterhttps://github.com/angular/angular/tree/master
mhevery:transplant_viewshttps://github.com/mhevery/angular/tree/transplant_views
Conversationhttps://github.com/angular/angular/pull/33644
Commits1 (1)https://github.com/angular/angular/pull/33644/commits
Checkshttps://github.com/angular/angular/pull/33644/checks
Files changedhttps://github.com/angular/angular/pull/33644/files
fix(ivy): Run ChangeDetection on moved viewshttps://github.com/angular/angular/pull/33644#top
mheveryhttps://github.com/mhevery
angular:masterhttps://github.com/angular/angular/tree/master
mhevery:transplant_viewshttps://github.com/mhevery/angular/tree/transplant_views
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Nov 7, 2019https://github.com/angular/angular/pull/33644#issue-519071065
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Nov 7, 2019https://github.com/angular/angular/pull/33644#event-2777932284
https://github.com/mhevery
mheveryhttps://github.com/mhevery
karahttps://github.com/kara
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
November 7, 2019 06:35https://github.com/angular/angular/pull/33644#event-2777932299
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Nov 7, 2019https://github.com/angular/angular/pull/33644#event-2777932350
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 7, 2019https://github.com/angular/angular/pull/33644#event-2777932387
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/ec4352735a3e3bf7462ccacc8f2c76990721e6b3..05fd3c51e7bd8c26f35732c31eda80964c133ece
ec43527https://github.com/angular/angular/commit/ec4352735a3e3bf7462ccacc8f2c76990721e6b3
05fd3c5https://github.com/angular/angular/commit/05fd3c51e7bd8c26f35732c31eda80964c133ece
Compare https://github.com/angular/angular/compare/ec4352735a3e3bf7462ccacc8f2c76990721e6b3..05fd3c51e7bd8c26f35732c31eda80964c133ece
November 7, 2019 06:56https://github.com/angular/angular/pull/33644#event-2777972975
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 7, 2019https://github.com/angular/angular/pull/33644#issuecomment-550940954
VE Presubmithttp://test/OCL:279016656:BASE:279016697:1573110401251:ae1c5b99
Ivy Presubmithttp://test/OCL:279016656:BASE:279016806:1573110467915:1cad5204
Global Ivy Presubmithttps://test.corp.google.com/OCL:279016656:BASE:279016960:1573110567958:11743276
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Nov 7, 2019 https://github.com/angular/angular/pull/33644#pullrequestreview-313372005
View reviewed changes https://github.com/angular/angular/pull/33644/files
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/33644/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Nov 7, 2019https://github.com/angular/angular/pull/33644#discussion_r343675393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33644
mheveryhttps://github.com/mhevery
Nov 8, 2019https://github.com/angular/angular/pull/33644#discussion_r344004400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Nov 7, 2019 https://github.com/angular/angular/pull/33644#pullrequestreview-313373532
View reviewed changes https://github.com/angular/angular/pull/33644/files
packages/core/test/acceptance/view_container_ref_spec.tshttps://github.com/angular/angular/pull/33644/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/550ded3d6990e3434b5000e37e0be2e890588c93..7e015dfc086f1e73f38ceb044a886e1c6ffd8aa5
550ded3https://github.com/angular/angular/commit/550ded3d6990e3434b5000e37e0be2e890588c93
7e015dfhttps://github.com/angular/angular/commit/7e015dfc086f1e73f38ceb044a886e1c6ffd8aa5
Compare https://github.com/angular/angular/compare/550ded3d6990e3434b5000e37e0be2e890588c93..7e015dfc086f1e73f38ceb044a886e1c6ffd8aa5
November 8, 2019 06:31https://github.com/angular/angular/pull/33644#event-2781846595
https://github.com/mhevery
fix(ivy): Run ChangeDetection on transplanted viewshttps://github.com/angular/angular/pull/33644/commits/d26c30210af08140707a2dc488662dc1545a7ebd
d26c302https://github.com/angular/angular/pull/33644/commits/d26c30210af08140707a2dc488662dc1545a7ebd
https://hackmd.io/@mhevery/rJUJsvv9Hhttps://hackmd.io/@mhevery/rJUJsvv9H
angular#33393https://github.com/angular/angular/issues/33393
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/7e015dfc086f1e73f38ceb044a886e1c6ffd8aa5..d26c30210af08140707a2dc488662dc1545a7ebd
7e015dfhttps://github.com/angular/angular/commit/7e015dfc086f1e73f38ceb044a886e1c6ffd8aa5
d26c302https://github.com/angular/angular/commit/d26c30210af08140707a2dc488662dc1545a7ebd
Compare https://github.com/angular/angular/compare/7e015dfc086f1e73f38ceb044a886e1c6ffd8aa5..d26c30210af08140707a2dc488662dc1545a7ebd
November 8, 2019 17:06https://github.com/angular/angular/pull/33644#event-2783914101
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Nov 8, 2019https://github.com/angular/angular/pull/33644#issuecomment-551912608
presubmithttp://test/OCL:279326390:BASE:279326428:1573233010393:a5c671a7
ivy presubmithttp://test/OCL:279326390:BASE:279326612:1573233084961:dabd247e
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Nov 8, 2019 https://github.com/angular/angular/pull/33644#ref-issue-509737272
BUG: IVY change detection on push for component within ng-template not invalidated #33285 https://github.com/angular/angular/issues/33285
https://github.com/mhevery
mheveryhttps://github.com/mhevery
November 8, 2019 23:02https://github.com/angular/angular/pull/33644#event-2784789187
https://github.com/mhevery
mheveryhttps://github.com/mhevery
November 8, 2019 23:02https://github.com/angular/angular/pull/33644#event-2784789208
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Nov 8, 2019 https://github.com/angular/angular/pull/33644#ref-pullrequest-520278378
Transplant views refactor #33702 https://github.com/angular/angular/pull/33702
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 11, 2019https://github.com/angular/angular/pull/33644#event-2788919103
https://github.com/kara
karahttps://github.com/kara
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 12, 2019https://github.com/angular/angular/pull/33644#event-2789735902
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Nov 12, 2019https://github.com/angular/angular/pull/33644#issuecomment-552956667
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Nov 12, 2019https://github.com/angular/angular/pull/33644#event-2792294171
https://github.com/kara
karahttps://github.com/kara
Nov 12, 2019 https://github.com/angular/angular/pull/33644#pullrequestreview-315228260
View reviewed changes https://github.com/angular/angular/pull/33644/files/d26c30210af08140707a2dc488662dc1545a7ebd
karahttps://github.com/kara
https://github.com/angular/angular/pull/33644#pullrequestreview-315228260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33644
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/33644/files/d26c30210af08140707a2dc488662dc1545a7ebd#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/kara
karahttps://github.com/kara
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 12, 2019https://github.com/angular/angular/pull/33644#event-2792724128
https://github.com/kara
karahttps://github.com/kara
mheveryhttps://github.com/mhevery
Nov 12, 2019https://github.com/angular/angular/pull/33644#event-2792724335
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Nov 12, 2019https://github.com/angular/angular/pull/33644#event-2793021095
https://github.com/kara
karahttps://github.com/kara
mheveryhttps://github.com/mhevery
Nov 12, 2019https://github.com/angular/angular/pull/33644#event-2793149103
https://github.com/kara
karahttps://github.com/kara
b62b11bhttps://github.com/angular/angular/commit/b62b11bd6b239e62e475fcf3fe12c4d9a0738f7e
Nov 12, 2019https://github.com/angular/angular/pull/33644#event-2793151397
karahttps://github.com/kara
Nov 12, 2019 https://github.com/angular/angular/pull/33644#ref-commit-37ae45e
https://github.com/mhevery
https://github.com/kara
fix(ivy): Run ChangeDetection on transplanted views (https://github.com/angular/angular/commit/37ae45e2ece867fd9980832908e8edec924b38d4
#33644https://github.com/angular/angular/pull/33644
)https://github.com/angular/angular/commit/37ae45e2ece867fd9980832908e8edec924b38d4
37ae45ehttps://github.com/angular/angular/commit/37ae45e2ece867fd9980832908e8edec924b38d4
https://hackmd.io/@mhevery/rJUJsvv9Hhttps://hackmd.io/@mhevery/rJUJsvv9H
#33393https://github.com/angular/angular/issues/33393
#33644https://github.com/angular/angular/pull/33644
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 13, 2019https://github.com/angular/angular/pull/33644#issuecomment-565497442
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 13, 2019https://github.com/angular/angular/pull/33644#event-2881849708
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33644
https://github.com/pkozlowski-opensource
pkozlowski-opensource https://github.com/pkozlowski-opensource
https://github.com/angular/angular/pull/33644/files/05fd3c51e7bd8c26f35732c31eda80964c133ece
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/33644/files/d26c30210af08140707a2dc488662dc1545a7ebd
Please reload this pagehttps://github.com/angular/angular/pull/33644
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/33644
https://github.com/mhevery
https://github.com/AndrewKushnir
https://github.com/pkozlowski-opensource
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.