René's URL Explorer Experiment


Title: fix(core): make QueryList implement Iterable in the type system by alxhub · Pull Request #33536 · angular/angular · GitHub

Open Graph Title: fix(core): make QueryList implement Iterable in the type system by alxhub · Pull Request #33536 · angular/angular

X Title: fix(core): make QueryList implement Iterable in the type system by alxhub · Pull Request #33536 · angular/angular

Description: Originally, QueryList implemented Iterable and provided a Symbol.iterator on its prototype. This caused issues with tree-shaking, so QueryList was refactored and the Symbol.iterator added in its constructor instead. As part of this change, QueryList no longer implemented Iterable directly. Unfortunately, this meant that QueryList was no longer assignable to Iterable or, consequently, NgIterable. NgIterable is used for NgFor's input, so this meant that QueryList was not usable (in a type sense) for NgFor iteration. View Engine's template type checking would not catch this, but Ivy's did. As a fix, this commit adds the declaration (but not the implementation) of the Symbol.iterator function back to QueryList. This has no runtime effect, so it doesn't affect tree-shaking of QueryList, but it ensures that QueryList is assignable to NgIterable and thus usable with NgFor. Fixes #29842

Open Graph Description: Originally, QueryList implemented Iterable and provided a Symbol.iterator on its prototype. This caused issues with tree-shaking, so QueryList was refactored and the Symbol.iterator added in its co...

X Description: Originally, QueryList implemented Iterable and provided a Symbol.iterator on its prototype. This caused issues with tree-shaking, so QueryList was refactored and the Symbol.iterator added in its co...

Opengraph URL: https://github.com/angular/angular/pull/33536

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8c933f67-fd3f-e78e-909b-58ccf3c1a66f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2D2:291B58:1AB803F:21D4F46:6B018AEE
html-safe-noncebd92ee35d5324d6b899043ff6fc178eddeadae59bb874555dc142a44625f4d3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkQyOjI5MUI1ODoxQUI4MDNGOjIxRDRGNDY6NkIwMThBRUUiLCJ2aXNpdG9yX2lkIjoiNDkxMzY4MDkxNjE1NDUxODI1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca021772afe7a889f04b49d22dcd6915e2b9f7211e44e23e6549ba7b4e8d4d5a1
hovercard-subject-tagpull_request:335593761
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/33536/files
twitter:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
og:image:altOriginally, QueryList implemented Iterable and provided a Symbol.iterator on its prototype. This caused issues with tree-shaking, so QueryList was refactored and the Symbol.iterator added in its co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33536/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33536%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33536%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33536/files
Reloadhttps://github.com/angular/angular/pull/33536/files
Reloadhttps://github.com/angular/angular/pull/33536/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
alxhub:core/querylist-iterablehttps://github.com/alxhub/angular/tree/core/querylist-iterable
Conversation 5 https://github.com/angular/angular/pull/33536
Commits 1 https://github.com/angular/angular/pull/33536/commits
Checks 0 https://github.com/angular/angular/pull/33536/checks
Files changed https://github.com/angular/angular/pull/33536/files
Please reload this pagehttps://github.com/angular/angular/pull/33536/files
fix(core): make QueryList implement Iterable in the type system https://github.com/angular/angular/pull/33536/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/33536/files
fa75d1a fix(core): make QueryList implement Iterable in the type system alxhub Nov 1, 2019 https://github.com/angular/angular/pull/33536/commits/fa75d1a2634b3a4461d86bf39c241819659d4ae9
Clear filters https://github.com/angular/angular/pull/33536/files
Please reload this pagehttps://github.com/angular/angular/pull/33536/files
Please reload this pagehttps://github.com/angular/angular/pull/33536/files
index.ts https://github.com/angular/angular/pull/33536/files#diff-753068f3cae615a8c03f853e1fea4810745460c83b35ae67d4f8ac81ab89ce96
template_typecheck_spec.ts https://github.com/angular/angular/pull/33536/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
query_list.ts https://github.com/angular/angular/pull/33536/files#diff-28d6add596d41a073a75f60a25bddf1655300ea5afc2b09b8bced28f64f02675
query_list_spec.ts https://github.com/angular/angular/pull/33536/files#diff-358982ab8c42a843cecce9378d542f5f87dfac6c38ac5cc6beef64d35ee9dbde
core.d.ts https://github.com/angular/angular/pull/33536/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
index.bzl https://github.com/angular/angular/pull/33536/files#diff-128818f1a5ddc04080e724adc2f16465df853115440c6d1dd976fc84892471cf
packages/compiler-cli/test/ngtsc/fake_core/index.tshttps://github.com/angular/angular/pull/33536/files#diff-753068f3cae615a8c03f853e1fea4810745460c83b35ae67d4f8ac81ab89ce96
View file https://github.com/alxhub/angular/blob/fa75d1a2634b3a4461d86bf39c241819659d4ae9/packages/compiler-cli/test/ngtsc/fake_core/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33536/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33536/files#diff-753068f3cae615a8c03f853e1fea4810745460c83b35ae67d4f8ac81ab89ce96
packages/compiler-cli/test/ngtsc/template_typecheck_spec.tshttps://github.com/angular/angular/pull/33536/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
View file https://github.com/alxhub/angular/blob/fa75d1a2634b3a4461d86bf39c241819659d4ae9/packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33536/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33536/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
https://github.com/angular/angular/pull/33536/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
https://github.com/angular/angular/pull/33536/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
https://github.com/angular/angular/pull/33536/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
https://github.com/angular/angular/pull/33536/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
packages/core/src/linker/query_list.tshttps://github.com/angular/angular/pull/33536/files#diff-28d6add596d41a073a75f60a25bddf1655300ea5afc2b09b8bced28f64f02675
View file https://github.com/alxhub/angular/blob/fa75d1a2634b3a4461d86bf39c241819659d4ae9/packages/core/src/linker/query_list.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33536/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33536/files#diff-28d6add596d41a073a75f60a25bddf1655300ea5afc2b09b8bced28f64f02675
https://github.com/angular/angular/pull/33536/files#diff-28d6add596d41a073a75f60a25bddf1655300ea5afc2b09b8bced28f64f02675
https://github.com/angular/angular/pull/33536/files#diff-28d6add596d41a073a75f60a25bddf1655300ea5afc2b09b8bced28f64f02675
Splaktarhttps://github.com/Splaktar
Nov 3, 2019https://github.com/angular/angular/pull/33536/files#r341870765
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://www.typescriptlang.org/docs/handbook/symbols.htmlhttps://www.typescriptlang.org/docs/handbook/symbols.html
Please reload this pagehttps://github.com/angular/angular/pull/33536/files
packages/core/test/linker/query_list_spec.tshttps://github.com/angular/angular/pull/33536/files#diff-358982ab8c42a843cecce9378d542f5f87dfac6c38ac5cc6beef64d35ee9dbde
View file https://github.com/alxhub/angular/blob/fa75d1a2634b3a4461d86bf39c241819659d4ae9/packages/core/test/linker/query_list_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33536/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33536/files#diff-358982ab8c42a843cecce9378d542f5f87dfac6c38ac5cc6beef64d35ee9dbde
https://github.com/angular/angular/pull/33536/files#diff-358982ab8c42a843cecce9378d542f5f87dfac6c38ac5cc6beef64d35ee9dbde
tools/public_api_guard/core/core.d.tshttps://github.com/angular/angular/pull/33536/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
View file https://github.com/alxhub/angular/blob/fa75d1a2634b3a4461d86bf39c241819659d4ae9/tools/public_api_guard/core/core.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33536/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33536/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
https://github.com/angular/angular/pull/33536/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
tools/ts-api-guardian/index.bzlhttps://github.com/angular/angular/pull/33536/files#diff-128818f1a5ddc04080e724adc2f16465df853115440c6d1dd976fc84892471cf
View file https://github.com/alxhub/angular/blob/fa75d1a2634b3a4461d86bf39c241819659d4ae9/tools/ts-api-guardian/index.bzl
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33536/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33536/files#diff-128818f1a5ddc04080e724adc2f16465df853115440c6d1dd976fc84892471cf
https://github.com/angular/angular/pull/33536/files#diff-128818f1a5ddc04080e724adc2f16465df853115440c6d1dd976fc84892471cf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.