René's URL Explorer Experiment


Title: fix(ivy): ensure module scope is rebuild on dependent change by JoostK · Pull Request #33522 · angular/angular · GitHub

Open Graph Title: fix(ivy): ensure module scope is rebuild on dependent change by JoostK · Pull Request #33522 · angular/angular

X Title: fix(ivy): ensure module scope is rebuild on dependent change by JoostK · Pull Request #33522 · angular/angular

Description: During incremental compilations, ngtsc needs to know which metadata from a previous compilation can be reused, versus which metadata has to be recomputed as some dependency was updated. Changes to directives/components should cause the NgModule in which they are declared to be recompiled, as the NgModule's compilation is dependent on its directives/components. When a dependent source file of a directive/component is updated, however, a more subtle dependency should also cause to NgModule's source file to be invalidated. During the reconciliation of state from a previous compilation into the new program, the component's source file is invalidated because one of its dependency has changed, ergo the NgModule needs to be invalidated as well. Up until now, this implicit dependency was not imposed on the NgModule. Additionally, any change to a dependent file may influence the module scope to change, so all components within the module must be invalidated as well. This commit fixes the bug by introducing additional file dependencies, as to ensure a proper rebuild of the module scope and its components. Fixes #32416

Open Graph Description: During incremental compilations, ngtsc needs to know which metadata from a previous compilation can be reused, versus which metadata has to be recomputed as some dependency was updated. Changes to ...

X Description: During incremental compilations, ngtsc needs to know which metadata from a previous compilation can be reused, versus which metadata has to be recomputed as some dependency was updated. Changes to ...

Opengraph URL: https://github.com/angular/angular/pull/33522

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:24ecf8a4-bd6c-492c-9d83-344ff67e72a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7F0:EDA7A:1ADF566:221E50A:6B014F43
html-safe-nonced5b2f864401d730a6224bb031f52939b477ea2827e096eda76daaddb6a196780
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0YwOkVEQTdBOjFBREY1NjY6MjIxRTUwQTo2QjAxNEY0MyIsInZpc2l0b3JfaWQiOiI1NDg5NDg3ODE5ODE2NjUyNjExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac506d972dafe4d08d25d643b6d73353277b9a851148c73a71ef1ccfad118cc11b
hovercard-subject-tagpull_request:335152700
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/33522/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altDuring incremental compilations, ngtsc needs to know which metadata from a previous compilation can be reused, versus which metadata has to be recomputed as some dependency was updated. Changes to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33522/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33522%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33522%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33522/files
Reloadhttps://github.com/angular/angular/pull/33522/files
Reloadhttps://github.com/angular/angular/pull/33522/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngtsc-fix-incremental-buildshttps://github.com/JoostK/angular/tree/ngtsc-fix-incremental-builds
Conversation 5 https://github.com/angular/angular/pull/33522
Commits 1 https://github.com/angular/angular/pull/33522/commits
Checks 0 https://github.com/angular/angular/pull/33522/checks
Files changed https://github.com/angular/angular/pull/33522/files
Please reload this pagehttps://github.com/angular/angular/pull/33522/files
fix(ivy): ensure module scope is rebuild on dependent change https://github.com/angular/angular/pull/33522/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/33522/files
c898090 fix(ivy): ensure module scope is rebuild on dependent change JoostK Oct 31, 2019 https://github.com/angular/angular/pull/33522/commits/c8980904784ca0142bb0d04bcb09c37089a6d857
Clear filters https://github.com/angular/angular/pull/33522/files
Please reload this pagehttps://github.com/angular/angular/pull/33522/files
Please reload this pagehttps://github.com/angular/angular/pull/33522/files
state.ts https://github.com/angular/angular/pull/33522/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
compilation.ts https://github.com/angular/angular/pull/33522/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
incremental_spec.ts https://github.com/angular/angular/pull/33522/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
packages/compiler-cli/src/ngtsc/incremental/src/state.tshttps://github.com/angular/angular/pull/33522/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
View file https://github.com/JoostK/angular/blob/c8980904784ca0142bb0d04bcb09c37089a6d857/packages/compiler-cli/src/ngtsc/incremental/src/state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33522/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33522/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
https://github.com/angular/angular/pull/33522/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
packages/compiler-cli/src/ngtsc/transform/src/compilation.tshttps://github.com/angular/angular/pull/33522/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
View file https://github.com/JoostK/angular/blob/c8980904784ca0142bb0d04bcb09c37089a6d857/packages/compiler-cli/src/ngtsc/transform/src/compilation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33522/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33522/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
https://github.com/angular/angular/pull/33522/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
packages/compiler-cli/test/ngtsc/incremental_spec.tshttps://github.com/angular/angular/pull/33522/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
View file https://github.com/JoostK/angular/blob/c8980904784ca0142bb0d04bcb09c37089a6d857/packages/compiler-cli/test/ngtsc/incremental_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33522/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33522/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
https://github.com/angular/angular/pull/33522/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.