| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bfc50f17-13f8-1403-88e9-81e1c65ab7b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 964A:3DD488:1511007:1AB731D:6B013053 |
| html-safe-nonce | 28763000bcaafae3c80cf6f29ec5fe790c902be96a2c2bb4a7fa3038e1052e8b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjRBOjNERDQ4ODoxNTExMDA3OjFBQjczMUQ6NkIwMTMwNTMiLCJ2aXNpdG9yX2lkIjoiMjcxNDI1Njc0Njg4MDI0OTkzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 04d08ce00f880df4bf13d65a9113a814cfdcbf6b85d32317a6fcb14793ca0a07 |
| hovercard-subject-tag | pull_request:331697036 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33362/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/085a9bd6eb7591fa7cca7d5cd523f2d2e4b37ace28b41e34db52931709695961/angular/angular/pull/33362 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/085a9bd6eb7591fa7cca7d5cd523f2d2e4b37ace28b41e34db52931709695961/angular/angular/pull/33362 |
| og:image:alt | PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alxhub |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/33362#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/33362 |
| Reload | https://github.com/angular/angular/pull/33362 |
| Reload | https://github.com/angular/angular/pull/33362 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| alxhub | https://github.com/alxhub |
| angular:master | https://github.com/angular/angular/tree/master |
| alxhub:ngcc/migrations | https://github.com/alxhub/angular/tree/ngcc/migrations |
| Conversation | https://github.com/angular/angular/pull/33362 |
| Commits7 (7) | https://github.com/angular/angular/pull/33362/commits |
| Checks | https://github.com/angular/angular/pull/33362/checks |
| Files changed | https://github.com/angular/angular/pull/33362/files |
| All ngcc migrations | https://github.com/angular/angular/pull/33362#top |
| alxhub | https://github.com/alxhub |
| angular:master | https://github.com/angular/angular/tree/master |
| alxhub:ngcc/migrations | https://github.com/alxhub/angular/tree/ngcc/migrations |
|
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#issue-511513235 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-545589433 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#event-2738218032 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Oct 23, 2019
| https://github.com/angular/angular/pull/33362#pullrequestreview-306151376 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33362/files |
| JoostK | https://github.com/JoostK |
| https://github.com/angular/angular/pull/33362#pullrequestreview-306151376 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/src/migrations/undecorated_child_migration.ts | https://github.com/angular/angular/pull/33362/files#diff-70a8a09f007922f3df3a03e6ef6a6c17f6083c37a4a11662faacf0b9edc3d4dd |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/src/migrations/undecorated_child_migration.ts | https://github.com/angular/angular/pull/33362/files#diff-70a8a09f007922f3df3a03e6ef6a6c17f6083c37a4a11662faacf0b9edc3d4dd |
| JoostK | https://github.com/JoostK |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338249574 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @petebacondarwin | https://github.com/petebacondarwin |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338270816 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/test/integration/util.ts | https://github.com/angular/angular/pull/33362/files#diff-1679b296bcd06e86ebda5eebdbeb82e4fd71ea3f22e348075c0a1e98ff392ed3 |
| JoostK | https://github.com/JoostK |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338257676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338272153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/test/integration/util.ts | https://github.com/angular/angular/pull/33362/files#diff-1679b296bcd06e86ebda5eebdbeb82e4fd71ea3f22e348075c0a1e98ff392ed3 |
| JoostK | https://github.com/JoostK |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338258294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/test/integration/util.ts | https://github.com/angular/angular/pull/33362/files#diff-1679b296bcd06e86ebda5eebdbeb82e4fd71ea3f22e348075c0a1e98ff392ed3 |
| JoostK | https://github.com/JoostK |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338258958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/src/ngtsc/transform/src/api.ts | https://github.com/angular/angular/pull/33362/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/core/src/render3/features/copy_definition_feature.ts | https://github.com/angular/angular/pull/33362/files#diff-31ef5cfd6756a9a1952613bbc3be62818f3f02b127b273a54c082bd72cb41529 |
| JoostK | https://github.com/JoostK |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338267552 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/core/src/render3/features/copy_definition_feature.ts | https://github.com/angular/angular/pull/33362/files#diff-31ef5cfd6756a9a1952613bbc3be62818f3f02b127b273a54c082bd72cb41529 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/core/src/render3/features/copy_definition_feature.ts | https://github.com/angular/angular/pull/33362/files#diff-31ef5cfd6756a9a1952613bbc3be62818f3f02b127b273a54c082bd72cb41529 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler/src/render3/view/compiler.ts | https://github.com/angular/angular/pull/33362/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6 |
| JoostK | https://github.com/JoostK |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338269535 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338304487 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338335694 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @kara | https://github.com/kara |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| force-pushed | https://github.com/angular/angular/compare/0750fc8ee889683884be5681692c9a845047f476..4f22811f81fc8a583667b30f5f9ee15e84715f5f |
| 0750fc8 | https://github.com/angular/angular/commit/0750fc8ee889683884be5681692c9a845047f476 |
| 4f22811 | https://github.com/angular/angular/commit/4f22811f81fc8a583667b30f5f9ee15e84715f5f |
|
Compare
| https://github.com/angular/angular/compare/0750fc8ee889683884be5681692c9a845047f476..4f22811f81fc8a583667b30f5f9ee15e84715f5f |
| October 23, 2019 23:58 | https://github.com/angular/angular/pull/33362#event-2738922237 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#event-2738960689 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-545689875 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#event-2738961044 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| kara | https://github.com/kara |
| October 24, 2019 00:25 | https://github.com/angular/angular/pull/33362#event-2738961273 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 24, 2019
| https://github.com/angular/angular/pull/33362#pullrequestreview-306406248 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33362/files |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/33362#pullrequestreview-306406248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/src/migrations/utils.ts | https://github.com/angular/angular/pull/33362/files#diff-3bef6b526e40c722163a637ac3c90c40f0d2056b2b634c72e4e85914527da2e7 |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338449150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338751296 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/src/ngtsc/transform/src/api.ts | https://github.com/angular/angular/pull/33362/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8 |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338454766 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338751269 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/src/ngtsc/transform/src/api.ts | https://github.com/angular/angular/pull/33362/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8 |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338456560 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338751646 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/src/migrations/undecorated_child_migration.ts | https://github.com/angular/angular/pull/33362/files#diff-70a8a09f007922f3df3a03e6ef6a6c17f6083c37a4a11662faacf0b9edc3d4dd |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338462081 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/src/migrations/undecorated_child_migration.ts | https://github.com/angular/angular/pull/33362/files#diff-70a8a09f007922f3df3a03e6ef6a6c17f6083c37a4a11662faacf0b9edc3d4dd |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338463514 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/src/migrations/undecorated_child_migration.ts | https://github.com/angular/angular/pull/33362/files#diff-70a8a09f007922f3df3a03e6ef6a6c17f6083c37a4a11662faacf0b9edc3d4dd |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338463899 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338752238 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/test/integration/util.ts | https://github.com/angular/angular/pull/33362/files#diff-1679b296bcd06e86ebda5eebdbeb82e4fd71ea3f22e348075c0a1e98ff392ed3 |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338470614 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| alxhub | https://github.com/alxhub |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#discussion_r338754348 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Oct 24, 2019
| https://github.com/angular/angular/pull/33362#pullrequestreview-306262022 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33362/files |
| kara | https://github.com/kara |
| https://github.com/angular/angular/pull/33362#pullrequestreview-306262022 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/core/src/render3/features/copy_definition_feature.ts | https://github.com/angular/angular/pull/33362/files#diff-31ef5cfd6756a9a1952613bbc3be62818f3f02b127b273a54c082bd72cb41529 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts | https://github.com/angular/angular/pull/33362/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| packages/core/src/render3/features/copy_definition_feature.ts | https://github.com/angular/angular/pull/33362/files#diff-31ef5cfd6756a9a1952613bbc3be62818f3f02b127b273a54c082bd72cb41529 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/kara |
| kara | https://github.com/kara |
| October 24, 2019 18:59 | https://github.com/angular/angular/pull/33362#event-2741873224 |
| https://github.com/kara |
| kara | https://github.com/kara |
| October 24, 2019 18:59 | https://github.com/angular/angular/pull/33362#event-2741873234 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Oct 24, 2019
| https://github.com/angular/angular/pull/33362#ref-pullrequest-509656650 |
|
feat(ngcc): execute schematic-like migrations in ngcc
#33279
| https://github.com/angular/angular/pull/33279 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| force-pushed | https://github.com/angular/angular/compare/4f22811f81fc8a583667b30f5f9ee15e84715f5f..5144be25737003781db8381999469890aed7b1b3 |
| 4f22811 | https://github.com/angular/angular/commit/4f22811f81fc8a583667b30f5f9ee15e84715f5f |
| 5144be2 | https://github.com/angular/angular/commit/5144be25737003781db8381999469890aed7b1b3 |
|
Compare
| https://github.com/angular/angular/compare/4f22811f81fc8a583667b30f5f9ee15e84715f5f..5144be25737003781db8381999469890aed7b1b3 |
| October 24, 2019 19:21 | https://github.com/angular/angular/pull/33362#event-2741932625 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546064925 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#event-2741933044 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Oct 24, 2019
| https://github.com/angular/angular/pull/33362#pullrequestreview-306810413 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33362/files |
| kara | https://github.com/kara |
| https://github.com/angular/angular/pull/33362#pullrequestreview-306810413 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| force-pushed | https://github.com/angular/angular/compare/ae402b55ef4ddf1b5ec744235520968a476f60f3..e015bdda81020d0fbf1f3a882fdd68a395287fe5 |
| ae402b5 | https://github.com/angular/angular/commit/ae402b55ef4ddf1b5ec744235520968a476f60f3 |
| e015bdd | https://github.com/angular/angular/commit/e015bdda81020d0fbf1f3a882fdd68a395287fe5 |
|
Compare
| https://github.com/angular/angular/compare/ae402b55ef4ddf1b5ec744235520968a476f60f3..e015bdda81020d0fbf1f3a882fdd68a395287fe5 |
| October 24, 2019 22:42 | https://github.com/angular/angular/pull/33362#event-2742434866 |
| JoostK | https://github.com/JoostK |
| October 24, 2019 16:19 | https://github.com/angular/angular/pull/33362#commits-pushed-5c427c5 |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
| fix(ngcc): prevent reflected decorators from being clobbered | https://github.com/angular/angular/pull/33362/commits/5c427c5276438c3581842553679e7f88216fa92d |
| 5c427c5 | https://github.com/angular/angular/pull/33362/commits/5c427c5276438c3581842553679e7f88216fa92d |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
| feat(ngcc): migrate services that are missing @Injectable() | https://github.com/angular/angular/pull/33362/commits/77200880561c96a5aacc8ed08d8134c055e83641 |
| 7720088 | https://github.com/angular/angular/pull/33362/commits/77200880561c96a5aacc8ed08d8134c055e83641 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| force-pushed | https://github.com/angular/angular/compare/e015bdda81020d0fbf1f3a882fdd68a395287fe5..d3998f064519203fae877bbdf19a157541fe5056 |
| e015bdd | https://github.com/angular/angular/commit/e015bdda81020d0fbf1f3a882fdd68a395287fe5 |
| d3998f0 | https://github.com/angular/angular/commit/d3998f064519203fae877bbdf19a157541fe5056 |
|
Compare
| https://github.com/angular/angular/compare/e015bdda81020d0fbf1f3a882fdd68a395287fe5..d3998f064519203fae877bbdf19a157541fe5056 |
| October 24, 2019 23:29 | https://github.com/angular/angular/pull/33362#event-2742508367 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33362#event-2742510070 |
| https://github.com/kara |
| kara | https://github.com/kara |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546151841 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#event-2742587521 |
| JoostK | https://github.com/JoostK |
| October 24, 2019 17:29 | https://github.com/angular/angular/pull/33362#commits-pushed-c8cfa3e |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
| refactor(ivy): mark synthetic decorators explicitly | https://github.com/angular/angular/pull/33362/commits/c8cfa3ec1f2ab73185aa3e40f80b08a348f73e1c |
| c8cfa3e | https://github.com/angular/angular/pull/33362/commits/c8cfa3ec1f2ab73185aa3e40f80b08a348f73e1c |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
| refactor(ngcc): rework undecorated parent migration | https://github.com/angular/angular/pull/33362/commits/e28043dc31c680a790db12a7e5c2cc74bea121c4 |
| e28043d | https://github.com/angular/angular/pull/33362/commits/e28043dc31c680a790db12a7e5c2cc74bea121c4 |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
| feat(ngcc): enable migrations to apply schematics to libraries | https://github.com/angular/angular/pull/33362/commits/1af6a29946fad32c67c539138561f0e5e7c57c09 |
| 1af6a29 | https://github.com/angular/angular/pull/33362/commits/1af6a29946fad32c67c539138561f0e5e7c57c09 |
|
| https://github.com/alxhub |
| feat(ivy): add a runtime feature to copy cmp/dir definitions | https://github.com/angular/angular/pull/33362/commits/cc29841bef27c79ab6f270bd7bd8eec212edabb2 |
| cc29841 | https://github.com/angular/angular/pull/33362/commits/cc29841bef27c79ab6f270bd7bd8eec212edabb2 |
| @component | https://github.com/component |
| @directive | https://github.com/directive |
|
| https://github.com/alxhub |
| feat(ngcc): add a migration for undecorated child classes | https://github.com/angular/angular/pull/33362/commits/f1b630213430e106bd59cbd4884fe2c1c62fbd67 |
| f1b6302 | https://github.com/angular/angular/pull/33362/commits/f1b630213430e106bd59cbd4884fe2c1c62fbd67 |
| @component | https://github.com/component |
| @directive | https://github.com/directive |
| @input | https://github.com/input |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| force-pushed | https://github.com/angular/angular/compare/d3998f064519203fae877bbdf19a157541fe5056..f1b630213430e106bd59cbd4884fe2c1c62fbd67 |
| d3998f0 | https://github.com/angular/angular/commit/d3998f064519203fae877bbdf19a157541fe5056 |
| f1b6302 | https://github.com/angular/angular/commit/f1b630213430e106bd59cbd4884fe2c1c62fbd67 |
|
Compare
| https://github.com/angular/angular/compare/d3998f064519203fae877bbdf19a157541fe5056..f1b630213430e106bd59cbd4884fe2c1c62fbd67 |
| October 25, 2019 00:29 | https://github.com/angular/angular/pull/33362#event-2742590455 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546152720 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#event-2742590622 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546153445 |
| VE Presubmit | http://test/OCL:276600395:BASE:276600439:1571963381083:f634a203 |
| Ivy Presubmit | http://test/OCL:276600395:BASE:276600939:1571963612175:dcc9ed4 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#event-2742595963 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546153607 |
| build failures in g3 | https://test.corp.google.com/ui#id=OCL:276600395:BASE:276600439:1571963381083:f634a203 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#event-2742617018 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546156687 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546157008 |
| VE Presubmit | http://test/OCL:276603636:BASE:276603684:1571964801520:a7fd8b91 |
| Ivy Presubmit | http://test/OCL:276603636:BASE:276603752:1571964843444:77933a48 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-546417460 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#event-2744745614 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| 0de2dbf | https://github.com/angular/angular/commit/0de2dbfec191bfaa9e6de179ed6a3491f29bc34c |
| Oct 25, 2019 | https://github.com/angular/angular/pull/33362#event-2744748292 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Oct 25, 2019
| https://github.com/angular/angular/pull/33362#ref-commit-31b9492 |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
| feat(ngcc): migrate services that are missing | https://github.com/angular/angular/commit/31b94929516ac9a222b96d7ffd150bf44f17b8bc |
| @Injectable() | https://github.com/angular/angular/commit/31b94929516ac9a222b96d7ffd150bf44f17b8bc |
| ( | https://github.com/angular/angular/commit/31b94929516ac9a222b96d7ffd150bf44f17b8bc |
| #33362 | https://github.com/angular/angular/pull/33362 |
| ) | https://github.com/angular/angular/commit/31b94929516ac9a222b96d7ffd150bf44f17b8bc |
| 31b9492 | https://github.com/angular/angular/commit/31b94929516ac9a222b96d7ffd150bf44f17b8bc |
| #33362 | https://github.com/angular/angular/pull/33362 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Oct 25, 2019
| https://github.com/angular/angular/pull/33362#ref-commit-3858b26 |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
| refactor(ivy): mark synthetic decorators explicitly ( | https://github.com/angular/angular/commit/3858b26211f55dbbae9be819a64a475d8291c217 |
| #33362 | https://github.com/angular/angular/pull/33362 |
| ) | https://github.com/angular/angular/commit/3858b26211f55dbbae9be819a64a475d8291c217 |
| 3858b26 | https://github.com/angular/angular/commit/3858b26211f55dbbae9be819a64a475d8291c217 |
| #33362 | https://github.com/angular/angular/pull/33362 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Oct 25, 2019
| https://github.com/angular/angular/pull/33362#ref-commit-2e5e1dd |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
| refactor(ngcc): rework undecorated parent migration ( | https://github.com/angular/angular/commit/2e5e1dd5f54a06d342e460f32dfcbad1549f57a7 |
| #33362 | https://github.com/angular/angular/pull/33362 |
| ) | https://github.com/angular/angular/commit/2e5e1dd5f54a06d342e460f32dfcbad1549f57a7 |
| 2e5e1dd | https://github.com/angular/angular/commit/2e5e1dd5f54a06d342e460f32dfcbad1549f57a7 |
| #33362 | https://github.com/angular/angular/pull/33362 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Oct 25, 2019
| https://github.com/angular/angular/pull/33362#ref-commit-6b26748 |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
| feat(ngcc): enable migrations to apply schematics to libraries ( | https://github.com/angular/angular/commit/6b267482d7ba9ec12d0a13eb7bba85a916d0e242 |
| #33362 | https://github.com/angular/angular/pull/33362 |
| ) | https://github.com/angular/angular/commit/6b267482d7ba9ec12d0a13eb7bba85a916d0e242 |
| 6b26748 | https://github.com/angular/angular/commit/6b267482d7ba9ec12d0a13eb7bba85a916d0e242 |
| #33362 | https://github.com/angular/angular/pull/33362 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Oct 25, 2019
| https://github.com/angular/angular/pull/33362#ref-commit-818c514 |
|
| https://github.com/alxhub |
|
| https://github.com/AndrewKushnir |
| feat(ivy): add a runtime feature to copy cmp/dir definitions ( | https://github.com/angular/angular/commit/818c51496861720a5039e8bff28ec1887c01327d |
| #33362 | https://github.com/angular/angular/pull/33362 |
| ) | https://github.com/angular/angular/commit/818c51496861720a5039e8bff28ec1887c01327d |
| 818c514 | https://github.com/angular/angular/commit/818c51496861720a5039e8bff28ec1887c01327d |
| @component | https://github.com/component |
| @directive | https://github.com/directive |
| #33362 | https://github.com/angular/angular/pull/33362 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Oct 25, 2019
| https://github.com/angular/angular/pull/33362#ref-commit-b381497 |
|
| https://github.com/alxhub |
|
| https://github.com/AndrewKushnir |
| feat(ngcc): add a migration for undecorated child classes ( | https://github.com/angular/angular/commit/b381497126c58321290bd7df5b90ddbb903bed5a |
| #33362 | https://github.com/angular/angular/pull/33362 |
| ) | https://github.com/angular/angular/commit/b381497126c58321290bd7df5b90ddbb903bed5a |
| b381497 | https://github.com/angular/angular/commit/b381497126c58321290bd7df5b90ddbb903bed5a |
| @component | https://github.com/component |
| @directive | https://github.com/directive |
| @input | https://github.com/input |
| #33362 | https://github.com/angular/angular/pull/33362 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Nov 25, 2019 | https://github.com/angular/angular/pull/33362#issuecomment-558225597 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Nov 25, 2019 | https://github.com/angular/angular/pull/33362#event-2828710403 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33362 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/33362/files/0750fc8ee889683884be5681692c9a845047f476 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/33362/files/4f22811f81fc8a583667b30f5f9ee15e84715f5f |
|
| https://github.com/kara |
|
kara
| https://github.com/kara |
|
| https://github.com/angular/angular/pull/33362/files/5144be25737003781db8381999469890aed7b1b3 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Please reload this page | https://github.com/angular/angular/pull/33362 |
|
| https://github.com/alxhub |
|
| https://github.com/googlebot |
|
| https://github.com/kara |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/JoostK |
|
| https://github.com/gkalpak |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |