| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e18514b2-c0e7-a3a8-b941-92cb4abbc773 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE98:29FFA9:1570D30:1B30186:6B012E3F |
| html-safe-nonce | a75fd1a3e138618635a7fa434146ac2fde1b542e1b98788aecc481b7a841c5e5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTk4OjI5RkZBOToxNTcwRDMwOjFCMzAxODY6NkIwMTJFM0YiLCJ2aXNpdG9yX2lkIjoiNjc3ODkyMjUzNjM0OTU0Mzk5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0c6dcaa5425833cf9d8804113c633ebcd26d28e6c16dccabfef8f589d3686ff9 |
| hovercard-subject-tag | pull_request:331507118 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33351/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e7e55ca47a1ba25e5005714cdb340f730d407e3c5f4e4c7144e0a36eaaf1e4f8/angular/angular/pull/33351 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7e55ca47a1ba25e5005714cdb340f730d407e3c5f4e4c7144e0a36eaaf1e4f8/angular/angular/pull/33351 |
| og:image:alt | This PR switches to using NavigationNode#tooltip in aio-top-menu items and highlights the currently active node in top-bar. See individual commits for more details.
Related to #33239 and #33255. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/33351#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33351 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33351 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/33351 |
| Reload | https://github.com/angular/angular/pull/33351 |
| Reload | https://github.com/angular/angular/pull/33351 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-aio-highlight-topbar | https://github.com/gkalpak/angular/tree/fix-aio-highlight-topbar |
| Conversation | https://github.com/angular/angular/pull/33351 |
| Commits2 (2) | https://github.com/angular/angular/pull/33351/commits |
| Checks | https://github.com/angular/angular/pull/33351/checks |
| Files changed | https://github.com/angular/angular/pull/33351/files |
| fix(docs-infra): use .tooltip and highlight the currently active node in top-bar | https://github.com/angular/angular/pull/33351#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-aio-highlight-topbar | https://github.com/gkalpak/angular/tree/fix-aio-highlight-topbar |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#issue-511280645 |
| #33239 | https://github.com/angular/angular/issues/33239 |
| #33255 | https://github.com/angular/angular/pull/33255 |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| October 23, 2019 12:11 | https://github.com/angular/angular/pull/33351#event-2736800076 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#event-2736800743 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
comp: docs-infra
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20docs-infra%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#event-2736801253 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#event-2736801330 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#issuecomment-545413406 |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#event-2736801354 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| docs-infra-aio-app | https://github.com/angular/angular/milestone/95 |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#event-2736801661 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 23, 2019
| https://github.com/angular/angular/pull/33351#ref-pullrequest-509229108 |
|
fix(docs-infra): improve focus styles in topnav and footer
#33255
| https://github.com/angular/angular/pull/33255 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#issuecomment-545414257 |
| #33255 | https://github.com/angular/angular/pull/33255 |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 23, 2019 | https://github.com/angular/angular/pull/33351#issuecomment-545415995 |
| https://pr33351-1e431f8.ngbuilds.io/ | https://pr33351-1e431f8.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Oct 24, 2019
| https://github.com/angular/angular/pull/33351#pullrequestreview-306415719 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33351/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/33351#pullrequestreview-306415719 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/15655/67469583-507ba400-f644-11e9-9f7a-a81594216974.png |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
|
| https://github.com/gkalpak |
| fix(docs-infra): use .tooltip in aio-top-menu items | https://github.com/angular/angular/pull/33351/commits/79b7ddced9656c63104736fa916de9edee216a83 |
| 79b7ddc | https://github.com/angular/angular/pull/33351/commits/79b7ddced9656c63104736fa916de9edee216a83 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/1e431f8823e3d62d8df100e6a2f77aec354b1090..1787155f0be3ca52d4548af0a6ac0635719974dd |
| 1e431f8 | https://github.com/angular/angular/commit/1e431f8823e3d62d8df100e6a2f77aec354b1090 |
| 1787155 | https://github.com/angular/angular/commit/1787155f0be3ca52d4548af0a6ac0635719974dd |
|
Compare
| https://github.com/angular/angular/compare/1e431f8823e3d62d8df100e6a2f77aec354b1090..1787155f0be3ca52d4548af0a6ac0635719974dd |
| February 20, 2020 13:06 | https://github.com/angular/angular/pull/33351#event-3055976416 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 20, 2020 | https://github.com/angular/angular/pull/33351#issuecomment-589019427 |
| https://pr33351-1787155.ngbuilds.io/ | https://pr33351-1787155.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
|
| https://github.com/gkalpak |
| fix(docs-infra): highlight the currently active node in top-bar | https://github.com/angular/angular/pull/33351/commits/0ec3ce9f486d3a6d52b8d2982800c148815b1402 |
| 0ec3ce9 | https://github.com/angular/angular/pull/33351/commits/0ec3ce9f486d3a6d52b8d2982800c148815b1402 |
| angular#33239 | https://github.com/angular/angular/issues/33239 |
| angular#33255 | https://github.com/angular/angular/pull/33255 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/1787155f0be3ca52d4548af0a6ac0635719974dd..0ec3ce9f486d3a6d52b8d2982800c148815b1402 |
| 1787155 | https://github.com/angular/angular/commit/1787155f0be3ca52d4548af0a6ac0635719974dd |
| 0ec3ce9 | https://github.com/angular/angular/commit/0ec3ce9f486d3a6d52b8d2982800c148815b1402 |
|
Compare
| https://github.com/angular/angular/compare/1787155f0be3ca52d4548af0a6ac0635719974dd..0ec3ce9f486d3a6d52b8d2982800c148815b1402 |
| February 20, 2020 13:35 | https://github.com/angular/angular/pull/33351#event-3056088726 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 20, 2020 | https://github.com/angular/angular/pull/33351#issuecomment-589029800 |
| 0ec3ce9 | https://github.com/angular/angular/commit/0ec3ce9f486d3a6d52b8d2982800c148815b1402 |
| https://pr33351-0ec3ce9.ngbuilds.io/ | https://pr33351-0ec3ce9.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Feb 20, 2020 | https://github.com/angular/angular/pull/33351#event-3056209974 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Feb 20, 2020 | https://github.com/angular/angular/pull/33351#event-3056378455 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Feb 20, 2020 | https://github.com/angular/angular/pull/33351#issuecomment-589079713 |
| #33255 | https://github.com/angular/angular/pull/33255 |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
| mhevery | https://github.com/mhevery |
|
Feb 20, 2020
| https://github.com/angular/angular/pull/33351#ref-commit-677d277 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(docs-infra): use | https://github.com/angular/angular/commit/677d277cccc4db3bf7da58664390c5dfd8bed503 |
| .tooltip | https://github.com/angular/angular/commit/677d277cccc4db3bf7da58664390c5dfd8bed503 |
| in | https://github.com/angular/angular/commit/677d277cccc4db3bf7da58664390c5dfd8bed503 |
| aio-top-menu | https://github.com/angular/angular/commit/677d277cccc4db3bf7da58664390c5dfd8bed503 |
| items ( | https://github.com/angular/angular/commit/677d277cccc4db3bf7da58664390c5dfd8bed503 |
| #33351 | https://github.com/angular/angular/pull/33351 |
| ) | https://github.com/angular/angular/commit/677d277cccc4db3bf7da58664390c5dfd8bed503 |
| 677d277 | https://github.com/angular/angular/commit/677d277cccc4db3bf7da58664390c5dfd8bed503 |
| #33351 | https://github.com/angular/angular/pull/33351 |
| mhevery | https://github.com/mhevery |
|
Feb 20, 2020
| https://github.com/angular/angular/pull/33351#ref-commit-7dbbe24 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(docs-infra): highlight the currently active node in top-bar ( | https://github.com/angular/angular/commit/7dbbe24ccfa24d759e8fc98d3354ee6ab08cb959 |
| #33351 | https://github.com/angular/angular/pull/33351 |
| ) | https://github.com/angular/angular/commit/7dbbe24ccfa24d759e8fc98d3354ee6ab08cb959 |
| 7dbbe24 | https://github.com/angular/angular/commit/7dbbe24ccfa24d759e8fc98d3354ee6ab08cb959 |
| #33239 | https://github.com/angular/angular/issues/33239 |
| #33255 | https://github.com/angular/angular/pull/33255 |
| #33351 | https://github.com/angular/angular/pull/33351 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 34b84f6 | https://github.com/angular/angular/commit/34b84f61e06e3d3dd0dfef1a69fd275672ffd4fe |
| Feb 20, 2020 | https://github.com/angular/angular/pull/33351#event-3057726496 |
| mhevery | https://github.com/mhevery |
|
Feb 20, 2020
| https://github.com/angular/angular/pull/33351#ref-commit-2aa940f |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(docs-infra): highlight the currently active node in top-bar ( | https://github.com/angular/angular/commit/2aa940f55c036212ec3ec17f18dffa98c219b71c |
| #33351 | https://github.com/angular/angular/pull/33351 |
| ) | https://github.com/angular/angular/commit/2aa940f55c036212ec3ec17f18dffa98c219b71c |
| 2aa940f | https://github.com/angular/angular/commit/2aa940f55c036212ec3ec17f18dffa98c219b71c |
| #33239 | https://github.com/angular/angular/issues/33239 |
| #33255 | https://github.com/angular/angular/pull/33255 |
| #33351 | https://github.com/angular/angular/pull/33351 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| February 21, 2020 13:10 | https://github.com/angular/angular/pull/33351#event-3060430819 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 23, 2020 | https://github.com/angular/angular/pull/33351#issuecomment-602697516 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 23, 2020 | https://github.com/angular/angular/pull/33351#event-3155931778 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33351 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/33351/files/1e431f8823e3d62d8df100e6a2f77aec354b1090 |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
docs-infra-aio-app
| https://github.com/angular/angular/milestone/95 |
| Please reload this page | https://github.com/angular/angular/pull/33351 |
|
| https://github.com/gkalpak |
|
| https://github.com/googlebot |
|
| https://github.com/mary-poppins |
|
| https://github.com/petebacondarwin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |