René's URL Explorer Experiment


Title: fix(compiler): do not throw when using abstract directive from other compilation unit by devversion · Pull Request #33347 · angular/angular · GitHub

Open Graph Title: fix(compiler): do not throw when using abstract directive from other compilation unit by devversion · Pull Request #33347 · angular/angular

X Title: fix(compiler): do not throw when using abstract directive from other compilation unit by devversion · Pull Request #33347 · angular/angular

Description: Libraries can expose directive/component base classes that will be used by consumer applications. Using such a base class from another compilation unit works fine with "ngtsc", but when using "ngc", the compiler will thrown an error saying that the base class is not part of a NgModule. e.g. Cannot determine the module for class X in Y! Add X to the NgModule to fix it. This seems to be because the logic for distinguishing directives from abstract directives is scoped to the current compilation unit within ngc. This causes abstract directives from other compilation units to be considered as actual directives (causing the exception).

Open Graph Description: Libraries can expose directive/component base classes that will be used by consumer applications. Using such a base class from another compilation unit works fine with "ngtsc", but when u...

X Description: Libraries can expose directive/component base classes that will be used by consumer applications. Using such a base class from another compilation unit works fine with "ngtsc", bu...

Opengraph URL: https://github.com/angular/angular/pull/33347

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:54f8c8d2-ec01-40ee-9b1d-f863b3438f25
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA880:2AAD2E:209ACF4:2B7CB1C:6B0184AA
html-safe-nonceb83929a79acac4533294808728fe08be75e83aba5066fa38f5a9b22f52da8013
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODgwOjJBQUQyRToyMDlBQ0Y0OjJCN0NCMUM6NkIwMTg0QUEiLCJ2aXNpdG9yX2lkIjoiNzQxOTc5MzQ0MDAxNzMxOTA4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdf02f34329d03f670c234d38f248cc925bda7f39dc3dd55a008f14aa6a44c02a
hovercard-subject-tagpull_request:331463837
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/33347/files
twitter:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
og:image:altLibraries can expose directive/component base classes that will be used by consumer applications. Using such a base class from another compilation unit works fine with "ngtsc", but when u...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33347/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33347%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33347%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33347/files
Reloadhttps://github.com/angular/angular/pull/33347/files
Reloadhttps://github.com/angular/angular/pull/33347/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
devversionhttps://github.com/devversion
angular:masterhttps://github.com/angular/angular/tree/master
devversion:fix/compiler-inconsistency-ngtsc-ngchttps://github.com/devversion/angular/tree/fix/compiler-inconsistency-ngtsc-ngc
Conversation 3 https://github.com/angular/angular/pull/33347
Commits 1 https://github.com/angular/angular/pull/33347/commits
Checks 0 https://github.com/angular/angular/pull/33347/checks
Files changed https://github.com/angular/angular/pull/33347/files
Please reload this pagehttps://github.com/angular/angular/pull/33347/files
fix(compiler): do not throw when using abstract directive from other compilation unit https://github.com/angular/angular/pull/33347/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/33347/files
312e634 fix(compiler): do not throw when using abstract directive from other … devversion Oct 23, 2019 https://github.com/angular/angular/pull/33347/commits/312e634ebbe555f2641ccdc0278c616ead050455
Clear filters https://github.com/angular/angular/pull/33347/files
Please reload this pagehttps://github.com/angular/angular/pull/33347/files
Please reload this pagehttps://github.com/angular/angular/pull/33347/files
ngc_spec.ts https://github.com/angular/angular/pull/33347/files#diff-2188572d51633f43041e93d72c423e9cef07193ceae30d13203847d970577ef4
ngtsc_spec.ts https://github.com/angular/angular/pull/33347/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
compiler.ts https://github.com/angular/angular/pull/33347/files#diff-2277240aed9253b2c744300f76a4e7222a79a5dcbd3497611e10d7f93e016a9e
packages/compiler-cli/test/ngc_spec.tshttps://github.com/angular/angular/pull/33347/files#diff-2188572d51633f43041e93d72c423e9cef07193ceae30d13203847d970577ef4
View file https://github.com/devversion/angular/blob/312e634ebbe555f2641ccdc0278c616ead050455/packages/compiler-cli/test/ngc_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33347/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33347/files#diff-2188572d51633f43041e93d72c423e9cef07193ceae30d13203847d970577ef4
packages/compiler-cli/test/ngtsc/ngtsc_spec.tshttps://github.com/angular/angular/pull/33347/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
View file https://github.com/devversion/angular/blob/312e634ebbe555f2641ccdc0278c616ead050455/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33347/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33347/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/33347/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
packages/compiler/src/aot/compiler.tshttps://github.com/angular/angular/pull/33347/files#diff-2277240aed9253b2c744300f76a4e7222a79a5dcbd3497611e10d7f93e016a9e
View file https://github.com/devversion/angular/blob/312e634ebbe555f2641ccdc0278c616ead050455/packages/compiler/src/aot/compiler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33347/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33347/files#diff-2277240aed9253b2c744300f76a4e7222a79a5dcbd3497611e10d7f93e016a9e
https://github.com/angular/angular/pull/33347/files#diff-2277240aed9253b2c744300f76a4e7222a79a5dcbd3497611e10d7f93e016a9e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.