| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4cee36f7-d373-06cd-cbfb-16e6bc43bee4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A62A:291B58:1A23BB0:21172FE:6B01879B |
| html-safe-nonce | aa7e117ab8cb972976ece36d718909bc4dbb52af9552ecfba86f3bceba7c051a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjJBOjI5MUI1ODoxQTIzQkIwOjIxMTcyRkU6NkIwMTg3OUIiLCJ2aXNpdG9yX2lkIjoiNDUzNzgzMjU3MTUwOTI0NTg1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 49ed659b7fab9d95aa4810f845be9e0945e47adced9a94c611c4fecc8c652d07 |
| hovercard-subject-tag | pull_request:330007933 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/33264/files |
| twitter:image | https://avatars.githubusercontent.com/u/4450522?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4450522?s=400&v=4 |
| og:image:alt | Removes ngBaseDef from the compiler and any runtime code that was still referring to it. In the cases where we'd previously generate a base def we now generate a definition for an abstract dire... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/33264/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33264%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33264%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/33264/files |
| Reload | https://github.com/angular/angular/pull/33264/files |
| Reload | https://github.com/angular/angular/pull/33264/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests142 (142) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| crisbeto | https://github.com/crisbeto |
| angular:master | https://github.com/angular/angular/tree/master |
| crisbeto:FW-1613/base-def-remove | https://github.com/crisbeto/angular/tree/FW-1613/base-def-remove |
|
Conversation
41
| https://github.com/angular/angular/pull/33264 |
|
Commits
1
| https://github.com/angular/angular/pull/33264/commits |
|
Checks
0
| https://github.com/angular/angular/pull/33264/checks |
|
Files changed
| https://github.com/angular/angular/pull/33264/files |
| Please reload this page | https://github.com/angular/angular/pull/33264/files |
|
refactor(ivy): remove ngBaseDef
| https://github.com/angular/angular/pull/33264/files#top |
|
Show all changes
1 commit
| https://github.com/angular/angular/pull/33264/files |
|
e957e63
refactor(ivy): remove ngBaseDef
crisbeto Oct 25, 2019
| https://github.com/angular/angular/pull/33264/commits/e957e63ccb3cb748e927257793955469664c80c4 |
|
Clear filters
| https://github.com/angular/angular/pull/33264/files |
| Please reload this page | https://github.com/angular/angular/pull/33264/files |
| Please reload this page | https://github.com/angular/angular/pull/33264/files |
|
test.sh
| https://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63 |
|
decoration_analyzer.ts
| https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
renderer_spec.ts
| https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d |
|
index.ts
| https://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114 |
|
base_def.ts
| https://github.com/angular/angular/pull/33264/files#diff-884dfa056fef132832af9e8a5b4efba0d80519013b886576ea7c99810a9cdeda |
|
directive.ts
| https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
program.ts
| https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
nocollapse_hack.ts
| https://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177 |
|
r3_compiler_compliance_spec.ts
| https://github.com/angular/angular/pull/33264/files#diff-7b5a12c9f8db2172d56692d1403844321332621a815a974314fca26f98172841 |
|
r3_view_compiler_input_outputs_spec.ts
| https://github.com/angular/angular/pull/33264/files#diff-f3b0f751c83b10b40a77f298194a9e814c7583a9a12276b7d5e89c7c62fe9c56 |
|
ngtsc_spec.ts
| https://github.com/angular/angular/pull/33264/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb |
|
compiler.ts
| https://github.com/angular/angular/pull/33264/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92 |
|
compiler_facade_interface.ts
| https://github.com/angular/angular/pull/33264/files#diff-e577765cc283f392cc088f070123dfd505773dde21e8fe0ffb950b68c2eda23f |
|
jit_compiler_facade.ts
| https://github.com/angular/angular/pull/33264/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d |
|
r3_identifiers.ts
| https://github.com/angular/angular/pull/33264/files#diff-b8e22f4d293486e4728e970eb17751e6eef38e7ae8249279527e1abbb2e0bd81 |
|
compiler.ts
| https://github.com/angular/angular/pull/33264/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6 |
|
compiler_facade_interface_spec.ts
| https://github.com/angular/angular/pull/33264/files#diff-6586fcaf15d59acfaa2efaeed02f6c6dea28203c20216663a8b5e7bcb4c9f459 |
|
compiler_facade_interface.ts
| https://github.com/angular/angular/pull/33264/files#diff-d1957eb629f15db37308fc835215fd8f0dc1316fb570a784624887c69aaa518e |
|
core_render3_private_export.ts
| https://github.com/angular/angular/pull/33264/files#diff-de09a25a93c0410c75a7ff56fdc6fb572198bdbce5ecaa98cb001063018eb79e |
|
definition.ts
| https://github.com/angular/angular/pull/33264/files#diff-4374dd238deae3e4714315fc97bb9983092ada87475d8e0b8d28e191571941de |
|
inherit_definition_feature.ts
| https://github.com/angular/angular/pull/33264/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5 |
|
fields.ts
| https://github.com/angular/angular/pull/33264/files#diff-825ee631786c6779bc5d3774afae80b3948eb7ee3ae2bc4d2468559060bf98eb |
|
index.ts
| https://github.com/angular/angular/pull/33264/files#diff-a3ef3e01266ff033c4d48f63e1ba739566bdd8a0b2ce372c1659b67c456d8f82 |
|
definition.ts
| https://github.com/angular/angular/pull/33264/files#diff-60df3b2eecee5e87f2cf7fc7ab8f90cad469bd59c6714afc3682737740e26d69 |
|
directive.ts
| https://github.com/angular/angular/pull/33264/files#diff-4f93f07077211da349d6cebe7f4042363eb78ddcd97872c8359cd05a5de386b6 |
|
environment.ts
| https://github.com/angular/angular/pull/33264/files#diff-5b90e8d09c458d28c649738aadc150117eddab8963798868b60bc88d76c5534a |
|
inherit_definition_feature_spec.ts
| https://github.com/angular/angular/pull/33264/files#diff-e081c52415fb1989c4427ba0b0d70c798778deb8831146c83bea2615aea7735f |
|
jit_environment_spec.ts
| https://github.com/angular/angular/pull/33264/files#diff-87e0d6ca4da98f01300f9c408c8a9b27e989fbb5c054b7d5bda4993c98155b50 |
|
core.d.ts
| https://github.com/angular/angular/pull/33264/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8 |
| integration/ngcc/test.sh | https://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63 |
|
View file
| https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/integration/ngcc/test.sh |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33264/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63 |
|
| https://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63 |
| packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts | https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
View file
| https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33264/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
| packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts | https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d |
|
View file
| https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33264/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d |
|
| https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d |
|
| https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d |
| packages/compiler-cli/src/ngtsc/annotations/index.ts | https://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114 |
|
View file
| https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/ngtsc/annotations/index.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33264/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114 |
|
| https://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114 |
| packages/compiler-cli/src/ngtsc/annotations/src/base_def.ts | https://github.com/angular/angular/pull/33264/files#diff-884dfa056fef132832af9e8a5b4efba0d80519013b886576ea7c99810a9cdeda |
|
View file
| https://github.com/angular/angular/blob/8d15bfa6eebad42652855f65a2d660af5d273925/packages/compiler-cli/src/ngtsc/annotations/src/base_def.ts |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/angular/angular/pull/33264/files |
| packages/compiler-cli/src/ngtsc/annotations/src/directive.ts | https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
View file
| https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/ngtsc/annotations/src/directive.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33264/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
| https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
| https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
| alxhub | https://github.com/alxhub |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33264/files#r338827972 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33264/files |
| crisbeto | https://github.com/crisbeto |
| Oct 24, 2019 | https://github.com/angular/angular/pull/33264/files#r338829260 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33264/files |
|
| https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
| https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
| https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
| packages/compiler-cli/src/ngtsc/program.ts | https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
View file
| https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/ngtsc/program.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33264/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
| https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
| https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
| https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
| packages/compiler-cli/src/transformers/nocollapse_hack.ts | https://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177 |
|
View file
| https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/transformers/nocollapse_hack.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33264/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177 |
|
| https://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177 |
| Please reload this page | https://github.com/angular/angular/pull/33264/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |