René's URL Explorer Experiment


Title: refactor(ivy): remove ngBaseDef by crisbeto · Pull Request #33264 · angular/angular · GitHub

Open Graph Title: refactor(ivy): remove ngBaseDef by crisbeto · Pull Request #33264 · angular/angular

X Title: refactor(ivy): remove ngBaseDef by crisbeto · Pull Request #33264 · angular/angular

Description: Removes ngBaseDef from the compiler and any runtime code that was still referring to it. In the cases where we'd previously generate a base def we now generate a definition for an abstract directive.

Open Graph Description: Removes ngBaseDef from the compiler and any runtime code that was still referring to it. In the cases where we'd previously generate a base def we now generate a definition for an abstract dire...

X Description: Removes ngBaseDef from the compiler and any runtime code that was still referring to it. In the cases where we'd previously generate a base def we now generate a definition for an abstract ...

Opengraph URL: https://github.com/angular/angular/pull/33264

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4cee36f7-d373-06cd-cbfb-16e6bc43bee4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA62A:291B58:1A23BB0:21172FE:6B01879B
html-safe-nonceaa7e117ab8cb972976ece36d718909bc4dbb52af9552ecfba86f3bceba7c051a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjJBOjI5MUI1ODoxQTIzQkIwOjIxMTcyRkU6NkIwMTg3OUIiLCJ2aXNpdG9yX2lkIjoiNDUzNzgzMjU3MTUwOTI0NTg1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac49ed659b7fab9d95aa4810f845be9e0945e47adced9a94c611c4fecc8c652d07
hovercard-subject-tagpull_request:330007933
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/33264/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altRemoves ngBaseDef from the compiler and any runtime code that was still referring to it. In the cases where we'd previously generate a base def we now generate a definition for an abstract dire...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33264/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33264%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33264%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33264/files
Reloadhttps://github.com/angular/angular/pull/33264/files
Reloadhttps://github.com/angular/angular/pull/33264/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:masterhttps://github.com/angular/angular/tree/master
crisbeto:FW-1613/base-def-removehttps://github.com/crisbeto/angular/tree/FW-1613/base-def-remove
Conversation 41 https://github.com/angular/angular/pull/33264
Commits 1 https://github.com/angular/angular/pull/33264/commits
Checks 0 https://github.com/angular/angular/pull/33264/checks
Files changed https://github.com/angular/angular/pull/33264/files
Please reload this pagehttps://github.com/angular/angular/pull/33264/files
refactor(ivy): remove ngBaseDef https://github.com/angular/angular/pull/33264/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/33264/files
e957e63 refactor(ivy): remove ngBaseDef crisbeto Oct 25, 2019 https://github.com/angular/angular/pull/33264/commits/e957e63ccb3cb748e927257793955469664c80c4
Clear filters https://github.com/angular/angular/pull/33264/files
Please reload this pagehttps://github.com/angular/angular/pull/33264/files
Please reload this pagehttps://github.com/angular/angular/pull/33264/files
test.sh https://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
decoration_analyzer.ts https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
renderer_spec.ts https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d
index.ts https://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114
base_def.ts https://github.com/angular/angular/pull/33264/files#diff-884dfa056fef132832af9e8a5b4efba0d80519013b886576ea7c99810a9cdeda
directive.ts https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
program.ts https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
nocollapse_hack.ts https://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177
r3_compiler_compliance_spec.ts https://github.com/angular/angular/pull/33264/files#diff-7b5a12c9f8db2172d56692d1403844321332621a815a974314fca26f98172841
r3_view_compiler_input_outputs_spec.ts https://github.com/angular/angular/pull/33264/files#diff-f3b0f751c83b10b40a77f298194a9e814c7583a9a12276b7d5e89c7c62fe9c56
ngtsc_spec.ts https://github.com/angular/angular/pull/33264/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
compiler.ts https://github.com/angular/angular/pull/33264/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92
compiler_facade_interface.ts https://github.com/angular/angular/pull/33264/files#diff-e577765cc283f392cc088f070123dfd505773dde21e8fe0ffb950b68c2eda23f
jit_compiler_facade.ts https://github.com/angular/angular/pull/33264/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d
r3_identifiers.ts https://github.com/angular/angular/pull/33264/files#diff-b8e22f4d293486e4728e970eb17751e6eef38e7ae8249279527e1abbb2e0bd81
compiler.ts https://github.com/angular/angular/pull/33264/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6
compiler_facade_interface_spec.ts https://github.com/angular/angular/pull/33264/files#diff-6586fcaf15d59acfaa2efaeed02f6c6dea28203c20216663a8b5e7bcb4c9f459
compiler_facade_interface.ts https://github.com/angular/angular/pull/33264/files#diff-d1957eb629f15db37308fc835215fd8f0dc1316fb570a784624887c69aaa518e
core_render3_private_export.ts https://github.com/angular/angular/pull/33264/files#diff-de09a25a93c0410c75a7ff56fdc6fb572198bdbce5ecaa98cb001063018eb79e
definition.ts https://github.com/angular/angular/pull/33264/files#diff-4374dd238deae3e4714315fc97bb9983092ada87475d8e0b8d28e191571941de
inherit_definition_feature.ts https://github.com/angular/angular/pull/33264/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5
fields.ts https://github.com/angular/angular/pull/33264/files#diff-825ee631786c6779bc5d3774afae80b3948eb7ee3ae2bc4d2468559060bf98eb
index.ts https://github.com/angular/angular/pull/33264/files#diff-a3ef3e01266ff033c4d48f63e1ba739566bdd8a0b2ce372c1659b67c456d8f82
definition.ts https://github.com/angular/angular/pull/33264/files#diff-60df3b2eecee5e87f2cf7fc7ab8f90cad469bd59c6714afc3682737740e26d69
directive.ts https://github.com/angular/angular/pull/33264/files#diff-4f93f07077211da349d6cebe7f4042363eb78ddcd97872c8359cd05a5de386b6
environment.ts https://github.com/angular/angular/pull/33264/files#diff-5b90e8d09c458d28c649738aadc150117eddab8963798868b60bc88d76c5534a
inherit_definition_feature_spec.ts https://github.com/angular/angular/pull/33264/files#diff-e081c52415fb1989c4427ba0b0d70c798778deb8831146c83bea2615aea7735f
jit_environment_spec.ts https://github.com/angular/angular/pull/33264/files#diff-87e0d6ca4da98f01300f9c408c8a9b27e989fbb5c054b7d5bda4993c98155b50
core.d.ts https://github.com/angular/angular/pull/33264/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
integration/ngcc/test.shhttps://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
View file https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/integration/ngcc/test.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33264/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
https://github.com/angular/angular/pull/33264/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
View file https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33264/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/33264/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
packages/compiler-cli/ngcc/test/rendering/renderer_spec.tshttps://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d
View file https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33264/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d
https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d
https://github.com/angular/angular/pull/33264/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d
packages/compiler-cli/src/ngtsc/annotations/index.tshttps://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114
View file https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/ngtsc/annotations/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33264/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114
https://github.com/angular/angular/pull/33264/files#diff-79445d7efcb369559ca62d1a1c38d6244816429ecef0ac0dc6763acdf5ee2114
packages/compiler-cli/src/ngtsc/annotations/src/base_def.tshttps://github.com/angular/angular/pull/33264/files#diff-884dfa056fef132832af9e8a5b4efba0d80519013b886576ea7c99810a9cdeda
View file https://github.com/angular/angular/blob/8d15bfa6eebad42652855f65a2d660af5d273925/packages/compiler-cli/src/ngtsc/annotations/src/base_def.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angular/pull/33264/files
packages/compiler-cli/src/ngtsc/annotations/src/directive.tshttps://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
View file https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/ngtsc/annotations/src/directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33264/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
alxhubhttps://github.com/alxhub
Oct 24, 2019https://github.com/angular/angular/pull/33264/files#r338827972
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33264/files
crisbetohttps://github.com/crisbeto
Oct 24, 2019https://github.com/angular/angular/pull/33264/files#r338829260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33264/files
https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
https://github.com/angular/angular/pull/33264/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
packages/compiler-cli/src/ngtsc/program.tshttps://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
View file https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/ngtsc/program.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33264/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
https://github.com/angular/angular/pull/33264/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
packages/compiler-cli/src/transformers/nocollapse_hack.tshttps://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177
View file https://github.com/crisbeto/angular/blob/e957e63ccb3cb748e927257793955469664c80c4/packages/compiler-cli/src/transformers/nocollapse_hack.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33264/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177
https://github.com/angular/angular/pull/33264/files#diff-866c9bfb7974c499820989cb247a03c7a23db34345de57d7129a08b8e08f8177
Please reload this pagehttps://github.com/angular/angular/pull/33264/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.