René's URL Explorer Experiment


Title: feat(core): add ModuleWithProviders generic type migration by CaerusKaru · Pull Request #33217 · angular/angular · GitHub

Open Graph Title: feat(core): add ModuleWithProviders generic type migration by CaerusKaru · Pull Request #33217 · angular/angular

X Title: feat(core): add ModuleWithProviders generic type migration by CaerusKaru · Pull Request #33217 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Static methods that return a type of ModuleWithProviders currently do not have to specify a type because the generic falls back to any. This is problematic because the type of the actual module bei...

X Description: Static methods that return a type of ModuleWithProviders currently do not have to specify a type because the generic falls back to any. This is problematic because the type of the actual module bei...

Opengraph URL: https://github.com/angular/angular/pull/33217

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d19201de-fc41-fa06-7787-6fcb87bdb5de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC94A:B336C:1D3BCD:27D5EA:6A57F896
html-safe-nonce68ab6ebfd11505caf3da101477fd48add924431914b3fef38a9cb9eca5b403eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTRBOkIzMzZDOjFEM0JDRDoyN0Q1RUE6NkE1N0Y4OTYiLCJ2aXNpdG9yX2lkIjoiMTA5OTk2NzAyMDY0NzU3Nzc1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac57c989cb136eb13d77128810f976498e0f444508319c2691886efd2f01068552
hovercard-subject-tagpull_request:329095047
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33217/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/771638e0aeabcc723baab8d66cbf6affc6f9e0b0dbd05933c3db1138d3ad6962/angular/angular/pull/33217
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/771638e0aeabcc723baab8d66cbf6affc6f9e0b0dbd05933c3db1138d3ad6962/angular/angular/pull/33217
og:image:altStatic methods that return a type of ModuleWithProviders currently do not have to specify a type because the generic falls back to any. This is problematic because the type of the actual module bei...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCaerusKaru
hostnamegithub.com
expected-hostnamegithub.com
None49c8c15fabcbf356d607a90ca115c13b273e42ff8b74155de050fd229a9b0121
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3fb1f684e7a833eb1b2d01d39875a2b52cb4fe9b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33217#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33217
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33217
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33217
Reloadhttps://github.com/angular/angular/pull/33217
Reloadhttps://github.com/angular/angular/pull/33217
Please reload this pagehttps://github.com/angular/angular/pull/33217
angular https://github.com/angular
angularhttps://github.com/angular/angular
Notifications https://github.com/login?return_to=%2Fangular%2Fangular
Fork 27.5k https://github.com/login?return_to=%2Fangular%2Fangular
Star 101k https://github.com/login?return_to=%2Fangular%2Fangular
Code https://github.com/angular/angular
Issues 976 https://github.com/angular/angular/issues
Pull requests 155 https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality 24 https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Code https://github.com/angular/angular
Issues https://github.com/angular/angular/issues
Pull requests https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
CaerusKaruhttps://github.com/CaerusKaru
angular:masterhttps://github.com/angular/angular/tree/master
CaerusKaru:adam/mwphttps://github.com/CaerusKaru/angular/tree/adam/mwp
Conversationhttps://github.com/angular/angular/pull/33217
Commits6 (6)https://github.com/angular/angular/pull/33217/commits
Checkshttps://github.com/angular/angular/pull/33217/checks
Files changedhttps://github.com/angular/angular/pull/33217/files
feat(core): add ModuleWithProviders generic type migrationhttps://github.com/angular/angular/pull/33217#top
CaerusKaruhttps://github.com/CaerusKaru
angular:masterhttps://github.com/angular/angular/tree/master
CaerusKaru:adam/mwphttps://github.com/CaerusKaru/angular/tree/adam/mwp
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
Oct 17, 2019https://github.com/angular/angular/pull/33217#issue-508270306
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 17, 2019https://github.com/angular/angular/pull/33217#event-2720081385
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
Oct 17, 2019 https://github.com/angular/angular/pull/33217#ref-pullrequest-508280581
fix: add generic type for ModuleWithProviders angular/in-memory-web-api#245 https://github.com/angular/in-memory-web-api/pull/245
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/4f96a13ba122b08ab48448e22320f803bdc9dca1..5d38a2076e6d6d0444d27cfc5d14c4629b4fed42
4f96a13https://github.com/angular/angular/commit/4f96a13ba122b08ab48448e22320f803bdc9dca1
5d38a20https://github.com/angular/angular/commit/5d38a2076e6d6d0444d27cfc5d14c4629b4fed42
Compare https://github.com/angular/angular/compare/4f96a13ba122b08ab48448e22320f803bdc9dca1..5d38a2076e6d6d0444d27cfc5d14c4629b4fed42
October 17, 2019 17:10https://github.com/angular/angular/pull/33217#event-2722086491
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
October 17, 2019 17:10https://github.com/angular/angular/pull/33217#event-2722088519
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
October 17, 2019 17:11https://github.com/angular/angular/pull/33217#event-2722088532
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
Oct 17, 2019https://github.com/angular/angular/pull/33217#issuecomment-543272961
@devversionhttps://github.com/devversion
@IgorMinarhttps://github.com/IgorMinar
@karahttps://github.com/kara
@vikermanhttps://github.com/vikerman
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/vikerman
vikermanhttps://github.com/vikerman
devversionhttps://github.com/devversion
karahttps://github.com/kara
October 17, 2019 18:43https://github.com/angular/angular/pull/33217#event-2722363680
https://github.com/kara
karahttps://github.com/kara
Oct 17, 2019 https://github.com/angular/angular/pull/33217#pullrequestreview-303474792
View reviewed changes https://github.com/angular/angular/pull/33217/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/33217#pullrequestreview-303474792
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33217
tools/public_api_guard/core/core.d.tshttps://github.com/angular/angular/pull/33217/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/src/metadata/ng_module.tshttps://github.com/angular/angular/pull/33217/files#diff-791385b9b1cb7518e5cdd4d27ceb90b602b40253a1f2f30c9d4004e8189a76d1
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/README.mdhttps://github.com/angular/angular/pull/33217/files#diff-ccfb3ffad522a0981d97baf1b8af62339b53ccd649962229ef8e6bc409c012b7
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/test/module_with_providers_migration_spec.tshttps://github.com/angular/angular/pull/33217/files#diff-5ccbefdd771662e6e26a89f8dc77287898e32debed905168d47e8437f42c9149
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
Oct 17, 2019https://github.com/angular/angular/pull/33217#event-2722671628
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/5d38a2076e6d6d0444d27cfc5d14c4629b4fed42..c04f6f2dad56b9b8718cebac83cc1e8e9258b3f2
5d38a20https://github.com/angular/angular/commit/5d38a2076e6d6d0444d27cfc5d14c4629b4fed42
c04f6f2https://github.com/angular/angular/commit/c04f6f2dad56b9b8718cebac83cc1e8e9258b3f2
Compare https://github.com/angular/angular/compare/5d38a2076e6d6d0444d27cfc5d14c4629b4fed42..c04f6f2dad56b9b8718cebac83cc1e8e9258b3f2
October 17, 2019 20:41https://github.com/angular/angular/pull/33217#event-2722697321
https://github.com/googlebot
googlebothttps://github.com/googlebot
Oct 17, 2019https://github.com/angular/angular/pull/33217#issuecomment-543353046
login herehttps://cla.developers.google.com/
Go herehttps://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33217
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 17, 2019https://github.com/angular/angular/pull/33217#event-2722697466
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/c04f6f2dad56b9b8718cebac83cc1e8e9258b3f2..ed526816450979d0d28bfd42eaf69d54ccb9e296
c04f6f2https://github.com/angular/angular/commit/c04f6f2dad56b9b8718cebac83cc1e8e9258b3f2
ed52681https://github.com/angular/angular/commit/ed526816450979d0d28bfd42eaf69d54ccb9e296
Compare https://github.com/angular/angular/compare/c04f6f2dad56b9b8718cebac83cc1e8e9258b3f2..ed526816450979d0d28bfd42eaf69d54ccb9e296
October 17, 2019 20:46https://github.com/angular/angular/pull/33217#event-2722709886
https://github.com/googlebot
googlebothttps://github.com/googlebot
Oct 17, 2019https://github.com/angular/angular/pull/33217#issuecomment-543354805
Go herehttps://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33217
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Oct 17, 2019https://github.com/angular/angular/pull/33217#event-2722710689
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/ed526816450979d0d28bfd42eaf69d54ccb9e296..db2edeb6e4adf60a36a5370661aa1f64933f3f43
ed52681https://github.com/angular/angular/commit/ed526816450979d0d28bfd42eaf69d54ccb9e296
db2edebhttps://github.com/angular/angular/commit/db2edeb6e4adf60a36a5370661aa1f64933f3f43
Compare https://github.com/angular/angular/compare/ed526816450979d0d28bfd42eaf69d54ccb9e296..db2edeb6e4adf60a36a5370661aa1f64933f3f43
October 17, 2019 20:51https://github.com/angular/angular/pull/33217#event-2722722408
https://github.com/matsko
matskohttps://github.com/matsko
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
Oct 17, 2019https://github.com/angular/angular/pull/33217#event-2723019232
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Oct 17, 2019https://github.com/angular/angular/pull/33217#event-2723019272
https://github.com/devversion
devversionhttps://github.com/devversion
Oct 18, 2019 https://github.com/angular/angular/pull/33217#pullrequestreview-303747351
View reviewed changes https://github.com/angular/angular/pull/33217/files
packages/core/schematics/migrations/module-with-providers/README.mdhttps://github.com/angular/angular/pull/33217/files#diff-ccfb3ffad522a0981d97baf1b8af62339b53ccd649962229ef8e6bc409c012b7
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/module_collector.tshttps://github.com/angular/angular/pull/33217/files#diff-5b154116f97cfc0a0efb3859b0cc7ac93dee823f84c5e7de275b20e2e51831d7
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/module_collector.tshttps://github.com/angular/angular/pull/33217/files#diff-5b154116f97cfc0a0efb3859b0cc7ac93dee823f84c5e7de275b20e2e51831d7
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/util.tshttps://github.com/angular/angular/pull/33217/files#diff-3119604df50c65f05f7c7476304742e2bcc52b76c4de79edf7cd3eacab43cf91
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/util.tshttps://github.com/angular/angular/pull/33217/files#diff-3119604df50c65f05f7c7476304742e2bcc52b76c4de79edf7cd3eacab43cf91
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/util.tshttps://github.com/angular/angular/pull/33217/files#diff-3119604df50c65f05f7c7476304742e2bcc52b76c4de79edf7cd3eacab43cf91
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/BUILD.bazelhttps://github.com/angular/angular/pull/33217/files#diff-c7083a33149de0a2087d6cfc76e6fb292999053347a102d0ec37b823dbcd401c
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/index.tshttps://github.com/angular/angular/pull/33217/files#diff-e591ae7dedef63282f46e159f1e4f0a58db40a6b3f710eaa9d3676a3b9d4b8f6
Please reload this pagehttps://github.com/angular/angular/pull/33217
CaerusKaruhttps://github.com/CaerusKaru
October 18, 2019 16:13https://github.com/angular/angular/pull/33217#commits-pushed-8d1fd27
https://github.com/CaerusKaru
feat(core): add ModuleWithProviders generic type migrationhttps://github.com/angular/angular/pull/33217/commits/8d1fd2784c9df33dc787788a9f28feb49ad0185d
8d1fd27https://github.com/angular/angular/pull/33217/commits/8d1fd2784c9df33dc787788a9f28feb49ad0185d
https://github.com/CaerusKaru
fixup! feat(core): add ModuleWithProviders generic type migrationhttps://github.com/angular/angular/pull/33217/commits/eb94839ba57778fbfb97da1b7e7022d4a608013f
eb94839https://github.com/angular/angular/pull/33217/commits/eb94839ba57778fbfb97da1b7e7022d4a608013f
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/c41ee141ea66f8c8972bbb96f702848c16520d05..66ad8302778ba1fe1d308800dadd0d462bc6dbd6
c41ee14https://github.com/angular/angular/commit/c41ee141ea66f8c8972bbb96f702848c16520d05
66ad830https://github.com/angular/angular/commit/66ad8302778ba1fe1d308800dadd0d462bc6dbd6
Compare https://github.com/angular/angular/compare/c41ee141ea66f8c8972bbb96f702848c16520d05..66ad8302778ba1fe1d308800dadd0d462bc6dbd6
October 18, 2019 21:27https://github.com/angular/angular/pull/33217#event-2726302671
https://github.com/CaerusKaru
fixup! feat(core): add ModuleWithProviders generic type migrationhttps://github.com/angular/angular/pull/33217/commits/fc6482ffc69022dc9d5c2cb730a121846a3cf41a
fc6482fhttps://github.com/angular/angular/pull/33217/commits/fc6482ffc69022dc9d5c2cb730a121846a3cf41a
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
devversionhttps://github.com/devversion
karahttps://github.com/kara
October 18, 2019 22:21https://github.com/angular/angular/pull/33217#event-2726413444
https://github.com/CaerusKaru
fixup! feat(core): add ModuleWithProviders generic type migrationhttps://github.com/angular/angular/pull/33217/commits/96725797e88755352fb6cb823ed2f41b05442b23
9672579https://github.com/angular/angular/pull/33217/commits/96725797e88755352fb6cb823ed2f41b05442b23
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/cf394727ce37e51c532a50b27e617004e555a0fd..96725797e88755352fb6cb823ed2f41b05442b23
cf39472https://github.com/angular/angular/commit/cf394727ce37e51c532a50b27e617004e555a0fd
9672579https://github.com/angular/angular/commit/96725797e88755352fb6cb823ed2f41b05442b23
Compare https://github.com/angular/angular/compare/cf394727ce37e51c532a50b27e617004e555a0fd..96725797e88755352fb6cb823ed2f41b05442b23
October 18, 2019 22:48https://github.com/angular/angular/pull/33217#event-2726460835
https://github.com/devversion
devversionhttps://github.com/devversion
Oct 19, 2019 https://github.com/angular/angular/pull/33217#pullrequestreview-304203391
View reviewed changes https://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23
devversionhttps://github.com/devversion
https://github.com/angular/angular/pull/33217#pullrequestreview-304203391
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/index.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-e591ae7dedef63282f46e159f1e4f0a58db40a6b3f710eaa9d3676a3b9d4b8f6
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/index.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-e591ae7dedef63282f46e159f1e4f0a58db40a6b3f710eaa9d3676a3b9d4b8f6
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/util.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-3119604df50c65f05f7c7476304742e2bcc52b76c4de79edf7cd3eacab43cf91
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/test/module_with_providers_migration_spec.tshttps://github.com/angular/angular/pull/33217/files/96725797e88755352fb6cb823ed2f41b05442b23#diff-5ccbefdd771662e6e26a89f8dc77287898e32debed905168d47e8437f42c9149
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/9813cf97b9f04f5d3611c4a4306968b7c9d069c0..e3822ade2ed708f4241b216477e873d843369f0b
9813cf9https://github.com/angular/angular/commit/9813cf97b9f04f5d3611c4a4306968b7c9d069c0
e3822adhttps://github.com/angular/angular/commit/e3822ade2ed708f4241b216477e873d843369f0b
Compare https://github.com/angular/angular/compare/9813cf97b9f04f5d3611c4a4306968b7c9d069c0..e3822ade2ed708f4241b216477e873d843369f0b
October 20, 2019 17:59https://github.com/angular/angular/pull/33217#event-2727800608
https://github.com/CaerusKaru
fixup! feat(core): add ModuleWithProviders generic type migrationhttps://github.com/angular/angular/pull/33217/commits/dd4b96af9ad66001243f77cf72670c0b476c31e0
dd4b96ahttps://github.com/angular/angular/pull/33217/commits/dd4b96af9ad66001243f77cf72670c0b476c31e0
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
force-pushedhttps://github.com/angular/angular/compare/e3822ade2ed708f4241b216477e873d843369f0b..dd4b96af9ad66001243f77cf72670c0b476c31e0
e3822adhttps://github.com/angular/angular/commit/e3822ade2ed708f4241b216477e873d843369f0b
dd4b96ahttps://github.com/angular/angular/commit/dd4b96af9ad66001243f77cf72670c0b476c31e0
Compare https://github.com/angular/angular/compare/e3822ade2ed708f4241b216477e873d843369f0b..dd4b96af9ad66001243f77cf72670c0b476c31e0
October 20, 2019 18:06https://github.com/angular/angular/pull/33217#event-2727804755
https://github.com/kara
karahttps://github.com/kara
Oct 20, 2019 https://github.com/angular/angular/pull/33217#pullrequestreview-304276563
View reviewed changes https://github.com/angular/angular/pull/33217/files/dd4b96af9ad66001243f77cf72670c0b476c31e0
karahttps://github.com/kara
https://github.com/angular/angular/pull/33217#pullrequestreview-304276563
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/README.mdhttps://github.com/angular/angular/pull/33217/files/dd4b96af9ad66001243f77cf72670c0b476c31e0#diff-ccfb3ffad522a0981d97baf1b8af62339b53ccd649962229ef8e6bc409c012b7
Please reload this pagehttps://github.com/angular/angular/pull/33217
packages/core/schematics/migrations/module-with-providers/transform.tshttps://github.com/angular/angular/pull/33217/files/dd4b96af9ad66001243f77cf72670c0b476c31e0#diff-a7da5e0948c4d1bb5b6e0133ae5e3c481e1be735050c0f9fb90b366e1f98e523
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/kara
karahttps://github.com/kara
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 20, 2019https://github.com/angular/angular/pull/33217#event-2727881415
https://github.com/kara
karahttps://github.com/kara
CaerusKaruhttps://github.com/CaerusKaru
Oct 20, 2019https://github.com/angular/angular/pull/33217#event-2727881451
https://github.com/kara
karahttps://github.com/kara
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Oct 20, 2019https://github.com/angular/angular/pull/33217#event-2727881469
https://github.com/CaerusKaru
fixup! feat(core): add ModuleWithProviders generic type migrationhttps://github.com/angular/angular/pull/33217/commits/4e13fdc389e15c614c8e2599eb6882e26ba9dac8
4e13fdchttps://github.com/angular/angular/pull/33217/commits/4e13fdc389e15c614c8e2599eb6882e26ba9dac8
https://github.com/devversion
devversionhttps://github.com/devversion
Oct 21, 2019 https://github.com/angular/angular/pull/33217#pullrequestreview-304367092
View reviewed changes https://github.com/angular/angular/pull/33217/files/4e13fdc389e15c614c8e2599eb6882e26ba9dac8
devversionhttps://github.com/devversion
https://github.com/angular/angular/pull/33217#pullrequestreview-304367092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/devversion
devversionhttps://github.com/devversion
karahttps://github.com/kara
CaerusKaruhttps://github.com/CaerusKaru
Oct 21, 2019https://github.com/angular/angular/pull/33217#event-2728572705
https://github.com/kara
karahttps://github.com/kara
Oct 21, 2019 https://github.com/angular/angular/pull/33217#pullrequestreview-304713044
View reviewed changes https://github.com/angular/angular/pull/33217/files/4e13fdc389e15c614c8e2599eb6882e26ba9dac8
karahttps://github.com/kara
https://github.com/angular/angular/pull/33217#pullrequestreview-304713044
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/kara
karahttps://github.com/kara
Oct 21, 2019https://github.com/angular/angular/pull/33217#event-2730498951
https://github.com/kara
karahttps://github.com/kara
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 21, 2019https://github.com/angular/angular/pull/33217#event-2730499178
https://github.com/kara
karahttps://github.com/kara
Oct 21, 2019https://github.com/angular/angular/pull/33217#issuecomment-544618470
VE presubmithttp://test/OCL:275869701:BASE:275869768:1571678382238:e47ce3a0
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/kara
karahttps://github.com/kara
Oct 21, 2019https://github.com/angular/angular/pull/33217#issuecomment-544650945
herehttps://critique.corp.google.com/#review/275889072
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/kara
karahttps://github.com/kara
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Oct 21, 2019https://github.com/angular/angular/pull/33217#event-2730809223
https://github.com/matsko
matskohttps://github.com/matsko
56731f6https://github.com/angular/angular/commit/56731f624a1f65e302fab01dc7136f453d4d8a6d
Oct 21, 2019https://github.com/angular/angular/pull/33217#event-2731043536
https://github.com/CaerusKaru
CaerusKaruhttps://github.com/CaerusKaru
October 21, 2019 20:54https://github.com/angular/angular/pull/33217#event-2731232442
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 21, 2019https://github.com/angular/angular/pull/33217#issuecomment-557155483
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 21, 2019https://github.com/angular/angular/pull/33217#event-2820249955
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33217
https://github.com/devversion
devversion https://github.com/devversion
https://github.com/angular/angular/pull/33217/files/4e13fdc389e15c614c8e2599eb6882e26ba9dac8
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/33217/files/4e13fdc389e15c614c8e2599eb6882e26ba9dac8
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/33217
https://github.com/CaerusKaru
https://github.com/googlebot
https://github.com/kara
https://github.com/devversion
https://github.com/matsko
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.