René's URL Explorer Experiment


Title: fix(ivy): support abstract directives in template type checking by JoostK · Pull Request #33131 · angular/angular · GitHub

Open Graph Title: fix(ivy): support abstract directives in template type checking by JoostK · Pull Request #33131 · angular/angular

X Title: fix(ivy): support abstract directives in template type checking by JoostK · Pull Request #33131 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Recently it was made possible to have a directive without selector, which are referred to as abstract directives. Such directives should not be registered in an NgModule, but can still contain deco...

X Description: Recently it was made possible to have a directive without selector, which are referred to as abstract directives. Such directives should not be registered in an NgModule, but can still contain deco...

Opengraph URL: https://github.com/angular/angular/pull/33131

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ab2ea938-7cb9-1e4c-d727-be217a84578b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEADE:215B92:1335AA7:1993E6B:6B0127EE
html-safe-nonce9776311b727c9d1cb14e2cca06fcea3dd9641973f8d10f3f71fc6805a9b5a843
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQURFOjIxNUI5MjoxMzM1QUE3OjE5OTNFNkI6NkIwMTI3RUUiLCJ2aXNpdG9yX2lkIjoiMjgzNDgxMjM5MDA3MDEwMTk5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac86e59c6575b7f04a2adef469a9862db05237837b9fd838038f7cbaad20834ba6
hovercard-subject-tagpull_request:327562926
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33131/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/09a7d636117d62447516811b7983ac46a7becfbbb0d2f451506dc70f274c54b4/angular/angular/pull/33131
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/09a7d636117d62447516811b7983ac46a7becfbbb0d2f451506dc70f274c54b4/angular/angular/pull/33131
og:image:altRecently it was made possible to have a directive without selector, which are referred to as abstract directives. Such directives should not be registered in an NgModule, but can still contain deco...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJoostK
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/33131#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33131
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33131
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33131
Reloadhttps://github.com/angular/angular/pull/33131
Reloadhttps://github.com/angular/angular/pull/33131
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngtsc-abstract-directiveshttps://github.com/JoostK/angular/tree/ngtsc-abstract-directives
Conversationhttps://github.com/angular/angular/pull/33131
Commits1 (1)https://github.com/angular/angular/pull/33131/commits
Checkshttps://github.com/angular/angular/pull/33131/checks
Files changedhttps://github.com/angular/angular/pull/33131/files
fix(ivy): support abstract directives in template type checkinghttps://github.com/angular/angular/pull/33131#top
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngtsc-abstract-directiveshttps://github.com/JoostK/angular/tree/ngtsc-abstract-directives
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 13, 2019https://github.com/angular/angular/pull/33131#issue-506336678
#30080https://github.com/angular/angular/issues/30080
Please reload this pagehttps://github.com/angular/angular/pull/33131
https://github.com/JoostK
JoostKhttps://github.com/JoostK
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
effort1: hours https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
freq2: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity3: broken https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
workaround2: non-obvious https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
Oct 13, 2019https://github.com/angular/angular/pull/33131#event-2708708065
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Oct 13, 2019https://github.com/angular/angular/pull/33131#event-2708708091
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 13, 2019https://github.com/angular/angular/pull/33131#event-2708708104
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/04c3225e5ca7419e93d5f54fae8dd096e22412dc..52552f9ce80696dfadd25a1fd345e65971d9ae5e
04c3225https://github.com/angular/angular/commit/04c3225e5ca7419e93d5f54fae8dd096e22412dc
52552f9https://github.com/angular/angular/commit/52552f9ce80696dfadd25a1fd345e65971d9ae5e
Compare https://github.com/angular/angular/compare/04c3225e5ca7419e93d5f54fae8dd096e22412dc..52552f9ce80696dfadd25a1fd345e65971d9ae5e
October 13, 2019 15:49https://github.com/angular/angular/pull/33131#event-2708733479
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 14, 2019 https://github.com/angular/angular/pull/33131#ref-issue-436579816
Inputs are not inherited when Ivy is enabled #30080 https://github.com/angular/angular/issues/30080
https://github.com/Splaktar
Splaktarhttps://github.com/Splaktar
Oct 15, 2019 https://github.com/angular/angular/pull/33131#ref-pullrequest-506687136
refactor: enable Ivy and fix template type checking issues angular/components#17392 https://github.com/angular/components/pull/17392
Ivy: Input fields inherited from abstract class cause runtime exception #32428 https://github.com/angular/angular/issues/32428
refactor(ivy): remove ngBaseDef #33264 https://github.com/angular/angular/pull/33264
https://github.com/JoostK
JoostKhttps://github.com/JoostK
October 22, 2019 16:24https://github.com/angular/angular/pull/33131#event-2733969598
https://github.com/JoostK
JoostKhttps://github.com/JoostK
October 22, 2019 16:24https://github.com/angular/angular/pull/33131#event-2733969618
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Oct 22, 2019https://github.com/angular/angular/pull/33131#event-2733970087
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 22, 2019 https://github.com/angular/angular/pull/33131#ref-pullrequest-509656650
feat(ngcc): execute schematic-like migrations in ngcc #33279 https://github.com/angular/angular/pull/33279
https://github.com/devversion
devversionhttps://github.com/devversion
Oct 23, 2019 https://github.com/angular/angular/pull/33131#ref-pullrequest-511161774
refactor: remove abstract directive selector workaround angular/components#17476 https://github.com/angular/components/pull/17476
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Oct 24, 2019 https://github.com/angular/angular/pull/33131#pullrequestreview-306707241
View reviewed changes https://github.com/angular/angular/pull/33131/files
https://github.com/alxhub
alxhubhttps://github.com/alxhub
force-pushedhttps://github.com/angular/angular/compare/52552f9ce80696dfadd25a1fd345e65971d9ae5e..61c2c2fa3a2e422c7a6631a6f39aaeb7d972eb68
52552f9https://github.com/angular/angular/commit/52552f9ce80696dfadd25a1fd345e65971d9ae5e
61c2c2fhttps://github.com/angular/angular/commit/61c2c2fa3a2e422c7a6631a6f39aaeb7d972eb68
Compare https://github.com/angular/angular/compare/52552f9ce80696dfadd25a1fd345e65971d9ae5e..61c2c2fa3a2e422c7a6631a6f39aaeb7d972eb68
October 24, 2019 17:03https://github.com/angular/angular/pull/33131#event-2741531965
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Oct 24, 2019https://github.com/angular/angular/pull/33131#issuecomment-546012509
Presubmithttp://test/OCL:276510970:BASE:276511030:1571936707202:7131f2eb
Please reload this pagehttps://github.com/angular/angular/pull/33131
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Oct 24, 2019https://github.com/angular/angular/pull/33131#event-2741586056
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Oct 24, 2019https://github.com/angular/angular/pull/33131#event-2741586393
https://github.com/JoostK
https://github.com/alxhub
fix(ivy): support abstract directives in template type checkinghttps://github.com/angular/angular/pull/33131/commits/3d1960cb40720c2dafbdd00b05353934c9347fba
3d1960chttps://github.com/angular/angular/pull/33131/commits/3d1960cb40720c2dafbdd00b05353934c9347fba
angular#30080https://github.com/angular/angular/issues/30080
https://github.com/alxhub
alxhubhttps://github.com/alxhub
force-pushedhttps://github.com/angular/angular/compare/61c2c2fa3a2e422c7a6631a6f39aaeb7d972eb68..3d1960cb40720c2dafbdd00b05353934c9347fba
61c2c2fhttps://github.com/angular/angular/commit/61c2c2fa3a2e422c7a6631a6f39aaeb7d972eb68
3d1960chttps://github.com/angular/angular/commit/3d1960cb40720c2dafbdd00b05353934c9347fba
Compare https://github.com/angular/angular/compare/61c2c2fa3a2e422c7a6631a6f39aaeb7d972eb68..3d1960cb40720c2dafbdd00b05353934c9347fba
October 24, 2019 17:26https://github.com/angular/angular/pull/33131#event-2741599688
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Oct 24, 2019https://github.com/angular/angular/pull/33131#issuecomment-546036223
VE Presubmithttp://test/OCL:276524882:BASE:276524952:1571940325305:6296944e
Ivy Presubmithttp://test/OCL:276524882:BASE:276525470:1571940436789:d3651b9b
Please reload this pagehttps://github.com/angular/angular/pull/33131
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 24, 2019https://github.com/angular/angular/pull/33131#event-2741719476
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Oct 24, 2019https://github.com/angular/angular/pull/33131#event-2741973987
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
a42057dhttps://github.com/angular/angular/commit/a42057d0f8ea3f8bd7c0afc2b92a29f1800cf787
Oct 24, 2019https://github.com/angular/angular/pull/33131#event-2741994977
https://github.com/kumaresan-subramani
kumaresan-subramanihttps://github.com/kumaresan-subramani
Oct 25, 2019 https://github.com/angular/angular/pull/33131#ref-issue-451450530
Enable ivy in angular 8 - production build got failed #30818 https://github.com/angular/angular/issues/30818
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 24, 2019https://github.com/angular/angular/pull/33131#issuecomment-557902915
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/33131
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 24, 2019https://github.com/angular/angular/pull/33131#event-2826062529
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33131
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/33131/files/52552f9ce80696dfadd25a1fd345e65971d9ae5e
Please reload this pagehttps://github.com/angular/angular/pull/33131
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
effort1: hours https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
freq2: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
workaround2: non-obvious https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
Backlog https://github.com/angular/angular/milestone/82
Inputs are not inherited when Ivy is enabled https://github.com/angular/angular/issues/30080
Please reload this pagehttps://github.com/angular/angular/pull/33131
https://github.com/JoostK
https://github.com/alxhub
https://github.com/AndrewKushnir
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.