René's URL Explorer Experiment


Title: feat(ivy): type checking of event bindings by JoostK · Pull Request #33125 · angular/angular · GitHub

Open Graph Title: feat(ivy): type checking of event bindings by JoostK · Pull Request #33125 · angular/angular

X Title: feat(ivy): type checking of event bindings by JoostK · Pull Request #33125 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Until now, the template type checker has not checked any of the event bindings that could be present on an element, for example <my-cmp (changed)="handleChange($event)" (click)=&qu...

X Description: Until now, the template type checker has not checked any of the event bindings that could be present on an element, for example &lt;my-cmp (changed)=&quot;handleChange($event)&quot; ...

Opengraph URL: https://github.com/angular/angular/pull/33125

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ef372a15-6b40-f2dc-d814-eb42bedff19e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB82:28815B:E658D1:133C529:6B0106E5
html-safe-nonce04723fa60ced26bd50a4e452a55d0ed748e5e5c693c25dc836c003b1f02c5e22
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjgyOjI4ODE1QjpFNjU4RDE6MTMzQzUyOTo2QjAxMDZFNSIsInZpc2l0b3JfaWQiOiIzMTcxMzc1MDQ2ODE1OTc1MTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaa3bd3bdc93c12659223cebb2d4ab730282e098753f6d72253ee05c33efecc9f
hovercard-subject-tagpull_request:327480372
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33125/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/771638e0aeabcc723baab8d66cbf6affc6f9e0b0dbd05933c3db1138d3ad6962/angular/angular/pull/33125
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/771638e0aeabcc723baab8d66cbf6affc6f9e0b0dbd05933c3db1138d3ad6962/angular/angular/pull/33125
og:image:altUntil now, the template type checker has not checked any of the event bindings that could be present on an element, for example <my-cmp (changed)="handleChange($event)" (click)=&qu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJoostK
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/33125#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33125
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33125
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33125
Reloadhttps://github.com/angular/angular/pull/33125
Reloadhttps://github.com/angular/angular/pull/33125
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngtsc-ttc-outputshttps://github.com/JoostK/angular/tree/ngtsc-ttc-outputs
Conversationhttps://github.com/angular/angular/pull/33125
Commits2 (2)https://github.com/angular/angular/pull/33125/commits
Checkshttps://github.com/angular/angular/pull/33125/checks
Files changedhttps://github.com/angular/angular/pull/33125/files
feat(ivy): type checking of event bindingshttps://github.com/angular/angular/pull/33125#top
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngtsc-ttc-outputshttps://github.com/JoostK/angular/tree/ngtsc-ttc-outputs
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 12, 2019https://github.com/angular/angular/pull/33125#issue-506209730
Please reload this pagehttps://github.com/angular/angular/pull/33125
Please reload this pagehttps://github.com/angular/angular/pull/33125
https://github.com/JoostK
JoostKhttps://github.com/JoostK
feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
effort1: hours https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
Oct 12, 2019https://github.com/angular/angular/pull/33125#event-2708181887
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Oct 12, 2019https://github.com/angular/angular/pull/33125#event-2708181906
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 12, 2019https://github.com/angular/angular/pull/33125#event-2708181936
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/f1155b2c763ac7b7c7a3c35431cfaaa5a3b7eeae..922deae7acc6e660c5a7ddb3aaa33389cd52a961
f1155b2https://github.com/angular/angular/commit/f1155b2c763ac7b7c7a3c35431cfaaa5a3b7eeae
922deaehttps://github.com/angular/angular/commit/922deae7acc6e660c5a7ddb3aaa33389cd52a961
Compare https://github.com/angular/angular/compare/f1155b2c763ac7b7c7a3c35431cfaaa5a3b7eeae..922deae7acc6e660c5a7ddb3aaa33389cd52a961
October 12, 2019 20:03https://github.com/angular/angular/pull/33125#event-2708278323
https://github.com/JoostK
JoostKhttps://github.com/JoostK
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Oct 15, 2019https://github.com/angular/angular/pull/33125#event-2715367056
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/5edee97728920347abda2249afda0cd4df109408..aca379077556e44bbf96a417a2e1a3bbaba30d54
5edee97https://github.com/angular/angular/commit/5edee97728920347abda2249afda0cd4df109408
aca3790https://github.com/angular/angular/commit/aca379077556e44bbf96a417a2e1a3bbaba30d54
Compare https://github.com/angular/angular/compare/5edee97728920347abda2249afda0cd4df109408..aca379077556e44bbf96a417a2e1a3bbaba30d54
October 16, 2019 20:36https://github.com/angular/angular/pull/33125#event-2719044314
https://github.com/JoostK
feat(ivy): type checking of event bindingshttps://github.com/angular/angular/pull/33125/commits/3d3986c386029b2ba314d153e4348fc356c235a7
3d3986chttps://github.com/angular/angular/pull/33125/commits/3d3986c386029b2ba314d153e4348fc356c235a7
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/8bef5b462aae8ef1ce82d9ef2b4a28f2faf31333..3d3986c386029b2ba314d153e4348fc356c235a7
8bef5b4https://github.com/angular/angular/commit/8bef5b462aae8ef1ce82d9ef2b4a28f2faf31333
3d3986chttps://github.com/angular/angular/commit/3d3986c386029b2ba314d153e4348fc356c235a7
Compare https://github.com/angular/angular/compare/8bef5b462aae8ef1ce82d9ef2b4a28f2faf31333..3d3986c386029b2ba314d153e4348fc356c235a7
October 17, 2019 18:06https://github.com/angular/angular/pull/33125#event-2722254391
https://github.com/JoostK
JoostKhttps://github.com/JoostK
October 17, 2019 18:46https://github.com/angular/angular/pull/33125#event-2722372202
https://github.com/JoostK
JoostKhttps://github.com/JoostK
October 17, 2019 18:46https://github.com/angular/angular/pull/33125#event-2722372225
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Oct 17, 2019https://github.com/angular/angular/pull/33125#event-2722387868
https://github.com/JoostK
fixup! feat(ivy): type checking of event bindingshttps://github.com/angular/angular/pull/33125/commits/d337e58e8145ca81d0ac2a9afa86a7192e067695
d337e58https://github.com/angular/angular/pull/33125/commits/d337e58e8145ca81d0ac2a9afa86a7192e067695
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Oct 18, 2019 https://github.com/angular/angular/pull/33125#pullrequestreview-303574081
View reviewed changes https://github.com/angular/angular/pull/33125/files/d337e58e8145ca81d0ac2a9afa86a7192e067695
packages/compiler-cli/src/ngtsc/typecheck/src/diagnostics.tshttps://github.com/angular/angular/pull/33125/files/d337e58e8145ca81d0ac2a9afa86a7192e067695#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
alxhubhttps://github.com/alxhub
Oct 17, 2019https://github.com/angular/angular/pull/33125#discussion_r336248187
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33125
JoostKhttps://github.com/JoostK
Oct 18, 2019https://github.com/angular/angular/pull/33125#discussion_r336611640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/33125
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Oct 18, 2019https://github.com/angular/angular/pull/33125#issuecomment-543833570
Presubmithttp://test/OCL:275491665:BASE:275491689:1571417373452:ba942170
Please reload this pagehttps://github.com/angular/angular/pull/33125
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Oct 18, 2019https://github.com/angular/angular/pull/33125#event-2725556431
https://github.com/matsko
matskohttps://github.com/matsko
6958d11https://github.com/angular/angular/commit/6958d11d958f5e6002c4de4ba95494c5f8f34aa6
Oct 18, 2019https://github.com/angular/angular/pull/33125#event-2725869539
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Nov 1, 2019 https://github.com/angular/angular/pull/33125#ref-issue-516032633
Ivy: fullTemplateTypeCheck errors with noImplicitAny and null in function expressions #33528 https://github.com/angular/angular/issues/33528
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 18, 2019https://github.com/angular/angular/pull/33125#issuecomment-555086316
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/33125
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 18, 2019https://github.com/angular/angular/pull/33125#event-2808129099
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33125
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/33125/files/d337e58e8145ca81d0ac2a9afa86a7192e067695
Please reload this pagehttps://github.com/angular/angular/pull/33125
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
effort1: hours https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/33125
https://github.com/JoostK
https://github.com/alxhub
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.