| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bd799fe6-9dda-d5dc-e376-40eb6dd05ee9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCF4:157C65:22B85FB:2E5F1DF:6B019427 |
| html-safe-nonce | 267e3356c23b77b93cfa960abb80f6f64638d3debbfd51ec15b898199c772646 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0Y0OjE1N0M2NToyMkI4NUZCOjJFNUYxREY6NkIwMTk0MjciLCJ2aXNpdG9yX2lkIjoiMTgzOTg3ODUyMTU1MjQ3NTE3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3777bed72dac3a2349150fe07cbec661db3eae907bdb424507fbd0e24ba5fa4c |
| hovercard-subject-tag | pull_request:326435342 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/33066/files |
| twitter:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| og:image:alt | fix(ivy): do not always accept undefined for directive inputs
Prior to this change, the template type checker would always allow a
value of type undefined to be passed into a directive's inputs... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/33066/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33066%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33066%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/33066/files |
| Reload | https://github.com/angular/angular/pull/33066/files |
| Reload | https://github.com/angular/angular/pull/33066/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests143 (143) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:ngtsc-ttc-missing-inputs | https://github.com/JoostK/angular/tree/ngtsc-ttc-missing-inputs |
|
Conversation
9
| https://github.com/angular/angular/pull/33066 |
|
Commits
6
| https://github.com/angular/angular/pull/33066/commits |
|
Checks
0
| https://github.com/angular/angular/pull/33066/checks |
|
Files changed
| https://github.com/angular/angular/pull/33066/files |
| Please reload this page | https://github.com/angular/angular/pull/33066/files |
|
fix(ivy): do not always accept undefined for directive inputs
| https://github.com/angular/angular/pull/33066/files#top |
|
Show all changes
6 commits
| https://github.com/angular/angular/pull/33066/files |
|
e391c3b
fix(ivy): do not always accept `undefined` for directive inputs
JoostK Oct 9, 2019
| https://github.com/angular/angular/pull/33066/commits/e391c3bbe32006fcfccca15737c339f68018f65a |
|
9b75ad1
fixup! fix(ivy): do not always accept `undefined` for directive inputs
JoostK Oct 10, 2019
| https://github.com/angular/angular/pull/33066/commits/9b75ad193fdc28370b6b0493d1e21cd825af20f4 |
|
34d1611
feat(ivy): disable strict null checks for input bindings
JoostK Oct 11, 2019
| https://github.com/angular/angular/pull/33066/commits/34d16113c2887711e84bf9568ad4025a0ebbb26d |
|
422bda1
build(docs-infra): fix template type check errors
JoostK Oct 11, 2019
| https://github.com/angular/angular/pull/33066/commits/422bda12d9d3fd6b0703e62312bf598958987fef |
|
9aa8d75
feat(ivy): check regular attributes that correspond with directive in…
JoostK Oct 10, 2019
| https://github.com/angular/angular/pull/33066/commits/9aa8d75163b39a9d8371f1be4fc4184dc4c4cd9c |
|
169ef36
fixup! feat(ivy): check regular attributes that correspond with direc…
JoostK Oct 11, 2019
| https://github.com/angular/angular/pull/33066/commits/169ef3665242fdce44368c63c46fb7056dc4fa51 |
|
Clear filters
| https://github.com/angular/angular/pull/33066/files |
| Please reload this page | https://github.com/angular/angular/pull/33066/files |
| Please reload this page | https://github.com/angular/angular/pull/33066/files |
|
code-tabs.component.ts
| https://github.com/angular/angular/pull/33066/files#diff-f62968b2a6ec0542b0296aee23ded72b7ff02026487e5412559117a18b959e09 |
|
code.component.ts
| https://github.com/angular/angular/pull/33066/files#diff-3c8cd113b5fa4c350fc9d6491e48b6a0720c5e31a4a8307205e6628d1480bc41 |
|
nav-item.component.ts
| https://github.com/angular/angular/pull/33066/files#diff-743a08c7370cf6c76952d5bf7aacb675c378024b331169626adb1ba85150104b |
|
nav-menu.component.ts
| https://github.com/angular/angular/pull/33066/files#diff-daac4cfd97d7e79ae315c1678c4e2589848c160f060512f760d1ca988bcdebb7 |
|
program.ts
| https://github.com/angular/angular/pull/33066/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
api.ts
| https://github.com/angular/angular/pull/33066/files#diff-9eb22a14bc945542a06c095624ae9a9a2d4470e83888018cbbd05b956d82df81 |
|
context.ts
| https://github.com/angular/angular/pull/33066/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc |
|
expression.ts
| https://github.com/angular/angular/pull/33066/files#diff-453240e317877158d2d05725500921dc264a215eb61995bd95e194e52464cfd2 |
|
type_check_block.ts
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
type_constructor.ts
| https://github.com/angular/angular/pull/33066/files#diff-cedaec82510b21783211df4df690092a3ec37d90cea435b8486ffa9dd9e4d8d6 |
|
diagnostics_spec.ts
| https://github.com/angular/angular/pull/33066/files#diff-5d0a8394612d2d8f653ea59dfda0c809795c6bc38d2fee638849ea6f4a2fdbfd |
|
test_utils.ts
| https://github.com/angular/angular/pull/33066/files#diff-2bf4eba9f2fc57abc04d96b11f4d4ecb1c43f1d7dec431226b8fe13fe4dd70c1 |
|
type_check_block_spec.ts
| https://github.com/angular/angular/pull/33066/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad |
|
template_typecheck_spec.ts
| https://github.com/angular/angular/pull/33066/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1 |
| aio/src/app/custom-elements/code/code-tabs.component.ts | https://github.com/angular/angular/pull/33066/files#diff-f62968b2a6ec0542b0296aee23ded72b7ff02026487e5412559117a18b959e09 |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/aio/src/app/custom-elements/code/code-tabs.component.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-f62968b2a6ec0542b0296aee23ded72b7ff02026487e5412559117a18b959e09 |
|
| https://github.com/angular/angular/pull/33066/files#diff-f62968b2a6ec0542b0296aee23ded72b7ff02026487e5412559117a18b959e09 |
| aio/src/app/custom-elements/code/code.component.ts | https://github.com/angular/angular/pull/33066/files#diff-3c8cd113b5fa4c350fc9d6491e48b6a0720c5e31a4a8307205e6628d1480bc41 |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/aio/src/app/custom-elements/code/code.component.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-3c8cd113b5fa4c350fc9d6491e48b6a0720c5e31a4a8307205e6628d1480bc41 |
|
| https://github.com/angular/angular/pull/33066/files#diff-3c8cd113b5fa4c350fc9d6491e48b6a0720c5e31a4a8307205e6628d1480bc41 |
|
| https://github.com/angular/angular/pull/33066/files#diff-3c8cd113b5fa4c350fc9d6491e48b6a0720c5e31a4a8307205e6628d1480bc41 |
| aio/src/app/layout/nav-item/nav-item.component.ts | https://github.com/angular/angular/pull/33066/files#diff-743a08c7370cf6c76952d5bf7aacb675c378024b331169626adb1ba85150104b |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/aio/src/app/layout/nav-item/nav-item.component.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-743a08c7370cf6c76952d5bf7aacb675c378024b331169626adb1ba85150104b |
|
| https://github.com/angular/angular/pull/33066/files#diff-743a08c7370cf6c76952d5bf7aacb675c378024b331169626adb1ba85150104b |
| aio/src/app/layout/nav-menu/nav-menu.component.ts | https://github.com/angular/angular/pull/33066/files#diff-daac4cfd97d7e79ae315c1678c4e2589848c160f060512f760d1ca988bcdebb7 |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/aio/src/app/layout/nav-menu/nav-menu.component.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-daac4cfd97d7e79ae315c1678c4e2589848c160f060512f760d1ca988bcdebb7 |
|
| https://github.com/angular/angular/pull/33066/files#diff-daac4cfd97d7e79ae315c1678c4e2589848c160f060512f760d1ca988bcdebb7 |
| packages/compiler-cli/src/ngtsc/program.ts | https://github.com/angular/angular/pull/33066/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/packages/compiler-cli/src/ngtsc/program.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
| https://github.com/angular/angular/pull/33066/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
|
| https://github.com/angular/angular/pull/33066/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b |
| packages/compiler-cli/src/ngtsc/typecheck/src/api.ts | https://github.com/angular/angular/pull/33066/files#diff-9eb22a14bc945542a06c095624ae9a9a2d4470e83888018cbbd05b956d82df81 |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/packages/compiler-cli/src/ngtsc/typecheck/src/api.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-9eb22a14bc945542a06c095624ae9a9a2d4470e83888018cbbd05b956d82df81 |
|
| https://github.com/angular/angular/pull/33066/files#diff-9eb22a14bc945542a06c095624ae9a9a2d4470e83888018cbbd05b956d82df81 |
| packages/compiler-cli/src/ngtsc/typecheck/src/context.ts | https://github.com/angular/angular/pull/33066/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/packages/compiler-cli/src/ngtsc/typecheck/src/context.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc |
|
| https://github.com/angular/angular/pull/33066/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc |
|
| https://github.com/angular/angular/pull/33066/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc |
|
| https://github.com/angular/angular/pull/33066/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc |
|
| https://github.com/angular/angular/pull/33066/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc |
| packages/compiler-cli/src/ngtsc/typecheck/src/expression.ts | https://github.com/angular/angular/pull/33066/files#diff-453240e317877158d2d05725500921dc264a215eb61995bd95e194e52464cfd2 |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/packages/compiler-cli/src/ngtsc/typecheck/src/expression.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-453240e317877158d2d05725500921dc264a215eb61995bd95e194e52464cfd2 |
|
| https://github.com/angular/angular/pull/33066/files#diff-453240e317877158d2d05725500921dc264a215eb61995bd95e194e52464cfd2 |
| packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts | https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
View file
| https://github.com/JoostK/angular/blob/169ef3665242fdce44368c63c46fb7056dc4fa51/packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/33066/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
| Please reload this page | https://github.com/angular/angular/pull/33066/files |
|
| https://github.com/angular/angular/pull/33066/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
| Please reload this page | https://github.com/angular/angular/pull/33066/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |