René's URL Explorer Experiment


Title: feat(compiler-cli): resolve type of exported *ngIf variable. by andrius-pra · Pull Request #33016 · angular/angular · GitHub

Open Graph Title: feat(compiler-cli): resolve type of exported *ngIf variable. by andrius-pra · Pull Request #33016 · angular/angular

X Title: feat(compiler-cli): resolve type of exported *ngIf variable. by andrius-pra · Pull Request #33016 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Angular compiler does not resolve the type of exported variable from *ngIf directive. It always returns any type. So language service can't provide completions for type members. Issue Number: angular/vscode-ng-language-service#255 What is the new behavior? Compiler will try resolve type of exported variable and will use this type for type-checking. Angular language service will use this type for completions, go to definition and quick info functionality. Also language service will provide more accurate diagnostic errors during development. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/33016

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ab271d30-5494-f08a-697f-dcecfe391aa7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE78C:215B92:1FFEB60:2A8BF87:6B017CA8
html-safe-nonce2546e4c6584d4eee9ea7b9acdddb798e7a511f8ca9556170edb3527e82f757db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzhDOjIxNUI5MjoxRkZFQjYwOjJBOEJGODc6NkIwMTdDQTgiLCJ2aXNpdG9yX2lkIjoiNTkzNDAwMTY1MzQ1OTAyNTA2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac193d623491601bb5752e7cda052e6ab0639f27a40625c12f4f079c3b9a5261e8
hovercard-subject-tagpull_request:324940177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/33016/files
twitter:imagehttps://avatars.githubusercontent.com/u/17968027?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17968027?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33016/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33016%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33016%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33016/files
Reloadhttps://github.com/angular/angular/pull/33016/files
Reloadhttps://github.com/angular/angular/pull/33016/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
andrius-prahttps://github.com/andrius-pra
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 14 https://github.com/angular/angular/pull/33016
Commits 1 https://github.com/angular/angular/pull/33016/commits
Checks 0 https://github.com/angular/angular/pull/33016/checks
Files changed https://github.com/angular/angular/pull/33016/files
Please reload this pagehttps://github.com/angular/angular/pull/33016/files
feat(compiler-cli): resolve type of exported *ngIf variable. https://github.com/angular/angular/pull/33016/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/33016/files
e8a167f fix(compiler-cli): resolve type of exported *ngIf variable. andrius-pra Oct 5, 2019 https://github.com/angular/angular/pull/33016/commits/e8a167ff4e2cf12b4b93156fe9d4fccd31ba5f9f
Clear filters https://github.com/angular/angular/pull/33016/files
Please reload this pagehttps://github.com/angular/angular/pull/33016/files
Please reload this pagehttps://github.com/angular/angular/pull/33016/files
expression_diagnostics.ts https://github.com/angular/angular/pull/33016/files#diff-044d1adc990700ed0c41431aae0062114068464e010203b04c4f989c5c627714
expression_diagnostics_spec.ts https://github.com/angular/angular/pull/33016/files#diff-6994d99ca07d2a9f4d4a370983c140f2e7300e5b61f135174a97d9887b4712eb
completions_spec.ts https://github.com/angular/angular/pull/33016/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
packages/compiler-cli/src/diagnostics/expression_diagnostics.tshttps://github.com/angular/angular/pull/33016/files#diff-044d1adc990700ed0c41431aae0062114068464e010203b04c4f989c5c627714
View file https://github.com/angular/angular/blob/e8a167ff4e2cf12b4b93156fe9d4fccd31ba5f9f/packages/compiler-cli/src/diagnostics/expression_diagnostics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33016/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33016/files#diff-044d1adc990700ed0c41431aae0062114068464e010203b04c4f989c5c627714
https://github.com/angular/angular/pull/33016/files#diff-044d1adc990700ed0c41431aae0062114068464e010203b04c4f989c5c627714
packages/compiler-cli/test/diagnostics/expression_diagnostics_spec.tshttps://github.com/angular/angular/pull/33016/files#diff-6994d99ca07d2a9f4d4a370983c140f2e7300e5b61f135174a97d9887b4712eb
View file https://github.com/angular/angular/blob/e8a167ff4e2cf12b4b93156fe9d4fccd31ba5f9f/packages/compiler-cli/test/diagnostics/expression_diagnostics_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33016/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33016/files#diff-6994d99ca07d2a9f4d4a370983c140f2e7300e5b61f135174a97d9887b4712eb
Please reload this pagehttps://github.com/angular/angular/pull/33016/files
https://github.com/angular/angular/pull/33016/files#diff-6994d99ca07d2a9f4d4a370983c140f2e7300e5b61f135174a97d9887b4712eb
packages/language-service/test/completions_spec.tshttps://github.com/angular/angular/pull/33016/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
View file https://github.com/angular/angular/blob/e8a167ff4e2cf12b4b93156fe9d4fccd31ba5f9f/packages/language-service/test/completions_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33016/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33016/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
https://github.com/angular/angular/pull/33016/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.