René's URL Explorer Experiment


Title: fix(router): support lazy loading for named outlets by asvishnyakov · Pull Request #32688 · angular/angular · GitHub

Open Graph Title: fix(router): support lazy loading for named outlets by asvishnyakov · Pull Request #32688 · angular/angular

X Title: fix(router): support lazy loading for named outlets by asvishnyakov · Pull Request #32688 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? This is correct implementation and replacement of #25483 This PR is avoid problem appear in #25483: the same error occurs when you have lazy-loaded default route and routes with empty path and named outlet before it. Given the following route configuration: [ {path: '', loadChildren: 'children'}, {path: 'a', loadChildren: 'otherChildren', outlet: 'aux'} ] With this configuration, using the outlet as an entry point to the application, the root module will not load properly and results in the following error: TypeError: Cannot read property 'routes' of undefined at getChildConfig (router.js:3041) The _loadedConfig property of the route remains undefined as the expandSegmentAgainstRoute() isn't executed. This issue is only present if the root has a lazy loaded module, works fine with a component or even with a lazy loaded module if the root path is not empty. Issue Number: #12842 What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/32688

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1c43a533-ea19-2bc7-d9a1-2d9525fdd925
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6C6:7A60E:F2B972:13939E3:6B010074
html-safe-nonce789c93815d1df853d4d49382f1d6b264d8a47739bdc81a700f36eb9e62c94357
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkM2OjdBNjBFOkYyQjk3MjoxMzkzOUUzOjZCMDEwMDc0IiwidmlzaXRvcl9pZCI6IjM5Njg2MTIyNDkzMDM1ODA3ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7edaca02264e17bcc8e6881b0f67eda74b67e7ce9ca6f7af3698642447631902
hovercard-subject-tagpull_request:317664864
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/32688/files
twitter:imagehttps://avatars.githubusercontent.com/u/6369252?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6369252?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/32688/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F32688%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F32688%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/32688/files
Reloadhttps://github.com/angular/angular/pull/32688/files
Reloadhttps://github.com/angular/angular/pull/32688/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
asvishnyakovhttps://github.com/asvishnyakov
angular:masterhttps://github.com/angular/angular/tree/master
asvishnyakov:masterhttps://github.com/asvishnyakov/angular/tree/master
Conversation 14 https://github.com/angular/angular/pull/32688
Commits 3 https://github.com/angular/angular/pull/32688/commits
Checks 0 https://github.com/angular/angular/pull/32688/checks
Files changed https://github.com/angular/angular/pull/32688/files
Please reload this pagehttps://github.com/angular/angular/pull/32688/files
fix(router): support lazy loading for named outlets https://github.com/angular/angular/pull/32688/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/32688/files
f51a108 fix(router): support lazy loading for named outlets with empty path asvishnyakov Sep 15, 2019 https://github.com/angular/angular/pull/32688/commits/f51a108259045ebccf142bad5b9809b4d6dd6d85
7f5f43b fixup! fix(router): support lazy loading for named outlets with empty… atscott Aug 4, 2020 https://github.com/angular/angular/pull/32688/commits/7f5f43b846d18d2baa3093adecd27dab576fcfb4
37e273b fixup! fix(router): support lazy loading for named outlets with empty… atscott Aug 6, 2020 https://github.com/angular/angular/pull/32688/commits/37e273b720f53cad0d5f0858eb45b87f419dcaeb
Clear filters https://github.com/angular/angular/pull/32688/files
Please reload this pagehttps://github.com/angular/angular/pull/32688/files
Please reload this pagehttps://github.com/angular/angular/pull/32688/files
apply_redirects.ts https://github.com/angular/angular/pull/32688/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
apply_redirects.spec.ts https://github.com/angular/angular/pull/32688/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
packages/router/src/apply_redirects.tshttps://github.com/angular/angular/pull/32688/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
View file https://github.com/asvishnyakov/angular/blob/37e273b720f53cad0d5f0858eb45b87f419dcaeb/packages/router/src/apply_redirects.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32688/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32688/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/32688/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/32688/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/32688/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/32688/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
packages/router/test/apply_redirects.spec.tshttps://github.com/angular/angular/pull/32688/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
View file https://github.com/asvishnyakov/angular/blob/37e273b720f53cad0d5f0858eb45b87f419dcaeb/packages/router/test/apply_redirects.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32688/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32688/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com/angular/angular/pull/32688/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com/angular/angular/pull/32688/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com/angular/angular/pull/32688/files#diff-f2a6ddca34dd8b18717187c7b81638613c564d9aa1fc72e99434fc66a78e4ba5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.