René's URL Explorer Experiment


Title: feat(language-service): Completions for custom-event bindings by andrius-pra · Pull Request #32085 · angular/angular · GitHub

Open Graph Title: feat(language-service): Completions for custom-event bindings by andrius-pra · Pull Request #32085 · angular/angular

X Title: feat(language-service): Completions for custom-event bindings by andrius-pra · Pull Request #32085 · angular/angular

Description: Resolves type of $event variable in a event binding. So language service can provide completions for $event type members. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? The method getEventDeclaration() always returns "any" type for the event. So language service can't provide completions for $event variable. Issue Number: #25545 What is the new behavior? Determine the type of the event based on the Observable or EventEmitter types. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: Resolves type of $event variable in a event binding. So language service can provide completions for $event type members. PR Checklist Please check if your PR fulfills the following requirements: ...

X Description: Resolves type of $event variable in a event binding. So language service can provide completions for $event type members. PR Checklist Please check if your PR fulfills the following requirements: ...

Opengraph URL: https://github.com/angular/angular/pull/32085

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:74f18ab8-a570-8a46-17d2-e281da0b86f5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id918A:EDA7A:1E1D00C:263D6A4:6B01627C
html-safe-noncec68112a8c53fe16c747e6872fcb5a096565551eb97895ef14b6656f58c50524d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MThBOkVEQTdBOjFFMUQwMEM6MjYzRDZBNDo2QjAxNjI3QyIsInZpc2l0b3JfaWQiOiI0OTEyMzQzMDE2NjYxOTM0NzE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdf6b49d0ff61c607ca67ad03f08bc062cacf184d4ede542e712760ee1a2eac36
hovercard-subject-tagpull_request:306099150
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/32085/files
twitter:imagehttps://avatars.githubusercontent.com/u/17968027?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17968027?s=400&v=4
og:image:altResolves type of $event variable in a event binding. So language service can provide completions for $event type members. PR Checklist Please check if your PR fulfills the following requirements: ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/32085/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F32085%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F32085%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/32085/files
Reloadhttps://github.com/angular/angular/pull/32085/files
Reloadhttps://github.com/angular/angular/pull/32085/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
andrius-prahttps://github.com/andrius-pra
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 3 https://github.com/angular/angular/pull/32085
Commits 1 https://github.com/angular/angular/pull/32085/commits
Checks 0 https://github.com/angular/angular/pull/32085/checks
Files changed https://github.com/angular/angular/pull/32085/files
Please reload this pagehttps://github.com/angular/angular/pull/32085/files
feat(language-service): Completions for custom-event bindings https://github.com/angular/angular/pull/32085/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/32085/files
8790662 feat(language-service): Completions for event bindings andrius-pra Aug 9, 2019 https://github.com/angular/angular/pull/32085/commits/87906628b63ebdb30c98fc49ca005fb3f9c7791a
Clear filters https://github.com/angular/angular/pull/32085/files
Please reload this pagehttps://github.com/angular/angular/pull/32085/files
Please reload this pagehttps://github.com/angular/angular/pull/32085/files
completions.ts https://github.com/angular/angular/pull/32085/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
expression_diagnostics.ts https://github.com/angular/angular/pull/32085/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
locate_symbol.ts https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
symbols.ts https://github.com/angular/angular/pull/32085/files#diff-191e97cb0d49b19e88a3f83451d0bd1c7dc064cddf5396ed1cbac5bfeb1fb28f
typescript_symbols.ts https://github.com/angular/angular/pull/32085/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
completions_spec.ts https://github.com/angular/angular/pull/32085/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
main.ts https://github.com/angular/angular/pull/32085/files#diff-c60722d70d347cf0fd4ff2de118cc2ca2bc045d8e9ceb19c4d2dbf1d3a60855e
parsing-cases.ts https://github.com/angular/angular/pull/32085/files#diff-21fda52d7af70c473ededd3a9724dd39eed96de4f2afd852f27edd7267cffceb
typescript_host_spec.ts https://github.com/angular/angular/pull/32085/files#diff-fe0e93533e851eb04546b1bb0de70cb8f4078e4ea01bf0d207189735b7365b88
packages/language-service/src/completions.tshttps://github.com/angular/angular/pull/32085/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/src/completions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
https://github.com/angular/angular/pull/32085/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
packages/language-service/src/expression_diagnostics.tshttps://github.com/angular/angular/pull/32085/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/src/expression_diagnostics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
https://github.com/angular/angular/pull/32085/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
https://github.com/angular/angular/pull/32085/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
https://github.com/angular/angular/pull/32085/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
packages/language-service/src/locate_symbol.tshttps://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/src/locate_symbol.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/32085/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
packages/language-service/src/symbols.tshttps://github.com/angular/angular/pull/32085/files#diff-191e97cb0d49b19e88a3f83451d0bd1c7dc064cddf5396ed1cbac5bfeb1fb28f
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/src/symbols.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-191e97cb0d49b19e88a3f83451d0bd1c7dc064cddf5396ed1cbac5bfeb1fb28f
https://github.com/angular/angular/pull/32085/files#diff-191e97cb0d49b19e88a3f83451d0bd1c7dc064cddf5396ed1cbac5bfeb1fb28f
packages/language-service/src/typescript_symbols.tshttps://github.com/angular/angular/pull/32085/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/src/typescript_symbols.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/32085/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
packages/language-service/test/completions_spec.tshttps://github.com/angular/angular/pull/32085/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/test/completions_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
https://github.com/angular/angular/pull/32085/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
packages/language-service/test/project/app/main.tshttps://github.com/angular/angular/pull/32085/files#diff-c60722d70d347cf0fd4ff2de118cc2ca2bc045d8e9ceb19c4d2dbf1d3a60855e
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/test/project/app/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-c60722d70d347cf0fd4ff2de118cc2ca2bc045d8e9ceb19c4d2dbf1d3a60855e
https://github.com/angular/angular/pull/32085/files#diff-c60722d70d347cf0fd4ff2de118cc2ca2bc045d8e9ceb19c4d2dbf1d3a60855e
packages/language-service/test/project/app/parsing-cases.tshttps://github.com/angular/angular/pull/32085/files#diff-21fda52d7af70c473ededd3a9724dd39eed96de4f2afd852f27edd7267cffceb
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/test/project/app/parsing-cases.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-21fda52d7af70c473ededd3a9724dd39eed96de4f2afd852f27edd7267cffceb
packages/language-service/test/typescript_host_spec.tshttps://github.com/angular/angular/pull/32085/files#diff-fe0e93533e851eb04546b1bb0de70cb8f4078e4ea01bf0d207189735b7365b88
View file https://github.com/angular/angular/blob/87906628b63ebdb30c98fc49ca005fb3f9c7791a/packages/language-service/test/typescript_host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/32085/{{ revealButtonHref }}
https://github.com/angular/angular/pull/32085/files#diff-fe0e93533e851eb04546b1bb0de70cb8f4078e4ea01bf0d207189735b7365b88
https://github.com/angular/angular/pull/32085/files#diff-fe0e93533e851eb04546b1bb0de70cb8f4078e4ea01bf0d207189735b7365b88
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.