| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b3b71591-305e-0c1e-feb3-d64320d9e3d1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A534:4BB79:1516BFD:1AE8385:6B013356 |
| html-safe-nonce | 0de8863a08af924596e6962b21cc7f51c79cbca0624aae3332365040ea7d1474 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTM0OjRCQjc5OjE1MTZCRkQ6MUFFODM4NTo2QjAxMzM1NiIsInZpc2l0b3JfaWQiOiIxOTU5NjA4ODY1MzAxNTQxNzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a233d72f53c8a88683034e9af64fc682c1814514faa8b5921dfde7087afaef36 |
| hovercard-subject-tag | pull_request:304002115 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31983/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e5d16a55183ac40de53bad740e8e751b2f00f5eaa748da9c1b7aa496b5e9a2bf/angular/angular/pull/31983 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e5d16a55183ac40de53bad740e8e751b2f00f5eaa748da9c1b7aa496b5e9a2bf/angular/angular/pull/31983 |
| og:image:alt | In BrowserModule the value of LOCALE_ID is defined in the APPLICATION_MODULE_PROVIDERS after APP_INITIALIZER has run.
This PR ensures that LOCALE_ID is also set for ivy at the same moment which all... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ocombe |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/31983#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31983 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31983 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/31983 |
| Reload | https://github.com/angular/angular/pull/31983 |
| Reload | https://github.com/angular/angular/pull/31983 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| ocombe | https://github.com/ocombe |
| angular:8.2.x | https://github.com/angular/angular/tree/8.2.x |
| ocombe:fix/ivy/fw-1436-locale-id | https://github.com/ocombe/angular/tree/fix/ivy/fw-1436-locale-id |
| Conversation | https://github.com/angular/angular/pull/31983 |
| Commits1 (1) | https://github.com/angular/angular/pull/31983/commits |
| Checks | https://github.com/angular/angular/pull/31983/checks |
| Files changed | https://github.com/angular/angular/pull/31983/files |
| fix(ivy): set LOCALE_ID when using the injector | https://github.com/angular/angular/pull/31983#top |
| ocombe | https://github.com/ocombe |
| angular:8.2.x | https://github.com/angular/angular/tree/8.2.x |
| ocombe:fix/ivy/fw-1436-locale-id | https://github.com/ocombe/angular/tree/fix/ivy/fw-1436-locale-id |
|
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Aug 3, 2019 | https://github.com/angular/angular/pull/31983#issue-476454343 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
PR target: patch-only
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22PR%20target%3A%20patch-only%22 |
| Aug 3, 2019 | https://github.com/angular/angular/pull/31983#event-2531323910 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| AndrewKushnir | https://github.com/AndrewKushnir |
| August 3, 2019 14:01 | https://github.com/angular/angular/pull/31983#event-2531323915 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Aug 3, 2019 | https://github.com/angular/angular/pull/31983#event-2531323946 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Aug 3, 2019 | https://github.com/angular/angular/pull/31983#event-2531323964 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Aug 3, 2019 | https://github.com/angular/angular/pull/31983#event-2531324089 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Aug 3, 2019
| https://github.com/angular/angular/pull/31983#pullrequestreview-270466724 |
|
View reviewed changes
| https://github.com/angular/angular/pull/31983/files |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/31983#pullrequestreview-270466724 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ocombe | https://github.com/ocombe |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Aug 3, 2019 | https://github.com/angular/angular/pull/31983#event-2531402547 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Aug 5, 2019 | https://github.com/angular/angular/pull/31983#issuecomment-518313927 |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Aug 5, 2019 | https://github.com/angular/angular/pull/31983#issuecomment-518326432 |
| @alxhub | https://github.com/alxhub |
| #31465 | https://github.com/angular/angular/issues/31465 |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
|
| https://github.com/ocombe |
|
| https://github.com/alxhub |
| fix(ivy): set LOCALE_ID when using the injector | https://github.com/angular/angular/pull/31983/commits/08c449dd746bae31ba228164054b90c8402de20f |
| 08c449d | https://github.com/angular/angular/pull/31983/commits/08c449dd746bae31ba228164054b90c8402de20f |
| angular#31465 | https://github.com/angular/angular/issues/31465 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| force-pushed | https://github.com/angular/angular/compare/57430b5034e790f62ec24476ee5be227af917941..08c449dd746bae31ba228164054b90c8402de20f |
| 57430b5 | https://github.com/angular/angular/commit/57430b5034e790f62ec24476ee5be227af917941 |
| 08c449d | https://github.com/angular/angular/commit/08c449dd746bae31ba228164054b90c8402de20f |
|
Compare
| https://github.com/angular/angular/compare/57430b5034e790f62ec24476ee5be227af917941..08c449dd746bae31ba228164054b90c8402de20f |
| August 5, 2019 20:13 | https://github.com/angular/angular/pull/31983#event-2534654725 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Aug 8, 2019
| https://github.com/angular/angular/pull/31983#ref-issue-477764807 |
|
Promise rejection: Cannot read property 'toLowerCase' of undefined
#32034
| https://github.com/angular/angular/issues/32034 |
| alxhub | https://github.com/alxhub |
|
Aug 8, 2019
| https://github.com/angular/angular/pull/31983#ref-commit-cfaefa9 |
|
| https://github.com/ocombe |
|
| https://github.com/alxhub |
| fix(ivy): set LOCALE_ID when using the injector ( | https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8 |
| #31983 | https://github.com/angular/angular/pull/31983 |
| ) | https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8 |
| cfaefa9 | https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8 |
| #31465 | https://github.com/angular/angular/issues/31465 |
| #31983 | https://github.com/angular/angular/pull/31983 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Aug 8, 2019 | https://github.com/angular/angular/pull/31983#issuecomment-519662970 |
| cfaefa9 | https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8 |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Aug 8, 2019 | https://github.com/angular/angular/pull/31983#event-2544498463 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 15, 2019 | https://github.com/angular/angular/pull/31983#issuecomment-531551377 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 15, 2019 | https://github.com/angular/angular/pull/31983#event-2634565980 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31983 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/31983/files/57430b5034e790f62ec24476ee5be227af917941 |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/31983 |
|
| https://github.com/ocombe |
|
| https://github.com/alxhub |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |