René's URL Explorer Experiment


Title: fix(ivy): set LOCALE_ID when using the injector by ocombe · Pull Request #31983 · angular/angular · GitHub

Open Graph Title: fix(ivy): set LOCALE_ID when using the injector by ocombe · Pull Request #31983 · angular/angular

X Title: fix(ivy): set LOCALE_ID when using the injector by ocombe · Pull Request #31983 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: In BrowserModule the value of LOCALE_ID is defined in the APPLICATION_MODULE_PROVIDERS after APP_INITIALIZER has run. This PR ensures that LOCALE_ID is also set for ivy at the same moment which all...

X Description: In BrowserModule the value of LOCALE_ID is defined in the APPLICATION_MODULE_PROVIDERS after APP_INITIALIZER has run. This PR ensures that LOCALE_ID is also set for ivy at the same moment which all...

Opengraph URL: https://github.com/angular/angular/pull/31983

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b3b71591-305e-0c1e-feb3-d64320d9e3d1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA534:4BB79:1516BFD:1AE8385:6B013356
html-safe-nonce0de8863a08af924596e6962b21cc7f51c79cbca0624aae3332365040ea7d1474
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTM0OjRCQjc5OjE1MTZCRkQ6MUFFODM4NTo2QjAxMzM1NiIsInZpc2l0b3JfaWQiOiIxOTU5NjA4ODY1MzAxNTQxNzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca233d72f53c8a88683034e9af64fc682c1814514faa8b5921dfde7087afaef36
hovercard-subject-tagpull_request:304002115
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31983/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e5d16a55183ac40de53bad740e8e751b2f00f5eaa748da9c1b7aa496b5e9a2bf/angular/angular/pull/31983
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e5d16a55183ac40de53bad740e8e751b2f00f5eaa748da9c1b7aa496b5e9a2bf/angular/angular/pull/31983
og:image:altIn BrowserModule the value of LOCALE_ID is defined in the APPLICATION_MODULE_PROVIDERS after APP_INITIALIZER has run. This PR ensures that LOCALE_ID is also set for ivy at the same moment which all...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameocombe
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/31983#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31983
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31983
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31983
Reloadhttps://github.com/angular/angular/pull/31983
Reloadhttps://github.com/angular/angular/pull/31983
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
ocombehttps://github.com/ocombe
angular:8.2.xhttps://github.com/angular/angular/tree/8.2.x
ocombe:fix/ivy/fw-1436-locale-idhttps://github.com/ocombe/angular/tree/fix/ivy/fw-1436-locale-id
Conversationhttps://github.com/angular/angular/pull/31983
Commits1 (1)https://github.com/angular/angular/pull/31983/commits
Checkshttps://github.com/angular/angular/pull/31983/checks
Files changedhttps://github.com/angular/angular/pull/31983/files
fix(ivy): set LOCALE_ID when using the injectorhttps://github.com/angular/angular/pull/31983#top
ocombehttps://github.com/ocombe
angular:8.2.xhttps://github.com/angular/angular/tree/8.2.x
ocombe:fix/ivy/fw-1436-locale-idhttps://github.com/ocombe/angular/tree/fix/ivy/fw-1436-locale-id
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 3, 2019https://github.com/angular/angular/pull/31983#issue-476454343
@AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/31983
https://github.com/ocombe
ocombehttps://github.com/ocombe
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
PR target: patch-only https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22PR%20target%3A%20patch-only%22
Aug 3, 2019https://github.com/angular/angular/pull/31983#event-2531323910
https://github.com/ocombe
ocombehttps://github.com/ocombe
AndrewKushnirhttps://github.com/AndrewKushnir
August 3, 2019 14:01https://github.com/angular/angular/pull/31983#event-2531323915
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Aug 3, 2019https://github.com/angular/angular/pull/31983#event-2531323946
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 3, 2019https://github.com/angular/angular/pull/31983#event-2531323964
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 3, 2019https://github.com/angular/angular/pull/31983#event-2531324089
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Aug 3, 2019 https://github.com/angular/angular/pull/31983#pullrequestreview-270466724
View reviewed changes https://github.com/angular/angular/pull/31983/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/31983#pullrequestreview-270466724
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ocombehttps://github.com/ocombe
Please reload this pagehttps://github.com/angular/angular/pull/31983
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 3, 2019https://github.com/angular/angular/pull/31983#event-2531402547
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Aug 5, 2019https://github.com/angular/angular/pull/31983#issuecomment-518313927
Please reload this pagehttps://github.com/angular/angular/pull/31983
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 5, 2019https://github.com/angular/angular/pull/31983#issuecomment-518326432
@alxhubhttps://github.com/alxhub
#31465https://github.com/angular/angular/issues/31465
Please reload this pagehttps://github.com/angular/angular/pull/31983
https://github.com/ocombe
https://github.com/alxhub
fix(ivy): set LOCALE_ID when using the injectorhttps://github.com/angular/angular/pull/31983/commits/08c449dd746bae31ba228164054b90c8402de20f
08c449dhttps://github.com/angular/angular/pull/31983/commits/08c449dd746bae31ba228164054b90c8402de20f
angular#31465https://github.com/angular/angular/issues/31465
https://github.com/alxhub
alxhubhttps://github.com/alxhub
force-pushedhttps://github.com/angular/angular/compare/57430b5034e790f62ec24476ee5be227af917941..08c449dd746bae31ba228164054b90c8402de20f
57430b5https://github.com/angular/angular/commit/57430b5034e790f62ec24476ee5be227af917941
08c449dhttps://github.com/angular/angular/commit/08c449dd746bae31ba228164054b90c8402de20f
Compare https://github.com/angular/angular/compare/57430b5034e790f62ec24476ee5be227af917941..08c449dd746bae31ba228164054b90c8402de20f
August 5, 2019 20:13https://github.com/angular/angular/pull/31983#event-2534654725
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Aug 8, 2019 https://github.com/angular/angular/pull/31983#ref-issue-477764807
Promise rejection: Cannot read property 'toLowerCase' of undefined #32034 https://github.com/angular/angular/issues/32034
alxhubhttps://github.com/alxhub
Aug 8, 2019 https://github.com/angular/angular/pull/31983#ref-commit-cfaefa9
https://github.com/ocombe
https://github.com/alxhub
fix(ivy): set LOCALE_ID when using the injector (https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8
#31983https://github.com/angular/angular/pull/31983
)https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8
cfaefa9https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8
#31465https://github.com/angular/angular/issues/31465
#31983https://github.com/angular/angular/pull/31983
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Aug 8, 2019https://github.com/angular/angular/pull/31983#issuecomment-519662970
cfaefa9https://github.com/angular/angular/commit/cfaefa9964775e6ad892ed96d2287cdb0608b3c8
Please reload this pagehttps://github.com/angular/angular/pull/31983
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Aug 8, 2019https://github.com/angular/angular/pull/31983#event-2544498463
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31983#issuecomment-531551377
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/31983
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31983#event-2634565980
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31983
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/31983/files/57430b5034e790f62ec24476ee5be227af917941
Please reload this pagehttps://github.com/angular/angular/pull/31983
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/31983
https://github.com/ocombe
https://github.com/alxhub
https://github.com/AndrewKushnir
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.