René's URL Explorer Experiment


Title: fix(ivy): reuse compilation scope for incremental template changes. by petebacondarwin · Pull Request #31932 · angular/angular · GitHub

Open Graph Title: fix(ivy): reuse compilation scope for incremental template changes. by petebacondarwin · Pull Request #31932 · angular/angular

X Title: fix(ivy): reuse compilation scope for incremental template changes. by petebacondarwin · Pull Request #31932 · angular/angular

Description: Previously if only a component template changed then we would know to rebuild its component source file. But the compilation was incorrect if the component was part of an NgModule, since we were not capturing the compilation scope information that had a been acquired from the NgModule and was not being regenerated since we were not needing to recompile the NgModule. Now we register compilation scope information for each component, via the ComponentScopeRegistry interface, so that it is available for incremental compilation. The ComponentDecoratorHandler now reads the compilation scope from a ComponentScopeReader interface which is implemented as a compound reader composed of the original LocalModuleScopeRegistry and the IncrementalState. Fixes #31654

Open Graph Description: Previously if only a component template changed then we would know to rebuild its component source file. But the compilation was incorrect if the component was part of an NgModule, since we were no...

X Description: Previously if only a component template changed then we would know to rebuild its component source file. But the compilation was incorrect if the component was part of an NgModule, since we were no...

Opengraph URL: https://github.com/angular/angular/pull/31932

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ad305ea1-807f-836e-96f9-8e1fd073d7f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD3C:21AC3F:1F79573:27D33FC:6B014DFC
html-safe-nonce12fc13695c96c7abdc1399188d36ffd7fdeb7f9b708eebd53c91e4dbadda178d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDNDOjIxQUMzRjoxRjc5NTczOjI3RDMzRkM6NkIwMTRERkMiLCJ2aXNpdG9yX2lkIjoiNDI1MjQ3Nzk5Mzc4OTc3MTI2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacccba73f042c6df0950afb1c9230cf0d37b4fb25e536627cbe1cf7bb174da27cb
hovercard-subject-tagpull_request:303028416
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/31932/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altPreviously if only a component template changed then we would know to rebuild its component source file. But the compilation was incorrect if the component was part of an NgModule, since we were no...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/31932/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31932%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31932%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31932/files
Reloadhttps://github.com/angular/angular/pull/31932/files
Reloadhttps://github.com/angular/angular/pull/31932/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngtsc-incremental-resource-fix-issue-15122-ahttps://github.com/petebacondarwin/angular/tree/ngtsc-incremental-resource-fix-issue-15122-a
Conversation 16 https://github.com/angular/angular/pull/31932
Commits 1 https://github.com/angular/angular/pull/31932/commits
Checks 0 https://github.com/angular/angular/pull/31932/checks
Files changed https://github.com/angular/angular/pull/31932/files
Please reload this pagehttps://github.com/angular/angular/pull/31932/files
fix(ivy): reuse compilation scope for incremental template changes. https://github.com/angular/angular/pull/31932/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/31932/files
d643043 fix(ivy): reuse compilation scope for incremental template changes. petebacondarwin Jul 31, 2019 https://github.com/angular/angular/pull/31932/commits/d6430436fb205de2c3a20efdc88ab1a3a35c7da9
Clear filters https://github.com/angular/angular/pull/31932/files
Please reload this pagehttps://github.com/angular/angular/pull/31932/files
Please reload this pagehttps://github.com/angular/angular/pull/31932/files
decoration_analyzer.ts https://github.com/angular/angular/pull/31932/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
component.ts https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
component_spec.ts https://github.com/angular/angular/pull/31932/files#diff-fd4e70e4fdb43e6edb1c1c425c87890ffb8820721e028f09d355bb849591fb82
BUILD.bazel https://github.com/angular/angular/pull/31932/files#diff-e6717de52264de0757f2ab7db3ecc6282de8f5483c65992b6cf8223fad0ac2fe
state.ts https://github.com/angular/angular/pull/31932/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
program.ts https://github.com/angular/angular/pull/31932/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
index.ts https://github.com/angular/angular/pull/31932/files#diff-3f517eec84b53460713bc8b4784d2372b5fbc4c1b2501c89f786f903e3ff8437
component_scope.ts https://github.com/angular/angular/pull/31932/files#diff-81bca30b08fd0e500cda6ec5fd896f98a17d56dddbd0d1ba502d706f5a4d9a54
local.ts https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
incremental_spec.ts https://github.com/angular/angular/pull/31932/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/31932/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/31932/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
packages/compiler-cli/src/ngtsc/annotations/src/component.tshttps://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/annotations/src/component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/31932/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
packages/compiler-cli/src/ngtsc/annotations/test/component_spec.tshttps://github.com/angular/angular/pull/31932/files#diff-fd4e70e4fdb43e6edb1c1c425c87890ffb8820721e028f09d355bb849591fb82
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/annotations/test/component_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-fd4e70e4fdb43e6edb1c1c425c87890ffb8820721e028f09d355bb849591fb82
https://github.com/angular/angular/pull/31932/files#diff-fd4e70e4fdb43e6edb1c1c425c87890ffb8820721e028f09d355bb849591fb82
packages/compiler-cli/src/ngtsc/incremental/BUILD.bazelhttps://github.com/angular/angular/pull/31932/files#diff-e6717de52264de0757f2ab7db3ecc6282de8f5483c65992b6cf8223fad0ac2fe
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/incremental/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-e6717de52264de0757f2ab7db3ecc6282de8f5483c65992b6cf8223fad0ac2fe
https://github.com/angular/angular/pull/31932/files#diff-e6717de52264de0757f2ab7db3ecc6282de8f5483c65992b6cf8223fad0ac2fe
packages/compiler-cli/src/ngtsc/incremental/src/state.tshttps://github.com/angular/angular/pull/31932/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/incremental/src/state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
https://github.com/angular/angular/pull/31932/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
https://github.com/angular/angular/pull/31932/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
https://github.com/angular/angular/pull/31932/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
Please reload this pagehttps://github.com/angular/angular/pull/31932/files
alxhubhttps://github.com/alxhub
Aug 5, 2019https://github.com/angular/angular/pull/31932/files#r310816597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31932/files
petebacondarwinhttps://github.com/petebacondarwin
Aug 6, 2019https://github.com/angular/angular/pull/31932/files#r311058095
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://angular-team.atlassian.net/browse/FW-1501https://angular-team.atlassian.net/browse/FW-1501
Please reload this pagehttps://github.com/angular/angular/pull/31932/files
https://github.com/angular/angular/pull/31932/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
packages/compiler-cli/src/ngtsc/program.tshttps://github.com/angular/angular/pull/31932/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/program.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
https://github.com/angular/angular/pull/31932/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
https://github.com/angular/angular/pull/31932/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
https://github.com/angular/angular/pull/31932/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
https://github.com/angular/angular/pull/31932/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
packages/compiler-cli/src/ngtsc/scope/index.tshttps://github.com/angular/angular/pull/31932/files#diff-3f517eec84b53460713bc8b4784d2372b5fbc4c1b2501c89f786f903e3ff8437
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/scope/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-3f517eec84b53460713bc8b4784d2372b5fbc4c1b2501c89f786f903e3ff8437
packages/compiler-cli/src/ngtsc/scope/src/component_scope.tshttps://github.com/angular/angular/pull/31932/files#diff-81bca30b08fd0e500cda6ec5fd896f98a17d56dddbd0d1ba502d706f5a4d9a54
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/scope/src/component_scope.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
packages/compiler-cli/src/ngtsc/scope/src/local.tshttps://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
View file https://github.com/petebacondarwin/angular/blob/d6430436fb205de2c3a20efdc88ab1a3a35c7da9/packages/compiler-cli/src/ngtsc/scope/src/local.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
https://github.com/angular/angular/pull/31932/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
Please reload this pagehttps://github.com/angular/angular/pull/31932/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.