René's URL Explorer Experiment


Title: Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" by alexeagle · Pull Request #31918 · angular/angular · GitHub

Open Graph Title: Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" by alexeagle · Pull Request #31918 · angular/angular

X Title: Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" by alexeagle · Pull Request #31918 · angular/angular

Description: This reverts commit 2bb9a65. It breaks tests in google3 which rely on the error handling behavior. After google3 is syncing from this code location we can roll forward with flags as needed.

Open Graph Description: This reverts commit 2bb9a65. It breaks tests in google3 which rely on the error handling behavior. After google3 is syncing from this code location we can roll forward with flags as needed.

X Description: This reverts commit 2bb9a65. It breaks tests in google3 which rely on the error handling behavior. After google3 is syncing from this code location we can roll forward with flags as needed.

Opengraph URL: https://github.com/angular/angular/pull/31918

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:db627448-a7ce-a56b-4f22-f3a051c9b251
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93CC:1F65:BF8AEB:F2CD16:6B015439
html-safe-nonce3d13e8a20ce70807d3a3a2afb48410bb6ec8ddd4f28272d9d6f13aaa5168bd86
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0NDOjFGNjU6QkY4QUVCOkYyQ0QxNjo2QjAxNTQzOSIsInZpc2l0b3JfaWQiOiI2NjA5Mzk2NTY5NDAzOTA1MDgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf32b8bf797d54e22749dcf3dafbaa0733dbd90139b53b473001ca692d5a06120
hovercard-subject-tagpull_request:302705274
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/31918/files
twitter:imagehttps://avatars.githubusercontent.com/u/47395?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/47395?s=400&v=4
og:image:altThis reverts commit 2bb9a65. It breaks tests in google3 which rely on the error handling behavior. After google3 is syncing from this code location we can roll forward with flags as needed.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/31918/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31918%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31918%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31918/files
Reloadhttps://github.com/angular/angular/pull/31918/files
Reloadhttps://github.com/angular/angular/pull/31918/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alexeaglehttps://github.com/alexeagle
angular:masterhttps://github.com/angular/angular/tree/master
alexeagle:zone_synchttps://github.com/alexeagle/angular/tree/zone_sync
Conversation 1 https://github.com/angular/angular/pull/31918
Commits 1 https://github.com/angular/angular/pull/31918/commits
Checks 0 https://github.com/angular/angular/pull/31918/checks
Files changed https://github.com/angular/angular/pull/31918/files
Please reload this pagehttps://github.com/angular/angular/pull/31918/files
Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" https://github.com/angular/angular/pull/31918/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/31918/files
374607a Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" alexeagle Jul 30, 2019 https://github.com/angular/angular/pull/31918/commits/374607a33bb11ecfec1ad944f41f139e1cf9f8f3
Clear filters https://github.com/angular/angular/pull/31918/files
Please reload this pagehttps://github.com/angular/angular/pull/31918/files
Please reload this pagehttps://github.com/angular/angular/pull/31918/files
promise.ts https://github.com/angular/angular/pull/31918/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
Promise.spec.ts https://github.com/angular/angular/pull/31918/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
fake-async-test.spec.ts https://github.com/angular/angular/pull/31918/files#diff-f88858cb9f75f303f1dbd34588d17c6a7804f867db1f8debf30b90bcd5cf036e
packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/pull/31918/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
View file https://github.com/alexeagle/angular/blob/374607a33bb11ecfec1ad944f41f139e1cf9f8f3/packages/zone.js/lib/common/promise.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31918/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31918/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/31918/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
packages/zone.js/test/common/Promise.spec.tshttps://github.com/angular/angular/pull/31918/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
View file https://github.com/alexeagle/angular/blob/374607a33bb11ecfec1ad944f41f139e1cf9f8f3/packages/zone.js/test/common/Promise.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31918/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31918/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
https://github.com/angular/angular/pull/31918/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
https://github.com/angular/angular/pull/31918/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
https://github.com/angular/angular/pull/31918/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
packages/zone.js/test/zone-spec/fake-async-test.spec.tshttps://github.com/angular/angular/pull/31918/files#diff-f88858cb9f75f303f1dbd34588d17c6a7804f867db1f8debf30b90bcd5cf036e
View file https://github.com/alexeagle/angular/blob/374607a33bb11ecfec1ad944f41f139e1cf9f8f3/packages/zone.js/test/zone-spec/fake-async-test.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31918/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31918/files#diff-f88858cb9f75f303f1dbd34588d17c6a7804f867db1f8debf30b90bcd5cf036e
https://github.com/angular/angular/pull/31918/files#diff-f88858cb9f75f303f1dbd34588d17c6a7804f867db1f8debf30b90bcd5cf036e
https://github.com/angular/angular/pull/31918/files#diff-f88858cb9f75f303f1dbd34588d17c6a7804f867db1f8debf30b90bcd5cf036e
https://github.com/angular/angular/pull/31918/files#diff-f88858cb9f75f303f1dbd34588d17c6a7804f867db1f8debf30b90bcd5cf036e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.