René's URL Explorer Experiment


Title: Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" by alexeagle · Pull Request #31918 · angular/angular · GitHub

Open Graph Title: Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" by alexeagle · Pull Request #31918 · angular/angular

X Title: Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)" by alexeagle · Pull Request #31918 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This reverts commit 2bb9a65. It breaks tests in google3 which rely on the error handling behavior. After google3 is syncing from this code location we can roll forward with flags as needed.

X Description: This reverts commit 2bb9a65. It breaks tests in google3 which rely on the error handling behavior. After google3 is syncing from this code location we can roll forward with flags as needed.

Opengraph URL: https://github.com/angular/angular/pull/31918

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:24c0701f-0e70-85bf-0e66-1ed24b5f0790
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84F0:29FFA9:1B69B38:22B5013:6B014F7A
html-safe-nonced046d4a178c6a2056ad7c1a387cf85fca9e66c2a59dbc3bbffda1e81a1043942
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEYwOjI5RkZBOToxQjY5QjM4OjIyQjUwMTM6NkIwMTRGN0EiLCJ2aXNpdG9yX2lkIjoiNjIwMDkwODc1MzkzNjY2NjQ5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacebbdaafe3a049eaebc23aa319f6b888f12c1c3cb611958a7e0f0143f4cfbec52
hovercard-subject-tagpull_request:302705274
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31918/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/793f6043056b361fb85a68aff63a2cdabd2692f89d6c30652a8eea74c57da983/angular/angular/pull/31918
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/793f6043056b361fb85a68aff63a2cdabd2692f89d6c30652a8eea74c57da983/angular/angular/pull/31918
og:image:altThis reverts commit 2bb9a65. It breaks tests in google3 which rely on the error handling behavior. After google3 is syncing from this code location we can roll forward with flags as needed.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexeagle
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/31918#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31918
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31918
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31918
Reloadhttps://github.com/angular/angular/pull/31918
Reloadhttps://github.com/angular/angular/pull/31918
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
alexeaglehttps://github.com/alexeagle
angular:masterhttps://github.com/angular/angular/tree/master
alexeagle:zone_synchttps://github.com/alexeagle/angular/tree/zone_sync
Conversationhttps://github.com/angular/angular/pull/31918
Commits1 (1)https://github.com/angular/angular/pull/31918/commits
Checkshttps://github.com/angular/angular/pull/31918/checks
Files changedhttps://github.com/angular/angular/pull/31918/files
Revert "fix(zone.js): don't wrap uncaught promise error. (#31443)"https://github.com/angular/angular/pull/31918#top
alexeaglehttps://github.com/alexeagle
angular:masterhttps://github.com/angular/angular/tree/master
alexeagle:zone_synchttps://github.com/alexeagle/angular/tree/zone_sync
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
Jul 30, 2019https://github.com/angular/angular/pull/31918#issue-474832707
2bb9a65https://github.com/angular/angular/commit/2bb9a6535115ad8ba3c56781a4fe4141936cefe6
Please reload this pagehttps://github.com/angular/angular/pull/31918
https://github.com/alexeagle
Revert "fix(zone.js): don't wrap uncaught promise error. (https://github.com/angular/angular/pull/31918/commits/374607a33bb11ecfec1ad944f41f139e1cf9f8f3
angular#31443https://github.com/angular/angular/pull/31443
…https://github.com/angular/angular/pull/31918/commits/374607a33bb11ecfec1ad944f41f139e1cf9f8f3
374607ahttps://github.com/angular/angular/pull/31918/commits/374607a33bb11ecfec1ad944f41f139e1cf9f8f3
2bb9a65https://github.com/alexeagle/angular/commit/2bb9a6535115ad8ba3c56781a4fe4141936cefe6
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
JiaLiPassionhttps://github.com/JiaLiPassion
July 30, 2019 21:37https://github.com/angular/angular/pull/31918#event-2521341196
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 30, 2019https://github.com/angular/angular/pull/31918#event-2521341381
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Jul 30, 2019 https://github.com/angular/angular/pull/31918#pullrequestreview-268683729
View reviewed changes https://github.com/angular/angular/pull/31918/files/374607a33bb11ecfec1ad944f41f139e1cf9f8f3
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jul 30, 2019https://github.com/angular/angular/pull/31918#event-2521347487
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
975917bhttps://github.com/angular/angular/commit/975917bafd1609be96be9b1d73fde76be4c6e241
Jul 30, 2019https://github.com/angular/angular/pull/31918#event-2521409410
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 30, 2019 https://github.com/angular/angular/pull/31918#ref-commit-03e8a31
https://github.com/alexeagle
https://github.com/AndrewKushnir
Revert "fix(zone.js): don't wrap uncaught promise error. (https://github.com/angular/angular/commit/03e8a31bf5a22d827e03f632c9f83d037266b5be
#31443https://github.com/angular/angular/pull/31443
)" (https://github.com/angular/angular/commit/03e8a31bf5a22d827e03f632c9f83d037266b5be
#…https://github.com/angular/angular/pull/31918
03e8a31https://github.com/angular/angular/commit/03e8a31bf5a22d827e03f632c9f83d037266b5be
…31918https://github.com/angular/angular/pull/31918
2bb9a65https://github.com/angular/angular/commit/2bb9a6535115ad8ba3c56781a4fe4141936cefe6
#31918https://github.com/angular/angular/pull/31918
sabeersulaimanhttps://github.com/sabeersulaiman
Sep 6, 2019 https://github.com/angular/angular/pull/31918#ref-commit-4f7dd19
https://github.com/alexeagle
https://github.com/sabeersulaiman
Revert "fix(zone.js): don't wrap uncaught promise error. (https://github.com/sabeersulaiman/angular/commit/4f7dd1971cb03521ad5feb59f03a52cedf61cc4f
angular#31443https://github.com/angular/angular/pull/31443
…https://github.com/sabeersulaiman/angular/commit/4f7dd1971cb03521ad5feb59f03a52cedf61cc4f
4f7dd19https://github.com/sabeersulaiman/angular/commit/4f7dd1971cb03521ad5feb59f03a52cedf61cc4f
angular#31918https://github.com/angular/angular/pull/31918
2bb9a65https://github.com/sabeersulaiman/angular/commit/2bb9a6535115ad8ba3c56781a4fe4141936cefe6
angular#31918https://github.com/angular/angular/pull/31918
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31918#issuecomment-531549416
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/31918
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31918#event-2634554272
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31918
https://github.com/JiaLiPassion
JiaLiPassion https://github.com/JiaLiPassion
https://github.com/angular/angular/pull/31918/files/374607a33bb11ecfec1ad944f41f139e1cf9f8f3
Please reload this pagehttps://github.com/angular/angular/pull/31918
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Please reload this pagehttps://github.com/angular/angular/pull/31918
https://github.com/alexeagle
https://github.com/JiaLiPassion
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.