René's URL Explorer Experiment


Title: fix(ivy): support attribute selectors in dynamic component creation by kara · Pull Request #31812 · angular/angular · GitHub

Open Graph Title: fix(ivy): support attribute selectors in dynamic component creation by kara · Pull Request #31812 · angular/angular

X Title: fix(ivy): support attribute selectors in dynamic component creation by kara · Pull Request #31812 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit fixes a bug where we assumed all dynamically created components would have tag-name selectors, so we passed through the "tag name" to the renderer as the first index of the se...

X Description: This commit fixes a bug where we assumed all dynamically created components would have tag-name selectors, so we passed through the "tag name" to the renderer as the first index o...

Opengraph URL: https://github.com/angular/angular/pull/31812

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e38bc296-4b05-5cb2-6c2a-f6209d9c3ee9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCAA:A71F9:D63C5A:10D3207:6B013BB4
html-safe-nonce4ce8d765956a0df4d19e775574546bae87a0472950de115900e17f7477c965eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0FBOkE3MUY5OkQ2M0M1QToxMEQzMjA3OjZCMDEzQkI0IiwidmlzaXRvcl9pZCI6IjcxOTAzNjE1Nzg0NjQ2ODkwNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3dc513fd209f550a01b2f6fef780a2a81db2048a491c26af03272a09963821d9
hovercard-subject-tagpull_request:300504433
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31812/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b56ebef886e0b508b43f9dcfe2c87882ba64be9efa0a1f9592c07fd3837be4fe/angular/angular/pull/31812
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b56ebef886e0b508b43f9dcfe2c87882ba64be9efa0a1f9592c07fd3837be4fe/angular/angular/pull/31812
og:image:altThis commit fixes a bug where we assumed all dynamically created components would have tag-name selectors, so we passed through the "tag name" to the renderer as the first index of the se...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekara
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/31812#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31812
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31812
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31812
Reloadhttps://github.com/angular/angular/pull/31812
Reloadhttps://github.com/angular/angular/pull/31812
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
karahttps://github.com/kara
angular:masterhttps://github.com/angular/angular/tree/master
kara:fix-attr-selectorshttps://github.com/kara/angular/tree/fix-attr-selectors
Conversationhttps://github.com/angular/angular/pull/31812
Commits1 (1)https://github.com/angular/angular/pull/31812/commits
Checkshttps://github.com/angular/angular/pull/31812/checks
Files changedhttps://github.com/angular/angular/pull/31812/files
fix(ivy): support attribute selectors in dynamic component creationhttps://github.com/angular/angular/pull/31812#top
karahttps://github.com/kara
angular:masterhttps://github.com/angular/angular/tree/master
kara:fix-attr-selectorshttps://github.com/kara/angular/tree/fix-attr-selectors
https://github.com/kara
karahttps://github.com/kara
Jul 23, 2019https://github.com/angular/angular/pull/31812#issue-472007604
#31785https://github.com/angular/angular/issues/31785
Please reload this pagehttps://github.com/angular/angular/pull/31812
https://github.com/kara
fix(ivy): support attribute selectors in dynamic component creationhttps://github.com/angular/angular/pull/31812/commits/050ef1981c7b92ed643539a6207f9a0956422e5e
050ef19https://github.com/angular/angular/pull/31812/commits/050ef1981c7b92ed643539a6207f9a0956422e5e
angular#31785https://github.com/angular/angular/issues/31785
https://github.com/kara
karahttps://github.com/kara
July 23, 2019 23:14https://github.com/angular/angular/pull/31812#event-2504666684
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 23, 2019https://github.com/angular/angular/pull/31812#event-2504666729
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 23, 2019 https://github.com/angular/angular/pull/31812#pullrequestreview-265726029
View reviewed changes https://github.com/angular/angular/pull/31812/files/050ef1981c7b92ed643539a6207f9a0956422e5e
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/31812#pullrequestreview-265726029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31812
https://github.com/kara
karahttps://github.com/kara
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Jul 23, 2019https://github.com/angular/angular/pull/31812#event-2504698019
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jul 23, 2019https://github.com/angular/angular/pull/31812#event-2504698049
https://github.com/kara
karahttps://github.com/kara
Jul 23, 2019https://github.com/angular/angular/pull/31812#issuecomment-514423505
VE presubmithttps://test.corp.google.com/ui#id=OCL:259637650:BASE:259637662:1563925146992:b1cd0f2b
Ivy presubmithttp://test/OCL:259637650:BASE:259638762:1563925493734:9b96a7ed
Please reload this pagehttps://github.com/angular/angular/pull/31812
https://github.com/kara
karahttps://github.com/kara
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jul 24, 2019https://github.com/angular/angular/pull/31812#event-2504757557
https://github.com/kara
karahttps://github.com/kara
Jul 24, 2019https://github.com/angular/angular/pull/31812#issuecomment-514431479
Please reload this pagehttps://github.com/angular/angular/pull/31812
https://github.com/mhevery
mheveryhttps://github.com/mhevery
b696413https://github.com/angular/angular/commit/b696413a7991ee39dea475b64e9027a17dc61b92
Jul 24, 2019https://github.com/angular/angular/pull/31812#event-2505044472
sabeersulaimanhttps://github.com/sabeersulaiman
Sep 6, 2019 https://github.com/angular/angular/pull/31812#ref-commit-67153c0
https://github.com/kara
https://github.com/sabeersulaiman
fix(ivy): support attribute selectors in dynamic component creation (https://github.com/sabeersulaiman/angular/commit/67153c0ca181221b15a1dc62e2955ee0787ae10d
a…https://github.com/angular/angular/pull/31812
67153c0https://github.com/sabeersulaiman/angular/commit/67153c0ca181221b15a1dc62e2955ee0787ae10d
…ngular#31812https://github.com/angular/angular/pull/31812
angular#31785https://github.com/angular/angular/issues/31785
angular#31812https://github.com/angular/angular/pull/31812
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31812#issuecomment-531545498
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/31812
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31812#event-2634531934
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31812
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/31812/files/050ef1981c7b92ed643539a6207f9a0956422e5e
Please reload this pagehttps://github.com/angular/angular/pull/31812
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
needsTriage https://github.com/angular/angular/milestone/83
Regression Ivy with ComponentFactory https://github.com/angular/angular/issues/31785
Please reload this pagehttps://github.com/angular/angular/pull/31812
https://github.com/kara
https://github.com/AndrewKushnir
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.