René's URL Explorer Experiment


Title: fix(ivy): ngcc - resolve `main` property paths correctly by petebacondarwin · Pull Request #31509 · angular/angular · GitHub

Open Graph Title: fix(ivy): ngcc - resolve `main` property paths correctly by petebacondarwin · Pull Request #31509 · angular/angular

X Title: fix(ivy): ngcc - resolve `main` property paths correctly by petebacondarwin · Pull Request #31509 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: When determining if a main path points to a UMD or CommonJS format, the contents of the file need to be loaded and parsed. Previously, it was assumed that the path referred to the exact filename, b...

X Description: When determining if a main path points to a UMD or CommonJS format, the contents of the file need to be loaded and parsed. Previously, it was assumed that the path referred to the exact filename, b...

Opengraph URL: https://github.com/angular/angular/pull/31509

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:736d04d4-b948-1ff6-7cee-3e92359a85ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE4E:1148D3:142FBC2:19CBE4D:6B012C9C
html-safe-nonce9fbdf581fa247e637fe2338ab2e28d89aa6211f1585f3b33ad46f20e11529005
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTRFOjExNDhEMzoxNDJGQkMyOjE5Q0JFNEQ6NkIwMTJDOUMiLCJ2aXNpdG9yX2lkIjoiOTIyMjI4MTk0NzUyMDUyNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfd789dec941b1cb6e4df5eced7e62cfb10567bdf685db5265c87b897d0101c74
hovercard-subject-tagpull_request:296605229
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31509/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ed38b28d42d01e6e36f37149fe582848ec8f9ea65138ea559979724c01e19316/angular/angular/pull/31509
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ed38b28d42d01e6e36f37149fe582848ec8f9ea65138ea559979724c01e19316/angular/angular/pull/31509
og:image:altWhen determining if a main path points to a UMD or CommonJS format, the contents of the file need to be loaded and parsed. Previously, it was assumed that the path referred to the exact filename, b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/31509#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31509
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31509
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31509
Reloadhttps://github.com/angular/angular/pull/31509
Reloadhttps://github.com/angular/angular/pull/31509
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-isumdmodule-bug-FW-1444https://github.com/petebacondarwin/angular/tree/ngcc-isumdmodule-bug-FW-1444
Conversationhttps://github.com/angular/angular/pull/31509
Commits1 (1)https://github.com/angular/angular/pull/31509/commits
Checkshttps://github.com/angular/angular/pull/31509/checks
Files changedhttps://github.com/angular/angular/pull/31509/files
fix(ivy): ngcc - resolve main property paths correctlyhttps://github.com/angular/angular/pull/31509#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-isumdmodule-bug-FW-1444https://github.com/petebacondarwin/angular/tree/ngcc-isumdmodule-bug-FW-1444
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jul 11, 2019https://github.com/angular/angular/pull/31509#issue-466837951
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
effort1: hours https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
freq2: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Jul 11, 2019https://github.com/angular/angular/pull/31509#event-2475610365
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
July 11, 2019 11:35https://github.com/angular/angular/pull/31509#event-2475610378
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Jul 11, 2019https://github.com/angular/angular/pull/31509#event-2475610414
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 11, 2019https://github.com/angular/angular/pull/31509#event-2475610465
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/a3317552e7180768d392e0efabd9a76c8ce71431..0ab9f93e526269746eef19805422bf19292db1f5
a331755https://github.com/angular/angular/commit/a3317552e7180768d392e0efabd9a76c8ce71431
0ab9f93https://github.com/angular/angular/commit/0ab9f93e526269746eef19805422bf19292db1f5
Compare https://github.com/angular/angular/compare/a3317552e7180768d392e0efabd9a76c8ce71431..0ab9f93e526269746eef19805422bf19292db1f5
July 11, 2019 11:54https://github.com/angular/angular/pull/31509#event-2475657859
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jul 11, 2019https://github.com/angular/angular/pull/31509#event-2476238920
https://github.com/matsko
matskohttps://github.com/matsko
103a5b4https://github.com/angular/angular/commit/103a5b42ecc7de916ed9815058771ae3e231619e
Jul 11, 2019https://github.com/angular/angular/pull/31509#event-2476409277
https://github.com/matsko
matskohttps://github.com/matsko
Jul 11, 2019https://github.com/angular/angular/pull/31509#event-2476437241
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 11, 2019 https://github.com/angular/angular/pull/31509#pullrequestreview-260827922
View reviewed changes https://github.com/angular/angular/pull/31509/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/31509#pullrequestreview-260827922
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jul 11, 2019https://github.com/angular/angular/pull/31509#event-2476599974
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jul 11, 2019https://github.com/angular/angular/pull/31509#issuecomment-510567704
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 11, 2019https://github.com/angular/angular/pull/31509#issuecomment-510569471
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jul 11, 2019https://github.com/angular/angular/pull/31509#issuecomment-510602441
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/0ab9f93e526269746eef19805422bf19292db1f5..e703a3c14441044ac66e76c62afcfc5abb03949b
0ab9f93https://github.com/angular/angular/commit/0ab9f93e526269746eef19805422bf19292db1f5
e703a3chttps://github.com/angular/angular/commit/e703a3c14441044ac66e76c62afcfc5abb03949b
Compare https://github.com/angular/angular/compare/0ab9f93e526269746eef19805422bf19292db1f5..e703a3c14441044ac66e76c62afcfc5abb03949b
July 11, 2019 20:33https://github.com/angular/angular/pull/31509#event-2477178832
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jul 11, 2019https://github.com/angular/angular/pull/31509#issuecomment-510647874
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/e703a3c14441044ac66e76c62afcfc5abb03949b..965648e86b9bea5d3619f34181a85c1bc584359c
e703a3chttps://github.com/angular/angular/commit/e703a3c14441044ac66e76c62afcfc5abb03949b
965648ehttps://github.com/angular/angular/commit/965648e86b9bea5d3619f34181a85c1bc584359c
Compare https://github.com/angular/angular/compare/e703a3c14441044ac66e76c62afcfc5abb03949b..965648e86b9bea5d3619f34181a85c1bc584359c
July 11, 2019 21:01https://github.com/angular/angular/pull/31509#event-2477252059
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 11, 2019 https://github.com/angular/angular/pull/31509#pullrequestreview-260963941
View reviewed changes https://github.com/angular/angular/pull/31509/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/31509#pullrequestreview-260963941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31509
packages/compiler-cli/ngcc/test/dependencies/umd_dependency_host_spec.tshttps://github.com/angular/angular/pull/31509/files#diff-9f7341c854cc1e2cec5a0c1a5749880ea9babdd1aec4497cbf81349bb3ee0e26
Please reload this pagehttps://github.com/angular/angular/pull/31509
packages/compiler-cli/ngcc/src/dependencies/dependency_host.tshttps://github.com/angular/angular/pull/31509/files#diff-8b82312b1159503f944f0708700acbd17646bfae65da96882cebaa74ac1ce5e9
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jul 12, 2019 https://github.com/angular/angular/pull/31509#ref-issue-464378887
@angular@8.2.0-next.0: ERROR in ENOTDIR: not a directory, scandir *****/index.ts #31424 https://github.com/angular/angular/issues/31424
https://github.com/petebacondarwin
fix(ivy): ngcc - resolve main property paths correctlyhttps://github.com/angular/angular/pull/31509/commits/e7ba641d3a50cddc1514b870d27790b92578cded
e7ba641https://github.com/angular/angular/pull/31509/commits/e7ba641d3a50cddc1514b870d27790b92578cded
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/965648e86b9bea5d3619f34181a85c1bc584359c..e7ba641d3a50cddc1514b870d27790b92578cded
965648ehttps://github.com/angular/angular/commit/965648e86b9bea5d3619f34181a85c1bc584359c
e7ba641https://github.com/angular/angular/commit/e7ba641d3a50cddc1514b870d27790b92578cded
Compare https://github.com/angular/angular/compare/965648e86b9bea5d3619f34181a85c1bc584359c..e7ba641d3a50cddc1514b870d27790b92578cded
July 12, 2019 09:28https://github.com/angular/angular/pull/31509#event-2478462019
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Jul 12, 2019https://github.com/angular/angular/pull/31509#event-2478462458
https://github.com/matsko
matskohttps://github.com/matsko
fac20bdhttps://github.com/angular/angular/commit/fac20bd8d1dc4c202a01682839101454f792f9ac
Jul 12, 2019https://github.com/angular/angular/pull/31509#event-2479446351
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
July 12, 2019 15:43https://github.com/angular/angular/pull/31509#event-2479458336
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Jul 15, 2019 https://github.com/angular/angular/pull/31509#ref-issue-467993358
NgccProcessor slowing down subsequent builds with AngularCompilerPlugin angular/angular-cli#15078 https://github.com/angular/angular-cli/issues/15078
sabeersulaimanhttps://github.com/sabeersulaiman
Sep 6, 2019 https://github.com/angular/angular/pull/31509#ref-commit-3493b52
https://github.com/petebacondarwin
https://github.com/sabeersulaiman
fix(ivy): ngcc - resolvehttps://github.com/sabeersulaiman/angular/commit/3493b52803a9684247d246d9729d23bf838a1971
mainhttps://github.com/sabeersulaiman/angular/commit/3493b52803a9684247d246d9729d23bf838a1971
property paths correctly (https://github.com/sabeersulaiman/angular/commit/3493b52803a9684247d246d9729d23bf838a1971
angular#31509https://github.com/angular/angular/pull/31509
)https://github.com/sabeersulaiman/angular/commit/3493b52803a9684247d246d9729d23bf838a1971
3493b52https://github.com/sabeersulaiman/angular/commit/3493b52803a9684247d246d9729d23bf838a1971
angular#31509https://github.com/angular/angular/pull/31509
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31509#issuecomment-531541675
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31509#event-2634509435
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31509
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/31509/files/965648e86b9bea5d3619f34181a85c1bc584359c
Please reload this pagehttps://github.com/angular/angular/pull/31509
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
effort1: hours https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
freq2: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/31509
https://github.com/petebacondarwin
https://github.com/gkalpak
https://github.com/matsko
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.