René's URL Explorer Experiment


Title: fix(elements): handle inputs set before upgrade by robwormald · Pull Request #31416 · angular/angular · GitHub

Open Graph Title: fix(elements): handle inputs set before upgrade by robwormald · Pull Request #31416 · angular/angular

X Title: fix(elements): handle inputs set before upgrade by robwormald · Pull Request #31416 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/31416

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:015361de-469b-bc62-71a7-302807463704
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE326:291B58:5176F7:66C006:6B010E35
html-safe-noncee8f9f8c3e5177f65c8f511012f0989e816b636276b7c7d97a61407d2ae72bc00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzI2OjI5MUI1ODo1MTc2Rjc6NjZDMDA2OjZCMDEwRTM1IiwidmlzaXRvcl9pZCI6IjI2MzMwMzAxMzIxMDQ3NjA4ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca2cabbc75d69c8908310c7f47bd3dbe5b1afc402ea78f5313ae8d351f9861543
hovercard-subject-tagpull_request:294370257
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31416/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c54e12b1285a2d0ecd6a1ff3809a0059aec2c6b5983ef892dfd9419e9f359b4d/angular/angular/pull/31416
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c54e12b1285a2d0ecd6a1ff3809a0059aec2c6b5983ef892dfd9419e9f359b4d/angular/angular/pull/31416
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerobwormald
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/31416#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31416
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31416
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31416
Reloadhttps://github.com/angular/angular/pull/31416
Reloadhttps://github.com/angular/angular/pull/31416
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
robwormaldhttps://github.com/robwormald
angular:masterhttps://github.com/angular/angular/tree/master
robwormald:elements-fixeshttps://github.com/robwormald/angular/tree/elements-fixes
Conversationhttps://github.com/angular/angular/pull/31416
Commits1 (1)https://github.com/angular/angular/pull/31416/commits
Checkshttps://github.com/angular/angular/pull/31416/checks
Files changedhttps://github.com/angular/angular/pull/31416/files
fix(elements): handle inputs set before upgradehttps://github.com/angular/angular/pull/31416#top
robwormaldhttps://github.com/robwormald
angular:masterhttps://github.com/angular/angular/tree/master
robwormald:elements-fixeshttps://github.com/robwormald/angular/tree/elements-fixes
https://github.com/robwormald
robwormaldhttps://github.com/robwormald
Jul 4, 2019https://github.com/angular/angular/pull/31416#issue-464001613
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#30848https://github.com/angular/angular/issues/30848
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/robwormald
fix(elements): handle inputs set before upgradehttps://github.com/angular/angular/pull/31416/commits/3e2ddd808660121a601230d59ae9d1feae8c7e17
3e2ddd8https://github.com/angular/angular/pull/31416/commits/3e2ddd808660121a601230d59ae9d1feae8c7e17
https://github.com/robwormald
robwormaldhttps://github.com/robwormald
July 4, 2019 00:07https://github.com/angular/angular/pull/31416#event-2459102534
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 4, 2019https://github.com/angular/angular/pull/31416#event-2459102590
https://github.com/robwormald
robwormaldhttps://github.com/robwormald
Jul 4, 2019 https://github.com/angular/angular/pull/31416#ref-issue-452004734
Angular Elements doesn't bind existing property values to component inputs #30848 https://github.com/angular/angular/issues/30848
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 4, 2019https://github.com/angular/angular/pull/31416#issuecomment-508410125
Please reload this pagehttps://github.com/angular/angular/pull/31416
#20955https://github.com/angular/angular/pull/20955
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 4, 2019 https://github.com/angular/angular/pull/31416#pullrequestreview-257950662
View reviewed changes https://github.com/angular/angular/pull/31416/files/3e2ddd808660121a601230d59ae9d1feae8c7e17
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/31416#pullrequestreview-257950662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31416
packages/elements/src/component-factory-strategy.tshttps://github.com/angular/angular/pull/31416/files/3e2ddd808660121a601230d59ae9d1feae8c7e17#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
gkalpakhttps://github.com/gkalpak
Jul 4, 2019https://github.com/angular/angular/pull/31416#discussion_r300326698
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
"property upgrade"https://developers.google.com/web/fundamentals/web-components/best-practices#lazy-properties
and attributeshttps://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L156
ensure that the strategy is instantiatedhttps://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L151-L153
the input getters/settershttps://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L189-L190
not guaranteedhttps://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L142-L143
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
area: elements https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
Jul 9, 2019https://github.com/angular/angular/pull/31416#event-2470212186
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jul 9, 2019https://github.com/angular/angular/pull/31416#event-2470212253
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
robwormaldhttps://github.com/robwormald
Jul 13, 2019https://github.com/angular/angular/pull/31416#event-2480956798
https://github.com/dawidgarus
dawidgarushttps://github.com/dawidgarus
Dec 13, 2019https://github.com/angular/angular/pull/31416#issuecomment-565423246
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 13, 2019https://github.com/angular/angular/pull/31416#issuecomment-565433061
@robwormaldhttps://github.com/robwormald
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/antch
antchhttps://github.com/antch
Feb 4, 2020https://github.com/angular/angular/pull/31416#issuecomment-582103979
Please reload this pagehttps://github.com/angular/angular/pull/31416
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/antch
antchhttps://github.com/antch
Mar 16, 2020https://github.com/angular/angular/pull/31416#issuecomment-599718394
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 17, 2020 https://github.com/angular/angular/pull/31416#ref-pullrequest-583213427
fix(elements): a couple of small fixes #36114 https://github.com/angular/angular/pull/36114
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 17, 2020https://github.com/angular/angular/pull/31416#issuecomment-600244344
#36114https://github.com/angular/angular/pull/36114
@antchhttps://github.com/antch
build artifacts from therehttps://circleci.com/gh/angular/angular/656818#artifacts/containers/0
herehttps://github.com/angular/angular/blob/34a17f36990777a46b133b4e81ce15a564f0550d/docs/DEVELOPER.md#getting-packages-from-build-artifacts
@antchhttps://github.com/antch
#36114https://github.com/angular/angular/pull/36114
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/antch
antchhttps://github.com/antch
Mar 17, 2020https://github.com/angular/angular/pull/31416#issuecomment-600258055
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/antch
antchhttps://github.com/antch
Mar 17, 2020https://github.com/angular/angular/pull/31416#issuecomment-600289077
@gkalpakhttps://github.com/gkalpak
newer artifactshttps://circleci.com/gh/angular/angular/657041#artifacts/containers/0
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 17, 2020https://github.com/angular/angular/pull/31416#issuecomment-600311891
@antchhttps://github.com/antch
#36114https://github.com/angular/angular/pull/36114
#36114https://github.com/angular/angular/pull/36114
Please reload this pagehttps://github.com/angular/angular/pull/31416
gkalpakhttps://github.com/gkalpak
May 20, 2020 https://github.com/angular/angular/pull/31416#ref-commit-88b7d5b
https://github.com/gkalpak
fix(elements): capture input properties set before upgrading the elementhttps://github.com/gkalpak/angular/commit/88b7d5b9858f188346ce95cef6ac42151669f2c4
88b7d5bhttps://github.com/gkalpak/angular/commit/88b7d5b9858f188346ce95cef6ac42151669f2c4
https://angular-team.atlassian.net/browse/FW-2006https://angular-team.atlassian.net/browse/FW-2006
angular#30848https://github.com/angular/angular/issues/30848
angular#31416https://github.com/angular/angular/pull/31416
https://github.com/kara
karahttps://github.com/kara
2fc5ae5https://github.com/angular/angular/commit/2fc5ae561b2d2f3ec2b90cf580c41bf6f5b55fda
May 20, 2020https://github.com/angular/angular/pull/31416#event-3357358308
karahttps://github.com/kara
May 20, 2020 https://github.com/angular/angular/pull/31416#ref-commit-1c8f179
https://github.com/gkalpak
https://github.com/kara
fix(elements): capture input properties set before upgrading the elem…https://github.com/angular/angular/commit/1c8f1799d494254074e71c460db47dd65f58575a
1c8f179https://github.com/angular/angular/commit/1c8f1799d494254074e71c460db47dd65f58575a
#36114https://github.com/angular/angular/pull/36114
https://angular-team.atlassian.net/browse/FW-2006https://angular-team.atlassian.net/browse/FW-2006
#30848https://github.com/angular/angular/issues/30848
#31416https://github.com/angular/angular/pull/31416
#36114https://github.com/angular/angular/pull/36114
gkalpakhttps://github.com/gkalpak
May 20, 2020 https://github.com/angular/angular/pull/31416#ref-commit-769c1d9
https://github.com/gkalpak
fix(elements): capture input properties set before upgrading the elem…https://github.com/gkalpak/angular/commit/769c1d9283efe452140df6c400b9cddbc386dc25
769c1d9https://github.com/gkalpak/angular/commit/769c1d9283efe452140df6c400b9cddbc386dc25
angular#36114https://github.com/angular/angular/pull/36114
https://angular-team.atlassian.net/browse/FW-2006https://angular-team.atlassian.net/browse/FW-2006
angular#30848https://github.com/angular/angular/issues/30848
angular#31416https://github.com/angular/angular/pull/31416
angular#36114https://github.com/angular/angular/pull/36114
karahttps://github.com/kara
May 20, 2020 https://github.com/angular/angular/pull/31416#ref-commit-a33cb2d
https://github.com/gkalpak
https://github.com/kara
fix(elements): capture input properties set before upgrading the elem…https://github.com/angular/angular/commit/a33cb2d39b762a46fc3f78deb78264e2310894f3
a33cb2dhttps://github.com/angular/angular/commit/a33cb2d39b762a46fc3f78deb78264e2310894f3
#36114https://github.com/angular/angular/pull/36114
#37226https://github.com/angular/angular/pull/37226
https://angular-team.atlassian.net/browse/FW-2006https://angular-team.atlassian.net/browse/FW-2006
#30848https://github.com/angular/angular/issues/30848
#31416https://github.com/angular/angular/pull/31416
#36114https://github.com/angular/angular/pull/36114
#37226https://github.com/angular/angular/pull/37226
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jun 20, 2020https://github.com/angular/angular/pull/31416#issuecomment-647014675
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jun 20, 2020https://github.com/angular/angular/pull/31416#event-3464814215
profanishttps://github.com/profanis
Sep 5, 2020 https://github.com/angular/angular/pull/31416#ref-commit-9775670
https://github.com/gkalpak
https://github.com/profanis
fix(elements): capture input properties set before upgrading the elem…https://github.com/profanis/angular/commit/9775670505e95cf5cc80feaad5b14e16af7f207b
9775670https://github.com/profanis/angular/commit/9775670505e95cf5cc80feaad5b14e16af7f207b
angular#36114https://github.com/angular/angular/pull/36114
https://angular-team.atlassian.net/browse/FW-2006https://angular-team.atlassian.net/browse/FW-2006
angular#30848https://github.com/angular/angular/issues/30848
angular#31416https://github.com/angular/angular/pull/31416
angular#36114https://github.com/angular/angular/pull/36114
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31416
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/31416/files/3e2ddd808660121a601230d59ae9d1feae8c7e17
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/robwormald
robwormald https://github.com/robwormald
area: elements https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
needsTriage https://github.com/angular/angular/milestone/83
Angular Elements doesn't bind existing property values to component inputs https://github.com/angular/angular/issues/30848
Please reload this pagehttps://github.com/angular/angular/pull/31416
https://github.com/robwormald
https://github.com/gkalpak
https://github.com/dawidgarus
https://github.com/antch
https://github.com/jasonaden
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.