| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:015361de-469b-bc62-71a7-302807463704 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E326:291B58:5176F7:66C006:6B010E35 |
| html-safe-nonce | e8f9f8c3e5177f65c8f511012f0989e816b636276b7c7d97a61407d2ae72bc00 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzI2OjI5MUI1ODo1MTc2Rjc6NjZDMDA2OjZCMDEwRTM1IiwidmlzaXRvcl9pZCI6IjI2MzMwMzAxMzIxMDQ3NjA4ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a2cabbc75d69c8908310c7f47bd3dbe5b1afc402ea78f5313ae8d351f9861543 |
| hovercard-subject-tag | pull_request:294370257 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31416/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c54e12b1285a2d0ecd6a1ff3809a0059aec2c6b5983ef892dfd9419e9f359b4d/angular/angular/pull/31416 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c54e12b1285a2d0ecd6a1ff3809a0059aec2c6b5983ef892dfd9419e9f359b4d/angular/angular/pull/31416 |
| og:image:alt | PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | robwormald |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/31416#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31416 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31416 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/31416 |
| Reload | https://github.com/angular/angular/pull/31416 |
| Reload | https://github.com/angular/angular/pull/31416 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| robwormald | https://github.com/robwormald |
| angular:master | https://github.com/angular/angular/tree/master |
| robwormald:elements-fixes | https://github.com/robwormald/angular/tree/elements-fixes |
| Conversation | https://github.com/angular/angular/pull/31416 |
| Commits1 (1) | https://github.com/angular/angular/pull/31416/commits |
| Checks | https://github.com/angular/angular/pull/31416/checks |
| Files changed | https://github.com/angular/angular/pull/31416/files |
| fix(elements): handle inputs set before upgrade | https://github.com/angular/angular/pull/31416#top |
| robwormald | https://github.com/robwormald |
| angular:master | https://github.com/angular/angular/tree/master |
| robwormald:elements-fixes | https://github.com/robwormald/angular/tree/elements-fixes |
|
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| Jul 4, 2019 | https://github.com/angular/angular/pull/31416#issue-464001613 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #30848 | https://github.com/angular/angular/issues/30848 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
|
| https://github.com/robwormald |
| fix(elements): handle inputs set before upgrade | https://github.com/angular/angular/pull/31416/commits/3e2ddd808660121a601230d59ae9d1feae8c7e17 |
| 3e2ddd8 | https://github.com/angular/angular/pull/31416/commits/3e2ddd808660121a601230d59ae9d1feae8c7e17 |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| July 4, 2019 00:07 | https://github.com/angular/angular/pull/31416#event-2459102534 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jul 4, 2019 | https://github.com/angular/angular/pull/31416#event-2459102590 |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
|
Jul 4, 2019
| https://github.com/angular/angular/pull/31416#ref-issue-452004734 |
|
Angular Elements doesn't bind existing property values to component inputs
#30848
| https://github.com/angular/angular/issues/30848 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jul 4, 2019 | https://github.com/angular/angular/pull/31416#issuecomment-508410125 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| #20955 | https://github.com/angular/angular/pull/20955 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jul 4, 2019
| https://github.com/angular/angular/pull/31416#pullrequestreview-257950662 |
|
View reviewed changes
| https://github.com/angular/angular/pull/31416/files/3e2ddd808660121a601230d59ae9d1feae8c7e17 |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/31416#pullrequestreview-257950662 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| packages/elements/src/component-factory-strategy.ts | https://github.com/angular/angular/pull/31416/files/3e2ddd808660121a601230d59ae9d1feae8c7e17#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
| gkalpak | https://github.com/gkalpak |
| Jul 4, 2019 | https://github.com/angular/angular/pull/31416#discussion_r300326698 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| "property upgrade" | https://developers.google.com/web/fundamentals/web-components/best-practices#lazy-properties |
| and attributes | https://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L156 |
| ensure that the strategy is instantiated | https://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L151-L153 |
| the input getters/setters | https://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L189-L190 |
| not guaranteed | https://github.com/angular/angular/blob/3e2ddd808660121a601230d59ae9d1feae8c7e17/packages/elements/src/create-custom-element.ts#L142-L143 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
area: elements
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22 |
| Jul 9, 2019 | https://github.com/angular/angular/pull/31416#event-2470212186 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jul 9, 2019 | https://github.com/angular/angular/pull/31416#event-2470212253 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| robwormald | https://github.com/robwormald |
| Jul 13, 2019 | https://github.com/angular/angular/pull/31416#event-2480956798 |
| https://github.com/dawidgarus |
| dawidgarus | https://github.com/dawidgarus |
| Dec 13, 2019 | https://github.com/angular/angular/pull/31416#issuecomment-565423246 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 13, 2019 | https://github.com/angular/angular/pull/31416#issuecomment-565433061 |
| @robwormald | https://github.com/robwormald |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/antch |
| antch | https://github.com/antch |
| Feb 4, 2020 | https://github.com/angular/angular/pull/31416#issuecomment-582103979 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/antch |
| antch | https://github.com/antch |
| Mar 16, 2020 | https://github.com/angular/angular/pull/31416#issuecomment-599718394 |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 17, 2020
| https://github.com/angular/angular/pull/31416#ref-pullrequest-583213427 |
|
fix(elements): a couple of small fixes
#36114
| https://github.com/angular/angular/pull/36114 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 17, 2020 | https://github.com/angular/angular/pull/31416#issuecomment-600244344 |
| #36114 | https://github.com/angular/angular/pull/36114 |
| @antch | https://github.com/antch |
| build artifacts from there | https://circleci.com/gh/angular/angular/656818#artifacts/containers/0 |
| here | https://github.com/angular/angular/blob/34a17f36990777a46b133b4e81ce15a564f0550d/docs/DEVELOPER.md#getting-packages-from-build-artifacts |
| @antch | https://github.com/antch |
| #36114 | https://github.com/angular/angular/pull/36114 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/antch |
| antch | https://github.com/antch |
| Mar 17, 2020 | https://github.com/angular/angular/pull/31416#issuecomment-600258055 |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/antch |
| antch | https://github.com/antch |
| Mar 17, 2020 | https://github.com/angular/angular/pull/31416#issuecomment-600289077 |
| @gkalpak | https://github.com/gkalpak |
| newer artifacts | https://circleci.com/gh/angular/angular/657041#artifacts/containers/0 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 17, 2020 | https://github.com/angular/angular/pull/31416#issuecomment-600311891 |
| @antch | https://github.com/antch |
| #36114 | https://github.com/angular/angular/pull/36114 |
| #36114 | https://github.com/angular/angular/pull/36114 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| gkalpak | https://github.com/gkalpak |
|
May 20, 2020
| https://github.com/angular/angular/pull/31416#ref-commit-88b7d5b |
|
| https://github.com/gkalpak |
| fix(elements): capture input properties set before upgrading the element | https://github.com/gkalpak/angular/commit/88b7d5b9858f188346ce95cef6ac42151669f2c4 |
| 88b7d5b | https://github.com/gkalpak/angular/commit/88b7d5b9858f188346ce95cef6ac42151669f2c4 |
| https://angular-team.atlassian.net/browse/FW-2006 | https://angular-team.atlassian.net/browse/FW-2006 |
| angular#30848 | https://github.com/angular/angular/issues/30848 |
| angular#31416 | https://github.com/angular/angular/pull/31416 |
| https://github.com/kara |
| kara | https://github.com/kara |
| 2fc5ae5 | https://github.com/angular/angular/commit/2fc5ae561b2d2f3ec2b90cf580c41bf6f5b55fda |
| May 20, 2020 | https://github.com/angular/angular/pull/31416#event-3357358308 |
| kara | https://github.com/kara |
|
May 20, 2020
| https://github.com/angular/angular/pull/31416#ref-commit-1c8f179 |
|
| https://github.com/gkalpak |
|
| https://github.com/kara |
| fix(elements): capture input properties set before upgrading the elem… | https://github.com/angular/angular/commit/1c8f1799d494254074e71c460db47dd65f58575a |
| 1c8f179 | https://github.com/angular/angular/commit/1c8f1799d494254074e71c460db47dd65f58575a |
| #36114 | https://github.com/angular/angular/pull/36114 |
| https://angular-team.atlassian.net/browse/FW-2006 | https://angular-team.atlassian.net/browse/FW-2006 |
| #30848 | https://github.com/angular/angular/issues/30848 |
| #31416 | https://github.com/angular/angular/pull/31416 |
| #36114 | https://github.com/angular/angular/pull/36114 |
| gkalpak | https://github.com/gkalpak |
|
May 20, 2020
| https://github.com/angular/angular/pull/31416#ref-commit-769c1d9 |
|
| https://github.com/gkalpak |
| fix(elements): capture input properties set before upgrading the elem… | https://github.com/gkalpak/angular/commit/769c1d9283efe452140df6c400b9cddbc386dc25 |
| 769c1d9 | https://github.com/gkalpak/angular/commit/769c1d9283efe452140df6c400b9cddbc386dc25 |
| angular#36114 | https://github.com/angular/angular/pull/36114 |
| https://angular-team.atlassian.net/browse/FW-2006 | https://angular-team.atlassian.net/browse/FW-2006 |
| angular#30848 | https://github.com/angular/angular/issues/30848 |
| angular#31416 | https://github.com/angular/angular/pull/31416 |
| angular#36114 | https://github.com/angular/angular/pull/36114 |
| kara | https://github.com/kara |
|
May 20, 2020
| https://github.com/angular/angular/pull/31416#ref-commit-a33cb2d |
|
| https://github.com/gkalpak |
|
| https://github.com/kara |
| fix(elements): capture input properties set before upgrading the elem… | https://github.com/angular/angular/commit/a33cb2d39b762a46fc3f78deb78264e2310894f3 |
| a33cb2d | https://github.com/angular/angular/commit/a33cb2d39b762a46fc3f78deb78264e2310894f3 |
| #36114 | https://github.com/angular/angular/pull/36114 |
| #37226 | https://github.com/angular/angular/pull/37226 |
| https://angular-team.atlassian.net/browse/FW-2006 | https://angular-team.atlassian.net/browse/FW-2006 |
| #30848 | https://github.com/angular/angular/issues/30848 |
| #31416 | https://github.com/angular/angular/pull/31416 |
| #36114 | https://github.com/angular/angular/pull/36114 |
| #37226 | https://github.com/angular/angular/pull/37226 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jun 20, 2020 | https://github.com/angular/angular/pull/31416#issuecomment-647014675 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jun 20, 2020 | https://github.com/angular/angular/pull/31416#event-3464814215 |
| profanis | https://github.com/profanis |
|
Sep 5, 2020
| https://github.com/angular/angular/pull/31416#ref-commit-9775670 |
|
| https://github.com/gkalpak |
|
| https://github.com/profanis |
| fix(elements): capture input properties set before upgrading the elem… | https://github.com/profanis/angular/commit/9775670505e95cf5cc80feaad5b14e16af7f207b |
| 9775670 | https://github.com/profanis/angular/commit/9775670505e95cf5cc80feaad5b14e16af7f207b |
| angular#36114 | https://github.com/angular/angular/pull/36114 |
| https://angular-team.atlassian.net/browse/FW-2006 | https://angular-team.atlassian.net/browse/FW-2006 |
| angular#30848 | https://github.com/angular/angular/issues/30848 |
| angular#31416 | https://github.com/angular/angular/pull/31416 |
| angular#36114 | https://github.com/angular/angular/pull/36114 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31416 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/31416/files/3e2ddd808660121a601230d59ae9d1feae8c7e17 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
|
| https://github.com/robwormald |
|
robwormald
| https://github.com/robwormald |
|
area: elements
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
Angular Elements doesn't bind existing property values to component inputs
| https://github.com/angular/angular/issues/30848 |
| Please reload this page | https://github.com/angular/angular/pull/31416 |
|
| https://github.com/robwormald |
|
| https://github.com/gkalpak |
|
| https://github.com/dawidgarus |
|
| https://github.com/antch |
|
| https://github.com/jasonaden |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |