René's URL Explorer Experiment


Title: fix(common): expand type for "ngForOf" input to work with strict null checks by devversion · Pull Request #31371 · angular/angular · GitHub

Open Graph Title: fix(common): expand type for "ngForOf" input to work with strict null checks by devversion · Pull Request #31371 · angular/angular

X Title: fix(common): expand type for "ngForOf" input to work with strict null checks by devversion · Pull Request #31371 · angular/angular

Description: Currently the ngForOf input accepts null or undefined as valid values. Though when using strict template input type checking (which will be supported by ngtsc), passing null or undefined with strict null checks enabled causes a type check failure because the type for the ngForOf input becomes too strict if strict null checks are enabled. The type of the input needs to be expanded to also accept null or undefined to behave consistent (basically regardless of the strictNullChecks flag). This is necessary because whenever strict input type checking is enabled by default, most of the Angular projects that use *ngFor with the async pipe will either need to disable template type checking or strict null checks because the async pipe returns null if the observable hasn't been emitted yet. See for example how this affects the angular/components repository and how verbose it is to work around it: angular/components#16373.

Open Graph Description: Currently the ngForOf input accepts null or undefined as valid values. Though when using strict template input type checking (which will be supported by ngtsc), passing null or undefined with stric...

X Description: Currently the ngForOf input accepts null or undefined as valid values. Though when using strict template input type checking (which will be supported by ngtsc), passing null or undefined with stric...

Opengraph URL: https://github.com/angular/angular/pull/31371

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7fcc2fd6-5acc-e90b-82d2-27f77d635fbc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAD8:669A1:14569C:1ADF20:6B0186EA
html-safe-nonceb398b1673a036e6f93713159639925ec52d01bd20d19e0dda64ce07c77167fec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUQ4OjY2OUExOjE0NTY5QzoxQURGMjA6NkIwMTg2RUEiLCJ2aXNpdG9yX2lkIjoiNjI5MjkzNzgyNTY0MTkyNDMzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8253d5bf173c461281f6f8b17be9f61b55b5bc1fda5c2b74d188400aa5a1d5f8
hovercard-subject-tagpull_request:293436967
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/31371/files
twitter:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
og:image:altCurrently the ngForOf input accepts null or undefined as valid values. Though when using strict template input type checking (which will be supported by ngtsc), passing null or undefined with stric...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/31371/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31371%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31371%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31371/files
Reloadhttps://github.com/angular/angular/pull/31371/files
Reloadhttps://github.com/angular/angular/pull/31371/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
devversionhttps://github.com/devversion
angular:masterhttps://github.com/angular/angular/tree/master
devversion:refactor/common-expand-type-ngfor-of-strict-null-checkshttps://github.com/devversion/angular/tree/refactor/common-expand-type-ngfor-of-strict-null-checks
Conversation 12 https://github.com/angular/angular/pull/31371
Commits 1 https://github.com/angular/angular/pull/31371/commits
Checks 0 https://github.com/angular/angular/pull/31371/checks
Files changed https://github.com/angular/angular/pull/31371/files
Please reload this pagehttps://github.com/angular/angular/pull/31371/files
fix(common): expand type for "ngForOf" input to work with strict null checks https://github.com/angular/angular/pull/31371/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/31371/files
14ab901 fix(common): expand type for "ngForOf" input to work with strict null… devversion Oct 3, 2019 https://github.com/angular/angular/pull/31371/commits/14ab901a9cbd9262f8d47ebfbb618034ca33a5e2
Clear filters https://github.com/angular/angular/pull/31371/files
Please reload this pagehttps://github.com/angular/angular/pull/31371/files
Please reload this pagehttps://github.com/angular/angular/pull/31371/files
ng_for_of.ts https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
default_iterable_differ.ts https://github.com/angular/angular/pull/31371/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6
iterable_differs.ts https://github.com/angular/angular/pull/31371/files#diff-62a378c800ece263aa4515f8eacd567d826d3500f7dabb71bd7a1b9a8c305da3
common.d.ts https://github.com/angular/angular/pull/31371/files#diff-8f04e04e51db03a1fa86550e492017d75859c13236cac866e8727c788a843710
core.d.ts https://github.com/angular/angular/pull/31371/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
packages/common/src/directives/ng_for_of.tshttps://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
View file https://github.com/devversion/angular/blob/14ab901a9cbd9262f8d47ebfbb618034ca33a5e2/packages/common/src/directives/ng_for_of.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31371/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
https://github.com/angular/angular/pull/31371/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19
packages/core/src/change_detection/differs/default_iterable_differ.tshttps://github.com/angular/angular/pull/31371/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6
View file https://github.com/devversion/angular/blob/14ab901a9cbd9262f8d47ebfbb618034ca33a5e2/packages/core/src/change_detection/differs/default_iterable_differ.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31371/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31371/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6
https://github.com/angular/angular/pull/31371/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6
packages/core/src/change_detection/differs/iterable_differs.tshttps://github.com/angular/angular/pull/31371/files#diff-62a378c800ece263aa4515f8eacd567d826d3500f7dabb71bd7a1b9a8c305da3
View file https://github.com/devversion/angular/blob/14ab901a9cbd9262f8d47ebfbb618034ca33a5e2/packages/core/src/change_detection/differs/iterable_differs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31371/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31371/files#diff-62a378c800ece263aa4515f8eacd567d826d3500f7dabb71bd7a1b9a8c305da3
trotylhttps://github.com/trotyl
Jul 2, 2019https://github.com/angular/angular/pull/31371/files#r299423880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31371/files
devversionhttps://github.com/devversion
Jul 2, 2019https://github.com/angular/angular/pull/31371/files#r299431446
Please reload this pagehttps://github.com/angular/angular/pull/31371/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31371/files
https://github.com/angular/angular/pull/31371/files#diff-62a378c800ece263aa4515f8eacd567d826d3500f7dabb71bd7a1b9a8c305da3
tools/public_api_guard/common/common.d.tshttps://github.com/angular/angular/pull/31371/files#diff-8f04e04e51db03a1fa86550e492017d75859c13236cac866e8727c788a843710
View file https://github.com/devversion/angular/blob/14ab901a9cbd9262f8d47ebfbb618034ca33a5e2/tools/public_api_guard/common/common.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31371/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31371/files#diff-8f04e04e51db03a1fa86550e492017d75859c13236cac866e8727c788a843710
https://github.com/angular/angular/pull/31371/files#diff-8f04e04e51db03a1fa86550e492017d75859c13236cac866e8727c788a843710
tools/public_api_guard/core/core.d.tshttps://github.com/angular/angular/pull/31371/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
View file https://github.com/devversion/angular/blob/14ab901a9cbd9262f8d47ebfbb618034ca33a5e2/tools/public_api_guard/core/core.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31371/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31371/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
https://github.com/angular/angular/pull/31371/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
https://github.com/angular/angular/pull/31371/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
IgorMinarhttps://github.com/IgorMinar
Oct 4, 2019https://github.com/angular/angular/pull/31371/files#r331652408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31371/files
https://github.com/angular/angular/pull/31371/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.