René's URL Explorer Experiment


Title: fix(compiler): give ASTWithSource its own visit method by ayazhafiz · Pull Request #31347 · angular/angular · GitHub

Open Graph Title: fix(compiler): give ASTWithSource its own visit method by ayazhafiz · Pull Request #31347 · angular/angular

X Title: fix(compiler): give ASTWithSource its own visit method by ayazhafiz · Pull Request #31347 · angular/angular

Description: ASTWithSource contains more information that AST and should have its own visit method, if desired. This implements that. Part 1 of template parsing refactoring for stability. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) N/A, internal PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? ASTWithSource#visit defers to AST#visit. Issue Number: N/A What is the new behavior? ASTWithSource#visit has its own method if applicable, otherwise defers to AST#visit. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: ASTWithSource contains more information that AST and should have its own visit method, if desired. This implements that. Part 1 of template parsing refactoring for stability. PR Checklist Please ch...

X Description: ASTWithSource contains more information that AST and should have its own visit method, if desired. This implements that. Part 1 of template parsing refactoring for stability. PR Checklist Please ch...

Opengraph URL: https://github.com/angular/angular/pull/31347

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:79a7dec6-2931-2f70-5724-53e6f439ffec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB05C:21AC3F:1BF70C6:23655DE:6B013AB7
html-safe-nonce1230dcfd96f5b3d7edf7a3ed576dd8eda50a31ff555acaa6a75cd434f99a1a30
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDVDOjIxQUMzRjoxQkY3MEM2OjIzNjU1REU6NkIwMTNBQjciLCJ2aXNpdG9yX2lkIjoiNTk4MTQ2NTY0MTk4OTc4MjE5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb742e8cf0023b3cb98f92876f0a326d60ea2939fc35f63573ecbd20cb37aea80
hovercard-subject-tagpull_request:292992405
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/31347/files
twitter:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
og:image:altASTWithSource contains more information that AST and should have its own visit method, if desired. This implements that. Part 1 of template parsing refactoring for stability. PR Checklist Please ch...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/31347/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31347%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31347%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31347/files
Reloadhttps://github.com/angular/angular/pull/31347/files
Reloadhttps://github.com/angular/angular/pull/31347/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ayazhafizhttps://github.com/ayazhafiz
angular:masterhttps://github.com/angular/angular/tree/master
ayazhafiz:feature/ast-source-own-visitorhttps://github.com/ayazhafiz/angular/tree/feature/ast-source-own-visitor
Conversation 4 https://github.com/angular/angular/pull/31347
Commits 2 https://github.com/angular/angular/pull/31347/commits
Checks 0 https://github.com/angular/angular/pull/31347/checks
Files changed https://github.com/angular/angular/pull/31347/files
Please reload this pagehttps://github.com/angular/angular/pull/31347/files
fix(compiler): give ASTWithSource its own visit method https://github.com/angular/angular/pull/31347/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/31347/files
7fbe691 fix(compiler): give ASTWithSource its own visit method ayazhafiz Jun 28, 2019 https://github.com/angular/angular/pull/31347/commits/7fbe6915fbc40796a4d2d2f7356b8e094a2cfc8a
fcf6d54 fixup! fix(compiler): give ASTWithSource its own visit method ayazhafiz Jun 28, 2019 https://github.com/angular/angular/pull/31347/commits/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031
Clear filters https://github.com/angular/angular/pull/31347/files
Please reload this pagehttps://github.com/angular/angular/pull/31347/files
Please reload this pagehttps://github.com/angular/angular/pull/31347/files
template_spec.ts https://github.com/angular/angular/pull/31347/files#diff-fab6026596d094e51af1181534f50d80a846c89f94c2e90ab9a431da9aa03947
ast.ts https://github.com/angular/angular/pull/31347/files#diff-1002bdc266028e1c303492a63ed5990124b8fd29a8f87098d07f86c0519d47f0
packages/compiler-cli/src/ngtsc/indexer/test/template_spec.tshttps://github.com/angular/angular/pull/31347/files#diff-fab6026596d094e51af1181534f50d80a846c89f94c2e90ab9a431da9aa03947
View file https://github.com/ayazhafiz/angular/blob/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031/packages/compiler-cli/src/ngtsc/indexer/test/template_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31347/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31347/files#diff-fab6026596d094e51af1181534f50d80a846c89f94c2e90ab9a431da9aa03947
https://github.com/angular/angular/pull/31347/files#diff-fab6026596d094e51af1181534f50d80a846c89f94c2e90ab9a431da9aa03947
packages/compiler/src/expression_parser/ast.tshttps://github.com/angular/angular/pull/31347/files#diff-1002bdc266028e1c303492a63ed5990124b8fd29a8f87098d07f86c0519d47f0
View file https://github.com/ayazhafiz/angular/blob/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031/packages/compiler/src/expression_parser/ast.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31347/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31347/files#diff-1002bdc266028e1c303492a63ed5990124b8fd29a8f87098d07f86c0519d47f0
https://github.com/angular/angular/pull/31347/files#diff-1002bdc266028e1c303492a63ed5990124b8fd29a8f87098d07f86c0519d47f0
https://github.com/angular/angular/pull/31347/files#diff-1002bdc266028e1c303492a63ed5990124b8fd29a8f87098d07f86c0519d47f0
https://github.com/angular/angular/pull/31347/files#diff-1002bdc266028e1c303492a63ed5990124b8fd29a8f87098d07f86c0519d47f0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.