| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:968d5ee6-507f-5b66-384f-87f3d0a4a432 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D998:EA06E:181A349:1EC5267:6B0128D4 |
| html-safe-nonce | f50beb4db728f0f69cbcc5a52c016069336cb1875a777385742f68e929218309 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTk4OkVBMDZFOjE4MUEzNDk6MUVDNTI2Nzo2QjAxMjhENCIsInZpc2l0b3JfaWQiOiI0MzI0ODQ0OTQxNDM3MTE4Njc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 076f1034c433c792d79a25bb57b56b8c7a8c86b718f60093d550e7f1db81d716 |
| hovercard-subject-tag | pull_request:292992405 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31347/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3cf3baa818acfca34f07227c4d5a06393e7bcf093fb15f597fea476c3d8a4d73/angular/angular/pull/31347 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3cf3baa818acfca34f07227c4d5a06393e7bcf093fb15f597fea476c3d8a4d73/angular/angular/pull/31347 |
| og:image:alt | ASTWithSource contains more information that AST and should have its own
visit method, if desired. This implements that.
Part 1 of template parsing refactoring for stability.
PR Checklist
Please ch... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ayazhafiz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/31347#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31347 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31347 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/31347 |
| Reload | https://github.com/angular/angular/pull/31347 |
| Reload | https://github.com/angular/angular/pull/31347 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| ayazhafiz | https://github.com/ayazhafiz |
| angular:master | https://github.com/angular/angular/tree/master |
| ayazhafiz:feature/ast-source-own-visitor | https://github.com/ayazhafiz/angular/tree/feature/ast-source-own-visitor |
| Conversation | https://github.com/angular/angular/pull/31347 |
| Commits2 (2) | https://github.com/angular/angular/pull/31347/commits |
| Checks | https://github.com/angular/angular/pull/31347/checks |
| Files changed | https://github.com/angular/angular/pull/31347/files |
| fix(compiler): give ASTWithSource its own visit method | https://github.com/angular/angular/pull/31347#top |
| ayazhafiz | https://github.com/ayazhafiz |
| angular:master | https://github.com/angular/angular/tree/master |
| ayazhafiz:feature/ast-source-own-visitor | https://github.com/ayazhafiz/angular/tree/feature/ast-source-own-visitor |
|
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| Jun 28, 2019 | https://github.com/angular/angular/pull/31347#issue-462236385 |
| template parsing refactoring for stability | https://hackmd.io/@X3ECPVy-RCuVfba-pnvIpw/BkDUxaW84/%2FMA1oxh6jRXqSmZBcLfYdyw?type=book |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
| Jun 28, 2019 | https://github.com/angular/angular/pull/31347#event-2448597508 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| June 28, 2019 23:14 | https://github.com/angular/angular/pull/31347#event-2448597512 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| Jun 28, 2019 | https://github.com/angular/angular/pull/31347#event-2448597519 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jun 28, 2019 | https://github.com/angular/angular/pull/31347#event-2448597547 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jun 28, 2019 | https://github.com/angular/angular/pull/31347#event-2448597567 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| alxhub | https://github.com/alxhub |
| June 28, 2019 23:14 | https://github.com/angular/angular/pull/31347#event-2448598013 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Jul 1, 2019
| https://github.com/angular/angular/pull/31347#pullrequestreview-256607648 |
|
View reviewed changes
| https://github.com/angular/angular/pull/31347/files |
| alxhub | https://github.com/alxhub |
| https://github.com/angular/angular/pull/31347#pullrequestreview-256607648 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
| ayazhafiz | https://github.com/ayazhafiz |
| July 1, 2019 17:19 | https://github.com/angular/angular/pull/31347#commits-pushed-7fbe691 |
|
| https://github.com/ayazhafiz |
| fix(compiler): give ASTWithSource its own visit method | https://github.com/angular/angular/pull/31347/commits/7fbe6915fbc40796a4d2d2f7356b8e094a2cfc8a |
| 7fbe691 | https://github.com/angular/angular/pull/31347/commits/7fbe6915fbc40796a4d2d2f7356b8e094a2cfc8a |
|
| https://github.com/ayazhafiz |
| fixup! fix(compiler): give ASTWithSource its own visit method | https://github.com/angular/angular/pull/31347/commits/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031 |
| fcf6d54 | https://github.com/angular/angular/pull/31347/commits/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| force-pushed | https://github.com/angular/angular/compare/35a992e32c573f8bdd126ab5e2f6ecb2ea03b846..fcf6d54aa48ba065ca9a7ca5e49d8baf61299031 |
| 35a992e | https://github.com/angular/angular/commit/35a992e32c573f8bdd126ab5e2f6ecb2ea03b846 |
| fcf6d54 | https://github.com/angular/angular/commit/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031 |
|
Compare
| https://github.com/angular/angular/compare/35a992e32c573f8bdd126ab5e2f6ecb2ea03b846..fcf6d54aa48ba065ca9a7ca5e49d8baf61299031 |
| July 2, 2019 00:19 | https://github.com/angular/angular/pull/31347#event-2452766168 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| Jul 2, 2019 | https://github.com/angular/angular/pull/31347#issuecomment-507471065 |
| 7186f9c | https://github.com/angular/angular/commit/7186f9c0162601828a0735919eace3a73da47a46 |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| alxhub | https://github.com/alxhub |
| July 2, 2019 00:21 | https://github.com/angular/angular/pull/31347#event-2452768512 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
|
Jul 2, 2019
| https://github.com/angular/angular/pull/31347#ref-pullrequest-463464322 |
|
feature(ivy): record absolute position of template expressions
#31391
| https://github.com/angular/angular/pull/31391 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Jul 3, 2019
| https://github.com/angular/angular/pull/31347#pullrequestreview-257726778 |
|
View reviewed changes
| https://github.com/angular/angular/pull/31347/files/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031 |
| alxhub | https://github.com/alxhub |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
| https://github.com/angular/angular/pull/31347#pullrequestreview-257726778 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Jul 3, 2019 | https://github.com/angular/angular/pull/31347#event-2458927103 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| 6aaca21 | https://github.com/angular/angular/commit/6aaca21c27f0e220e2ec59b7ea46d20e1a70a597 |
| Jul 8, 2019 | https://github.com/angular/angular/pull/31347#event-2466911709 |
| https://github.com/ayazhafiz |
| ayazhafiz | https://github.com/ayazhafiz |
| July 8, 2019 17:39 | https://github.com/angular/angular/pull/31347#event-2466933288 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 15, 2019 | https://github.com/angular/angular/pull/31347#issuecomment-531540052 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 15, 2019 | https://github.com/angular/angular/pull/31347#event-2634499298 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31347 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/31347/files/fcf6d54aa48ba065ca9a7ca5e49d8baf61299031 |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
|
| https://github.com/ayazhafiz |
|
ayazhafiz
| https://github.com/ayazhafiz |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/31347 |
|
| https://github.com/ayazhafiz |
|
| https://github.com/alxhub |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |