René's URL Explorer Experiment


Title: fix(core): handle `undefined` meta in `injectArgs` by alan-agius4 · Pull Request #31333 · angular/angular · GitHub

Open Graph Title: fix(core): handle `undefined` meta in `injectArgs` by alan-agius4 · Pull Request #31333 · angular/angular

X Title: fix(core): handle `undefined` meta in `injectArgs` by alan-agius4 · Pull Request #31333 · angular/angular

Description: In the recent versions of the CLI we introduced a ctor downlevel for VE JIT build based on the one found in tsickle, to fix the TDZ issue of forwardRef. However this caused a regression as the injector is not handling that a position paramType can be undefined. Which is bubbled down to angular/packages/core/src/di/injector_compatibility.ts Line 162 in c6b29f4 export function injectArgs(types: (Type| InjectionToken| any[])[]): any[] { and will crash angular/packages/core/src/di/injector_compatibility.ts Lines 174 to 186 in c6b29f4 const meta = arg[j]; if (meta instanceof Optional || meta.ngMetadataName === 'Optional' || meta === Optional) { flags |= InjectFlags.Optional; } else if ( meta instanceof SkipSelf || meta.ngMetadataName === 'SkipSelf' || meta === SkipSelf) { flags |= InjectFlags.SkipSelf; } else if (meta instanceof Self || meta.ngMetadataName === 'Self' || meta === Self) { flags |= InjectFlags.Self; } else if (meta instanceof Inject || meta === Inject) { type = meta.token; } else { type = meta; } Fixes angular/angular-cli#14888 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: In the recent versions of the CLI we introduced a ctor downlevel for VE JIT build based on the one found in tsickle, to fix the TDZ issue of forwardRef. However this caused a regression as the inje...

X Description: In the recent versions of the CLI we introduced a ctor downlevel for VE JIT build based on the one found in tsickle, to fix the TDZ issue of forwardRef. However this caused a regression as the inje...

Opengraph URL: https://github.com/angular/angular/pull/31333

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d85b8f51-3cad-c279-dcb0-ad7c439780d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DB6:FE611:95CC46:CA2F70:6A6113D5
html-safe-noncedc349abc2f904f9f32a59593c92a3a56f0dd2b7f61d9e3dc55947ce22c34874b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REI2OkZFNjExOjk1Q0M0NjpDQTJGNzA6NkE2MTEzRDUiLCJ2aXNpdG9yX2lkIjoiNjM3NDI3MzQ4MTAzNjYwMDI3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac94fced35e912d8058e2c32b7a47ab09e3d5e325db9d1d7819496282b429cdbc7
hovercard-subject-tagpull_request:292785585
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/31333/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altIn the recent versions of the CLI we introduced a ctor downlevel for VE JIT build based on the one found in tsickle, to fix the TDZ issue of forwardRef. However this caused a regression as the inje...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef6dfd8e93b1f2b4f7bf96e6f6cd7edcd48360b75fee4f2ff9f611032fce38ec2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release731b2ebd4784c28b421dc5f41abecd2dbac357f2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/31333/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31333%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31333%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31333/files
Reloadhttps://github.com/angular/angular/pull/31333/files
Reloadhttps://github.com/angular/angular/pull/31333/files
Please reload this pagehttps://github.com/angular/angular/pull/31333/files
angular https://github.com/angular
angularhttps://github.com/angular/angular
Notifications https://github.com/login?return_to=%2Fangular%2Fangular
Fork 27.5k https://github.com/login?return_to=%2Fangular%2Fangular
Star 101k https://github.com/login?return_to=%2Fangular%2Fangular
Code https://github.com/angular/angular
Issues 977 https://github.com/angular/angular/issues
Pull requests 159 https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality 24 https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Code https://github.com/angular/angular
Issues https://github.com/angular/angular/issues
Pull requests https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 4 https://github.com/angular/angular/pull/31333
Commits 1 https://github.com/angular/angular/pull/31333/commits
Checks 0 https://github.com/angular/angular/pull/31333/checks
Files changed https://github.com/angular/angular/pull/31333/files
Please reload this pagehttps://github.com/angular/angular/pull/31333/files
fix(core): handle undefined meta in injectArgs https://github.com/angular/angular/pull/31333/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/31333/files
34b97c5 fix(core): handle `undefined` meta in `injectArgs` alan-agius4 Jun 28, 2019 https://github.com/angular/angular/pull/31333/commits/34b97c55d178f2301f758bf91c3e58419c4ab162
Clear filters https://github.com/angular/angular/pull/31333/files
Please reload this pagehttps://github.com/angular/angular/pull/31333/files
Please reload this pagehttps://github.com/angular/angular/pull/31333/files
reflection_capabilities.ts https://github.com/angular/angular/pull/31333/files#diff-8c5fb745169ff0eb724e95f6b54f3b842663c76f1abbd222fe13a3171f031242
reflector_spec.ts https://github.com/angular/angular/pull/31333/files#diff-8b5b9b55a92da808e36ba158213808bdb35d718f0af0d1b064bc8f961916ed2b
packages/core/src/reflection/reflection_capabilities.tshttps://github.com/angular/angular/pull/31333/files#diff-8c5fb745169ff0eb724e95f6b54f3b842663c76f1abbd222fe13a3171f031242
View file https://github.com/angular/angular/blob/34b97c55d178f2301f758bf91c3e58419c4ab162/packages/core/src/reflection/reflection_capabilities.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31333/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31333/files#diff-8c5fb745169ff0eb724e95f6b54f3b842663c76f1abbd222fe13a3171f031242
https://github.com/angular/angular/pull/31333/files#diff-8c5fb745169ff0eb724e95f6b54f3b842663c76f1abbd222fe13a3171f031242
packages/core/test/reflection/reflector_spec.tshttps://github.com/angular/angular/pull/31333/files#diff-8b5b9b55a92da808e36ba158213808bdb35d718f0af0d1b064bc8f961916ed2b
View file https://github.com/angular/angular/blob/34b97c55d178f2301f758bf91c3e58419c4ab162/packages/core/test/reflection/reflector_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31333/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31333/files#diff-8b5b9b55a92da808e36ba158213808bdb35d718f0af0d1b064bc8f961916ed2b
https://github.com/angular/angular/pull/31333/files#diff-8b5b9b55a92da808e36ba158213808bdb35d718f0af0d1b064bc8f961916ed2b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.