René's URL Explorer Experiment


Title: fix(ivy): handle modifiedResourceFiles being null on incremental compilation by mattlewis92 · Pull Request #31322 · angular/angular · GitHub

Open Graph Title: fix(ivy): handle modifiedResourceFiles being null on incremental compilation by mattlewis92 · Pull Request #31322 · angular/angular

X Title: fix(ivy): handle modifiedResourceFiles being null on incremental compilation by mattlewis92 · Pull Request #31322 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Incremental compilation fails with ivy: ERROR in Cannot read property 'has' of null ℹ 「wdm」: Failed to compile. /Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/incremental/src/state.js:120 .some(function (resourcePath) { return _this.modifiedResourceFiles.has(resourcePath); }); ^ TypeError: Cannot read property 'has' of null at /Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/incremental/src/state.js:120:84 at Array.some () at IncrementalState.hasChangedResourceDependencies (/Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/incremental/src/state.js:120:18) at IncrementalState.safeToSkip (/Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/incremental/src/state.js:70:57) at IvyCompilation.analyze (/Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:156:39) at IvyCompilation.analyzeSync (/Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/transform/src/compilation.js:71:76) at /Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/program.js:257:39 at Array.forEach () at NgtscProgram.ensureAnalyzed (/Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/program.js:255:22) at NgtscProgram.getNgSemanticDiagnostics (/Users/mattlewis/Code/clickup/frontend/node_modules/@angular/compiler-cli/src/ngtsc/program.js:167:36) What is the new behavior? Incremental compilation works Does this PR introduce a breaking change? Yes No Other information I applied this patch locally and everything worked smoothly after! 😄

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/31322

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ae126b3e-3e2e-8d1f-c9bf-012a6649f803
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E20:4E3C:1B7AAF8:24506BC:6B0152EE
html-safe-nonce42479bb8ac93a5254257b25b2c629d7957ffb947f1235c92c20b22fa1f6a5c1b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTIwOjRFM0M6MUI3QUFGODoyNDUwNkJDOjZCMDE1MkVFIiwidmlzaXRvcl9pZCI6Ijg2ODM5MzgwNDA0OTE2MjcyNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacabf4bdd9eb715becf8c1f320e4899d1e0e62aaaf02ba85e5c603e1e4283e366c
hovercard-subject-tagpull_request:292636877
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/31322/files
twitter:imagehttps://avatars.githubusercontent.com/u/6425649?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6425649?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/31322/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31322%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31322%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31322/files
Reloadhttps://github.com/angular/angular/pull/31322/files
Reloadhttps://github.com/angular/angular/pull/31322/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
mattlewis92https://github.com/mattlewis92
angular:masterhttps://github.com/angular/angular/tree/master
mattlewis92:fix-incremental-compilatonhttps://github.com/mattlewis92/angular/tree/fix-incremental-compilaton
Conversation 33 https://github.com/angular/angular/pull/31322
Commits 1 https://github.com/angular/angular/pull/31322/commits
Checks 0 https://github.com/angular/angular/pull/31322/checks
Files changed https://github.com/angular/angular/pull/31322/files
Please reload this pagehttps://github.com/angular/angular/pull/31322/files
fix(ivy): handle modifiedResourceFiles being null on incremental compilation https://github.com/angular/angular/pull/31322/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/31322/files
c470579 fix(ivy): support older CLI versions that do not pass a list of chang… mattlewis92 Jun 27, 2019 https://github.com/angular/angular/pull/31322/commits/c470579f90e7f12e69c16d53d52f4a0e57969ce3
Clear filters https://github.com/angular/angular/pull/31322/files
Please reload this pagehttps://github.com/angular/angular/pull/31322/files
Please reload this pagehttps://github.com/angular/angular/pull/31322/files
main.ts https://github.com/angular/angular/pull/31322/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
state.ts https://github.com/angular/angular/pull/31322/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
perform_compile.ts https://github.com/angular/angular/pull/31322/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
env.ts https://github.com/angular/angular/pull/31322/files#diff-eec7f01739be0ed6ee5ce90ac1b910259a171c6437230f7f2ed1e27677920ba4
incremental_spec.ts https://github.com/angular/angular/pull/31322/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
packages/compiler-cli/src/main.tshttps://github.com/angular/angular/pull/31322/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
View file https://github.com/mattlewis92/angular/blob/c470579f90e7f12e69c16d53d52f4a0e57969ce3/packages/compiler-cli/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31322/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31322/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
https://github.com/angular/angular/pull/31322/files#diff-e03a24dba7c770d19222809414161e8c862096ecd9b7e12745855322ea5a2bb7
packages/compiler-cli/src/ngtsc/incremental/src/state.tshttps://github.com/angular/angular/pull/31322/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
View file https://github.com/mattlewis92/angular/blob/c470579f90e7f12e69c16d53d52f4a0e57969ce3/packages/compiler-cli/src/ngtsc/incremental/src/state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31322/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31322/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
petebacondarwinhttps://github.com/petebacondarwin
Jul 17, 2019https://github.com/angular/angular/pull/31322/files#r304472914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alxhubhttps://github.com/alxhub
Please reload this pagehttps://github.com/angular/angular/pull/31322/files
petebacondarwinhttps://github.com/petebacondarwin
Jul 17, 2019https://github.com/angular/angular/pull/31322/files#r304473985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31322/files
alxhubhttps://github.com/alxhub
Jul 18, 2019https://github.com/angular/angular/pull/31322/files#r305091299
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31322/files
https://github.com/angular/angular/pull/31322/files#diff-da3638f7ac25cec6013d66e2eb4fd2bbaea3525109569a484ea891ce15eefb1a
packages/compiler-cli/src/perform_compile.tshttps://github.com/angular/angular/pull/31322/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
View file https://github.com/mattlewis92/angular/blob/c470579f90e7f12e69c16d53d52f4a0e57969ce3/packages/compiler-cli/src/perform_compile.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31322/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31322/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/31322/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
https://github.com/angular/angular/pull/31322/files#diff-c8ba76bb2fd0e382be7a9f052a3b63464fce6ede1d0f28cb3df696f3fab7e3aa
packages/compiler-cli/test/ngtsc/env.tshttps://github.com/angular/angular/pull/31322/files#diff-eec7f01739be0ed6ee5ce90ac1b910259a171c6437230f7f2ed1e27677920ba4
View file https://github.com/mattlewis92/angular/blob/c470579f90e7f12e69c16d53d52f4a0e57969ce3/packages/compiler-cli/test/ngtsc/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31322/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31322/files#diff-eec7f01739be0ed6ee5ce90ac1b910259a171c6437230f7f2ed1e27677920ba4
https://github.com/angular/angular/pull/31322/files#diff-eec7f01739be0ed6ee5ce90ac1b910259a171c6437230f7f2ed1e27677920ba4
https://github.com/angular/angular/pull/31322/files#diff-eec7f01739be0ed6ee5ce90ac1b910259a171c6437230f7f2ed1e27677920ba4
https://github.com/angular/angular/pull/31322/files#diff-eec7f01739be0ed6ee5ce90ac1b910259a171c6437230f7f2ed1e27677920ba4
packages/compiler-cli/test/ngtsc/incremental_spec.tshttps://github.com/angular/angular/pull/31322/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
View file https://github.com/mattlewis92/angular/blob/c470579f90e7f12e69c16d53d52f4a0e57969ce3/packages/compiler-cli/test/ngtsc/incremental_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/31322/{{ revealButtonHref }}
https://github.com/angular/angular/pull/31322/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
https://github.com/angular/angular/pull/31322/files#diff-412639ceb2878836a42f63778639172c8c20d2c9a02d664f6e904964fdfefbce
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.