René's URL Explorer Experiment


Title: fix(service-worker): registration failed on Safari by H--o-l · Pull Request #31140 · angular/angular · GitHub

Open Graph Title: fix(service-worker): registration failed on Safari by H--o-l · Pull Request #31140 · angular/angular

X Title: fix(service-worker): registration failed on Safari by H--o-l · Pull Request #31140 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/31140

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1762e406-158a-dbc5-61e0-72a247b6c4a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D0E:A99C2:1C8C4FA:245AE8A:6B0143D7
html-safe-nonce3cffb90729ffb44eae095799ef05e4e02579a668c097f348a7aeccc1adbe8035
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDBFOkE5OUMyOjFDOEM0RkE6MjQ1QUU4QTo2QjAxNDNENyIsInZpc2l0b3JfaWQiOiI3MzQ4NTA4OTQwMDkyNjU0NTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac381cdb1e67d44535c1140716c48a062c4c7a578627cb0d148577e562563cf4a3
hovercard-subject-tagpull_request:289797118
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/31140/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e38431bd841d8918b690ba498f2247bdcae796754bfa191d2a64eb00c4f40f44/angular/angular/pull/31140
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e38431bd841d8918b690ba498f2247bdcae796754bfa191d2a64eb00c4f40f44/angular/angular/pull/31140
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameH--o-l
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/31140#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31140
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31140
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/31140
Reloadhttps://github.com/angular/angular/pull/31140
Reloadhttps://github.com/angular/angular/pull/31140
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
H--o-lhttps://github.com/H--o-l
angular:masterhttps://github.com/angular/angular/tree/master
H--o-l:fix/service-worker-safari-v8https://github.com/H--o-l/angular/tree/fix/service-worker-safari-v8
Conversationhttps://github.com/angular/angular/pull/31140
Commits1 (1)https://github.com/angular/angular/pull/31140/commits
Checkshttps://github.com/angular/angular/pull/31140/checks
Files changedhttps://github.com/angular/angular/pull/31140/files
fix(service-worker): registration failed on Safarihttps://github.com/angular/angular/pull/31140#top
H--o-lhttps://github.com/H--o-l
angular:masterhttps://github.com/angular/angular/tree/master
H--o-l:fix/service-worker-safari-v8https://github.com/H--o-l/angular/tree/fix/service-worker-safari-v8
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
Jun 19, 2019https://github.com/angular/angular/pull/31140#issue-458126632
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#31061https://github.com/angular/angular/issues/31061
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
June 19, 2019 17:08https://github.com/angular/angular/pull/31140#event-2424882884
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jun 19, 2019https://github.com/angular/angular/pull/31140#event-2424883011
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
force-pushedhttps://github.com/angular/angular/compare/95e21666dd8399bea8612e57fabe188e9d2c2847..1e6d482d258c3d68c226fdcc267b1f7a188004a9
95e2166https://github.com/angular/angular/commit/95e21666dd8399bea8612e57fabe188e9d2c2847
1e6d482https://github.com/angular/angular/commit/1e6d482d258c3d68c226fdcc267b1f7a188004a9
Compare https://github.com/angular/angular/compare/95e21666dd8399bea8612e57fabe188e9d2c2847..1e6d482d258c3d68c226fdcc267b1f7a188004a9
June 19, 2019 17:27https://github.com/angular/angular/pull/31140#event-2424935751
https://github.com/kara
karahttps://github.com/kara
area: service-worker https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
Jun 19, 2019https://github.com/angular/angular/pull/31140#event-2425649620
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jun 19, 2019https://github.com/angular/angular/pull/31140#event-2425649651
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Jun 20, 2019 https://github.com/angular/angular/pull/31140#pullrequestreview-252053434
View reviewed changes https://github.com/angular/angular/pull/31140/files
IgorMinarhttps://github.com/IgorMinar
https://github.com/angular/angular/pull/31140#pullrequestreview-252053434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Jun 20, 2019https://github.com/angular/angular/pull/31140#issuecomment-503813924
Please reload this pagehttps://github.com/angular/angular/pull/31140
@H--o-lhttps://github.com/H--o-l
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
force-pushedhttps://github.com/angular/angular/compare/1e6d482d258c3d68c226fdcc267b1f7a188004a9..55fe5b8cb26dbf3ca7cd104c8f5874493b7825a0
1e6d482https://github.com/angular/angular/commit/1e6d482d258c3d68c226fdcc267b1f7a188004a9
55fe5b8https://github.com/angular/angular/commit/55fe5b8cb26dbf3ca7cd104c8f5874493b7825a0
Compare https://github.com/angular/angular/compare/1e6d482d258c3d68c226fdcc267b1f7a188004a9..55fe5b8cb26dbf3ca7cd104c8f5874493b7825a0
June 20, 2019 07:48https://github.com/angular/angular/pull/31140#event-2426546763
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
Jun 20, 2019https://github.com/angular/angular/pull/31140#issuecomment-503949144
@IgorMinarhttps://github.com/IgorMinar
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 20, 2019 https://github.com/angular/angular/pull/31140#pullrequestreview-252288294
View reviewed changes https://github.com/angular/angular/pull/31140/files
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Jun 20, 2019https://github.com/angular/angular/pull/31140#event-2427417632
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 20, 2019 https://github.com/angular/angular/pull/31140#pullrequestreview-252300286
View reviewed changes https://github.com/angular/angular/pull/31140/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/31140#pullrequestreview-252300286
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@H--o-lhttps://github.com/H--o-l
worker/testing/scope.tshttps://github.com/angular/angular/blob/75ac724842b82ffc72cd6c306f5b82ba9c0d5bca/packages/service-worker/worker/testing/scope.ts#L189
b3dda0ehttps://github.com/angular/angular/commit/b3dda0ebc142c92e8f32131fb7772b083e3a85d3
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
force-pushedhttps://github.com/angular/angular/compare/55fe5b8cb26dbf3ca7cd104c8f5874493b7825a0..34d7dc521671c0c9d47033f36caa926e81ed1174
55fe5b8https://github.com/angular/angular/commit/55fe5b8cb26dbf3ca7cd104c8f5874493b7825a0
34d7dc5https://github.com/angular/angular/commit/34d7dc521671c0c9d47033f36caa926e81ed1174
Compare https://github.com/angular/angular/compare/55fe5b8cb26dbf3ca7cd104c8f5874493b7825a0..34d7dc521671c0c9d47033f36caa926e81ed1174
June 20, 2019 14:05https://github.com/angular/angular/pull/31140#event-2427520371
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
Jun 20, 2019https://github.com/angular/angular/pull/31140#issuecomment-504039692
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 20, 2019 https://github.com/angular/angular/pull/31140#pullrequestreview-252393092
View reviewed changes https://github.com/angular/angular/pull/31140/files
gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/angular/angular/pull/31140#pullrequestreview-252393092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
Jun 20, 2019https://github.com/angular/angular/pull/31140#issuecomment-504090895
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
Jun 24, 2019https://github.com/angular/angular/pull/31140#issuecomment-504942254
@IgorMinarhttps://github.com/IgorMinar
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 24, 2019https://github.com/angular/angular/pull/31140#issuecomment-504975038
@H--o-lhttps://github.com/H--o-l
b3dda0ehttps://github.com/angular/angular/commit/b3dda0ebc142c92e8f32131fb7772b083e3a85d3
https://angular.io/https://angular.io/
https://angular.io/https://angular.io/
#31061https://github.com/angular/angular/issues/31061
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/H--o-l
fix(service-worker): registration failed on Safarihttps://github.com/angular/angular/pull/31140/commits/36066a918199f27eec5f860053c7277ad517afa1
36066a9https://github.com/angular/angular/pull/31140/commits/36066a918199f27eec5f860053c7277ad517afa1
b3dda0ehttps://github.com/H--o-l/angular/commit/b3dda0ebc142c92e8f32131fb7772b083e3a85d3
https://angular.io/https://angular.io/
https://angular.io/https://angular.io/
angular#31061https://github.com/angular/angular/issues/31061
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
force-pushedhttps://github.com/angular/angular/compare/34d7dc521671c0c9d47033f36caa926e81ed1174..36066a918199f27eec5f860053c7277ad517afa1
34d7dc5https://github.com/angular/angular/commit/34d7dc521671c0c9d47033f36caa926e81ed1174
36066a9https://github.com/angular/angular/commit/36066a918199f27eec5f860053c7277ad517afa1
Compare https://github.com/angular/angular/compare/34d7dc521671c0c9d47033f36caa926e81ed1174..36066a918199f27eec5f860053c7277ad517afa1
June 24, 2019 15:03https://github.com/angular/angular/pull/31140#event-2434595921
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
Jun 24, 2019https://github.com/angular/angular/pull/31140#issuecomment-505051769
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Jun 24, 2019https://github.com/angular/angular/pull/31140#event-2435366049
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 24, 2019https://github.com/angular/angular/pull/31140#issuecomment-505152387
@H--o-lhttps://github.com/H--o-l
Please reload this pagehttps://github.com/angular/angular/pull/31140
karahttps://github.com/kara
Jun 24, 2019 https://github.com/angular/angular/pull/31140#ref-commit-f470e69
https://github.com/H--o-l
https://github.com/kara
fix(service-worker): registration failed on Safari (https://github.com/angular/angular/commit/f470e69fbac6bf4e8fc49a625a2df5bec82b4709
#31140https://github.com/angular/angular/pull/31140
)https://github.com/angular/angular/commit/f470e69fbac6bf4e8fc49a625a2df5bec82b4709
f470e69https://github.com/angular/angular/commit/f470e69fbac6bf4e8fc49a625a2df5bec82b4709
b3dda0ehttps://github.com/angular/angular/commit/b3dda0ebc142c92e8f32131fb7772b083e3a85d3
https://angular.io/https://angular.io/
https://angular.io/https://angular.io/
#31061https://github.com/angular/angular/issues/31061
#31140https://github.com/angular/angular/pull/31140
https://github.com/kara
karahttps://github.com/kara
a5dd4edhttps://github.com/angular/angular/commit/a5dd4edab92b10c093596d554d07cba93f5f8c76
Jun 24, 2019https://github.com/angular/angular/pull/31140#event-2435692092
https://github.com/H--o-l
H--o-lhttps://github.com/H--o-l
June 24, 2019 22:13https://github.com/angular/angular/pull/31140#event-2435715336
https://github.com/iget-master
iget-masterhttps://github.com/iget-master
Jul 10, 2019 https://github.com/angular/angular/pull/31140#ref-issue-466431953
CHANGELOG.md shouldn't include pre-release changes? #31491 https://github.com/angular/angular/issues/31491
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31140#issuecomment-531537150
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/31140#event-2634481327
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F31140
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/31140/files/1e6d482d258c3d68c226fdcc267b1f7a188004a9
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/31140/files/34d7dc521671c0c9d47033f36caa926e81ed1174
Please reload this pagehttps://github.com/angular/angular/pull/31140
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: service-worker https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Service worker registration failed in Safari angular 8 https://github.com/angular/angular/issues/31061
Please reload this pagehttps://github.com/angular/angular/pull/31140
https://github.com/H--o-l
https://github.com/IgorMinar
https://github.com/gkalpak
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.