René's URL Explorer Experiment


Title: fix(service-worker): cache opaque responses in data groups with `freshness` strategy by gkalpak · Pull Request #30977 · angular/angular · GitHub

Open Graph Title: fix(service-worker): cache opaque responses in data groups with `freshness` strategy by gkalpak · Pull Request #30977 · angular/angular

X Title: fix(service-worker): cache opaque responses in data groups with `freshness` strategy by gkalpak · Pull Request #30977 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Fix caching of opaque responses in data groups with freshness strategy. Clean-up/Simplify service-worker tests. (See individual commits for details.) Fixes #30968.

X Description: Fix caching of opaque responses in data groups with freshness strategy. Clean-up/Simplify service-worker tests. (See individual commits for details.) Fixes #30968.

Opengraph URL: https://github.com/angular/angular/pull/30977

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ea163875-4863-67df-4627-89fed99c57d1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A1E:3B046E:96B4FA:C9880A:6A600B46
html-safe-nonce23833509ec69ce4255c1a1972d283358daeb06e5f28088f2f64988fa441957ee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTFFOjNCMDQ2RTo5NkI0RkE6Qzk4ODBBOjZBNjAwQjQ2IiwidmlzaXRvcl9pZCI6IjI5MTUwODM5NjczMTcxNTA1MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac379ceaeb0e12247cc18551737dd97632c11b1d54b5800b1d348f039ef420f1e4
hovercard-subject-tagpull_request:287176632
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/30977/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a69284e364a438de587216787ee03dc762ce9742f73f7c5009c7525332e0813/angular/angular/pull/30977
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a69284e364a438de587216787ee03dc762ce9742f73f7c5009c7525332e0813/angular/angular/pull/30977
og:image:altFix caching of opaque responses in data groups with freshness strategy. Clean-up/Simplify service-worker tests. (See individual commits for details.) Fixes #30968.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
None48cb2ed2304f8ae5a4a05d6327faf70466c4c0d9dcbf7b9df76251ca9c669a90
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecb0f10a384099e0765239a7cc220992cae52bdba
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/30977#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30977
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30977
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/30977
Reloadhttps://github.com/angular/angular/pull/30977
Reloadhttps://github.com/angular/angular/pull/30977
Please reload this pagehttps://github.com/angular/angular/pull/30977
angular https://github.com/angular
angularhttps://github.com/angular/angular
Notifications https://github.com/login?return_to=%2Fangular%2Fangular
Fork 27.5k https://github.com/login?return_to=%2Fangular%2Fangular
Star 101k https://github.com/login?return_to=%2Fangular%2Fangular
Code https://github.com/angular/angular
Issues 978 https://github.com/angular/angular/issues
Pull requests 162 https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality 24 https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Code https://github.com/angular/angular
Issues https://github.com/angular/angular/issues
Pull requests https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-sw-caching-opaquehttps://github.com/gkalpak/angular/tree/fix-sw-caching-opaque
Conversationhttps://github.com/angular/angular/pull/30977
Commits9 (9)https://github.com/angular/angular/pull/30977/commits
Checkshttps://github.com/angular/angular/pull/30977/checks
Files changedhttps://github.com/angular/angular/pull/30977/files
fix(service-worker): cache opaque responses in data groups with freshness strategyhttps://github.com/angular/angular/pull/30977#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-sw-caching-opaquehttps://github.com/gkalpak/angular/tree/fix-sw-caching-opaque
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 11, 2019https://github.com/angular/angular/pull/30977#issue-454797755
#30968https://github.com/angular/angular/issues/30968
Please reload this pagehttps://github.com/angular/angular/pull/30977
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
PR target: TBD https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22PR%20target%3A%20TBD%22
area: service-worker https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
Jun 11, 2019https://github.com/angular/angular/pull/30977#event-2404824749
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
June 11, 2019 16:47https://github.com/angular/angular/pull/30977#event-2404824765
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jun 11, 2019https://github.com/angular/angular/pull/30977#event-2404824855
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jun 11, 2019https://github.com/angular/angular/pull/30977#event-2404825176
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 11, 2019 https://github.com/angular/angular/pull/30977#ref-issue-454521037
Support caching opaque responses with freshness strategy in ngsw-config.json [PWA][SW] #30968 https://github.com/angular/angular/issues/30968
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jun 11, 2019https://github.com/angular/angular/pull/30977#issuecomment-500931269
https://pr30977-84d287d.ngbuilds.io/https://pr30977-84d287d.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/30977
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/84d287d503d11780bf495df1f6c158426f0bac53..d7dab2370127980b00bab6b104660ae6850b4ada
84d287dhttps://github.com/angular/angular/commit/84d287d503d11780bf495df1f6c158426f0bac53
d7dab23https://github.com/angular/angular/commit/d7dab2370127980b00bab6b104660ae6850b4ada
Compare https://github.com/angular/angular/compare/84d287d503d11780bf495df1f6c158426f0bac53..d7dab2370127980b00bab6b104660ae6850b4ada
June 24, 2019 12:04https://github.com/angular/angular/pull/30977#event-2434027816
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jun 24, 2019https://github.com/angular/angular/pull/30977#issuecomment-504993983
https://pr30977-d7dab23.ngbuilds.io/https://pr30977-d7dab23.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/30977
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Jun 24, 2019 https://github.com/angular/angular/pull/30977#pullrequestreview-253443677
View reviewed changes https://github.com/angular/angular/pull/30977/files
IgorMinarhttps://github.com/IgorMinar
https://github.com/angular/angular/pull/30977#pullrequestreview-253443677
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30977
packages/service-worker/worker/testing/fetch.tshttps://github.com/angular/angular/pull/30977/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
IgorMinarhttps://github.com/IgorMinar
Jun 24, 2019https://github.com/angular/angular/pull/30977#discussion_r296747056
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30977
gkalpakhttps://github.com/gkalpak
Jun 24, 2019https://github.com/angular/angular/pull/30977#discussion_r296887713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
sounds like a good namehttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer#Example
Please reload this pagehttps://github.com/angular/angular/pull/30977
packages/service-worker/worker/src/data.tshttps://github.com/angular/angular/pull/30977/files#diff-19451b46170bbcdd8b7870f20019e96cac5d1e1b9e2410601ff283cce51dfe28
IgorMinarhttps://github.com/IgorMinar
Jun 24, 2019https://github.com/angular/angular/pull/30977#discussion_r296751702
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30977
gkalpakhttps://github.com/gkalpak
Jun 24, 2019https://github.com/angular/angular/pull/30977#discussion_r296898913
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30977
gkalpakhttps://github.com/gkalpak
June 24, 2019 23:13https://github.com/angular/angular/pull/30977#commits-pushed-cb71a13
https://github.com/gkalpak
test(service-worker): remove obsolete async test helpershttps://github.com/angular/angular/pull/30977/commits/cb71a13990f9f7ff292aa4e37ba7573fec44cfef
cb71a13https://github.com/angular/angular/pull/30977/commits/cb71a13990f9f7ff292aa4e37ba7573fec44cfef
https://github.com/gkalpak
test(service-worker): simplify test helpershttps://github.com/angular/angular/pull/30977/commits/a725e1de87c1bff665061a3c151544ba999fcb97
a725e1dhttps://github.com/angular/angular/pull/30977/commits/a725e1de87c1bff665061a3c151544ba999fcb97
https://github.com/gkalpak
test(service-worker): properly reset mock server state for each testhttps://github.com/angular/angular/pull/30977/commits/60c406bfaaa8e32e866c4bb310fe28b987bab34b
60c406bhttps://github.com/angular/angular/pull/30977/commits/60c406bfaaa8e32e866c4bb310fe28b987bab34b
https://github.com/gkalpak
test(service-worker): better simulate opaque requestshttps://github.com/angular/angular/pull/30977/commits/b54d0a969bfc1ad6e389625612e52d70f0d1a483
b54d0a9https://github.com/angular/angular/pull/30977/commits/b54d0a969bfc1ad6e389625612e52d70f0d1a483
https://developer.mozilla.org/en-US/docs/Web/API/Bodyhttps://developer.mozilla.org/en-US/docs/Web/API/Body
https://fetch.spec.whatwg.org/#concept-body-consume-bodyhttps://fetch.spec.whatwg.org/#concept-body-consume-body
https://github.com/gkalpak
refactor(service-worker): make the caching behavior more explicithttps://github.com/angular/angular/pull/30977/commits/1fc2e3b3d45a038cc8a2da64c45d19c42cbbdc1c
1fc2e3bhttps://github.com/angular/angular/pull/30977/commits/1fc2e3b3d45a038cc8a2da64c45d19c42cbbdc1c
https://github.com/angular/angular/blob/2b4d5c754/packages/service-worker/worker/src/data.ts#L379-L388https://github.com/angular/angular/blob/2b4d5c754/packages/service-worker/worker/src/data.ts#L379-L388
https://github.com/gkalpak
fix(service-worker): cache opaque responses in data groups with `fres…https://github.com/angular/angular/pull/30977/commits/ea9f1162d2d5ea0899c4e4d130cce2e79d21a255
ea9f116https://github.com/angular/angular/pull/30977/commits/ea9f1162d2d5ea0899c4e4d130cce2e79d21a255
angular#30968https://github.com/angular/angular/issues/30968
https://github.com/gkalpak
fix(service-worker): cache opaque responses when requests exceeds tim…https://github.com/angular/angular/pull/30977/commits/be5109a32231003d7b4d581376d42d1bda47fc91
be5109ahttps://github.com/angular/angular/pull/30977/commits/be5109a32231003d7b4d581376d42d1bda47fc91
https://github.com/gkalpak
refactor(service-worker): remove redundant cache operationhttps://github.com/angular/angular/pull/30977/commits/9f10975c00bade79df7326b49f6d777bbae7f5ef
9f10975https://github.com/angular/angular/pull/30977/commits/9f10975c00bade79df7326b49f6d777bbae7f5ef
https://github.com/gkalpak
fixup! test(service-worker): better simulate opaque requestshttps://github.com/angular/angular/pull/30977/commits/b8b61c77dacd2c73336b05d3d535c0fcbc2be32c
b8b61c7https://github.com/angular/angular/pull/30977/commits/b8b61c77dacd2c73336b05d3d535c0fcbc2be32c
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/d7dab2370127980b00bab6b104660ae6850b4ada..b8b61c77dacd2c73336b05d3d535c0fcbc2be32c
d7dab23https://github.com/angular/angular/commit/d7dab2370127980b00bab6b104660ae6850b4ada
b8b61c7https://github.com/angular/angular/commit/b8b61c77dacd2c73336b05d3d535c0fcbc2be32c
Compare https://github.com/angular/angular/compare/d7dab2370127980b00bab6b104660ae6850b4ada..b8b61c77dacd2c73336b05d3d535c0fcbc2be32c
June 24, 2019 20:14https://github.com/angular/angular/pull/30977#event-2435442721
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jun 24, 2019https://github.com/angular/angular/pull/30977#issuecomment-505164354
b8b61c7https://github.com/angular/angular/commit/b8b61c77dacd2c73336b05d3d535c0fcbc2be32c
https://pr30977-b8b61c7.ngbuilds.io/https://pr30977-b8b61c7.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/30977
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
PR target: TBD https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22PR%20target%3A%20TBD%22
Jun 24, 2019https://github.com/angular/angular/pull/30977#event-2435467932
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 24, 2019https://github.com/angular/angular/pull/30977#issuecomment-505166459
@IgorMinarhttps://github.com/IgorMinar
Please reload this pagehttps://github.com/angular/angular/pull/30977
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Jun 26, 2019https://github.com/angular/angular/pull/30977#event-2442173142
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 26, 2019https://github.com/angular/angular/pull/30977#issuecomment-506054549
Please reload this pagehttps://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-d0e213d
https://github.com/gkalpak
https://github.com/alxhub
test(service-worker): remove obsolete async test helpers (https://github.com/angular/angular/commit/d0e213d137f303a8ff298de7a55a83c16576249f
#30977https://github.com/angular/angular/pull/30977
)https://github.com/angular/angular/commit/d0e213d137f303a8ff298de7a55a83c16576249f
d0e213dhttps://github.com/angular/angular/commit/d0e213d137f303a8ff298de7a55a83c16576249f
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-642f604
https://github.com/gkalpak
https://github.com/alxhub
test(service-worker): simplify test helpers (https://github.com/angular/angular/commit/642f6046af83f45bb883c9cf5006d12e7c8e185f
#30977https://github.com/angular/angular/pull/30977
)https://github.com/angular/angular/commit/642f6046af83f45bb883c9cf5006d12e7c8e185f
642f604https://github.com/angular/angular/commit/642f6046af83f45bb883c9cf5006d12e7c8e185f
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-54c171c
https://github.com/gkalpak
https://github.com/alxhub
test(service-worker): properly reset mock server state for each test (https://github.com/angular/angular/commit/54c171cdedb89e07afa512c0d087fb4b58da8ae1
#…https://github.com/angular/angular/pull/30977
54c171chttps://github.com/angular/angular/commit/54c171cdedb89e07afa512c0d087fb4b58da8ae1
…30977https://github.com/angular/angular/pull/30977
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-8b61287
https://github.com/gkalpak
https://github.com/alxhub
test(service-worker): better simulate opaque requests (https://github.com/angular/angular/commit/8b6128759cdb5fc9a0cc903f4160b37a32835943
#30977https://github.com/angular/angular/pull/30977
)https://github.com/angular/angular/commit/8b6128759cdb5fc9a0cc903f4160b37a32835943
8b61287https://github.com/angular/angular/commit/8b6128759cdb5fc9a0cc903f4160b37a32835943
https://developer.mozilla.org/en-US/docs/Web/API/Bodyhttps://developer.mozilla.org/en-US/docs/Web/API/Body
https://fetch.spec.whatwg.org/#concept-body-consume-bodyhttps://fetch.spec.whatwg.org/#concept-body-consume-body
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-26efc68
https://github.com/gkalpak
https://github.com/alxhub
refactor(service-worker): make the caching behavior more explicit (https://github.com/angular/angular/commit/26efc682d560b2971e882357792085584e74fcde
#3…https://github.com/angular/angular/pull/30977
26efc68https://github.com/angular/angular/commit/26efc682d560b2971e882357792085584e74fcde
…0977https://github.com/angular/angular/pull/30977
https://github.com/angular/angular/blob/2b4d5c754/packages/service-worker/worker/src/data.ts#L379-L388https://github.com/angular/angular/blob/2b4d5c754/packages/service-worker/worker/src/data.ts#L379-L388
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-b0c3453
https://github.com/gkalpak
https://github.com/alxhub
fix(service-worker): cache opaque responses in data groups with `fres…https://github.com/angular/angular/commit/b0c345324a8c11e034f98ded1b868f52c3a54e1c
b0c3453https://github.com/angular/angular/commit/b0c345324a8c11e034f98ded1b868f52c3a54e1c
#30977https://github.com/angular/angular/pull/30977
#30968https://github.com/angular/angular/issues/30968
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-a9038ef
https://github.com/gkalpak
https://github.com/alxhub
fix(service-worker): cache opaque responses when requests exceeds tim…https://github.com/angular/angular/commit/a9038ef13c5cf43f081574046db76e27135e0caa
a9038efhttps://github.com/angular/angular/commit/a9038ef13c5cf43f081574046db76e27135e0caa
#30977https://github.com/angular/angular/pull/30977
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-c00544a
https://github.com/gkalpak
https://github.com/alxhub
refactor(service-worker): remove redundant cache operation (https://github.com/angular/angular/commit/c00544ac51b3a4338864b71932d87a7626bf4efd
#30977https://github.com/angular/angular/pull/30977
)https://github.com/angular/angular/commit/c00544ac51b3a4338864b71932d87a7626bf4efd
c00544ahttps://github.com/angular/angular/commit/c00544ac51b3a4338864b71932d87a7626bf4efd
#30977https://github.com/angular/angular/pull/30977
https://github.com/alxhub
alxhubhttps://github.com/alxhub
b6e8d19https://github.com/angular/angular/commit/b6e8d19313b7abf5014b1ddae2b31d4ce86f9efd
Jun 27, 2019https://github.com/angular/angular/pull/30977#event-2444940627
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-7217525
https://github.com/gkalpak
https://github.com/alxhub
test(service-worker): simplify test helpers (https://github.com/angular/angular/commit/7217525da4949f936ee4f879c748b19033df614b
#30977https://github.com/angular/angular/pull/30977
)https://github.com/angular/angular/commit/7217525da4949f936ee4f879c748b19033df614b
7217525https://github.com/angular/angular/commit/7217525da4949f936ee4f879c748b19033df614b
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-c150354
https://github.com/gkalpak
https://github.com/alxhub
test(service-worker): properly reset mock server state for each test (https://github.com/angular/angular/commit/c150354464639408145444958ab1e32da2967b88
#…https://github.com/angular/angular/pull/30977
c150354https://github.com/angular/angular/commit/c150354464639408145444958ab1e32da2967b88
…30977https://github.com/angular/angular/pull/30977
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-5306330
https://github.com/gkalpak
https://github.com/alxhub
test(service-worker): better simulate opaque requests (https://github.com/angular/angular/commit/5306330d85ad68e98c5e9752fa18b8f27a16a3cd
#30977https://github.com/angular/angular/pull/30977
)https://github.com/angular/angular/commit/5306330d85ad68e98c5e9752fa18b8f27a16a3cd
5306330https://github.com/angular/angular/commit/5306330d85ad68e98c5e9752fa18b8f27a16a3cd
https://developer.mozilla.org/en-US/docs/Web/API/Bodyhttps://developer.mozilla.org/en-US/docs/Web/API/Body
https://fetch.spec.whatwg.org/#concept-body-consume-bodyhttps://fetch.spec.whatwg.org/#concept-body-consume-body
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-2d38623
https://github.com/gkalpak
https://github.com/alxhub
refactor(service-worker): make the caching behavior more explicit (https://github.com/angular/angular/commit/2d386239741945624c965a0d136c4ec5934d24e4
#3…https://github.com/angular/angular/pull/30977
2d38623https://github.com/angular/angular/commit/2d386239741945624c965a0d136c4ec5934d24e4
…0977https://github.com/angular/angular/pull/30977
https://github.com/angular/angular/blob/2b4d5c754/packages/service-worker/worker/src/data.ts#L379-L388https://github.com/angular/angular/blob/2b4d5c754/packages/service-worker/worker/src/data.ts#L379-L388
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-d7be38f
https://github.com/gkalpak
https://github.com/alxhub
fix(service-worker): cache opaque responses in data groups with `fres…https://github.com/angular/angular/commit/d7be38f84b7639935fa37953947c1e0c8211e738
d7be38fhttps://github.com/angular/angular/commit/d7be38f84b7639935fa37953947c1e0c8211e738
#30977https://github.com/angular/angular/pull/30977
#30968https://github.com/angular/angular/issues/30968
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-93abc35
https://github.com/gkalpak
https://github.com/alxhub
fix(service-worker): cache opaque responses when requests exceeds tim…https://github.com/angular/angular/commit/93abc35213450b1e116ce1408a70efe54009240d
93abc35https://github.com/angular/angular/commit/93abc35213450b1e116ce1408a70efe54009240d
#30977https://github.com/angular/angular/pull/30977
#30977https://github.com/angular/angular/pull/30977
alxhubhttps://github.com/alxhub
Jun 27, 2019 https://github.com/angular/angular/pull/30977#ref-commit-19e8570
https://github.com/gkalpak
https://github.com/alxhub
refactor(service-worker): remove redundant cache operation (https://github.com/angular/angular/commit/19e8570ac0a82daa4aa46e0e4ab44379e3d058ba
#30977https://github.com/angular/angular/pull/30977
)https://github.com/angular/angular/commit/19e8570ac0a82daa4aa46e0e4ab44379e3d058ba
19e8570https://github.com/angular/angular/commit/19e8570ac0a82daa4aa46e0e4ab44379e3d058ba
#30977https://github.com/angular/angular/pull/30977
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
June 27, 2019 18:30https://github.com/angular/angular/pull/30977#event-2445194715
https://github.com/iget-master
iget-masterhttps://github.com/iget-master
Jul 10, 2019 https://github.com/angular/angular/pull/30977#ref-issue-466431953
CHANGELOG.md shouldn't include pre-release changes? #31491 https://github.com/angular/angular/issues/31491
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/30977#issuecomment-531538478
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/30977
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/30977#event-2634489731
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30977
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/30977/files/88f79f33762e70b87b7bb75c3ba754c37f2f5f07
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: service-worker https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Support caching opaque responses with freshness strategy in ngsw-config.json [PWA][SW] https://github.com/angular/angular/issues/30968
Please reload this pagehttps://github.com/angular/angular/pull/30977
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/IgorMinar
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.