René's URL Explorer Experiment


Title: feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 by JoostK · Pull Request #30795 · angular/angular · GitHub

Open Graph Title: feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 by JoostK · Pull Request #30795 · angular/angular

X Title: feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 by JoostK · Pull Request #30795 · angular/angular

Description: feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 Packages that have been compiled using an older version of TypeScript can have their decorators at the top-level of the ES5 bundles, instead of inside the IIFE that is emitted for the class. Before this change, ngcc only took static property assignments inside the IIFE into account, therefore missing the decorators that were assigned at the top-level. This commit extends the ES5 host to look for static properties in two places. Testcases for all bundle formats that contain ES5 have been added to ensure that this works in the various flavours. A patch is included to support UMD bundles. The UMD factory affects how TypeScripts binds the static properties to symbols, see the docblock of the patch function for more details.

Open Graph Description: feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 Packages that have been compiled using an older version of TypeScript can have their decorators at the top-level of the ES5 ...

X Description: feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 Packages that have been compiled using an older version of TypeScript can have their decorators at the top-level of the ES5 ...

Opengraph URL: https://github.com/angular/angular/pull/30795

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bdff3cdd-6d61-ee45-80b9-6d60eeebe2f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id873E:21AC3F:2287B04:2BAA4C9:6B015EF6
html-safe-nonce7b8abf9975ce7059513fa59b8f43e9992e694839c5e810a3cd054c1a0e8e6032
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzNFOjIxQUMzRjoyMjg3QjA0OjJCQUE0Qzk6NkIwMTVFRjYiLCJ2aXNpdG9yX2lkIjoiODA4MDY4MDc1MTAwNTI2MTU1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac63ca30f40398ea04fe979797d91b292e31bb68973d7413079447745f62bab999
hovercard-subject-tagpull_request:284214648
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/30795/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altfeat(ivy): ngcc - recognize static properties on the outer symbol in ES5 Packages that have been compiled using an older version of TypeScript can have their decorators at the top-level of the ES5 ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/30795/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30795%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30795%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/30795/files
Reloadhttps://github.com/angular/angular/pull/30795/files
Reloadhttps://github.com/angular/angular/pull/30795/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc-top-level-decoratorshttps://github.com/JoostK/angular/tree/ngcc-top-level-decorators
Conversation 18 https://github.com/angular/angular/pull/30795
Commits 4 https://github.com/angular/angular/pull/30795/commits
Checks 0 https://github.com/angular/angular/pull/30795/checks
Files changed https://github.com/angular/angular/pull/30795/files
Please reload this pagehttps://github.com/angular/angular/pull/30795/files
feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 https://github.com/angular/angular/pull/30795/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/30795/files
985c3ca feat(ivy): ngcc - recognize static properties on the outer symbol in ES5 JoostK May 31, 2019 https://github.com/angular/angular/pull/30795/commits/985c3ca97c7db6134a1b41778fd3afb92453a628
a374a63 fixup! feat(ivy): ngcc - recognize static properties on the outer sym… JoostK May 31, 2019 https://github.com/angular/angular/pull/30795/commits/a374a63d9c68cdbd87d17eac4d7ceb74a1e918fd
ca7565d fixup! feat(ivy): ngcc - recognize static properties on the outer sym… JoostK Jun 7, 2019 https://github.com/angular/angular/pull/30795/commits/ca7565dac1e315d5444e01ae3b87b413db963d7a
2a369e9 fixup! feat(ivy): ngcc - recognize static properties on the outer sym… JoostK Jun 9, 2019 https://github.com/angular/angular/pull/30795/commits/2a369e9f735a6cf8e8ce9f4c1963705f03d1c272
Clear filters https://github.com/angular/angular/pull/30795/files
Please reload this pagehttps://github.com/angular/angular/pull/30795/files
Please reload this pagehttps://github.com/angular/angular/pull/30795/files
esm5_host.ts https://github.com/angular/angular/pull/30795/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
bundle_program.ts https://github.com/angular/angular/pull/30795/files#diff-aca1e28855813c0299b22375a501e066f59bac9f95410b67e98a60f90dedbd02
patch_ts_expando_initializer.ts https://github.com/angular/angular/pull/30795/files#diff-052c5337bf85e9cfabecf9b7ed1246aeb84d937ab5186ed91fac9232e964c2d2
utils.ts https://github.com/angular/angular/pull/30795/files#diff-9426f38b1ae3b490d267de69d991dec093a25a3c5b4d05386fb3f077e130257b
commonjs_host_spec.ts https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
esm5_host_spec.ts https://github.com/angular/angular/pull/30795/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6
umd_host_spec.ts https://github.com/angular/angular/pull/30795/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
packages/compiler-cli/ngcc/src/host/esm5_host.tshttps://github.com/angular/angular/pull/30795/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
View file https://github.com/JoostK/angular/blob/2a369e9f735a6cf8e8ce9f4c1963705f03d1c272/packages/compiler-cli/ngcc/src/host/esm5_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/30795/{{ revealButtonHref }}
https://github.com/angular/angular/pull/30795/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/30795/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
packages/compiler-cli/ngcc/src/packages/bundle_program.tshttps://github.com/angular/angular/pull/30795/files#diff-aca1e28855813c0299b22375a501e066f59bac9f95410b67e98a60f90dedbd02
View file https://github.com/JoostK/angular/blob/2a369e9f735a6cf8e8ce9f4c1963705f03d1c272/packages/compiler-cli/ngcc/src/packages/bundle_program.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/30795/{{ revealButtonHref }}
https://github.com/angular/angular/pull/30795/files#diff-aca1e28855813c0299b22375a501e066f59bac9f95410b67e98a60f90dedbd02
https://github.com/angular/angular/pull/30795/files#diff-aca1e28855813c0299b22375a501e066f59bac9f95410b67e98a60f90dedbd02
https://github.com/angular/angular/pull/30795/files#diff-aca1e28855813c0299b22375a501e066f59bac9f95410b67e98a60f90dedbd02
https://github.com/angular/angular/pull/30795/files#diff-aca1e28855813c0299b22375a501e066f59bac9f95410b67e98a60f90dedbd02
packages/compiler-cli/ngcc/src/packages/patch_ts_expando_initializer.tshttps://github.com/angular/angular/pull/30795/files#diff-052c5337bf85e9cfabecf9b7ed1246aeb84d937ab5186ed91fac9232e964c2d2
View file https://github.com/JoostK/angular/blob/2a369e9f735a6cf8e8ce9f4c1963705f03d1c272/packages/compiler-cli/ngcc/src/packages/patch_ts_expando_initializer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/30795/{{ revealButtonHref }}
alxhubhttps://github.com/alxhub
Jun 7, 2019https://github.com/angular/angular/pull/30795/files#r291761678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30795/files
JoostKhttps://github.com/JoostK
Jun 7, 2019https://github.com/angular/angular/pull/30795/files#r291770021
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30795/files
alxhubhttps://github.com/alxhub
Jun 14, 2019https://github.com/angular/angular/pull/30795/files#r293875201
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30795/files
packages/compiler-cli/ngcc/test/helpers/utils.tshttps://github.com/angular/angular/pull/30795/files#diff-9426f38b1ae3b490d267de69d991dec093a25a3c5b4d05386fb3f077e130257b
View file https://github.com/JoostK/angular/blob/2a369e9f735a6cf8e8ce9f4c1963705f03d1c272/packages/compiler-cli/ngcc/test/helpers/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/30795/{{ revealButtonHref }}
https://github.com/angular/angular/pull/30795/files#diff-9426f38b1ae3b490d267de69d991dec093a25a3c5b4d05386fb3f077e130257b
https://github.com/angular/angular/pull/30795/files#diff-9426f38b1ae3b490d267de69d991dec093a25a3c5b4d05386fb3f077e130257b
https://github.com/angular/angular/pull/30795/files#diff-9426f38b1ae3b490d267de69d991dec093a25a3c5b4d05386fb3f077e130257b
https://github.com/angular/angular/pull/30795/files#diff-9426f38b1ae3b490d267de69d991dec093a25a3c5b4d05386fb3f077e130257b
packages/compiler-cli/ngcc/test/host/commonjs_host_spec.tshttps://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
View file https://github.com/JoostK/angular/blob/2a369e9f735a6cf8e8ce9f4c1963705f03d1c272/packages/compiler-cli/ngcc/test/host/commonjs_host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/30795/{{ revealButtonHref }}
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
https://github.com/angular/angular/pull/30795/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
Please reload this pagehttps://github.com/angular/angular/pull/30795/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.