| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:651baec1-fca2-d33c-0da5-53ffb7fb647f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A228:3A347:DED86A:1287E29:6B00FF68 |
| html-safe-nonce | 34198546fd0e9011cf5a17a8959ff98f151f412cef95764da96b759c2b27e671 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjI4OjNBMzQ3OkRFRDg2QToxMjg3RTI5OjZCMDBGRjY4IiwidmlzaXRvcl9pZCI6IjE1ODMzNjk1NzU1NTMxMDU3NjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fd059365a7f3e8a8fb9475acabbd64bb64a91d2a9fcdd33f2ab73ac8a23b1ac3 |
| hovercard-subject-tag | pull_request:277955406 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/30410/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5581bdd9a308a0d37e66d01a7d08afad069459fc0d1a0393c28adff9d0db2238/angular/angular/pull/30410 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5581bdd9a308a0d37e66d01a7d08afad069459fc0d1a0393c28adff9d0db2238/angular/angular/pull/30410 |
| og:image:alt | make recognize synchronous as suggested by @jasonaden in PR 15826.
This is better since it will allow to convert URLs to snapshot and use
metadata without the need for Observables
PR Checklist
Plea... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | yelhouti |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/30410#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30410 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30410 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/30410 |
| Reload | https://github.com/angular/angular/pull/30410 |
| Reload | https://github.com/angular/angular/pull/30410 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| yelhouti | https://github.com/yelhouti |
| angular:master | https://github.com/angular/angular/tree/master |
| yelhouti:router-recognize | https://github.com/yelhouti/angular/tree/router-recognize |
| Conversation | https://github.com/angular/angular/pull/30410 |
| Commits1 (1) | https://github.com/angular/angular/pull/30410/commits |
| Checks | https://github.com/angular/angular/pull/30410/checks |
| Files changed | https://github.com/angular/angular/pull/30410/files |
| refactor(router): make recognize synchronous to expose it later | https://github.com/angular/angular/pull/30410#top |
| yelhouti | https://github.com/yelhouti |
| angular:master | https://github.com/angular/angular/tree/master |
| yelhouti:router-recognize | https://github.com/yelhouti/angular/tree/router-recognize |
|
| https://github.com/yelhouti |
| yelhouti | https://github.com/yelhouti |
| May 11, 2019 | https://github.com/angular/angular/pull/30410#issue-442953744 |
| @jasonaden | https://github.com/jasonaden |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| @jasonaden | https://github.com/jasonaden |
| #15826 | https://github.com/angular/angular/pull/15826 |
| #15826 | https://github.com/angular/angular/pull/15826 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
|
| https://github.com/yelhouti |
| refactor(router): make recognize synchronous to expose it later | https://github.com/angular/angular/pull/30410/commits/20705956e31f141b510e3258a309e499df89c979 |
| 2070595 | https://github.com/angular/angular/pull/30410/commits/20705956e31f141b510e3258a309e499df89c979 |
| @jasonaden | https://github.com/jasonaden |
| https://github.com/yelhouti |
| yelhouti | https://github.com/yelhouti |
| May 11, 2019 04:48 | https://github.com/angular/angular/pull/30410#event-2334578814 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| May 11, 2019 | https://github.com/angular/angular/pull/30410#issuecomment-491479337 |
| https://cla.developers.google.com/ | https://cla.developers.google.com/ |
| your existing CLA data | https://cla.developers.google.com/clas |
| email is set on your git commits | https://help.github.com/articles/setting-your-email-in-git/ |
| go/cla#troubleshoot | http://go/cla#troubleshoot |
| Public version | https://opensource.google.com/docs/cla/#troubleshoot |
| your existing CLA data | https://cla.developers.google.com/clas |
| email is set on your git commits | https://help.github.com/articles/setting-your-email-in-git/ |
| attached to your GitHub account | https://github.com/settings/emails |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30410 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| May 11, 2019 | https://github.com/angular/angular/pull/30410#event-2334578837 |
| https://github.com/yelhouti |
| yelhouti | https://github.com/yelhouti |
| May 11, 2019 | https://github.com/angular/angular/pull/30410#issuecomment-491479364 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| May 11, 2019 | https://github.com/angular/angular/pull/30410#issuecomment-491479370 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30410 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| May 11, 2019 | https://github.com/angular/angular/pull/30410#event-2334579123 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
| May 15, 2019 | https://github.com/angular/angular/pull/30410#event-2344849880 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| May 15, 2019 | https://github.com/angular/angular/pull/30410#event-2344849980 |
| https://github.com/yelhouti |
| yelhouti | https://github.com/yelhouti |
| May 17, 2019 | https://github.com/angular/angular/pull/30410#issuecomment-493283206 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| @jasonaden | https://github.com/jasonaden |
| #30411 | https://github.com/angular/angular/pull/30411 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Aug 6, 2020
| https://github.com/angular/angular/pull/30410#pullrequestreview-462868279 |
|
View reviewed changes
| https://github.com/angular/angular/pull/30410/files/20705956e31f141b510e3258a309e499df89c979 |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/30410#pullrequestreview-462868279 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @yelhouti | https://github.com/yelhouti |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| packages/router/src/recognize.ts | https://github.com/angular/angular/pull/30410/files/20705956e31f141b510e3258a309e499df89c979#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1 |
| atscott | https://github.com/atscott |
| Aug 6, 2020 | https://github.com/angular/angular/pull/30410#discussion_r466679655 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Aug 6, 2020 | https://github.com/angular/angular/pull/30410#event-3630804689 |
| atscott | https://github.com/atscott |
|
Dec 14, 2020
| https://github.com/angular/angular/pull/30410#ref-commit-2eb49c3 |
|
| https://github.com/atscott |
| fix(router): apply redirects should match named outlets with empty pa… | https://github.com/atscott/angular/commit/2eb49c31d1a0314c038f82a33f26c218486c54ad |
| 2eb49c3 | https://github.com/atscott/angular/commit/2eb49c31d1a0314c038f82a33f26c218486c54ad |
| angular#38379 | https://github.com/angular/angular/pull/38379 |
| angular#38379 | https://github.com/angular/angular/pull/38379 |
| angular#39952 | https://github.com/angular/angular/issues/39952 |
| angular#10726 | https://github.com/angular/angular/issues/10726 |
| angular#30410 | https://github.com/angular/angular/pull/30410 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
| e43f7e2 | https://github.com/angular/angular/commit/e43f7e26fe8d3010682c56c68c0e09791bb3ed55 |
| Jan 5, 2021 | https://github.com/angular/angular/pull/30410#event-4171880088 |
| atscott | https://github.com/atscott |
|
Jan 5, 2021
| https://github.com/angular/angular/pull/30410#ref-commit-a1b4b95 |
|
| https://github.com/atscott |
| fix(router): apply redirects should match named outlets with empty pa… | https://github.com/atscott/angular/commit/a1b4b95eb049bee5c168b6a032d5eccf672bc4d0 |
| a1b4b95 | https://github.com/atscott/angular/commit/a1b4b95eb049bee5c168b6a032d5eccf672bc4d0 |
| angular#40029 | https://github.com/angular/angular/pull/40029 |
| angular#38379 | https://github.com/angular/angular/pull/38379 |
| angular#38379 | https://github.com/angular/angular/pull/38379 |
| angular#39952 | https://github.com/angular/angular/issues/39952 |
| angular#10726 | https://github.com/angular/angular/issues/10726 |
| angular#30410 | https://github.com/angular/angular/pull/30410 |
| angular#40029 | https://github.com/angular/angular/pull/40029 |
| josephperrott | https://github.com/josephperrott |
|
Jan 5, 2021
| https://github.com/angular/angular/pull/30410#ref-commit-f542e4e |
|
| https://github.com/atscott |
|
| https://github.com/josephperrott |
| fix(router): apply redirects should match named outlets with empty pa… | https://github.com/angular/angular/commit/f542e4ee9939a2049e3161d6f980a3dfc13cebad |
| f542e4e | https://github.com/angular/angular/commit/f542e4ee9939a2049e3161d6f980a3dfc13cebad |
| #40029 | https://github.com/angular/angular/pull/40029 |
| #40315 | https://github.com/angular/angular/pull/40315 |
| #38379 | https://github.com/angular/angular/pull/38379 |
| #38379 | https://github.com/angular/angular/pull/38379 |
| #39952 | https://github.com/angular/angular/issues/39952 |
| #10726 | https://github.com/angular/angular/issues/10726 |
| #30410 | https://github.com/angular/angular/pull/30410 |
| #40029 | https://github.com/angular/angular/pull/40029 |
| #40315 | https://github.com/angular/angular/pull/40315 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 5, 2021 | https://github.com/angular/angular/pull/30410#issuecomment-774142696 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 5, 2021 | https://github.com/angular/angular/pull/30410#event-4296976628 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30410 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/30410/files/20705956e31f141b510e3258a309e499df89c979 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/30410 |
|
| https://github.com/yelhouti |
|
| https://github.com/googlebot |
|
| https://github.com/atscott |
|
| https://github.com/jasonaden |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |