René's URL Explorer Experiment


Title: fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed by AndrewKushnir · Pull Request #30037 · angular/angular · GitHub

Open Graph Title: fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed by AndrewKushnir · Pull Request #30037 · angular/angular

X Title: fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed by AndrewKushnir · Pull Request #30037 · angular/angular

Description: This commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling compileNgModuleDefs explicitly for RootScopeModule. This change also resolves the problem where TestBed's code was used from the @angular/core NPM package: due to the "jit" flag, the @NgModule decorator on the RootScopeModule was transformed to RootScopeModule.decorators = [...], but actual ngModuleDef was never defined. This PR resolves FW-1280. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: This commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling compileNgModuleDefs explicitly for RootScopeModule. This change also resolves the pr...

X Description: This commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling compileNgModuleDefs explicitly for RootScopeModule. This change also resolves the pr...

Opengraph URL: https://github.com/angular/angular/pull/30037

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:75b9dfc9-ff79-206e-9a48-c2df7b36a625
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5BA:1201C:1AB4CCD:237DDAD:6B0153A7
html-safe-nonce7073c573d341d33c82cc8da9873686b5c9d44a2053c7137487d46bc2b09325c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUJBOjEyMDFDOjFBQjRDQ0Q6MjM3RERBRDo2QjAxNTNBNyIsInZpc2l0b3JfaWQiOiIyMDUxNTQ0MDc5MDg2NDc0MTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5a088b26fb86d38a10cfafd2bfc71b5cc75e65c600b2886b7773115a5d493b74
hovercard-subject-tagpull_request:272529515
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/30037/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altThis commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling compileNgModuleDefs explicitly for RootScopeModule. This change also resolves the pr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/30037/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30037%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30037%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/30037/files
Reloadhttps://github.com/angular/angular/pull/30037/files
Reloadhttps://github.com/angular/angular/pull/30037/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-1280_root_scope_module_compilehttps://github.com/AndrewKushnir/angular/tree/FW-1280_root_scope_module_compile
Conversation 3 https://github.com/angular/angular/pull/30037
Commits 1 https://github.com/angular/angular/pull/30037/commits
Checks 0 https://github.com/angular/angular/pull/30037/checks
Files changed https://github.com/angular/angular/pull/30037/files
Please reload this pagehttps://github.com/angular/angular/pull/30037/files
fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed https://github.com/angular/angular/pull/30037/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/30037/files
8f7a5ed fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3Tes… AndrewKushnir Apr 22, 2019 https://github.com/angular/angular/pull/30037/commits/8f7a5ed5a440f56a0a10adb328f70ea81983e9bd
Clear filters https://github.com/angular/angular/pull/30037/files
Please reload this pagehttps://github.com/angular/angular/pull/30037/files
Please reload this pagehttps://github.com/angular/angular/pull/30037/files
packages/core/testing/src/r3_test_bed_compiler.tshttps://github.com/angular/angular/pull/30037/files#diff-28e822ed36baa53a0a4e0283fdc0d33a896adf5d1595c7fd7ea206a06c9326cb
View file https://github.com/AndrewKushnir/angular/blob/8f7a5ed5a440f56a0a10adb328f70ea81983e9bd/packages/core/testing/src/r3_test_bed_compiler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/30037/{{ revealButtonHref }}
https://github.com/angular/angular/pull/30037/files#diff-28e822ed36baa53a0a4e0283fdc0d33a896adf5d1595c7fd7ea206a06c9326cb
https://github.com/angular/angular/pull/30037/files#diff-28e822ed36baa53a0a4e0283fdc0d33a896adf5d1595c7fd7ea206a06c9326cb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.