René's URL Explorer Experiment


Title: fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed by AndrewKushnir · Pull Request #30037 · angular/angular · GitHub

Open Graph Title: fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed by AndrewKushnir · Pull Request #30037 · angular/angular

X Title: fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed by AndrewKushnir · Pull Request #30037 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling compileNgModuleDefs explicitly for RootScopeModule. This change also resolves the pr...

X Description: This commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling compileNgModuleDefs explicitly for RootScopeModule. This change also resolves the pr...

Opengraph URL: https://github.com/angular/angular/pull/30037

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c2ad7fc9-a033-b4f5-d054-665346bcbb20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE386:24A0A:A71E91:D259B6:6B0124D6
html-safe-noncea06d112e34d5464042ab25cedc12d38dbc189bbf13f231233f6a3cc89ff36ac8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzg2OjI0QTBBOkE3MUU5MTpEMjU5QjY6NkIwMTI0RDYiLCJ2aXNpdG9yX2lkIjoiODU0MjU4NzY5MDM2NzkxOTMxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac95dec746fb595095689f15a41316a66482e6d38508d0afae5af9c7fded473650
hovercard-subject-tagpull_request:272529515
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/30037/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/25b8a1beb47a5ae356137a1885e280ba377e06b693dfb4f0ff7e0680a2d852ae/angular/angular/pull/30037
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/25b8a1beb47a5ae356137a1885e280ba377e06b693dfb4f0ff7e0680a2d852ae/angular/angular/pull/30037
og:image:altThis commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling compileNgModuleDefs explicitly for RootScopeModule. This change also resolves the pr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/30037#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30037
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30037
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/30037
Reloadhttps://github.com/angular/angular/pull/30037
Reloadhttps://github.com/angular/angular/pull/30037
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-1280_root_scope_module_compilehttps://github.com/AndrewKushnir/angular/tree/FW-1280_root_scope_module_compile
Conversationhttps://github.com/angular/angular/pull/30037
Commits1 (1)https://github.com/angular/angular/pull/30037/commits
Checkshttps://github.com/angular/angular/pull/30037/checks
Files changedhttps://github.com/angular/angular/pull/30037/files
fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBedhttps://github.com/angular/angular/pull/30037#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-1280_root_scope_module_compilehttps://github.com/AndrewKushnir/angular/tree/FW-1280_root_scope_module_compile
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 22, 2019https://github.com/angular/angular/pull/30037#issue-435924067
@NgModulehttps://github.com/NgModule
Please reload this pagehttps://github.com/angular/angular/pull/30037
https://github.com/AndrewKushnir
fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3Tes…https://github.com/angular/angular/pull/30037/commits/8f7a5ed5a440f56a0a10adb328f70ea81983e9bd
8f7a5edhttps://github.com/angular/angular/pull/30037/commits/8f7a5ed5a440f56a0a10adb328f70ea81983e9bd
@NgModulehttps://github.com/NgModule
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Apr 22, 2019https://github.com/angular/angular/pull/30037#event-2292489269
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
April 22, 2019 22:49https://github.com/angular/angular/pull/30037#event-2292489274
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Apr 22, 2019https://github.com/angular/angular/pull/30037#event-2292489299
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 22, 2019https://github.com/angular/angular/pull/30037#event-2292489348
https://github.com/kara
karahttps://github.com/kara
Apr 23, 2019 https://github.com/angular/angular/pull/30037#pullrequestreview-229310731
View reviewed changes https://github.com/angular/angular/pull/30037/files/8f7a5ed5a440f56a0a10adb328f70ea81983e9bd
karahttps://github.com/kara
https://github.com/angular/angular/pull/30037#pullrequestreview-229310731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/30037
https://github.com/kara
karahttps://github.com/kara
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Apr 23, 2019https://github.com/angular/angular/pull/30037#event-2292650053
https://github.com/kara
karahttps://github.com/kara
Apr 23, 2019https://github.com/angular/angular/pull/30037#issuecomment-485603603
presubmithttps://test.corp.google.com/ui#id=OCL:244771829:BASE:244771858:1555981322755:4bf068c8
Please reload this pagehttps://github.com/angular/angular/pull/30037
https://github.com/kara
karahttps://github.com/kara
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Apr 23, 2019https://github.com/angular/angular/pull/30037#event-2292651904
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Apr 23, 2019 https://github.com/angular/angular/pull/30037#ref-pullrequest-406548293
ci(docs-infra): run with Ivy #28530 https://github.com/angular/angular/pull/28530
https://github.com/benlesh
benleshhttps://github.com/benlesh
00ce9aahttps://github.com/angular/angular/commit/00ce9aab5b8d3295b8e570e3fdb5f25f9af5738f
Apr 23, 2019https://github.com/angular/angular/pull/30037#event-2294507863
gkalpakhttps://github.com/gkalpak
May 1, 2019 https://github.com/angular/angular/pull/30037#ref-commit-add0d00
https://github.com/gkalpak
fix(ivy): allow R3TestBedCompiler to work in ngcc-processed appshttps://github.com/gkalpak/angular/commit/add0d001a146168bf4a7885024bbd491b2fe6fcc
add0d00https://github.com/gkalpak/angular/commit/add0d001a146168bf4a7885024bbd491b2fe6fcc
angular#30121https://github.com/angular/angular/issues/30121
angular#30037https://github.com/angular/angular/pull/30037
angular#30121https://github.com/angular/angular/issues/30121
karahttps://github.com/kara
May 1, 2019 https://github.com/angular/angular/pull/30037#ref-commit-066ec33
https://github.com/gkalpak
https://github.com/kara
fix(ivy): allowhttps://github.com/angular/angular/commit/066ec33342c371e6a1a11e35a6c0d44f94b1c96a
R3TestBedCompilerhttps://github.com/angular/angular/commit/066ec33342c371e6a1a11e35a6c0d44f94b1c96a
to work in ngcc-processed apps (https://github.com/angular/angular/commit/066ec33342c371e6a1a11e35a6c0d44f94b1c96a
#…https://github.com/angular/angular/pull/28530
066ec33https://github.com/angular/angular/commit/066ec33342c371e6a1a11e35a6c0d44f94b1c96a
…28530https://github.com/angular/angular/pull/28530
#30121https://github.com/angular/angular/issues/30121
#30037https://github.com/angular/angular/pull/30037
#30121https://github.com/angular/angular/issues/30121
#28530https://github.com/angular/angular/pull/28530
karahttps://github.com/kara
May 1, 2019 https://github.com/angular/angular/pull/30037#ref-commit-7cbc69c
https://github.com/gkalpak
https://github.com/kara
fix(ivy): allowhttps://github.com/angular/angular/commit/7cbc69c890462d45ee77716b79e595fd21ada40d
R3TestBedCompilerhttps://github.com/angular/angular/commit/7cbc69c890462d45ee77716b79e595fd21ada40d
to work in ngcc-processed apps (https://github.com/angular/angular/commit/7cbc69c890462d45ee77716b79e595fd21ada40d
#…https://github.com/angular/angular/pull/28530
7cbc69chttps://github.com/angular/angular/commit/7cbc69c890462d45ee77716b79e595fd21ada40d
…28530https://github.com/angular/angular/pull/28530
#30121https://github.com/angular/angular/issues/30121
#30037https://github.com/angular/angular/pull/30037
#30121https://github.com/angular/angular/issues/30121
#28530https://github.com/angular/angular/pull/28530
BioPhotonhttps://github.com/BioPhoton
May 21, 2019 https://github.com/angular/angular/pull/30037#ref-commit-cfd4f1f
https://github.com/AndrewKushnir
https://github.com/BioPhoton
fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3Tes…https://github.com/BioPhoton/angular/commit/cfd4f1f5a8773d513945c40eac032ee64c44e99f
cfd4f1fhttps://github.com/BioPhoton/angular/commit/cfd4f1f5a8773d513945c40eac032ee64c44e99f
angular#30037https://github.com/angular/angular/pull/30037
@NgModulehttps://github.com/NgModule
angular#30037https://github.com/angular/angular/pull/30037
BioPhotonhttps://github.com/BioPhoton
May 21, 2019 https://github.com/angular/angular/pull/30037#ref-commit-891d162
https://github.com/gkalpak
https://github.com/BioPhoton
fix(ivy): allowhttps://github.com/BioPhoton/angular/commit/891d16228e790b9e010fd3ff90910d9cd6b7518b
R3TestBedCompilerhttps://github.com/BioPhoton/angular/commit/891d16228e790b9e010fd3ff90910d9cd6b7518b
to work in ngcc-processed apps (https://github.com/BioPhoton/angular/commit/891d16228e790b9e010fd3ff90910d9cd6b7518b
a…https://github.com/angular/angular/pull/28530
891d162https://github.com/BioPhoton/angular/commit/891d16228e790b9e010fd3ff90910d9cd6b7518b
…ngular#28530https://github.com/angular/angular/pull/28530
angular#30121https://github.com/angular/angular/issues/30121
angular#30037https://github.com/angular/angular/pull/30037
angular#30121https://github.com/angular/angular/issues/30121
angular#28530https://github.com/angular/angular/pull/28530
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/30037#issuecomment-531522424
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/30037
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/30037#event-2634386970
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F30037
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/30037/files/8f7a5ed5a440f56a0a10adb328f70ea81983e9bd
Please reload this pagehttps://github.com/angular/angular/pull/30037
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/30037
https://github.com/AndrewKushnir
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.