| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8e4204a8-86d4-9f7a-6550-211e3ea908fd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E810:36A3E:18CBF2C:21084EF:6B014F2E |
| html-safe-nonce | 10b872919e97612887ddf2134ddba5637b4e06fe09ae021738f0f93bcb68df2a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODEwOjM2QTNFOjE4Q0JGMkM6MjEwODRFRjo2QjAxNEYyRSIsInZpc2l0b3JfaWQiOiI1MjY2NDAzNzM1MjQzOTM1NTM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4a37168941d6d86fec5199ec8284f527b7fb9eb868b4e2ea62b2413736840047 |
| hovercard-subject-tag | pull_request:271785245 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/29978/files |
| twitter:image | https://avatars.githubusercontent.com/u/93018?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/93018?s=400&v=4 |
| og:image:alt | In ivy, because metadata is inherited, this may cause super and sub host bindings on
two components to update an animation binding in parallel. This patch ensures that
the animation transition code... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/29978/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29978%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29978%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/29978/files |
| Reload | https://github.com/angular/angular/pull/29978/files |
| Reload | https://github.com/angular/angular/pull/29978/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| matsko | https://github.com/matsko |
| angular:master | https://github.com/angular/angular/tree/master |
| matsko:FW-1220-fix_animation_transition_states_ivy | https://github.com/matsko/angular/tree/FW-1220-fix_animation_transition_states_ivy |
|
Conversation
9
| https://github.com/angular/angular/pull/29978 |
|
Commits
1
| https://github.com/angular/angular/pull/29978/commits |
|
Checks
0
| https://github.com/angular/angular/pull/29978/checks |
|
Files changed
| https://github.com/angular/angular/pull/29978/files |
| Please reload this page | https://github.com/angular/angular/pull/29978/files |
|
fix(ivy): ensure that super/sub classes can both update an animation binding in harmony
| https://github.com/angular/angular/pull/29978/files#top |
|
Show all changes
1 commit
| https://github.com/angular/angular/pull/29978/files |
|
ab6b89a
fix(ivy): ensure that super/sub classes can both update an animation …
matsko Apr 22, 2019
| https://github.com/angular/angular/pull/29978/commits/ab6b89a12e27b86f5bb0d0818dfc09d4a5d0ce76 |
|
Clear filters
| https://github.com/angular/angular/pull/29978/files |
| Please reload this page | https://github.com/angular/angular/pull/29978/files |
| Please reload this page | https://github.com/angular/angular/pull/29978/files |
|
transition_animation_engine.ts
| https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
|
BUILD.bazel
| https://github.com/angular/angular/pull/29978/files#diff-6abcdab6615387b65c22249bef42b088ae11ccff9eee000645e517cd3c1e2665 |
|
animation_spec.ts
| https://github.com/angular/angular/pull/29978/files#diff-b6bc76dc13a505cb4602823af02f9960fa302d895811f69f05d29c13130ac664 |
| packages/animations/browser/src/render/transition_animation_engine.ts | https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
|
View file
| https://github.com/matsko/angular/blob/ab6b89a12e27b86f5bb0d0818dfc09d4a5d0ce76/packages/animations/browser/src/render/transition_animation_engine.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/29978/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
|
| https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
|
| https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
|
| https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
|
| https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
|
| https://github.com/angular/angular/pull/29978/files#diff-7c6a1ecc8f007812aa11510234c87217ac5aefbe13ba20b42aa5e34ce991d1f4 |
| packages/core/test/acceptance/BUILD.bazel | https://github.com/angular/angular/pull/29978/files#diff-6abcdab6615387b65c22249bef42b088ae11ccff9eee000645e517cd3c1e2665 |
|
View file
| https://github.com/matsko/angular/blob/ab6b89a12e27b86f5bb0d0818dfc09d4a5d0ce76/packages/core/test/acceptance/BUILD.bazel |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/29978/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/29978/files#diff-6abcdab6615387b65c22249bef42b088ae11ccff9eee000645e517cd3c1e2665 |
|
| https://github.com/angular/angular/pull/29978/files#diff-6abcdab6615387b65c22249bef42b088ae11ccff9eee000645e517cd3c1e2665 |
| packages/core/test/acceptance/animation_spec.ts | https://github.com/angular/angular/pull/29978/files#diff-b6bc76dc13a505cb4602823af02f9960fa302d895811f69f05d29c13130ac664 |
|
View file
| https://github.com/matsko/angular/blob/ab6b89a12e27b86f5bb0d0818dfc09d4a5d0ce76/packages/core/test/acceptance/animation_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/29978/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |