René's URL Explorer Experiment


Title: fix(core): use shakeable global definitions by filipesilva · Pull Request #29929 · angular/angular · GitHub

Open Graph Title: fix(core): use shakeable global definitions by filipesilva · Pull Request #29929 · angular/angular

X Title: fix(core): use shakeable global definitions by filipesilva · Pull Request #29929 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? The ngDevMode and ngI18nClosureMode are special in that they should be set to false on production builds in order to shake out code associated with it. Angular CLI does this in https://github.com/angular/angular-cli/blob/5fc1f2499cbe57f9a95e4b0dfced130eb3a8046d/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts#L279-L282. But in #28689 the toplevel usage was changed from ngDevMode to global['ngDevMode'] (and the same for ngI18nClosureMode). This indirection prevents the static analysis in Terser from effecting the replacement. What is the new behavior? The variables that should be defined globally are synced between Angular core and CLI. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/29929

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f441a6f-15bd-4014-8a4b-9d70aad5de44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id883A:237673:1AB7B8A:23AC38E:6B015BE0
html-safe-noncec5ea83930a7477aeaaef7442746409edd02d423ca9cd814cd9b4ac99ac9899fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODNBOjIzNzY3MzoxQUI3QjhBOjIzQUMzOEU6NkIwMTVCRTAiLCJ2aXNpdG9yX2lkIjoiMTI5MzczMzk2NzcwNjU0NTEyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf95a1702bb5fe05a71f876507835e8344540e7e06ff26578f13995bc0dba8ba4
hovercard-subject-tagpull_request:270972092
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/29929/files
twitter:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/29929/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29929%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29929%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/29929/files
Reloadhttps://github.com/angular/angular/pull/29929/files
Reloadhttps://github.com/angular/angular/pull/29929/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
filipesilvahttps://github.com/filipesilva
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 5 https://github.com/angular/angular/pull/29929
Commits 2 https://github.com/angular/angular/pull/29929/commits
Checks 0 https://github.com/angular/angular/pull/29929/checks
Files changed https://github.com/angular/angular/pull/29929/files
Please reload this pagehttps://github.com/angular/angular/pull/29929/files
fix(core): use shakeable global definitions https://github.com/angular/angular/pull/29929/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/29929/files
b44260f fix(core): use shakeable global definitions filipesilva Apr 16, 2019 https://github.com/angular/angular/pull/29929/commits/b44260fd1812943f519f59891dbcfe8f4bf92910
c194b32 feat(compiler-cli): export tooling definitions filipesilva Apr 17, 2019 https://github.com/angular/angular/pull/29929/commits/c194b32ad64a892941048bf878ec3e407be462d8
Clear filters https://github.com/angular/angular/pull/29929/files
Please reload this pagehttps://github.com/angular/angular/pull/29929/files
Please reload this pagehttps://github.com/angular/angular/pull/29929/files
.gitignore https://github.com/angular/angular/pull/29929/files#diff-69cab876d08e93d373fe022f3c046e7b22736ec538b07f292ef57bcc895371f1
package.json https://github.com/angular/angular/pull/29929/files#diff-80e12a48069c78dfc951d4e9c8d1a14b7c83e78d66bd3f358e1a889a4d672fe8
test.js https://github.com/angular/angular/pull/29929/files#diff-e6d376774801696093ad90b7561ea6fe9c4a09667d1010907cdb6d4927fbe3c9
index.ts https://github.com/angular/angular/pull/29929/files#diff-6813ed643b1f627b7e01552cea00ded38bc28968904d931aea6cbf2d7ef985d2
tooling.ts https://github.com/angular/angular/pull/29929/files#diff-b997ec540757b0bb3a91ae8dc884dfc97921a1917feebee2b74c8df9cf781c45
ng_dev_mode.ts https://github.com/angular/angular/pull/29929/files#diff-661264449d6819485ca63fc302bc96f2488447254272a222b31b7cef67d9c461
ng_i18n_closure_mode.ts https://github.com/angular/angular/pull/29929/files#diff-f9b412c1ea24c7b4f185548c7fa3ab589ada997435792b9ce2041018e67e90bf
integration/terser/.gitignorehttps://github.com/angular/angular/pull/29929/files#diff-69cab876d08e93d373fe022f3c046e7b22736ec538b07f292ef57bcc895371f1
View file https://github.com/angular/angular/blob/c194b32ad64a892941048bf878ec3e407be462d8/integration/terser/.gitignore
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29929/{{ revealButtonHref }}
integration/terser/package.jsonhttps://github.com/angular/angular/pull/29929/files#diff-80e12a48069c78dfc951d4e9c8d1a14b7c83e78d66bd3f358e1a889a4d672fe8
View file https://github.com/angular/angular/blob/c194b32ad64a892941048bf878ec3e407be462d8/integration/terser/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29929/{{ revealButtonHref }}
integration/terser/test.jshttps://github.com/angular/angular/pull/29929/files#diff-e6d376774801696093ad90b7561ea6fe9c4a09667d1010907cdb6d4927fbe3c9
View file https://github.com/angular/angular/blob/c194b32ad64a892941048bf878ec3e407be462d8/integration/terser/test.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29929/{{ revealButtonHref }}
packages/compiler-cli/index.tshttps://github.com/angular/angular/pull/29929/files#diff-6813ed643b1f627b7e01552cea00ded38bc28968904d931aea6cbf2d7ef985d2
View file https://github.com/angular/angular/blob/c194b32ad64a892941048bf878ec3e407be462d8/packages/compiler-cli/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29929/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29929/files#diff-6813ed643b1f627b7e01552cea00ded38bc28968904d931aea6cbf2d7ef985d2
https://github.com/angular/angular/pull/29929/files#diff-6813ed643b1f627b7e01552cea00ded38bc28968904d931aea6cbf2d7ef985d2
packages/compiler-cli/src/tooling.tshttps://github.com/angular/angular/pull/29929/files#diff-b997ec540757b0bb3a91ae8dc884dfc97921a1917feebee2b74c8df9cf781c45
View file https://github.com/angular/angular/blob/c194b32ad64a892941048bf878ec3e407be462d8/packages/compiler-cli/src/tooling.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29929/{{ revealButtonHref }}
packages/core/src/util/ng_dev_mode.tshttps://github.com/angular/angular/pull/29929/files#diff-661264449d6819485ca63fc302bc96f2488447254272a222b31b7cef67d9c461
View file https://github.com/angular/angular/blob/c194b32ad64a892941048bf878ec3e407be462d8/packages/core/src/util/ng_dev_mode.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29929/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29929/files#diff-661264449d6819485ca63fc302bc96f2488447254272a222b31b7cef67d9c461
packages/core/src/util/ng_i18n_closure_mode.tshttps://github.com/angular/angular/pull/29929/files#diff-f9b412c1ea24c7b4f185548c7fa3ab589ada997435792b9ce2041018e67e90bf
View file https://github.com/angular/angular/blob/c194b32ad64a892941048bf878ec3e407be462d8/packages/core/src/util/ng_i18n_closure_mode.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29929/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29929/files#diff-f9b412c1ea24c7b4f185548c7fa3ab589ada997435792b9ce2041018e67e90bf
https://github.com/angular/angular/pull/29929/files#diff-f9b412c1ea24c7b4f185548c7fa3ab589ada997435792b9ce2041018e67e90bf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.