René's URL Explorer Experiment


Title: perf(ivy): ngcc - exit early if the targeted package has been compiled by petebacondarwin · Pull Request #29740 · angular/angular · GitHub

Open Graph Title: perf(ivy): ngcc - exit early if the targeted package has been compiled by petebacondarwin · Pull Request #29740 · angular/angular

X Title: perf(ivy): ngcc - exit early if the targeted package has been compiled by petebacondarwin · Pull Request #29740 · angular/angular

Description: This is a quick fix for webpack but there are more optimisations to be achieved on the first time run by replacing the TS module resolver for the initial walk of the tree. Previously we always walked the whole folder tree looking for entry-points before we tested whether a target package had been processed already. This could take >10secs! This commit does a quick check of the target package before doing the full walk which brings down the execution time for ngcc in this case dramatically. $ time ./node_modules/.bin/ivy-ngcc -t @angular/common/http/testing Compiling @angular/core : fesm2015 as esm2015 Compiling @angular/core : fesm5 as esm5 Compiling @angular/core : esm2015 as esm2015 Compiling @angular/core : esm5 as esm5 Compiling @angular/common/http : fesm2015 as esm2015 Compiling @angular/common/http : fesm5 as esm5 Compiling @angular/common/http : esm2015 as esm2015 Compiling @angular/common/http : esm5 as esm5 Compiling @angular/common/http/testing : fesm2015 as esm2015 Compiling @angular/common/http/testing : fesm5 as esm5 Compiling @angular/common/http/testing : esm2015 as esm2015 Compiling @angular/common/http/testing : esm5 as esm5 real 0m19.766s user 0m28.533s sys 0m2.262s $ time ./node_modules/.bin/ivy-ngcc -t @angular/common/http/testing The target entry-point has already been processed real 0m0.666s user 0m0.605s sys 0m0.113s

Open Graph Description: This is a quick fix for webpack but there are more optimisations to be achieved on the first time run by replacing the TS module resolver for the initial walk of the tree. Previously we always walk...

X Description: This is a quick fix for webpack but there are more optimisations to be achieved on the first time run by replacing the TS module resolver for the initial walk of the tree. Previously we always walk...

Opengraph URL: https://github.com/angular/angular/pull/29740

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eb1f37f9-cc3d-a88f-9078-2ed80cf9da3e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97EE:3FEC83:510CFA:6ABCFA:6B0179A3
html-safe-nonce10fe669f5de0fbb06ce5c68b1516a42a95aa1913ac04f76b6d21d3f9ecf189c5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0VFOjNGRUM4Mzo1MTBDRkE6NkFCQ0ZBOjZCMDE3OUEzIiwidmlzaXRvcl9pZCI6IjI1MTgzNTM4OTExMjEyNjUwNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac22e32b91fdf99fe04a798e2dd623300d3a5e14937298f1ce9a9879f1e3a7778b
hovercard-subject-tagpull_request:268019047
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/29740/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altThis is a quick fix for webpack but there are more optimisations to be achieved on the first time run by replacing the TS module resolver for the initial walk of the tree. Previously we always walk...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/29740/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29740%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29740%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/29740/files
Reloadhttps://github.com/angular/angular/pull/29740/files
Reloadhttps://github.com/angular/angular/pull/29740/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:FW-1222ahttps://github.com/petebacondarwin/angular/tree/FW-1222a
Conversation 29 https://github.com/angular/angular/pull/29740
Commits 2 https://github.com/angular/angular/pull/29740/commits
Checks 0 https://github.com/angular/angular/pull/29740/checks
Files changed https://github.com/angular/angular/pull/29740/files
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
perf(ivy): ngcc - exit early if the targeted package has been compiled https://github.com/angular/angular/pull/29740/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/29740/files
c718ce9 test(ivy): ngcc - improve and use the `MockLogger` petebacondarwin Apr 6, 2019 https://github.com/angular/angular/pull/29740/commits/c718ce979615387a5cec714c1600b38881a7c074
86c941c perf(ivy): ngcc - exit early if the targeted package has been compiled petebacondarwin Apr 6, 2019 https://github.com/angular/angular/pull/29740/commits/86c941cd1922e6cbfa8bbb2832b16119f653ea40
Clear filters https://github.com/angular/angular/pull/29740/files
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
main.ts https://github.com/angular/angular/pull/29740/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
BUILD.bazel https://github.com/angular/angular/pull/29740/files#diff-cef145ebf342c455bc7f94d8db1370af20debba820f82a70ec619e2405db27f2
BUILD.bazel https://github.com/angular/angular/pull/29740/files#diff-79bbee1392688e8361192835671df1f6d6ca7db780334e198e9686c131a7a1f6
mock_logger.ts https://github.com/angular/angular/pull/29740/files#diff-d2106a4339630e9929a22e6cc1cbf620560c1c0eafbe35f3ecf40a423a1abe17
ngcc_spec.ts https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
packages/compiler-cli/ngcc/src/main.tshttps://github.com/angular/angular/pull/29740/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
View file https://github.com/petebacondarwin/angular/blob/86c941cd1922e6cbfa8bbb2832b16119f653ea40/packages/compiler-cli/ngcc/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29740/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29740/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
https://github.com/angular/angular/pull/29740/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
https://github.com/angular/angular/pull/29740/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
alan-agius4https://github.com/alan-agius4
Apr 6, 2019https://github.com/angular/angular/pull/29740/files#r272802339
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
gkalpakhttps://github.com/gkalpak
Apr 9, 2019https://github.com/angular/angular/pull/29740/files#r273369706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
petebacondarwinhttps://github.com/petebacondarwin
Apr 9, 2019https://github.com/angular/angular/pull/29740/files#r273393636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
gkalpakhttps://github.com/gkalpak
Apr 9, 2019https://github.com/angular/angular/pull/29740/files#r273371149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
petebacondarwinhttps://github.com/petebacondarwin
Apr 9, 2019https://github.com/angular/angular/pull/29740/files#r273393695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
packages/compiler-cli/ngcc/test/BUILD.bazelhttps://github.com/angular/angular/pull/29740/files#diff-cef145ebf342c455bc7f94d8db1370af20debba820f82a70ec619e2405db27f2
View file https://github.com/petebacondarwin/angular/blob/86c941cd1922e6cbfa8bbb2832b16119f653ea40/packages/compiler-cli/ngcc/test/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29740/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29740/files#diff-cef145ebf342c455bc7f94d8db1370af20debba820f82a70ec619e2405db27f2
https://github.com/angular/angular/pull/29740/files#diff-cef145ebf342c455bc7f94d8db1370af20debba820f82a70ec619e2405db27f2
https://github.com/angular/angular/pull/29740/files#diff-cef145ebf342c455bc7f94d8db1370af20debba820f82a70ec619e2405db27f2
https://github.com/angular/angular/pull/29740/files#diff-cef145ebf342c455bc7f94d8db1370af20debba820f82a70ec619e2405db27f2
packages/compiler-cli/ngcc/test/helpers/BUILD.bazelhttps://github.com/angular/angular/pull/29740/files#diff-79bbee1392688e8361192835671df1f6d6ca7db780334e198e9686c131a7a1f6
View file https://github.com/petebacondarwin/angular/blob/86c941cd1922e6cbfa8bbb2832b16119f653ea40/packages/compiler-cli/ngcc/test/helpers/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29740/{{ revealButtonHref }}
packages/compiler-cli/ngcc/test/helpers/mock_logger.tshttps://github.com/angular/angular/pull/29740/files#diff-d2106a4339630e9929a22e6cc1cbf620560c1c0eafbe35f3ecf40a423a1abe17
View file https://github.com/petebacondarwin/angular/blob/86c941cd1922e6cbfa8bbb2832b16119f653ea40/packages/compiler-cli/ngcc/test/helpers/mock_logger.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29740/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29740/files#diff-d2106a4339630e9929a22e6cc1cbf620560c1c0eafbe35f3ecf40a423a1abe17
packages/compiler-cli/ngcc/test/integration/ngcc_spec.tshttps://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
View file https://github.com/petebacondarwin/angular/blob/86c941cd1922e6cbfa8bbb2832b16119f653ea40/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29740/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
alan-agius4https://github.com/alan-agius4
Apr 6, 2019https://github.com/angular/angular/pull/29740/files#r272802291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
petebacondarwinhttps://github.com/petebacondarwin
Apr 6, 2019https://github.com/angular/angular/pull/29740/files#r272807851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
alan-agius4https://github.com/alan-agius4
Apr 6, 2019https://github.com/angular/angular/pull/29740/files#r272808111
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
petebacondarwinhttps://github.com/petebacondarwin
Apr 6, 2019https://github.com/angular/angular/pull/29740/files#r272808192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/angular/angular/blob/master/packages/compiler-cli/ngcc/test/packages/dependency_host_spec.tshttps://github.com/angular/angular/blob/master/packages/compiler-cli/ngcc/test/packages/dependency_host_spec.ts
Please reload this pagehttps://github.com/angular/angular/pull/29740/files
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/29740/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.