René's URL Explorer Experiment


Title: fix(ivy): ensure parent/sub-class components evaluate styling correctly by matsko · Pull Request #29602 · angular/angular · GitHub

Open Graph Title: fix(ivy): ensure parent/sub-class components evaluate styling correctly by matsko · Pull Request #29602 · angular/angular

X Title: fix(ivy): ensure parent/sub-class components evaluate styling correctly by matsko · Pull Request #29602 · angular/angular

Description: The new styling algorithm in angular is designed to evaluate host bindings stylinh priority in order of directive evaluation order. This, however, does not work with respect to parent/sub-class directives because sub-class host bindings are run after the parent host bindings but still have priority. This patch ensures that the host styling bindings for parent and sub-class components/directives are executed with respect to the styling algorithm prioritization. Jira Issue: FW-1132

Open Graph Description: The new styling algorithm in angular is designed to evaluate host bindings stylinh priority in order of directive evaluation order. This, however, does not work with respect to parent/sub-class dir...

X Description: The new styling algorithm in angular is designed to evaluate host bindings stylinh priority in order of directive evaluation order. This, however, does not work with respect to parent/sub-class dir...

Opengraph URL: https://github.com/angular/angular/pull/29602

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8d3753ea-3985-82cc-9115-46f270bc682f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8FA:38C5CF:18C7B97:1F8C707:6B012BD3
html-safe-noncee619c64c12ba45e6693c508064b35eed9b4535f478f774e6b12d8cfab2783784
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEZBOjM4QzVDRjoxOEM3Qjk3OjFGOEM3MDc6NkIwMTJCRDMiLCJ2aXNpdG9yX2lkIjoiNDg1NjkxMjg5NDU4OTIxNzc0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4d1664bd2ae9f56df9d1a34fc2dfd2bc25eb3b354864ff130f344cb8001cbdea
hovercard-subject-tagpull_request:265888166
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/29602/files
twitter:imagehttps://avatars.githubusercontent.com/u/93018?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/93018?s=400&v=4
og:image:altThe new styling algorithm in angular is designed to evaluate host bindings stylinh priority in order of directive evaluation order. This, however, does not work with respect to parent/sub-class dir...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/29602/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29602%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29602%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/29602/files
Reloadhttps://github.com/angular/angular/pull/29602/files
Reloadhttps://github.com/angular/angular/pull/29602/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
matskohttps://github.com/matsko
angular:masterhttps://github.com/angular/angular/tree/master
matsko:styling_queuehttps://github.com/matsko/angular/tree/styling_queue
Conversation 55 https://github.com/angular/angular/pull/29602
Commits 3 https://github.com/angular/angular/pull/29602/commits
Checks 0 https://github.com/angular/angular/pull/29602/checks
Files changed https://github.com/angular/angular/pull/29602/files
Please reload this pagehttps://github.com/angular/angular/pull/29602/files
fix(ivy): ensure parent/sub-class components evaluate styling correctly https://github.com/angular/angular/pull/29602/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/29602/files
998fb09 fix(ivy): ensure parent/sub-class components evaluate styling correctly matsko Apr 2, 2019 https://github.com/angular/angular/pull/29602/commits/998fb096961074bfe50e25ea694d04052d306764
f54c708 fixup! fix(ivy): ensure parent/sub-class components evaluate styling … matsko Apr 5, 2019 https://github.com/angular/angular/pull/29602/commits/f54c70850699d45ac38727ca1654f58047c23960
311817d fixup! fix(ivy): ensure parent/sub-class components evaluate styling … matsko Apr 5, 2019 https://github.com/angular/angular/pull/29602/commits/311817d99673b611cfcbc99f00992c6234e17127
Clear filters https://github.com/angular/angular/pull/29602/files
Please reload this pagehttps://github.com/angular/angular/pull/29602/files
Please reload this pagehttps://github.com/angular/angular/pull/29602/files
_payload-limits.json https://github.com/angular/angular/pull/29602/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
component.ts https://github.com/angular/angular/pull/29602/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d
inherit_definition_feature.ts https://github.com/angular/angular/pull/29602/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5
element.ts https://github.com/angular/angular/pull/29602/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
element_container.ts https://github.com/angular/angular/pull/29602/files#diff-43a330932ce0ea26db564fe30266b9e443dd9d86adb7122aec9879decd45f6ee
shared.ts https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
styling_instructions.ts https://github.com/angular/angular/pull/29602/files#diff-1f892ecff72429f991f18cd8217f4c92bc2e9e76754f9a1e9f3744b830a94c55
styling.ts https://github.com/angular/angular/pull/29602/files#diff-300c60c886c49f4a29a099a79cd9ec930e8d423acfcd1fdc94c476b7070a6fc9
state.ts https://github.com/angular/angular/pull/29602/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
class_and_style_bindings.ts https://github.com/angular/angular/pull/29602/files#diff-c2ac959300ba1b1ce2c60b6dc13587b93b7df9add759712f7a2fc92e19efd184
host_instructions_queue.ts https://github.com/angular/angular/pull/29602/files#diff-3cb2672cd34bdcd36541f07900388cf3211b31a51fde39c30f1c57fcaf65cdb4
shared.ts https://github.com/angular/angular/pull/29602/files#diff-9fa3943565fb279ecb61afe1b21b6d0a1ea2368b05e79c2bdd04e79cfc705a93
util.ts https://github.com/angular/angular/pull/29602/files#diff-162b52b25d96871b421b8135f2fefce188e31d0bed1d4826e2dfb3436a937451
styling_spec.ts https://github.com/angular/angular/pull/29602/files#diff-6b23020f9ab26b6fc509b5425e735ae4b08ca75c826b16b6d81e44999aeef655
bundle.golden_symbols.json https://github.com/angular/angular/pull/29602/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
bundle.golden_symbols.json https://github.com/angular/angular/pull/29602/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd
bundle.golden_symbols.json https://github.com/angular/angular/pull/29602/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
class_and_style_bindings_spec.ts https://github.com/angular/angular/pull/29602/files#diff-b0be2b5170ae05a313b2710feee686b78692aefff148c44284b507d20daeeeb6
angular_material_test_blocklist.js https://github.com/angular/angular/pull/29602/files#diff-286d72af8f1d380079f930e24c5aeb1345654b16ff1a3a95c78575cce4b5c7ba
integration/_payload-limits.jsonhttps://github.com/angular/angular/pull/29602/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
View file https://github.com/matsko/angular/blob/311817d99673b611cfcbc99f00992c6234e17127/integration/_payload-limits.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29602/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29602/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/29602/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
packages/core/src/render3/component.tshttps://github.com/angular/angular/pull/29602/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d
View file https://github.com/matsko/angular/blob/311817d99673b611cfcbc99f00992c6234e17127/packages/core/src/render3/component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29602/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29602/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d
https://github.com/angular/angular/pull/29602/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d
https://github.com/angular/angular/pull/29602/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d
https://github.com/angular/angular/pull/29602/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d
packages/core/src/render3/features/inherit_definition_feature.tshttps://github.com/angular/angular/pull/29602/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5
View file https://github.com/matsko/angular/blob/311817d99673b611cfcbc99f00992c6234e17127/packages/core/src/render3/features/inherit_definition_feature.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29602/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29602/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5
https://github.com/angular/angular/pull/29602/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5
https://github.com/angular/angular/pull/29602/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5
https://github.com/angular/angular/pull/29602/files#diff-8e4e22f9bee5a335af38296d47c7493e02a2c888509320e659a22eba9883b7d5
packages/core/src/render3/instructions/element.tshttps://github.com/angular/angular/pull/29602/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
View file https://github.com/matsko/angular/blob/311817d99673b611cfcbc99f00992c6234e17127/packages/core/src/render3/instructions/element.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29602/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29602/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
https://github.com/angular/angular/pull/29602/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
https://github.com/angular/angular/pull/29602/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
packages/core/src/render3/instructions/element_container.tshttps://github.com/angular/angular/pull/29602/files#diff-43a330932ce0ea26db564fe30266b9e443dd9d86adb7122aec9879decd45f6ee
View file https://github.com/matsko/angular/blob/311817d99673b611cfcbc99f00992c6234e17127/packages/core/src/render3/instructions/element_container.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29602/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29602/files#diff-43a330932ce0ea26db564fe30266b9e443dd9d86adb7122aec9879decd45f6ee
https://github.com/angular/angular/pull/29602/files#diff-43a330932ce0ea26db564fe30266b9e443dd9d86adb7122aec9879decd45f6ee
https://github.com/angular/angular/pull/29602/files#diff-43a330932ce0ea26db564fe30266b9e443dd9d86adb7122aec9879decd45f6ee
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
View file https://github.com/matsko/angular/blob/311817d99673b611cfcbc99f00992c6234e17127/packages/core/src/render3/instructions/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29602/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
Please reload this pagehttps://github.com/angular/angular/pull/29602/files
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/29602/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
Please reload this pagehttps://github.com/angular/angular/pull/29602/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.