René's URL Explorer Experiment


Title: Add integration test for side effects, ban top-level property access by filipesilva · Pull Request #29329 · angular/angular · GitHub

Open Graph Title: Add integration test for side effects, ban top-level property access by filipesilva · Pull Request #29329 · angular/angular

X Title: Add integration test for side effects, ban top-level property access by filipesilva · Pull Request #29329 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/29329

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dc471248-dc0a-1472-c06f-22910e75cddc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91BA:10531B:73049A:928B44:6B011C86
html-safe-nonce15976a71919604ef6ae9568e14750e803a11ccc93160d8d0da31953a5f476d96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUJBOjEwNTMxQjo3MzA0OUE6OTI4QjQ0OjZCMDExQzg2IiwidmlzaXRvcl9pZCI6IjEwNTQwMjk0MjQ4NTAxODEyNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd676cc86b865d2321e19fa45edd80e4154a92c9624a93548d0448484111cd363
hovercard-subject-tagpull_request:261517752
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/29329/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/604791d494aa683d7dee6c61210b65002c77623ac66faa0b496b2506c93e4a2e/angular/angular/pull/29329
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/604791d494aa683d7dee6c61210b65002c77623ac66faa0b496b2506c93e4a2e/angular/angular/pull/29329
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefilipesilva
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/29329#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29329
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29329
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/29329
Reloadhttps://github.com/angular/angular/pull/29329
Reloadhttps://github.com/angular/angular/pull/29329
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
filipesilvahttps://github.com/filipesilva
angular:masterhttps://github.com/angular/angular/tree/master
Conversationhttps://github.com/angular/angular/pull/29329
Commits2 (2)https://github.com/angular/angular/pull/29329/commits
Checkshttps://github.com/angular/angular/pull/29329/checks
Files changedhttps://github.com/angular/angular/pull/29329/files
Add integration test for side effects, ban top-level property accesshttps://github.com/angular/angular/pull/29329#top
filipesilvahttps://github.com/filipesilva
angular:masterhttps://github.com/angular/angular/tree/master
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Mar 15, 2019https://github.com/angular/angular/pull/29329#issue-421476700
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
https://github.com/filipesilva/check-side-effectshttps://github.com/filipesilva/check-side-effects
#30239https://github.com/angular/angular/pull/30239
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
March 15, 2019 11:35https://github.com/angular/angular/pull/29329#event-2206194806
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 15, 2019https://github.com/angular/angular/pull/29329#event-2206194863
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
alexeaglehttps://github.com/alexeagle
March 15, 2019 11:35https://github.com/angular/angular/pull/29329#event-2206195077
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Mar 15, 2019https://github.com/angular/angular/pull/29329#event-2206577691
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Mar 15, 2019https://github.com/angular/angular/pull/29329#event-2206970196
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Mar 15, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-215133091
View reviewed changes https://github.com/angular/angular/pull/29329/files
integration/side-effects/snapshots/core/esm2015.jshttps://github.com/angular/angular/pull/29329/files#diff-8cc6d80710a22e2abf86ca7d5a93481cc0c77caaf6950934a78f011fc5c9f2dc
filipesilvahttps://github.com/filipesilva
Mar 15, 2019https://github.com/angular/angular/pull/29329#discussion_r266057035
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
alfaprojecthttps://github.com/alfaproject
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282018448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Mar 15, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-215134671
View reviewed changes https://github.com/angular/angular/pull/29329/files
integration/side-effects/snapshots/animations-browser/esm5.jshttps://github.com/angular/angular/pull/29329/files#diff-68ef79274bd9227cfc183e512a081720e3eea884b75e7c1c305ecbdb92b7d418
filipesilvahttps://github.com/filipesilva
Mar 15, 2019https://github.com/angular/angular/pull/29329#discussion_r266058268
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Mar 19, 2019https://github.com/angular/angular/pull/29329#event-2213029682
https://github.com/mhevery
mheveryhttps://github.com/mhevery
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
Mar 19, 2019https://github.com/angular/angular/pull/29329#event-2215182960
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Mar 19, 2019https://github.com/angular/angular/pull/29329#event-2215182979
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Apr 26, 2019https://github.com/angular/angular/pull/29329#event-2301802078
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-234974765
View reviewed changes https://github.com/angular/angular/pull/29329/files
integration/side-effects/snapshots/core/esm5.jshttps://github.com/angular/angular/pull/29329/files#diff-bb9381bc1244ef01cea35a3a17d8ffe8ddd661dc1a006f1fb3f97a4a43bc4cb2
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282002706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-234975487
View reviewed changes https://github.com/angular/angular/pull/29329/files
integration/side-effects/snapshots/elements/esm5.jshttps://github.com/angular/angular/pull/29329/files#diff-bcc6b87b91a403e81d5d34d48cfefa4a3a44ef3bab397725b64aeaaa9cb2ce31
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282003210
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
IgorMinarhttps://github.com/IgorMinar
May 14, 2019https://github.com/angular/angular/pull/29329#discussion_r284014449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
IgorMinarhttps://github.com/IgorMinar
May 8, 2019 10:18https://github.com/angular/angular/pull/29329#event-2326805302
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 8, 2019https://github.com/angular/angular/pull/29329#issuecomment-490499920
https://pr29329-d25b540.ngbuilds.io/https://pr29329-d25b540.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#event-2327397510
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-235084977
View reviewed changes https://github.com/angular/angular/pull/29329/files
integration/side-effects/snapshots/animations-browser/esm2015.jshttps://github.com/angular/angular/pull/29329/files#diff-7dae43924de0bed73bbd70762e7554044a534e498945de935e79bf831a70af2d
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282088422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-235085690
View reviewed changes https://github.com/angular/angular/pull/29329/files
integration/side-effects/snapshots/elements/esm2015.jshttps://github.com/angular/angular/pull/29329/files#diff-da04b32f39170418757758bcd73f273c540f5a6dc7fcddf57e55dcf91ebadef7
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282088992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-235085749
View reviewed changes https://github.com/angular/angular/pull/29329/files
integration/side-effects/snapshots/platform-browser/esm2015.jshttps://github.com/angular/angular/pull/29329/files#diff-fb21b9c79ecc0622f008854ad3a1fd0c7ad8c056295db3753cd2eed325541b59
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282089040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-235086495
View reviewed changes https://github.com/angular/angular/pull/29329/files
packages/core/test/bundling/cyclic_import/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/29329/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282089614
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 8, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-235086949
View reviewed changes https://github.com/angular/angular/pull/29329/files
packages/forms/src/directives/ng_model.tshttps://github.com/angular/angular/pull/29329/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
filipesilvahttps://github.com/filipesilva
May 8, 2019https://github.com/angular/angular/pull/29329#discussion_r282089949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 8, 2019https://github.com/angular/angular/pull/29329#issuecomment-490505828
https://pr29329-27a6287.ngbuilds.io/https://pr29329-27a6287.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 8, 2019https://github.com/angular/angular/pull/29329#issuecomment-490510196
https://pr29329-79d4519.ngbuilds.io/https://pr29329-79d4519.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 13, 2019https://github.com/angular/angular/pull/29329#issuecomment-491764143
https://pr29329-f39e136.ngbuilds.io/https://pr29329-f39e136.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/alfaproject
alfaprojecthttps://github.com/alfaproject
May 13, 2019https://github.com/angular/angular/pull/29329#issuecomment-491765261
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 13, 2019https://github.com/angular/angular/pull/29329#issuecomment-491772279
https://pr29329-9612baa.ngbuilds.io/https://pr29329-9612baa.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 13, 2019https://github.com/angular/angular/pull/29329#issuecomment-491794459
@alfaprojecthttps://github.com/alfaproject
prefix functionhttps://github.com/angular/angular-cli/tree/master/packages/angular_devkit/build_optimizer#prefix-functions
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/trotyl
trotylhttps://github.com/trotyl
May 13, 2019https://github.com/angular/angular/pull/29329#issuecomment-491822289
@filipesilvahttps://github.com/filipesilva
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 13, 2019https://github.com/angular/angular/pull/29329#issuecomment-491833283
@trotylhttps://github.com/trotyl
this fieldhttps://github.com/angular/angular/blob/cb6dea473f7abaf1925ea34a3dfdbbfe36465689/packages/core/package.json#L30
angular/angular-cli#14187https://github.com/angular/angular-cli/pull/14187
ReactiveX/rxjs#4769https://github.com/ReactiveX/rxjs/pull/4769
angular/angular-cli#14187https://github.com/angular/angular-cli/pull/14187
this specific Ivy testhttps://github.com/angular/angular/tree/master/integration/cli-hello-world-ivy-minimal
angular/angular-cli#14316https://github.com/angular/angular-cli/issues/14316
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
May 14, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-237520173
View reviewed changes https://github.com/angular/angular/pull/29329/files
IgorMinarhttps://github.com/IgorMinar
https://github.com/angular/angular/pull/29329#pullrequestreview-237520173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
May 14, 2019https://github.com/angular/angular/pull/29329#issuecomment-492424572
@filipesilvahttps://github.com/filipesilva
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/alxhub
alxhubhttps://github.com/alxhub
May 14, 2019https://github.com/angular/angular/pull/29329#issuecomment-492445062
@filipesilvahttps://github.com/filipesilva
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 14, 2019https://github.com/angular/angular/pull/29329#issuecomment-492447034
https://pr29329-c916f81.ngbuilds.io/https://pr29329-c916f81.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/29329
filipesilvahttps://github.com/filipesilva
May 14, 2019 16:54https://github.com/angular/angular/pull/29329#commits-pushed-ed74f92
https://github.com/filipesilva
https://github.com/alxhub
test: add integration test for side effectshttps://github.com/angular/angular/pull/29329/commits/ed74f92e2ca42f37530c8bb2ac3790877e83000b
ed74f92https://github.com/angular/angular/pull/29329/commits/ed74f92e2ca42f37530c8bb2ac3790877e83000b
https://github.com/filipesilva
https://github.com/alxhub
refactor: remove toplevel property accesseshttps://github.com/angular/angular/pull/29329/commits/e55db3c5dd444f5351c4a057c8fb9e8a6ae17c24
e55db3chttps://github.com/angular/angular/pull/29329/commits/e55db3c5dd444f5351c4a057c8fb9e8a6ae17c24
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 15, 2019https://github.com/angular/angular/pull/29329#issuecomment-492454157
e55db3chttps://github.com/angular/angular/commit/e55db3c5dd444f5351c4a057c8fb9e8a6ae17c24
https://pr29329-e55db3c.ngbuilds.io/https://pr29329-e55db3c.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
May 15, 2019 https://github.com/angular/angular/pull/29329#pullrequestreview-237580116
View reviewed changes https://github.com/angular/angular/pull/29329/files/e55db3c5dd444f5351c4a057c8fb9e8a6ae17c24
integration/_payload-limits.jsonhttps://github.com/angular/angular/pull/29329/files/e55db3c5dd444f5351c4a057c8fb9e8a6ae17c24#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
IgorMinarhttps://github.com/IgorMinar
May 15, 2019https://github.com/angular/angular/pull/29329#discussion_r284064040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@filipesilvahttps://github.com/filipesilva
Please reload this pagehttps://github.com/angular/angular/pull/29329
filipesilvahttps://github.com/filipesilva
May 15, 2019https://github.com/angular/angular/pull/29329#discussion_r284221619
Please reload this pagehttps://github.com/angular/angular/pull/29329
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/29329
filipesilvahttps://github.com/filipesilva
May 15, 2019https://github.com/angular/angular/pull/29329#discussion_r284244799
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/filipesilva/compare-toplevel-prop-iife/commit/3f116e913cb3d91b3cd4b83685f4393b08cf3e6d#diff-7a9076d6d94e62c13d641aa71f19ae8eL4109https://github.com/filipesilva/compare-toplevel-prop-iife/commit/3f116e913cb3d91b3cd4b83685f4393b08cf3e6d#diff-7a9076d6d94e62c13d641aa71f19ae8eL4109
https://github.com/filipesilva/compare-toplevel-prop-iife/commit/3f116e913cb3d91b3cd4b83685f4393b08cf3e6d#diff-7a9076d6d94e62c13d641aa71f19ae8eL1558https://github.com/filipesilva/compare-toplevel-prop-iife/commit/3f116e913cb3d91b3cd4b83685f4393b08cf3e6d#diff-7a9076d6d94e62c13d641aa71f19ae8eL1558
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
May 15, 2019https://github.com/angular/angular/pull/29329#issuecomment-492476541
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
May 15, 2019https://github.com/angular/angular/pull/29329#issuecomment-492491999
https://test.corp.google.com/ui#id=OCL:248239756:BASE:248259306:1557888153442:60052echttps://test.corp.google.com/ui#id=OCL:248239756:BASE:248259306:1557888153442:60052ec
Please reload this pagehttps://github.com/angular/angular/pull/29329
Patch branch version of #29329 #30470 https://github.com/angular/angular/pull/30470
Tree-shaking rxjs 6 produces left-over non-exported functions rollup/rollup#2415 https://github.com/rollup/rollup/issues/2415
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
May 16, 2019https://github.com/angular/angular/pull/29329#event-2347137416
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
May 16, 2019https://github.com/angular/angular/pull/29329#event-2347137478
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
May 16, 2019https://github.com/angular/angular/pull/29329#issuecomment-493154181
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 16, 2019 https://github.com/angular/angular/pull/29329#ref-issue-438934773
Investigate why pure_getters had to be re-added angular/angular-cli#14316 https://github.com/angular/angular-cli/issues/14316
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
May 16, 2019https://github.com/angular/angular/pull/29329#event-2347427088
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
739e5a4https://github.com/angular/angular/commit/739e5a4f53bcdf488b89b69e324e12dea6cdf19a
May 16, 2019https://github.com/angular/angular/pull/29329#event-2347432823
BioPhotonhttps://github.com/BioPhoton
May 21, 2019 https://github.com/angular/angular/pull/29329#ref-commit-c493b58
https://github.com/filipesilva
https://github.com/BioPhoton
test: add integration test for side effects (https://github.com/BioPhoton/angular/commit/c493b58cd0532c8fe8081369a0878c62eb9a4942
angular#29329https://github.com/angular/angular/pull/29329
)https://github.com/BioPhoton/angular/commit/c493b58cd0532c8fe8081369a0878c62eb9a4942
c493b58https://github.com/BioPhoton/angular/commit/c493b58cd0532c8fe8081369a0878c62eb9a4942
angular#29329https://github.com/angular/angular/pull/29329
BioPhotonhttps://github.com/BioPhoton
May 21, 2019 https://github.com/angular/angular/pull/29329#ref-commit-df9ef47
https://github.com/filipesilva
https://github.com/BioPhoton
refactor: remove toplevel property accesses (https://github.com/BioPhoton/angular/commit/df9ef47ccd44f0cfde87a3a2e14962bef54bf7a9
angular#29329https://github.com/angular/angular/pull/29329
)https://github.com/BioPhoton/angular/commit/df9ef47ccd44f0cfde87a3a2e14962bef54bf7a9
df9ef47https://github.com/BioPhoton/angular/commit/df9ef47ccd44f0cfde87a3a2e14962bef54bf7a9
angular#29329https://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 27, 2019 https://github.com/angular/angular/pull/29329#ref-issue-222163344
Explore CLJS require from node_modules anmonteiro/lumo#130 https://github.com/anmonteiro/lumo/issues/130
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/29329#issuecomment-531528539
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 15, 2019https://github.com/angular/angular/pull/29329#event-2634425207
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29329
https://github.com/alexeagle
alexeagle https://github.com/alexeagle
https://github.com/alfaproject
alfaproject https://github.com/alfaproject
https://github.com/angular/angular/pull/29329/files/557ca5c3c0ab7b6e8ffe18afeaff2ed778299240
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/29329/files/e55db3c5dd444f5351c4a057c8fb9e8a6ae17c24
Please reload this pagehttps://github.com/angular/angular/pull/29329
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/29329
https://github.com/filipesilva
https://github.com/mary-poppins
https://github.com/alfaproject
https://github.com/trotyl
https://github.com/IgorMinar
https://github.com/alxhub
https://github.com/mhevery
https://github.com/jasonaden
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.