René's URL Explorer Experiment


Title: refactor(ivy): correctly type class declarations by gkalpak · Pull Request #29209 · angular/angular · GitHub

Open Graph Title: refactor(ivy): correctly type class declarations by gkalpak · Pull Request #29209 · angular/angular

X Title: refactor(ivy): correctly type class declarations by gkalpak · Pull Request #29209 · angular/angular

Description: Previously, several ngtsc and ngcc APIs dealing with class declaration nodes used inconsistent types. For example, some methods of the DecoratorHandler interface expected a ts.Declaration argument, but actual DecoratorHandler implementations specified a stricter ts.ClassDeclaration type. As a result, the stricter methods would operate under the incorrect assumption that their arguments were of type ts.ClassDeclaration, while the actual arguments might be of different types (e.g. ngcc would call them with ts.FunctionDeclaration or ts.VariableDeclaration arguments, when compiling ES5 code). Additionally, since we need those class declarations to be referenced in other parts of the program, ngtsc/ngcc had to either repeatedly check for ts.isIdentifier(node.name) or assume there was a name identifier and use node.name!. While this assumption happens to be true in the current implementation, working around type-checking is error-prone (e.g. the assumption might stop being true in the future). This commit fixes this by introducing a new type to be used for such class declarations (ts.Declaration & {name: ts.Identifier}) and using it consistently throughput the code. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information Jira issue: FW-1151

Open Graph Description: Previously, several ngtsc and ngcc APIs dealing with class declaration nodes used inconsistent types. For example, some methods of the DecoratorHandler interface expected a ts.Declaration argument,...

X Description: Previously, several ngtsc and ngcc APIs dealing with class declaration nodes used inconsistent types. For example, some methods of the DecoratorHandler interface expected a ts.Declaration argument,...

Opengraph URL: https://github.com/angular/angular/pull/29209

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:903b70c5-0643-bc93-fc42-a831d3585370
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDACE:34DB8F:19DD6BF:22894A9:6B015BD9
html-safe-nonceba2d1081b86fa7cc961bb0d704e72a5738dcf4a59bb1b7b1a49e48e1dddc21ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUNFOjM0REI4RjoxOURENkJGOjIyODk0QTk6NkIwMTVCRDkiLCJ2aXNpdG9yX2lkIjoiNjA0NzM2MjYxMjI0Nzc0NzU0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7f34eb0a9f4c709ade615a7e4e951bd60651e2cc0c9b8d2fac2692c7930c3da2
hovercard-subject-tagpull_request:259771254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/29209/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPreviously, several ngtsc and ngcc APIs dealing with class declaration nodes used inconsistent types. For example, some methods of the DecoratorHandler interface expected a ts.Declaration argument,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/29209/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29209%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29209%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/29209/files
Reloadhttps://github.com/angular/angular/pull/29209/files
Reloadhttps://github.com/angular/angular/pull/29209/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ivy-ngcc-es5-classhttps://github.com/gkalpak/angular/tree/fix-ivy-ngcc-es5-class
Conversation 69 https://github.com/angular/angular/pull/29209
Commits 11 https://github.com/angular/angular/pull/29209/commits
Checks 0 https://github.com/angular/angular/pull/29209/checks
Files changed https://github.com/angular/angular/pull/29209/files
Please reload this pagehttps://github.com/angular/angular/pull/29209/files
refactor(ivy): correctly type class declarations https://github.com/angular/angular/pull/29209/files#top
Show all changes 11 commits https://github.com/angular/angular/pull/29209/files
34ad3fc refactor(ivy): remove unused code from `TypeCheckContext` gkalpak Mar 21, 2019 https://github.com/angular/angular/pull/29209/commits/34ad3fc965d94900122a958fd67ba3aaad6b82ad
c077d35 refactor(ivy): implement `DtsModuleScopeResolver` from `MetadataDtsMo… gkalpak Mar 21, 2019 https://github.com/angular/angular/pull/29209/commits/c077d35d064065a69e6a6fbca1c86401e9223f33
a666cdc refactor(ivy): correctly type class declarations in `ngtsc`/`ngcc` gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/a666cdc63a08709bc0ec0179f5399c49df80a819
bb9b62d fixup! refactor(ivy): correctly type class declarations in `ngtsc`/`n… gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/bb9b62dfb0ab14708d11fb0f856cab27c4b451a6
acd8af8 refactor(ivy): use `ClassDeclaration` in more `ReflectionHost` methods gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/acd8af834bfe8b2386e99a18f18d33d2863ee0a2
bbe935a fixup! refactor(ivy): use `ClassDeclaration` in more `ReflectionHost`… gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/bbe935a749e0968bba7c32e0f912a34644ea7a20
4c037b8 fix(ivy): handle class declarations consistently in ES5 code gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/4c037b8f789a212e432d3bde0b9d44103e43b723
fbdf8ce fixup! fix(ivy): handle class declarations consistently in ES5 code gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/fbdf8ce8e775577ad11620f7bafc0c2715a8ec75
ab11d5e fixup! refactor(ivy): correctly type class declarations in `ngtsc`/`n… gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/ab11d5e79192505da7fa88a625fa774680755755
02c2fa4 fixup! refactor(ivy): use `ClassDeclaration` in more `ReflectionHost`… gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/02c2fa47901de6dc2a4416e61e230955e6faed87
7ba59e1 fixup! fix(ivy): handle class declarations consistently in ES5 code gkalpak Mar 20, 2019 https://github.com/angular/angular/pull/29209/commits/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6
Clear filters https://github.com/angular/angular/pull/29209/files
Please reload this pagehttps://github.com/angular/angular/pull/29209/files
Please reload this pagehttps://github.com/angular/angular/pull/29209/files
decorated_class.ts https://github.com/angular/angular/pull/29209/files#diff-0717e2921b5ca008dfdfb1301fe6567d65416cc4c2549549f3a36139f74ba53c
esm2015_host.ts https://github.com/angular/angular/pull/29209/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
esm5_host.ts https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
ngcc_host.ts https://github.com/angular/angular/pull/29209/files#diff-c9e7c98be9caf7fbd312601bef38adf7b174855009f72fd33dee8def302d55e7
esm5_renderer.ts https://github.com/angular/angular/pull/29209/files#diff-3fb329446e0834f5d17af16afed39d7c08775a91b8394e8229c0694f350f396d
renderer.ts https://github.com/angular/angular/pull/29209/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
esm2015_host_import_helper_spec.ts https://github.com/angular/angular/pull/29209/files#diff-d8a2c53dd69dec92c391e47679bf6027a6d4c308c4c4c0caa6bd1c66b46128fc
esm2015_host_spec.ts https://github.com/angular/angular/pull/29209/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
esm5_host_import_helper_spec.ts https://github.com/angular/angular/pull/29209/files#diff-d1791039d9dde9827fa21bf2463f6bd8ddde9b19c4d54ecd6ca0fda067823ff1
esm5_host_spec.ts https://github.com/angular/angular/pull/29209/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6
esm5_renderer_spec.ts https://github.com/angular/angular/pull/29209/files#diff-196cb79d00553baa2e2655af2262c44e9098e54b6173502489f1b254b4218f82
base_def.ts https://github.com/angular/angular/pull/29209/files#diff-884dfa056fef132832af9e8a5b4efba0d80519013b886576ea7c99810a9cdeda
component.ts https://github.com/angular/angular/pull/29209/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
directive.ts https://github.com/angular/angular/pull/29209/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
injectable.ts https://github.com/angular/angular/pull/29209/files#diff-ff6958d9fff47e0156915cac8202d78930adcf33d353c70e60b230981cc36f20
metadata.ts https://github.com/angular/angular/pull/29209/files#diff-b229c711171ac9b71b9ab5f833760fe8d67187bd789bbda6575debebd28b13c4
ng_module.ts https://github.com/angular/angular/pull/29209/files#diff-8b9c0d2955b2182ee8ebd745a4f737de1207244d83ef08bdc00f9c8d9139c2a8
pipe.ts https://github.com/angular/angular/pull/29209/files#diff-cca09745361bb2d9844269a54bb34dfc82c87e86ceac4f72ffe7b740634b2437
util.ts https://github.com/angular/angular/pull/29209/files#diff-b408a07768aaddc7b73f38b26fb08aaeab74710c98a446ea03942fd875638e43
BUILD.bazel https://github.com/angular/angular/pull/29209/files#diff-63907f9c140e41e142829df3512c7e8ca49063cceeffc1b60e016dd8c24be253
component_spec.ts https://github.com/angular/angular/pull/29209/files#diff-fd4e70e4fdb43e6edb1c1c425c87890ffb8820721e028f09d355bb849591fb82
directive_spec.ts https://github.com/angular/angular/pull/29209/files#diff-aa248188703ff67bf44865bd3147926e1c2e7767bbb2b79d07b3dda38066a626
ng_module_spec.ts https://github.com/angular/angular/pull/29209/files#diff-63c383116b776f0f67ed08062ae7176aae3fa0ab90e19b51410c6bcdd8d14f77
BUILD.bazel https://github.com/angular/angular/pull/29209/files#diff-0356084fedfbf869aad05d9243c24dc5e7084d27ebc71f3bc4539853e01ca0e1
alias.ts https://github.com/angular/angular/pull/29209/files#diff-e31bdef0c760b2172713afc9982200d45b5da13eb6a1d39c611ee9f3a834d90e
index.ts https://github.com/angular/angular/pull/29209/files#diff-628722f536636c07ba84525c5d71200e4620c05b9640ae1212477fba4a89df64
host.ts https://github.com/angular/angular/pull/29209/files#diff-e7f1562798d174a4ababbfbf02ea86bd4c83efa846959878d56db221cc3dd389
typescript.ts https://github.com/angular/angular/pull/29209/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
util.ts https://github.com/angular/angular/pull/29209/files#diff-ad4965cce0f9c9f39d9b3edea0d0bf77001ea9e21c4ec0c2aa94c05a36a54a4c
ts_host_spec.ts https://github.com/angular/angular/pull/29209/files#diff-10d58e544cc23fe91b826fb10f0bf4ef335a1cb9d51360fadeec9e1688a5082a
api.ts https://github.com/angular/angular/pull/29209/files#diff-70a7c3373333d8a807abb7351d046a7f784a25d2bb5da5941414c7f702fa8d02
dependency.ts https://github.com/angular/angular/pull/29209/files#diff-aef97a276e2e1f812553387b578476e53502ad966e1c5eaa8b0e035bc7379984
local.ts https://github.com/angular/angular/pull/29209/files#diff-15a453d410fafb867ef7c28b8f39a18c22517b364186a441077131ede3ee18a8
util.ts https://github.com/angular/angular/pull/29209/files#diff-e0b0e58d402419ca61ab9fc895e76d024fcbb2cb941d0850a01f7d9276f00f45
dependency_spec.ts https://github.com/angular/angular/pull/29209/files#diff-d7b5cb0e6c4d61080f0414c2f4f04d38bfd252a7f40e2884077642b1f264ff23
local_spec.ts https://github.com/angular/angular/pull/29209/files#diff-313008e5895a974fa5e7b2bf88762953c2c426666b49ef533c8052070b1f2cdf
api.ts https://github.com/angular/angular/pull/29209/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8
compilation.ts https://github.com/angular/angular/pull/29209/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
tsc_plugin.ts https://github.com/angular/angular/pull/29209/files#diff-81e4948bf660dd64d4b4fc7c2e1c8561f9f46ed94039b3a44b78308cab807d60
BUILD.bazel https://github.com/angular/angular/pull/29209/files#diff-a95abd0c81443e33fe14e7e01742342084c87f089860d7c0fd525520947362b9
api.ts https://github.com/angular/angular/pull/29209/files#diff-9eb22a14bc945542a06c095624ae9a9a2d4470e83888018cbbd05b956d82df81
context.ts https://github.com/angular/angular/pull/29209/files#diff-d81d17371a306c9d905b85553a07ca31e0fea4aee0fd8dcd2f3779cdeb4698dc
type_check_block.ts https://github.com/angular/angular/pull/29209/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
type_constructor.ts https://github.com/angular/angular/pull/29209/files#diff-cedaec82510b21783211df4df690092a3ec37d90cea435b8486ffa9dd9e4d8d6
BUILD.bazel https://github.com/angular/angular/pull/29209/files#diff-cdeb3b36b0951871f4b294c46104b55906b2b8fa75f98656ea6ecbf594cfca72
type_constructor_spec.ts https://github.com/angular/angular/pull/29209/files#diff-87486a6bd71bea062b7ff897212aba4fd9b1a0630a85311b7949b2b3d52d2a09
packages/compiler-cli/ngcc/src/host/decorated_class.tshttps://github.com/angular/angular/pull/29209/files#diff-0717e2921b5ca008dfdfb1301fe6567d65416cc4c2549549f3a36139f74ba53c
View file https://github.com/gkalpak/angular/blob/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6/packages/compiler-cli/ngcc/src/host/decorated_class.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29209/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29209/files#diff-0717e2921b5ca008dfdfb1301fe6567d65416cc4c2549549f3a36139f74ba53c
https://github.com/angular/angular/pull/29209/files#diff-0717e2921b5ca008dfdfb1301fe6567d65416cc4c2549549f3a36139f74ba53c
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/29209/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
View file https://github.com/gkalpak/angular/blob/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6/packages/compiler-cli/ngcc/src/host/esm2015_host.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angular/pull/29209/files
packages/compiler-cli/ngcc/src/host/esm5_host.tshttps://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
View file https://github.com/gkalpak/angular/blob/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6/packages/compiler-cli/ngcc/src/host/esm5_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29209/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/29209/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
packages/compiler-cli/ngcc/src/host/ngcc_host.tshttps://github.com/angular/angular/pull/29209/files#diff-c9e7c98be9caf7fbd312601bef38adf7b174855009f72fd33dee8def302d55e7
View file https://github.com/gkalpak/angular/blob/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6/packages/compiler-cli/ngcc/src/host/ngcc_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29209/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29209/files#diff-c9e7c98be9caf7fbd312601bef38adf7b174855009f72fd33dee8def302d55e7
https://github.com/angular/angular/pull/29209/files#diff-c9e7c98be9caf7fbd312601bef38adf7b174855009f72fd33dee8def302d55e7
https://github.com/angular/angular/pull/29209/files#diff-c9e7c98be9caf7fbd312601bef38adf7b174855009f72fd33dee8def302d55e7
https://github.com/angular/angular/pull/29209/files#diff-c9e7c98be9caf7fbd312601bef38adf7b174855009f72fd33dee8def302d55e7
packages/compiler-cli/ngcc/src/rendering/esm5_renderer.tshttps://github.com/angular/angular/pull/29209/files#diff-3fb329446e0834f5d17af16afed39d7c08775a91b8394e8229c0694f350f396d
View file https://github.com/gkalpak/angular/blob/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6/packages/compiler-cli/ngcc/src/rendering/esm5_renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29209/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29209/files#diff-3fb329446e0834f5d17af16afed39d7c08775a91b8394e8229c0694f350f396d
https://github.com/angular/angular/pull/29209/files#diff-3fb329446e0834f5d17af16afed39d7c08775a91b8394e8229c0694f350f396d
https://github.com/angular/angular/pull/29209/files#diff-3fb329446e0834f5d17af16afed39d7c08775a91b8394e8229c0694f350f396d
Please reload this pagehttps://github.com/angular/angular/pull/29209/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.