| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:97982867-264e-7ec4-17dc-2e65153bd070 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF1E:2C4BED:11D7DB9:16BA387:6B011C57 |
| html-safe-nonce | 6b6935c5ed044131a9aea36dfcaaba744cc5e3f1710b4b38c0e1849712fd1c91 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjFFOjJDNEJFRDoxMUQ3REI5OjE2QkEzODc6NkIwMTFDNTciLCJ2aXNpdG9yX2lkIjoiODYwNDI0ODU3MzAzNjUzNDg3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4c59ea92cefe76087b0c46961beb07b52cd295c2452d7694d01e94810297500a |
| hovercard-subject-tag | pull_request:259771254 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/29209/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8f968266543f3b3c011101e6122dcc1132a8fc4c7887c7b85ad0332060eee5cd/angular/angular/pull/29209 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8f968266543f3b3c011101e6122dcc1132a8fc4c7887c7b85ad0332060eee5cd/angular/angular/pull/29209 |
| og:image:alt | Previously, several ngtsc and ngcc APIs dealing with class declaration nodes used inconsistent types. For example, some methods of the DecoratorHandler interface expected a ts.Declaration argument,... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/29209#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29209 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29209 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/29209 |
| Reload | https://github.com/angular/angular/pull/29209 |
| Reload | https://github.com/angular/angular/pull/29209 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ivy-ngcc-es5-class | https://github.com/gkalpak/angular/tree/fix-ivy-ngcc-es5-class |
| Conversation | https://github.com/angular/angular/pull/29209 |
| Commits11 (11) | https://github.com/angular/angular/pull/29209/commits |
| Checks | https://github.com/angular/angular/pull/29209/checks |
| Files changed | https://github.com/angular/angular/pull/29209/files |
| refactor(ivy): correctly type class declarations | https://github.com/angular/angular/pull/29209#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ivy-ngcc-es5-class | https://github.com/gkalpak/angular/tree/fix-ivy-ngcc-es5-class |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 10, 2019 | https://github.com/angular/angular/pull/29209#issue-419204194 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| FW-1151 | https://angular-team.atlassian.net/browse/FW-1151 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 10, 2019 | https://github.com/angular/angular/pull/29209#event-2192382605 |
| https://github.com/alfaproject |
| alfaproject | https://github.com/alfaproject |
|
Mar 10, 2019
| https://github.com/angular/angular/pull/29209#pullrequestreview-212610825 |
|
View reviewed changes
| https://github.com/angular/angular/pull/29209/files |
| packages/compiler-cli/src/ngtsc/scope/src/util.ts | https://github.com/angular/angular/pull/29209/files#diff-e0b0e58d402419ca61ab9fc895e76d024fcbb2cb941d0850a01f7d9276f00f45 |
| alfaproject | https://github.com/alfaproject |
| Mar 10, 2019 | https://github.com/angular/angular/pull/29209#discussion_r264047307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| gkalpak | https://github.com/gkalpak |
| Mar 10, 2019 | https://github.com/angular/angular/pull/29209#discussion_r264060788 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/0d88d102a0c47fd2383ddb028f21c26c5dde1526..dc1980843dfdd92f7e35dea31977bda7bf259073 |
| 0d88d10 | https://github.com/angular/angular/commit/0d88d102a0c47fd2383ddb028f21c26c5dde1526 |
| dc19808 | https://github.com/angular/angular/commit/dc1980843dfdd92f7e35dea31977bda7bf259073 |
|
Compare
| https://github.com/angular/angular/compare/0d88d102a0c47fd2383ddb028f21c26c5dde1526..dc1980843dfdd92f7e35dea31977bda7bf259073 |
| March 11, 2019 07:34 | https://github.com/angular/angular/pull/29209#event-2193045610 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
comp: ivy
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22 |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29209#event-2195701615 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29209#event-2195701639 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Mar 12, 2019
| https://github.com/angular/angular/pull/29209#pullrequestreview-213244117 |
|
View reviewed changes
| https://github.com/angular/angular/pull/29209/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/29209#pullrequestreview-213244117 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| packages/compiler-cli/src/ngcc/src/host/esm2015_host.ts | https://github.com/angular/angular/pull/29209/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| packages/compiler-cli/src/ngcc/src/host/esm2015_host.ts | https://github.com/angular/angular/pull/29209/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
| petebacondarwin | https://github.com/petebacondarwin |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29209#discussion_r264563621 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| gkalpak | https://github.com/gkalpak |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29209#discussion_r264628404 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| packages/compiler-cli/src/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/29209/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| packages/compiler-cli/src/ngcc/src/rendering/esm5_renderer.ts | https://github.com/angular/angular/pull/29209/files#diff-56f031797425eacffe23009eb9d9a93e056845fa48b4eda0cd84ba7b90987286 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| packages/compiler-cli/src/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/29209/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
| petebacondarwin | https://github.com/petebacondarwin |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29209#discussion_r264570810 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| gkalpak | https://github.com/gkalpak |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29209#discussion_r264629945 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/dc1980843dfdd92f7e35dea31977bda7bf259073..5fba061e2785fcc71e7efc123343cf33edfab20f |
| dc19808 | https://github.com/angular/angular/commit/dc1980843dfdd92f7e35dea31977bda7bf259073 |
| 5fba061 | https://github.com/angular/angular/commit/5fba061e2785fcc71e7efc123343cf33edfab20f |
|
Compare
| https://github.com/angular/angular/compare/dc1980843dfdd92f7e35dea31977bda7bf259073..5fba061e2785fcc71e7efc123343cf33edfab20f |
| March 12, 2019 09:19 | https://github.com/angular/angular/pull/29209#event-2196467404 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 12, 2019
| https://github.com/angular/angular/pull/29209#ref-issue-417350314 |
|
[Ivy] App crashes at runtime with NgRx 7.x
#29114
| https://github.com/angular/angular/issues/29114 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/a4721f62ff8711c092323e93b29b100f8fbb8561..9db9df50635322aa881c76ff719d935d7e5aaf33 |
| a4721f6 | https://github.com/angular/angular/commit/a4721f62ff8711c092323e93b29b100f8fbb8561 |
| 9db9df5 | https://github.com/angular/angular/commit/9db9df50635322aa881c76ff719d935d7e5aaf33 |
|
Compare
| https://github.com/angular/angular/compare/a4721f62ff8711c092323e93b29b100f8fbb8561..9db9df50635322aa881c76ff719d935d7e5aaf33 |
| March 13, 2019 15:49 | https://github.com/angular/angular/pull/29209#event-2200729365 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 13, 2019 | https://github.com/angular/angular/pull/29209#issuecomment-472495340 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Mar 13, 2019 | https://github.com/angular/angular/pull/29209#event-2200830088 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| March 13, 2019 16:19 | https://github.com/angular/angular/pull/29209#event-2200830803 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| March 13, 2019 16:19 | https://github.com/angular/angular/pull/29209#event-2200830830 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 13, 2019 | https://github.com/angular/angular/pull/29209#issuecomment-472499150 |
| #29119 | https://github.com/angular/angular/pull/29119 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/9db9df50635322aa881c76ff719d935d7e5aaf33..cf9abf9e63afbfde9e2fbe7912f3010f59084cb5 |
| 9db9df5 | https://github.com/angular/angular/commit/9db9df50635322aa881c76ff719d935d7e5aaf33 |
| cf9abf9 | https://github.com/angular/angular/commit/cf9abf9e63afbfde9e2fbe7912f3010f59084cb5 |
|
Compare
| https://github.com/angular/angular/compare/9db9df50635322aa881c76ff719d935d7e5aaf33..cf9abf9e63afbfde9e2fbe7912f3010f59084cb5 |
| March 14, 2019 10:31 | https://github.com/angular/angular/pull/29209#event-2202929750 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 14, 2019
| https://github.com/angular/angular/pull/29209#ref-pullrequest-406548293 |
|
ci(docs-infra): run with Ivy
#28530
| https://github.com/angular/angular/pull/28530 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Mar 15, 2019
| https://github.com/angular/angular/pull/29209#pullrequestreview-214912640 |
|
View reviewed changes
| https://github.com/angular/angular/pull/29209/files |
| packages/compiler-cli/src/ngtsc/reflection/src/host.ts | https://github.com/angular/angular/pull/29209/files#diff-e7f1562798d174a4ababbfbf02ea86bd4c83efa846959878d56db221cc3dd389 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Mar 15, 2019
| https://github.com/angular/angular/pull/29209#pullrequestreview-214922351 |
|
View reviewed changes
| https://github.com/angular/angular/pull/29209/files |
| packages/compiler-cli/src/ngtsc/transform/src/compilation.ts | https://github.com/angular/angular/pull/29209/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Mar 15, 2019
| https://github.com/angular/angular/pull/29209#pullrequestreview-214934543 |
|
View reviewed changes
| https://github.com/angular/angular/pull/29209/files |
| packages/compiler-cli/src/ngcc/test/host/util.ts | https://github.com/angular/angular/pull/29209/files#diff-6464bd79e4d857f5d6bc5997c82374255f793c7e8ad45458e00ccfde4906046e |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 20, 2019 | https://github.com/angular/angular/pull/29209#event-2216675162 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Mar 20, 2019 | https://github.com/angular/angular/pull/29209#issuecomment-474812346 |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 20, 2019 | https://github.com/angular/angular/pull/29209#issuecomment-474812601 |
| #29416 | https://github.com/angular/angular/pull/29416 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| gkalpak | https://github.com/gkalpak |
| March 21, 2019 19:47 | https://github.com/angular/angular/pull/29209#commits-pushed-34ad3fc |
|
| https://github.com/gkalpak |
| refactor(ivy): remove unused code from TypeCheckContext | https://github.com/angular/angular/pull/29209/commits/34ad3fc965d94900122a958fd67ba3aaad6b82ad |
| 34ad3fc | https://github.com/angular/angular/pull/29209/commits/34ad3fc965d94900122a958fd67ba3aaad6b82ad |
|
| https://github.com/gkalpak |
| refactor(ivy): implement DtsModuleScopeResolver from `MetadataDtsMo… | https://github.com/angular/angular/pull/29209/commits/c077d35d064065a69e6a6fbca1c86401e9223f33 |
| c077d35 | https://github.com/angular/angular/pull/29209/commits/c077d35d064065a69e6a6fbca1c86401e9223f33 |
|
| https://github.com/gkalpak |
| refactor(ivy): correctly type class declarations in ngtsc/ngcc | https://github.com/angular/angular/pull/29209/commits/a666cdc63a08709bc0ec0179f5399c49df80a819 |
| a666cdc | https://github.com/angular/angular/pull/29209/commits/a666cdc63a08709bc0ec0179f5399c49df80a819 |
|
| https://github.com/gkalpak |
| fixup! refactor(ivy): correctly type class declarations in ngtsc/`n… | https://github.com/angular/angular/pull/29209/commits/bb9b62dfb0ab14708d11fb0f856cab27c4b451a6 |
| bb9b62d | https://github.com/angular/angular/pull/29209/commits/bb9b62dfb0ab14708d11fb0f856cab27c4b451a6 |
|
| https://github.com/gkalpak |
| refactor(ivy): use ClassDeclaration in more ReflectionHost methods | https://github.com/angular/angular/pull/29209/commits/acd8af834bfe8b2386e99a18f18d33d2863ee0a2 |
| acd8af8 | https://github.com/angular/angular/pull/29209/commits/acd8af834bfe8b2386e99a18f18d33d2863ee0a2 |
|
| https://github.com/gkalpak |
| fixup! refactor(ivy): use ClassDeclaration in more ReflectionHost… | https://github.com/angular/angular/pull/29209/commits/bbe935a749e0968bba7c32e0f912a34644ea7a20 |
| bbe935a | https://github.com/angular/angular/pull/29209/commits/bbe935a749e0968bba7c32e0f912a34644ea7a20 |
|
| https://github.com/gkalpak |
| fix(ivy): handle class declarations consistently in ES5 code | https://github.com/angular/angular/pull/29209/commits/4c037b8f789a212e432d3bde0b9d44103e43b723 |
| 4c037b8 | https://github.com/angular/angular/pull/29209/commits/4c037b8f789a212e432d3bde0b9d44103e43b723 |
|
| https://github.com/gkalpak |
| fixup! fix(ivy): handle class declarations consistently in ES5 code | https://github.com/angular/angular/pull/29209/commits/fbdf8ce8e775577ad11620f7bafc0c2715a8ec75 |
| fbdf8ce | https://github.com/angular/angular/pull/29209/commits/fbdf8ce8e775577ad11620f7bafc0c2715a8ec75 |
|
| https://github.com/gkalpak |
| fixup! refactor(ivy): correctly type class declarations in ngtsc/`n… | https://github.com/angular/angular/pull/29209/commits/ab11d5e79192505da7fa88a625fa774680755755 |
| ab11d5e | https://github.com/angular/angular/pull/29209/commits/ab11d5e79192505da7fa88a625fa774680755755 |
|
| https://github.com/gkalpak |
| fixup! refactor(ivy): use ClassDeclaration in more ReflectionHost… | https://github.com/angular/angular/pull/29209/commits/02c2fa47901de6dc2a4416e61e230955e6faed87 |
| 02c2fa4 | https://github.com/angular/angular/pull/29209/commits/02c2fa47901de6dc2a4416e61e230955e6faed87 |
|
| https://github.com/gkalpak |
| fixup! fix(ivy): handle class declarations consistently in ES5 code | https://github.com/angular/angular/pull/29209/commits/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6 |
| 7ba59e1 | https://github.com/angular/angular/pull/29209/commits/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/322e6aa77a75859f3b4b3c0262961c8dd00a8c06..7ba59e1fa001c500c9b2e6322133c54a2d3f48c6 |
| 322e6aa | https://github.com/angular/angular/commit/322e6aa77a75859f3b4b3c0262961c8dd00a8c06 |
| 7ba59e1 | https://github.com/angular/angular/commit/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6 |
|
Compare
| https://github.com/angular/angular/compare/322e6aa77a75859f3b4b3c0262961c8dd00a8c06..7ba59e1fa001c500c9b2e6322133c54a2d3f48c6 |
| March 21, 2019 17:56 | https://github.com/angular/angular/pull/29209#event-2220572310 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 21, 2019 | https://github.com/angular/angular/pull/29209#issuecomment-475340988 |
| 7ba59e1 | https://github.com/angular/angular/commit/7ba59e1fa001c500c9b2e6322133c54a2d3f48c6 |
| https://pr29209-7ba59e1.ngbuilds.io/ | https://pr29209-7ba59e1.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 70fffba | https://github.com/angular/angular/commit/70fffba0541e9b0ab99015e9ae509cc1f22658c3 |
| Mar 21, 2019 | https://github.com/angular/angular/pull/29209#event-2221200961 |
| mhevery | https://github.com/mhevery |
|
Mar 21, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-2d859a8 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| refactor(ivy): implement DtsModuleScopeResolver from `MetadataDtsMo… | https://github.com/angular/angular/commit/2d859a8c3aed6f67f6625fd616236d9d5bf0a68c |
| 2d859a8 | https://github.com/angular/angular/commit/2d859a8c3aed6f67f6625fd616236d9d5bf0a68c |
| #29209 | https://github.com/angular/angular/pull/29209 |
| #29209 | https://github.com/angular/angular/pull/29209 |
| mhevery | https://github.com/mhevery |
|
Mar 21, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-bb6a363 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| refactor(ivy): correctly type class declarations in | https://github.com/angular/angular/commit/bb6a3632f6e7a3cf4abd21ee4ce23f9b1df68c0b |
| ngtsc | https://github.com/angular/angular/commit/bb6a3632f6e7a3cf4abd21ee4ce23f9b1df68c0b |
| / | https://github.com/angular/angular/commit/bb6a3632f6e7a3cf4abd21ee4ce23f9b1df68c0b |
| ngcc | https://github.com/angular/angular/commit/bb6a3632f6e7a3cf4abd21ee4ce23f9b1df68c0b |
| ( | https://github.com/angular/angular/commit/bb6a3632f6e7a3cf4abd21ee4ce23f9b1df68c0b |
| #… | https://github.com/angular/angular/pull/29209 |
| bb6a363 | https://github.com/angular/angular/commit/bb6a3632f6e7a3cf4abd21ee4ce23f9b1df68c0b |
| …29209 | https://github.com/angular/angular/pull/29209 |
| #29209 | https://github.com/angular/angular/pull/29209 |
| mhevery | https://github.com/mhevery |
|
Mar 21, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-2790352 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| refactor(ivy): use ClassDeclaration in more ReflectionHost methods ( | https://github.com/angular/angular/commit/2790352d048db5e4d1a8ff7f62536002dd791b39 |
| 2790352 | https://github.com/angular/angular/commit/2790352d048db5e4d1a8ff7f62536002dd791b39 |
| #29209 | https://github.com/angular/angular/pull/29209 |
| #29209 | https://github.com/angular/angular/pull/29209 |
| mhevery | https://github.com/mhevery |
|
Mar 21, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-21835af |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(ivy): handle class declarations consistently in ES5 code ( | https://github.com/angular/angular/commit/21835af70cf0535273270be827633471d9ec465d |
| #29209 | https://github.com/angular/angular/pull/29209 |
| ) | https://github.com/angular/angular/commit/21835af70cf0535273270be827633471d9ec465d |
| 21835af | https://github.com/angular/angular/commit/21835af70cf0535273270be827633471d9ec465d |
| #29209 | https://github.com/angular/angular/pull/29209 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| March 22, 2019 14:08 | https://github.com/angular/angular/pull/29209#event-2222734934 |
| wKoza | https://github.com/wKoza |
|
Apr 17, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-b4092e8 |
|
| https://github.com/gkalpak |
|
| https://github.com/wKoza |
| refactor(ivy): remove unused code from | https://github.com/wKoza/angular/commit/b4092e8cbe3f01c5214e5388bcf0787ef5ff1cc6 |
| TypeCheckContext | https://github.com/wKoza/angular/commit/b4092e8cbe3f01c5214e5388bcf0787ef5ff1cc6 |
| ( | https://github.com/wKoza/angular/commit/b4092e8cbe3f01c5214e5388bcf0787ef5ff1cc6 |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| b4092e8 | https://github.com/wKoza/angular/commit/b4092e8cbe3f01c5214e5388bcf0787ef5ff1cc6 |
| https://github.com/angular/angular/pull/29209 |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| wKoza | https://github.com/wKoza |
|
Apr 17, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-0a8ec9e |
|
| https://github.com/gkalpak |
|
| https://github.com/wKoza |
| refactor(ivy): implement DtsModuleScopeResolver from `MetadataDtsMo… | https://github.com/wKoza/angular/commit/0a8ec9e79ffd48f9c6b7036ddaa83168b49a18d1 |
| 0a8ec9e | https://github.com/wKoza/angular/commit/0a8ec9e79ffd48f9c6b7036ddaa83168b49a18d1 |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| wKoza | https://github.com/wKoza |
|
Apr 17, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-9789936 |
|
| https://github.com/gkalpak |
|
| https://github.com/wKoza |
| refactor(ivy): correctly type class declarations in | https://github.com/wKoza/angular/commit/97899364384362137576bb2c6369cc2cf36bbe44 |
| ngtsc | https://github.com/wKoza/angular/commit/97899364384362137576bb2c6369cc2cf36bbe44 |
| / | https://github.com/wKoza/angular/commit/97899364384362137576bb2c6369cc2cf36bbe44 |
| ngcc | https://github.com/wKoza/angular/commit/97899364384362137576bb2c6369cc2cf36bbe44 |
| ( | https://github.com/wKoza/angular/commit/97899364384362137576bb2c6369cc2cf36bbe44 |
| a… | https://github.com/angular/angular/pull/29209 |
| 9789936 | https://github.com/wKoza/angular/commit/97899364384362137576bb2c6369cc2cf36bbe44 |
| …ngular#29209 | https://github.com/angular/angular/pull/29209 |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| wKoza | https://github.com/wKoza |
|
Apr 17, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-6a97c4b |
|
| https://github.com/gkalpak |
|
| https://github.com/wKoza |
| refactor(ivy): use ClassDeclaration in more ReflectionHost methods ( | https://github.com/wKoza/angular/commit/6a97c4b085c1c33363b0fc3bdc7de845f4cce8fa |
| 6a97c4b | https://github.com/wKoza/angular/commit/6a97c4b085c1c33363b0fc3bdc7de845f4cce8fa |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| wKoza | https://github.com/wKoza |
|
Apr 17, 2019
| https://github.com/angular/angular/pull/29209#ref-commit-d02ce15 |
|
| https://github.com/gkalpak |
|
| https://github.com/wKoza |
| fix(ivy): handle class declarations consistently in ES5 code ( | https://github.com/wKoza/angular/commit/d02ce15df376e4ea7740313487d2efbdd7005d0a |
| angular… | https://github.com/angular/angular/pull/29209 |
| d02ce15 | https://github.com/wKoza/angular/commit/d02ce15df376e4ea7740313487d2efbdd7005d0a |
| …#29209 | https://github.com/angular/angular/pull/29209 |
| angular#29209 | https://github.com/angular/angular/pull/29209 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/29209#issuecomment-531515074 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/29209#event-2634342298 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29209 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/29209/files/8a91e183ef7b97cfaf912548448967fdd83ac7ff |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/alfaproject |
|
alfaproject
| https://github.com/alfaproject |
|
| https://github.com/angular/angular/pull/29209/files/6846e9c9863a029bdbf31adc013cfcce04c1bd63 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/29209/files/b0cf2824c989e4b12c2db689e481e6401b0e679c |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/29209 |
|
| https://github.com/gkalpak |
|
| https://github.com/petebacondarwin |
|
| https://github.com/mary-poppins |
|
| https://github.com/alfaproject |
|
| https://github.com/JoostK |
|
| https://github.com/kara |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |