René's URL Explorer Experiment


Title: Use correct plural form for ivy by ocombe · Pull Request #29160 · angular/angular · GitHub

Open Graph Title: Use correct plural form for ivy by ocombe · Pull Request #29160 · angular/angular

X Title: Use correct plural form for ivy by ocombe · Pull Request #29160 · angular/angular

Description: You should review each commit independently, it'll be easier. Plural ICU expressions depend on the locale (different languages have different plural forms). Until now the locale was hard coded as en-US. This PR refactors all of the localization code that was previously living in @angular/common. Everything but the locale data has been moved to @angular/core, making it possible to get the correct plural form. Since we plan on refactoring all of this later and we didn't want to create a breaking change for that now, everything is still publicly exported by @angular/common, but the code is actually in @angular/core, making it possible to use it in core (core cannot import from common). For compatibility reasons, if you use ivy with AOT and bootstrap your app with bootstrapModule then the LOCALE_ID token will be set automatically for ivy, which is then used to get the correct plural form. ⚠️ For JIT you need to call ɵsetLocaleId manually to define the LOCALE_ID before bootstrap. Same thing if you don't use the compat mode and start your app with renderComponent. We expect this to change once we start adding the new i18n APIs, so don't rely on this function (there's a reason why it's a private export). BREAKING CHANGE: In v5, we deprecated support for the intl API in order to improve the browser support. We are now removing these deprecated APIs for v8. See the original change here for more info on why: #18284.

Open Graph Description: You should review each commit independently, it'll be easier. Plural ICU expressions depend on the locale (different languages have different plural forms). Until now the locale was hard coded...

X Description: You should review each commit independently, it'll be easier. Plural ICU expressions depend on the locale (different languages have different plural forms). Until now the locale was hard c...

Opengraph URL: https://github.com/angular/angular/pull/29160

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:38ff60c6-3001-eb8e-49ae-3a552fcd01df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB16:296654:1960C2C:21D7077:6B015087
html-safe-nonce2d96f15754be1c6abf6f0b54af21efbc22213f4c98539554b10e7db23d792d3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjE2OjI5NjY1NDoxOTYwQzJDOjIxRDcwNzc6NkIwMTUwODciLCJ2aXNpdG9yX2lkIjoiMzk4MTAyODc0MTAzNTY2NDcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf291fa6b65fc1d5bb1c9dfe0d0384e33d9275d2f7b94ccd27a7d29bc56832e4e
hovercard-subject-tagpull_request:259187789
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/29160/files
twitter:imagehttps://avatars.githubusercontent.com/u/265378?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/265378?s=400&v=4
og:image:altYou should review each commit independently, it'll be easier. Plural ICU expressions depend on the locale (different languages have different plural forms). Until now the locale was hard coded...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/29160/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29160%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29160%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/29160/files
Reloadhttps://github.com/angular/angular/pull/29160/files
Reloadhttps://github.com/angular/angular/pull/29160/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:feat/ivy/fw-632-locale_idhttps://github.com/ocombe/angular/tree/feat/ivy/fw-632-locale_id
Conversation 15 https://github.com/angular/angular/pull/29160
Commits 2 https://github.com/angular/angular/pull/29160/commits
Checks 0 https://github.com/angular/angular/pull/29160/checks
Files changed https://github.com/angular/angular/pull/29160/files
Please reload this pagehttps://github.com/angular/angular/pull/29160/files
Use correct plural form for ivy https://github.com/angular/angular/pull/29160/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/29160/files
303510e fix(common): remove deprecated support for intl API ocombe Feb 27, 2019 https://github.com/angular/angular/pull/29160/commits/303510ef2ed77fa27aaec4104cd983f196e4d310
2859c9f feat(ivy): use i18n locale data to determine the plural form of ICU e… ocombe Mar 7, 2019 https://github.com/angular/angular/pull/29160/commits/2859c9f37942c6e22eb06af5b4d803397e74c0de
Clear filters https://github.com/angular/angular/pull/29160/files
Please reload this pagehttps://github.com/angular/angular/pull/29160/files
Please reload this pagehttps://github.com/angular/angular/pull/29160/files
browser-support.md https://github.com/angular/angular/pull/29160/files#diff-4e1092c803803b28f5a3f066a7029627bdb0bcbd5af6bb469e5bdc6bb1c6552e
common.ts https://github.com/angular/angular/pull/29160/files#diff-621bbe741d16a7c5415944c00433d7484679a5e63fb2db9f144a33a9272ac896
common_module.ts https://github.com/angular/angular/pull/29160/files#diff-9fafde72f3654231345df309aed185c1b60fdb1754fdf40eb7fecaec8029ad70
locale_data.ts https://github.com/angular/angular/pull/29160/files#diff-76e6a88b0a64daaf3795764d820033fd8fe2c957278e8c2bea77f1c0351ca455
locale_data_api.ts https://github.com/angular/angular/pull/29160/files#diff-6ae44b665474df44ef4527f678979454c7d0bbadb9e51cef25c6557e30b83113
localization.ts https://github.com/angular/angular/pull/29160/files#diff-496432220d9c63845cd57392391b4bac17b490eade03c1c09db517473ee776e7
date_pipe.ts https://github.com/angular/angular/pull/29160/files#diff-3903bfe4dc8f63c1e741e6ad871c9c45f224b1afc44724e7bf7b903009484995
index.ts https://github.com/angular/angular/pull/29160/files#diff-be16367160f9657bab2f9f7d1b01bbec31d3911e2d5c2b46c08f905bbedc0f38
intl.ts https://github.com/angular/angular/pull/29160/files#diff-d023dfb91d311fe551e309aa994f3b7bb0b12f17d4741b552428aec83a5c127f
number_pipe.ts https://github.com/angular/angular/pull/29160/files#diff-b5a5f7baf093c32f13e95635ba00740c93ef2e752920abb4fee3d0af93f1388c
common_module_spec.ts https://github.com/angular/angular/pull/29160/files#diff-b18c19da63a6414e3de273414c69ddf3ab6fd971df0d81c4abef5a8dc8f8a29e
localization_spec.ts https://github.com/angular/angular/pull/29160/files#diff-72cecab13754257cce98db96d39e47c5c2f7945f54143c918a49bee22a1ecc89
date_pipe_spec.ts https://github.com/angular/angular/pull/29160/files#diff-814b932dc27e1e25aa9bdd8b18f19f8956a05c7058ab97859aef24afe0e490b2
number_pipe_spec.ts https://github.com/angular/angular/pull/29160/files#diff-524dd1d6a56a59f06fb0461999ad58723072c9d11f6b68b615df4bd4f0f0e360
ng_module.ts https://github.com/angular/angular/pull/29160/files#diff-8b9c0d2955b2182ee8ebd745a4f737de1207244d83ef08bdc00f9c8d9139c2a8
program.ts https://github.com/angular/angular/pull/29160/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
core_private_export.ts https://github.com/angular/angular/pull/29160/files#diff-2b5852df25d6ad975ee77aa156106f45e8b17465fd64a0569ef0ed49e3b3a3f0
core_render3_private_export.ts https://github.com/angular/angular/pull/29160/files#diff-de09a25a93c0410c75a7ff56fdc6fb572198bdbce5ecaa98cb001063018eb79e
currencies.ts https://github.com/angular/angular/pull/29160/files#diff-cb17b161336c96fcaa563cba211b9bb2319bc9cb08f2da5499029546fafd64fd
locale_data.ts https://github.com/angular/angular/pull/29160/files#diff-6c0e1f42025d53201a344f2769548c9f524595ed7fe5a89e89324681a919c111
locale_data_api.ts https://github.com/angular/angular/pull/29160/files#diff-9db4d7b8dd69bd2c6ee4dffccb5cd2b9ddf4c272287588a2173ae7bcf34d13ff
locale_en.ts https://github.com/angular/angular/pull/29160/files#diff-19fb8f3291033c69ec83c3e7edde7639e7d5c2aed77d69e55728c30c5227e544
localization.ts https://github.com/angular/angular/pull/29160/files#diff-400727fde78606be916c993dd6bb3d8856c7dde44cc4c56a313d34407aacbc38
component.ts https://github.com/angular/angular/pull/29160/files#diff-dcda220a37338462837f5abe90db2b576fca57f34b40f36820514cdc696e097d
definition.ts https://github.com/angular/angular/pull/29160/files#diff-4374dd238deae3e4714315fc97bb9983092ada87475d8e0b8d28e191571941de
fields.ts https://github.com/angular/angular/pull/29160/files#diff-825ee631786c6779bc5d3774afae80b3948eb7ee3ae2bc4d2468559060bf98eb
i18n.ts https://github.com/angular/angular/pull/29160/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
index.ts https://github.com/angular/angular/pull/29160/files#diff-a3ef3e01266ff033c4d48f63e1ba739566bdd8a0b2ce372c1659b67c456d8f82
module.ts https://github.com/angular/angular/pull/29160/files#diff-d7312b298dbbe322603ff75633c99e8074bc20ed5d4370392ec2b80d86c3bf62
ng_module_ref.ts https://github.com/angular/angular/pull/29160/files#diff-8db5009cd4b3347c14f38e0fd3f41146c3484ec92721561ae1d82ff9bf93ac27
BUILD.bazel https://github.com/angular/angular/pull/29160/files#diff-a1bbbf89952cbb0e556756019cc5e6e678bdd2e3be263e82896ff0e7906cda2a
i18n_spec.ts https://github.com/angular/angular/pull/29160/files#diff-84da0a6c098802842313ab3dff8c314d0b832a4883db66cfc234eb88cdd1f1b4
extract.js https://github.com/angular/angular/pull/29160/files#diff-40b1a9f593b985c33152680e9c064573de7a924ce50b04dc4f58e2a2f0397c9c
common.d.ts https://github.com/angular/angular/pull/29160/files#diff-8f04e04e51db03a1fa86550e492017d75859c13236cac866e8727c788a843710
aio/content/guide/browser-support.mdhttps://github.com/angular/angular/pull/29160/files#diff-4e1092c803803b28f5a3f066a7029627bdb0bcbd5af6bb469e5bdc6bb1c6552e
View file https://github.com/ocombe/angular/blob/2859c9f37942c6e22eb06af5b4d803397e74c0de/aio/content/guide/browser-support.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29160/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29160/files#diff-4e1092c803803b28f5a3f066a7029627bdb0bcbd5af6bb469e5bdc6bb1c6552e
https://github.com/angular/angular/pull/29160/files#diff-4e1092c803803b28f5a3f066a7029627bdb0bcbd5af6bb469e5bdc6bb1c6552e
packages/common/src/common.tshttps://github.com/angular/angular/pull/29160/files#diff-621bbe741d16a7c5415944c00433d7484679a5e63fb2db9f144a33a9272ac896
View file https://github.com/ocombe/angular/blob/2859c9f37942c6e22eb06af5b4d803397e74c0de/packages/common/src/common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29160/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29160/files#diff-621bbe741d16a7c5415944c00433d7484679a5e63fb2db9f144a33a9272ac896
https://github.com/angular/angular/pull/29160/files#diff-621bbe741d16a7c5415944c00433d7484679a5e63fb2db9f144a33a9272ac896
packages/common/src/common_module.tshttps://github.com/angular/angular/pull/29160/files#diff-9fafde72f3654231345df309aed185c1b60fdb1754fdf40eb7fecaec8029ad70
View file https://github.com/ocombe/angular/blob/2859c9f37942c6e22eb06af5b4d803397e74c0de/packages/common/src/common_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29160/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29160/files#diff-9fafde72f3654231345df309aed185c1b60fdb1754fdf40eb7fecaec8029ad70
https://github.com/angular/angular/pull/29160/files#diff-9fafde72f3654231345df309aed185c1b60fdb1754fdf40eb7fecaec8029ad70
https://github.com/angular/angular/pull/29160/files#diff-9fafde72f3654231345df309aed185c1b60fdb1754fdf40eb7fecaec8029ad70
packages/common/src/i18n/locale_data.tshttps://github.com/angular/angular/pull/29160/files#diff-76e6a88b0a64daaf3795764d820033fd8fe2c957278e8c2bea77f1c0351ca455
View file https://github.com/ocombe/angular/blob/2859c9f37942c6e22eb06af5b4d803397e74c0de/packages/common/src/i18n/locale_data.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/29160/{{ revealButtonHref }}
https://github.com/angular/angular/pull/29160/files#diff-76e6a88b0a64daaf3795764d820033fd8fe2c957278e8c2bea77f1c0351ca455
Please reload this pagehttps://github.com/angular/angular/pull/29160/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.