| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:678a05ad-789b-9325-7b4f-c43da8063bcb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CFCA:6365:165B9AD:1DCFC94:6B013E71 |
| html-safe-nonce | b069173c223590cac5f4eefe444c40ecd411f6f0be0992a897929ae9a4b490c0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkNBOjYzNjU6MTY1QjlBRDoxRENGQzk0OjZCMDEzRTcxIiwidmlzaXRvcl9pZCI6IjU2NjI4NTQxMzkzMzcyNzM0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2751b335d0785e2ad41d321ec0e75b7f73f32efb9b0d3ecf159d8676a9450690 |
| hovercard-subject-tag | pull_request:259187789 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/29160/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/631fb78a77291f87efeeb0a5aae6b8be953376b9b6ea3cd0678a000a16084583/angular/angular/pull/29160 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/631fb78a77291f87efeeb0a5aae6b8be953376b9b6ea3cd0678a000a16084583/angular/angular/pull/29160 |
| og:image:alt | You should review each commit independently, it'll be easier.
Plural ICU expressions depend on the locale (different languages have different plural forms). Until now the locale was hard coded... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ocombe |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/29160#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29160 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29160 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/29160 |
| Reload | https://github.com/angular/angular/pull/29160 |
| Reload | https://github.com/angular/angular/pull/29160 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:feat/ivy/fw-632-locale_id | https://github.com/ocombe/angular/tree/feat/ivy/fw-632-locale_id |
| Conversation | https://github.com/angular/angular/pull/29160 |
| Commits2 (2) | https://github.com/angular/angular/pull/29160/commits |
| Checks | https://github.com/angular/angular/pull/29160/checks |
| Files changed | https://github.com/angular/angular/pull/29160/files |
| Use correct plural form for ivy | https://github.com/angular/angular/pull/29160#top |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:feat/ivy/fw-632-locale_id | https://github.com/ocombe/angular/tree/feat/ivy/fw-632-locale_id |
|
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#issue-418407969 |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| #18284 | https://github.com/angular/angular/pull/18284 |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
comp: ivy
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22 |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#event-2187800169 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| March 7, 2019 16:44 | https://github.com/angular/angular/pull/29160#event-2187800217 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#event-2187800394 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#event-2187800648 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/b3cd48b5307e1cfbd71ee095601d5aed5b72adba..146c94af701f36ec8c0fd098bff52019285cd25c |
| b3cd48b | https://github.com/angular/angular/commit/b3cd48b5307e1cfbd71ee095601d5aed5b72adba |
| 146c94a | https://github.com/angular/angular/commit/146c94af701f36ec8c0fd098bff52019285cd25c |
|
Compare
| https://github.com/angular/angular/compare/b3cd48b5307e1cfbd71ee095601d5aed5b72adba..146c94af701f36ec8c0fd098bff52019285cd25c |
| March 7, 2019 17:06 | https://github.com/angular/angular/pull/29160#event-2187867924 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| March 7, 2019 17:06 | https://github.com/angular/angular/pull/29160#event-2187867928 |
|
| https://github.com/ocombe |
| fix(common): remove deprecated support for intl API | https://github.com/angular/angular/pull/29160/commits/303510ef2ed77fa27aaec4104cd983f196e4d310 |
| 303510e | https://github.com/angular/angular/pull/29160/commits/303510ef2ed77fa27aaec4104cd983f196e4d310 |
| angular#18284 | https://github.com/angular/angular/pull/18284 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/146c94af701f36ec8c0fd098bff52019285cd25c..2acd56d51bcff059322178eee00b53fc76f0d617 |
| 146c94a | https://github.com/angular/angular/commit/146c94af701f36ec8c0fd098bff52019285cd25c |
| 2acd56d | https://github.com/angular/angular/commit/2acd56d51bcff059322178eee00b53fc76f0d617 |
|
Compare
| https://github.com/angular/angular/compare/146c94af701f36ec8c0fd098bff52019285cd25c..2acd56d51bcff059322178eee00b53fc76f0d617 |
| March 7, 2019 17:20 | https://github.com/angular/angular/pull/29160#event-2187906904 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| March 7, 2019 17:20 | https://github.com/angular/angular/pull/29160#event-2187906915 |
|
| https://github.com/ocombe |
| feat(ivy): use i18n locale data to determine the plural form of ICU e… | https://github.com/angular/angular/pull/29160/commits/2859c9f37942c6e22eb06af5b4d803397e74c0de |
| 2859c9f | https://github.com/angular/angular/pull/29160/commits/2859c9f37942c6e22eb06af5b4d803397e74c0de |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/2acd56d51bcff059322178eee00b53fc76f0d617..2859c9f37942c6e22eb06af5b4d803397e74c0de |
| 2acd56d | https://github.com/angular/angular/commit/2acd56d51bcff059322178eee00b53fc76f0d617 |
| 2859c9f | https://github.com/angular/angular/commit/2859c9f37942c6e22eb06af5b4d803397e74c0de |
|
Compare
| https://github.com/angular/angular/compare/2acd56d51bcff059322178eee00b53fc76f0d617..2859c9f37942c6e22eb06af5b4d803397e74c0de |
| March 7, 2019 17:23 | https://github.com/angular/angular/pull/29160#event-2187916055 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| AndrewKushnir | https://github.com/AndrewKushnir |
| IgorMinar | https://github.com/IgorMinar |
| alxhub | https://github.com/alxhub |
| mhevery | https://github.com/mhevery |
| March 7, 2019 17:41 | https://github.com/angular/angular/pull/29160#event-2187963321 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#issuecomment-470630238 |
| @kara | https://github.com/kara |
| @mhevery | https://github.com/mhevery |
| @StephenFluin | https://github.com/StephenFluin |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Mar 7, 2019
| https://github.com/angular/angular/pull/29160#pullrequestreview-211960074 |
|
View reviewed changes
| https://github.com/angular/angular/pull/29160/files/2859c9f37942c6e22eb06af5b4d803397e74c0de |
| mhevery | https://github.com/mhevery |
| https://github.com/angular/angular/pull/29160#pullrequestreview-211960074 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| packages/common/src/i18n/localization.ts | https://github.com/angular/angular/pull/29160/files/303510ef2ed77fa27aaec4104cd983f196e4d310..2859c9f37942c6e22eb06af5b4d803397e74c0de#diff-496432220d9c63845cd57392391b4bac17b490eade03c1c09db517473ee776e7 |
| mhevery | https://github.com/mhevery |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263520419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| ocombe | https://github.com/ocombe |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263534260 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| packages/compiler-cli/src/ngtsc/annotations/src/ng_module.ts | https://github.com/angular/angular/pull/29160/files/303510ef2ed77fa27aaec4104cd983f196e4d310..2859c9f37942c6e22eb06af5b4d803397e74c0de#diff-8b9c0d2955b2182ee8ebd745a4f737de1207244d83ef08bdc00f9c8d9139c2a8 |
| mhevery | https://github.com/mhevery |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263522566 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| ocombe | https://github.com/ocombe |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263535070 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| packages/core/src/render3/ng_module_ref.ts | https://github.com/angular/angular/pull/29160/files/303510ef2ed77fa27aaec4104cd983f196e4d310..2859c9f37942c6e22eb06af5b4d803397e74c0de#diff-8db5009cd4b3347c14f38e0fd3f41146c3484ec92721561ae1d82ff9bf93ac27 |
| mhevery | https://github.com/mhevery |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263522993 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| ocombe | https://github.com/ocombe |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263535302 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| ocombe | https://github.com/ocombe |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29160#discussion_r264703548 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| tools/public_api_guard/common/common.d.ts | https://github.com/angular/angular/pull/29160/files/303510ef2ed77fa27aaec4104cd983f196e4d310..2859c9f37942c6e22eb06af5b4d803397e74c0de#diff-8f04e04e51db03a1fa86550e492017d75859c13236cac866e8727c788a843710 |
| mhevery | https://github.com/mhevery |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263524130 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| ocombe | https://github.com/ocombe |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#discussion_r263535832 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @IgorMinar | https://github.com/IgorMinar |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Mar 7, 2019 | https://github.com/angular/angular/pull/29160#issuecomment-470702978 |
| @ocombe | https://github.com/ocombe |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29160#issuecomment-472022028 |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29160#event-2197299310 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Mar 12, 2019 | https://github.com/angular/angular/pull/29160#issuecomment-472024479 |
| #29249 | https://github.com/angular/angular/pull/29249 |
| #29250 | https://github.com/angular/angular/pull/29250 |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/29160#issuecomment-531508506 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/29160#event-2634306689 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F29160 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/angular/angular/pull/29160/files/2859c9f37942c6e22eb06af5b4d803397e74c0de |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/29160 |
|
| https://github.com/ocombe |
|
| https://github.com/IgorMinar |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/mhevery |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |