| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c9fee66c-3285-0cda-67e7-b23173ecc18f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B120:3BB4BB:432643:572BB5:6A5FF21D |
| html-safe-nonce | 3c0a17d0ba28bdb92d7e2023e1d8a69f7ab9380196180ed641794f858f6cd92a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTIwOjNCQjRCQjo0MzI2NDM6NTcyQkI1OjZBNUZGMjFEIiwidmlzaXRvcl9pZCI6IjU2NTE3MTg4NDkyMjM5Nzk1NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b197936e2c17bba8c784e055c9b02fbd5a64b187e8694b7bbe23e126377ff4c4 |
| hovercard-subject-tag | pull_request:254331517 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/28831/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d197ef8972cced670c563787c292eab5933187699a0e2798e5629fd8ef462eeb/angular/angular/pull/28831 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d197ef8972cced670c563787c292eab5933187699a0e2798e5629fd8ef462eeb/angular/angular/pull/28831 |
| og:image:alt | This change is kind of similar to #27466, but instead of ensuring that
these shims can be generated, we also need to make sure that developers
are able to also use the factory shims like with ngc.
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | devversion |
| hostname | github.com |
| expected-hostname | github.com |
| None | ec26f1a08b78b3d576999ee8b45a2abc017c95dbee903a8019940cd2e9bf7b3d |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0a29f0b91ade2368fc0b74327c0f64ec1f98f5ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/28831#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28831 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28831 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/28831 |
| Reload | https://github.com/angular/angular/pull/28831 |
| Reload | https://github.com/angular/angular/pull/28831 |
| Please reload this page | https://github.com/angular/angular/pull/28831 |
|
angular
| https://github.com/angular |
| angular | https://github.com/angular/angular |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27.5k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Star
101k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://github.com/angular/angular |
|
Issues
977
| https://github.com/angular/angular/issues |
|
Pull requests
161
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
24
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
|
Code
| https://github.com/angular/angular |
|
Issues
| https://github.com/angular/angular/issues |
|
Pull requests
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
| devversion | https://github.com/devversion |
| angular:master | https://github.com/angular/angular/tree/master |
| devversion:fix/ngtsc-windows-factory-file-shim-not-working | https://github.com/devversion/angular/tree/fix/ngtsc-windows-factory-file-shim-not-working |
| Conversation | https://github.com/angular/angular/pull/28831 |
| Commits2 (2) | https://github.com/angular/angular/pull/28831/commits |
| Checks | https://github.com/angular/angular/pull/28831/checks |
| Files changed | https://github.com/angular/angular/pull/28831/files |
| fix(ivy): unable to import shim factory files on case-insensitive platforms | https://github.com/angular/angular/pull/28831#top |
| devversion | https://github.com/devversion |
| angular:master | https://github.com/angular/angular/tree/master |
| devversion:fix/ngtsc-windows-factory-file-shim-not-working | https://github.com/devversion/angular/tree/fix/ngtsc-windows-factory-file-shim-not-working |
|
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28831#issue-412024881 |
| Please reload this page | https://github.com/angular/angular/pull/28831 |
| #27466 | https://github.com/angular/angular/pull/27466 |
| Please reload this page | https://github.com/angular/angular/pull/28831 |
| devversion | https://github.com/devversion |
| February 19, 2019 17:29 | https://github.com/angular/angular/pull/28831#commits-pushed-96c0a77 |
|
| https://github.com/devversion |
| refactor(ivy): fix typo in ngtsc "listLazyRoutes" method | https://github.com/angular/angular/pull/28831/commits/96c0a773f631d9c2ef733a63762c37f9846d203e |
| 96c0a77 | https://github.com/angular/angular/pull/28831/commits/96c0a773f631d9c2ef733a63762c37f9846d203e |
|
| https://github.com/devversion |
| fix(ivy): unable to import shim factory files on case-insensitive pla… | https://github.com/angular/angular/pull/28831/commits/a129ec7f2a2c25bdfeab44f6aa403bfb4f540ddd |
| a129ec7 | https://github.com/angular/angular/pull/28831/commits/a129ec7f2a2c25bdfeab44f6aa403bfb4f540ddd |
| angular#27466 | https://github.com/angular/angular/pull/27466 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
comp: ivy
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22 |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28831#event-2149491692 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| alxhub | https://github.com/alxhub |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28831#event-2149491737 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| February 19, 2019 16:54 | https://github.com/angular/angular/pull/28831#event-2149491793 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28831#event-2149491856 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28831#event-2149491874 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28831#event-2149492995 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Feb 20, 2019
| https://github.com/angular/angular/pull/28831#pullrequestreview-206023226 |
|
View reviewed changes
| https://github.com/angular/angular/pull/28831/files/a129ec7f2a2c25bdfeab44f6aa403bfb4f540ddd |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Feb 20, 2019 | https://github.com/angular/angular/pull/28831#event-2153387118 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Feb 21, 2019 | https://github.com/angular/angular/pull/28831#issuecomment-465819561 |
| http://test/OCL:234898223:BASE:234899161:1550711124947:3889ce6d | http://test/OCL:234898223:BASE:234899161:1550711124947:3889ce6d |
| Please reload this page | https://github.com/angular/angular/pull/28831 |
| https://github.com/benlesh |
| benlesh | https://github.com/benlesh |
| 3336de0 | https://github.com/angular/angular/commit/3336de0970c5b35a60a9157bfc291cd5395697de |
| Feb 21, 2019 | https://github.com/angular/angular/pull/28831#event-2153744483 |
| benlesh | https://github.com/benlesh |
|
Feb 21, 2019
| https://github.com/angular/angular/pull/28831#ref-commit-58436fd |
|
| https://github.com/devversion |
|
| https://github.com/benlesh |
| fix(ivy): unable to import shim factory files on case-insensitive pla… | https://github.com/angular/angular/commit/58436fd81adf915bcefef0100938e6bf3d262b78 |
| 58436fd | https://github.com/angular/angular/commit/58436fd81adf915bcefef0100938e6bf3d262b78 |
| #28831 | https://github.com/angular/angular/pull/28831 |
| #27466 | https://github.com/angular/angular/pull/27466 |
| #28831 | https://github.com/angular/angular/pull/28831 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/28831#issuecomment-531499959 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/28831 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/28831#event-2634256686 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28831 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/28831/files/a129ec7f2a2c25bdfeab44f6aa403bfb4f540ddd |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/28831 |
|
| https://github.com/devversion |
|
| https://github.com/IgorMinar |
|
| https://github.com/alxhub |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |