René's URL Explorer Experiment


Title: fix(ivy): fix class inheritance detection for ES5 code in `ngtsc` by gkalpak · Pull Request #28773 · angular/angular · GitHub

Open Graph Title: fix(ivy): fix class inheritance detection for ES5 code in `ngtsc` by gkalpak · Pull Request #28773 · angular/angular

X Title: fix(ivy): fix class inheritance detection for ES5 code in `ngtsc` by gkalpak · Pull Request #28773 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix What is the current behavior? ngtsc detects class inheritance in a way that only works in TS or ES2015 code. As a result, inheritance will not be detected for code in ES5 format, such as when running ngtsc through ngcc to transform old-style Angular code to ivy format. Related issue: #28643 What is the new behavior? This PR fixes the issue by delegating class inheritance detection to the current ReflectionHost, which is able to correctly interpret the used code format. Does this PR introduce a breaking change? Yes No

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

Opengraph URL: https://github.com/angular/angular/pull/28773

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1bd87827-5adc-8daa-b83a-b85bc59e096b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id873E:21AC3F:1B1B21E:2250ADF:6B0135F8
html-safe-nonce568bc05d0db84f7d44f8cc66485e28070dba162abf04dd21396b79234561dc42
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzNFOjIxQUMzRjoxQjFCMjFFOjIyNTBBREY6NkIwMTM1RjgiLCJ2aXNpdG9yX2lkIjoiMTgwOTAxMTA2NDA0MjUwMTYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac82078afade56cdb995985fabb46940187f0cbf397e8b6a1fb9f329c35c914b57
hovercard-subject-tagpull_request:253646699
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/28773/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/28773/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28773%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28773%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/28773/files
Reloadhttps://github.com/angular/angular/pull/28773/files
Reloadhttps://github.com/angular/angular/pull/28773/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ivy-class-inheritance-in-ngcchttps://github.com/gkalpak/angular/tree/fix-ivy-class-inheritance-in-ngcc
Conversation 1 https://github.com/angular/angular/pull/28773
Commits 1 https://github.com/angular/angular/pull/28773/commits
Checks 0 https://github.com/angular/angular/pull/28773/checks
Files changed https://github.com/angular/angular/pull/28773/files
Please reload this pagehttps://github.com/angular/angular/pull/28773/files
fix(ivy): fix class inheritance detection for ES5 code in ngtsc https://github.com/angular/angular/pull/28773/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/28773/files
f1c1c7e fix(ivy): fix class inheritance detection for ES5 code in `ngtsc` gkalpak Feb 15, 2019 https://github.com/angular/angular/pull/28773/commits/f1c1c7e8dea369f067f56db399deab83ef1da184
Clear filters https://github.com/angular/angular/pull/28773/files
Please reload this pagehttps://github.com/angular/angular/pull/28773/files
Please reload this pagehttps://github.com/angular/angular/pull/28773/files
directive.ts https://github.com/angular/angular/pull/28773/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
directive_spec.ts https://github.com/angular/angular/pull/28773/files#diff-aa248188703ff67bf44865bd3147926e1c2e7767bbb2b79d07b3dda38066a626
packages/compiler-cli/src/ngtsc/annotations/src/directive.tshttps://github.com/angular/angular/pull/28773/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
View file https://github.com/gkalpak/angular/blob/f1c1c7e8dea369f067f56db399deab83ef1da184/packages/compiler-cli/src/ngtsc/annotations/src/directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28773/{{ revealButtonHref }}
https://github.com/angular/angular/pull/28773/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
https://github.com/angular/angular/pull/28773/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
packages/compiler-cli/src/ngtsc/annotations/test/directive_spec.tshttps://github.com/angular/angular/pull/28773/files#diff-aa248188703ff67bf44865bd3147926e1c2e7767bbb2b79d07b3dda38066a626
View file https://github.com/gkalpak/angular/blob/f1c1c7e8dea369f067f56db399deab83ef1da184/packages/compiler-cli/src/ngtsc/annotations/test/directive_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28773/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.