René's URL Explorer Experiment


Title: feat(ivy): support i18n without closure by ocombe · Pull Request #28689 · angular/angular · GitHub

Open Graph Title: feat(ivy): support i18n without closure by ocombe · Pull Request #28689 · angular/angular

X Title: feat(ivy): support i18n without closure by ocombe · Pull Request #28689 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: So far using runtime i18n with ivy meant that you needed to use Closure and goog.getMsg (or a polyfill). This PR changes the compiler to only output closure code when the compiler option i18nUseClo...

X Description: So far using runtime i18n with ivy meant that you needed to use Closure and goog.getMsg (or a polyfill). This PR changes the compiler to only output closure code when the compiler option i18nUseClo...

Opengraph URL: https://github.com/angular/angular/pull/28689

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:991d0962-380c-4a3d-7024-0878fd837c5e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA62:1F44:CF0412:10F40F8:6B012091
html-safe-nonce55efe4473aeeba19984f5411618fa42b8596ad4a24e8ac48f165be3f27d82ed0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTYyOjFGNDQ6Q0YwNDEyOjEwRjQwRjg6NkIwMTIwOTEiLCJ2aXNpdG9yX2lkIjoiMjAwMDUyNzEzNDY5NDY0NTkwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3c53c82009553684f7033fbac9d19bba65c75929ab74c55c94026cbcbcff6ccd
hovercard-subject-tagpull_request:252702021
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/28689/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f85dcac6b4acb13e87d8489176d7c00887f0d37b96020de860bea199b84ea08f/angular/angular/pull/28689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f85dcac6b4acb13e87d8489176d7c00887f0d37b96020de860bea199b84ea08f/angular/angular/pull/28689
og:image:altSo far using runtime i18n with ivy meant that you needed to use Closure and goog.getMsg (or a polyfill). This PR changes the compiler to only output closure code when the compiler option i18nUseClo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameocombe
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/28689#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28689
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28689
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/28689
Reloadhttps://github.com/angular/angular/pull/28689
Reloadhttps://github.com/angular/angular/pull/28689
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:feat/ivy/runtime-i18n-shimhttps://github.com/ocombe/angular/tree/feat/ivy/runtime-i18n-shim
Conversationhttps://github.com/angular/angular/pull/28689
Commits1 (1)https://github.com/angular/angular/pull/28689/commits
Checkshttps://github.com/angular/angular/pull/28689/checks
Files changedhttps://github.com/angular/angular/pull/28689/files
feat(ivy): support i18n without closurehttps://github.com/angular/angular/pull/28689#top
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:feat/ivy/runtime-i18n-shimhttps://github.com/ocombe/angular/tree/feat/ivy/runtime-i18n-shim
https://github.com/ocombe
ocombehttps://github.com/ocombe
Feb 13, 2019https://github.com/angular/angular/pull/28689#issue-409815456
Please reload this pagehttps://github.com/angular/angular/pull/28689
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
IgorMinarhttps://github.com/IgorMinar
code ownerhttps://github.com/angular/angular/blob/ac58d01a8e42fbc77ba7adea6f87a657f023334a/.github/CODEOWNERS#L340
February 13, 2019 13:52https://github.com/angular/angular/pull/28689#event-2136764642
https://github.com/ocombe
ocombehttps://github.com/ocombe
February 13, 2019 13:52https://github.com/angular/angular/pull/28689#event-2136764647
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 13, 2019https://github.com/angular/angular/pull/28689#event-2136764778
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 13, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-203221770
View reviewed changes https://github.com/angular/angular/pull/28689/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/28689#pullrequestreview-203221770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Feb 13, 2019https://github.com/angular/angular/pull/28689#event-2136804389
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/7742649281d58556ea5f7bcc2f87f7df4ecf3065..50198273d34bfe868794b57ba6c7dca41a55af48
7742649https://github.com/angular/angular/commit/7742649281d58556ea5f7bcc2f87f7df4ecf3065
5019827https://github.com/angular/angular/commit/50198273d34bfe868794b57ba6c7dca41a55af48
Compare https://github.com/angular/angular/compare/7742649281d58556ea5f7bcc2f87f7df4ecf3065..50198273d34bfe868794b57ba6c7dca41a55af48
February 13, 2019 14:07https://github.com/angular/angular/pull/28689#event-2136804395
https://github.com/ocombe
ocombehttps://github.com/ocombe
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Feb 13, 2019https://github.com/angular/angular/pull/28689#event-2136804589
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Feb 13, 2019https://github.com/angular/angular/pull/28689#event-2136805375
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 13, 2019 https://github.com/angular/angular/pull/28689#ref-issue-398326006
ivy: i18n messages identifiers have dots in their name #28080 https://github.com/angular/angular/issues/28080
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Feb 13, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-203406492
View reviewed changes https://github.com/angular/angular/pull/28689/files
https://github.com/mhevery
mheveryhttps://github.com/mhevery
AndrewKushnirhttps://github.com/AndrewKushnir
February 13, 2019 19:34https://github.com/angular/angular/pull/28689#event-2137722328
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Feb 13, 2019https://github.com/angular/angular/pull/28689#event-2137724059
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 13, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-203414361
View reviewed changes https://github.com/angular/angular/pull/28689/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/28689#pullrequestreview-203414361
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ocombehttps://github.com/ocombe
Please reload this pagehttps://github.com/angular/angular/pull/28689
packages/compiler-cli/src/ngtsc/program.tshttps://github.com/angular/angular/pull/28689/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
Please reload this pagehttps://github.com/angular/angular/pull/28689
packages/core/src/render3/i18n.tshttps://github.com/angular/angular/pull/28689/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Feb 18, 2019https://github.com/angular/angular/pull/28689#event-2146518953
https://github.com/ocombe
ocombehttps://github.com/ocombe
Feb 18, 2019https://github.com/angular/angular/pull/28689#issuecomment-464766064
https://angular-team.atlassian.net/browse/FW-1076https://angular-team.atlassian.net/browse/FW-1076
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/e2c6635b23a86e8473087945ff3ca8e3f9d27c36..8ef7ee5a36e21e380c83499d06a4ce3e67b71b2e
e2c6635https://github.com/angular/angular/commit/e2c6635b23a86e8473087945ff3ca8e3f9d27c36
8ef7ee5https://github.com/angular/angular/commit/8ef7ee5a36e21e380c83499d06a4ce3e67b71b2e
Compare https://github.com/angular/angular/compare/e2c6635b23a86e8473087945ff3ca8e3f9d27c36..8ef7ee5a36e21e380c83499d06a4ce3e67b71b2e
February 20, 2019 09:26https://github.com/angular/angular/pull/28689#event-2151322406
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
Feb 26, 2019https://github.com/angular/angular/pull/28689#issuecomment-467366360
https://angular-team.atlassian.net/browse/FW-1076https://angular-team.atlassian.net/browse/FW-1076
#21883https://github.com/angular/angular/pull/21883
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/8ef7ee5a36e21e380c83499d06a4ce3e67b71b2e..a578389d98e47c3008b355b7ef6aac5383a0d35a
8ef7ee5https://github.com/angular/angular/commit/8ef7ee5a36e21e380c83499d06a4ce3e67b71b2e
a578389https://github.com/angular/angular/commit/a578389d98e47c3008b355b7ef6aac5383a0d35a
Compare https://github.com/angular/angular/compare/8ef7ee5a36e21e380c83499d06a4ce3e67b71b2e..a578389d98e47c3008b355b7ef6aac5383a0d35a
February 26, 2019 12:57https://github.com/angular/angular/pull/28689#event-2164766513
https://github.com/ocombe
ocombehttps://github.com/ocombe
Feb 26, 2019https://github.com/angular/angular/pull/28689#issuecomment-467427932
Please reload this pagehttps://github.com/angular/angular/pull/28689
@gregmagolanhttps://github.com/gregmagolan
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
Feb 26, 2019 https://github.com/angular/angular/pull/28689#ref-pullrequest-414872885
build(bazel): allow a user to control a subset of angularCompilerOption in their tsconfig file when using ng_module #28995 https://github.com/angular/angular/pull/28995
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/f4f2e48c5281ea0ec5ba0eeaf56d1ca341524c8d..aebd03aac0d63f55db265a02e4c8e29c0145ce0b
f4f2e48https://github.com/angular/angular/commit/f4f2e48c5281ea0ec5ba0eeaf56d1ca341524c8d
aebd03ahttps://github.com/angular/angular/commit/aebd03aac0d63f55db265a02e4c8e29c0145ce0b
Compare https://github.com/angular/angular/compare/f4f2e48c5281ea0ec5ba0eeaf56d1ca341524c8d..aebd03aac0d63f55db265a02e4c8e29c0145ce0b
February 27, 2019 21:01https://github.com/angular/angular/pull/28689#event-2169230153
https://github.com/ocombe
ocombehttps://github.com/ocombe
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Feb 27, 2019https://github.com/angular/angular/pull/28689#event-2169230660
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Apr 4, 2019https://github.com/angular/angular/pull/28689#event-2253612924
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/7618e6a46dde3b71b7d9ae473bc5282f5809c64f..3afbb982ffb7fecaa027a3f1b2ca470ebf75419f
7618e6ahttps://github.com/angular/angular/commit/7618e6a46dde3b71b7d9ae473bc5282f5809c64f
3afbb98https://github.com/angular/angular/commit/3afbb982ffb7fecaa027a3f1b2ca470ebf75419f
Compare https://github.com/angular/angular/compare/7618e6a46dde3b71b7d9ae473bc5282f5809c64f..3afbb982ffb7fecaa027a3f1b2ca470ebf75419f
April 5, 2019 16:20https://github.com/angular/angular/pull/28689#event-2256303075
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Apr 5, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-223454177
View reviewed changes https://github.com/angular/angular/pull/28689/files
https://github.com/ocombe
ocombehttps://github.com/ocombe
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 5, 2019https://github.com/angular/angular/pull/28689#event-2256885935
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Apr 5, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-223481782
View reviewed changes https://github.com/angular/angular/pull/28689/files
IgorMinarhttps://github.com/IgorMinar
https://github.com/angular/angular/pull/28689#pullrequestreview-223481782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
integration/cli-hello-world-ivy-compat/package.jsonhttps://github.com/angular/angular/pull/28689/files#diff-af5d30ffdd3aa9e61746ed60c71f3789eb3022e3a72b7db1d3d5306117df13ee
IgorMinarhttps://github.com/IgorMinar
Apr 5, 2019https://github.com/angular/angular/pull/28689#discussion_r272745771
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
ocombehttps://github.com/ocombe
Apr 5, 2019https://github.com/angular/angular/pull/28689#discussion_r272761950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
IgorMinarhttps://github.com/IgorMinar
Apr 9, 2019https://github.com/angular/angular/pull/28689#discussion_r273286651
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
integration/cli-hello-world-ivy-compat/yarn.lockhttps://github.com/angular/angular/pull/28689/files#diff-2c8ca5602d98fa3ebd628165bce74a9c35e0d0f03677f3b60e72530d7bc4d961
Please reload this pagehttps://github.com/angular/angular/pull/28689
integration/cli-hello-world-ivy-minimal/package.jsonhttps://github.com/angular/angular/pull/28689/files#diff-0bc229383df02ece4d269dc9e2ec9d18d2a57a8a82c369386e511a6ed21b949c
Please reload this pagehttps://github.com/angular/angular/pull/28689
integration/cli-hello-world-ivy-minimal/yarn.lockhttps://github.com/angular/angular/pull/28689/files#diff-200ef27aa8c2ddb976223d89923db890292598d4c4b074c569c2c5aa261f2f36
Please reload this pagehttps://github.com/angular/angular/pull/28689
packages/core/test/bundling/todo_i18n/index.tshttps://github.com/angular/angular/pull/28689/files#diff-bf5164d4fae0ce16eaef94d26edf7233166f6694eb1c80cb78d2e6426acd1bef
IgorMinarhttps://github.com/IgorMinar
Apr 5, 2019https://github.com/angular/angular/pull/28689#discussion_r272749174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
ocombehttps://github.com/ocombe
Apr 5, 2019https://github.com/angular/angular/pull/28689#discussion_r272761851
Please reload this pagehttps://github.com/angular/angular/pull/28689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
IgorMinarhttps://github.com/IgorMinar
Apr 9, 2019https://github.com/angular/angular/pull/28689#discussion_r273287019
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
ocombehttps://github.com/ocombe
Apr 9, 2019https://github.com/angular/angular/pull/28689#discussion_r273656085
Please reload this pagehttps://github.com/angular/angular/pull/28689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
integration/_payload-limits.jsonhttps://github.com/angular/angular/pull/28689/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
Apr 5, 2019https://github.com/angular/angular/pull/28689#issuecomment-480443013
@IgorMinarhttps://github.com/IgorMinar
angular/angular-cli#13905https://github.com/angular/angular-cli/pull/13905
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 8, 2019https://github.com/angular/angular/pull/28689#event-2258916135
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/32d86957ed8489b61b3e3ad61410b9071ededf4f..29445e6f6e875e1f932672abea69d8b13b4256da
32d8695https://github.com/angular/angular/commit/32d86957ed8489b61b3e3ad61410b9071ededf4f
29445e6https://github.com/angular/angular/commit/29445e6f6e875e1f932672abea69d8b13b4256da
Compare https://github.com/angular/angular/compare/32d86957ed8489b61b3e3ad61410b9071ededf4f..29445e6f6e875e1f932672abea69d8b13b4256da
April 8, 2019 08:46https://github.com/angular/angular/pull/28689#event-2258944105
https://github.com/ocombe
ocombehttps://github.com/ocombe
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 8, 2019https://github.com/angular/angular/pull/28689#event-2258996156
https://github.com/ocombe
ocombehttps://github.com/ocombe
IgorMinarhttps://github.com/IgorMinar
April 8, 2019 09:05https://github.com/angular/angular/pull/28689#event-2258997250
https://github.com/ocombe
ocombehttps://github.com/ocombe
Apr 8, 2019https://github.com/angular/angular/pull/28689#issuecomment-480748767
@IgorMinarhttps://github.com/IgorMinar
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
IgorMinarhttps://github.com/IgorMinar
alxhubhttps://github.com/alxhub
IgorMinarhttps://github.com/IgorMinar
April 8, 2019 13:29https://github.com/angular/angular/pull/28689#event-2259687760
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Apr 8, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-223880354
View reviewed changes https://github.com/angular/angular/pull/28689/files
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Apr 9, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-224147241
View reviewed changes https://github.com/angular/angular/pull/28689/files
IgorMinarhttps://github.com/IgorMinar
https://github.com/angular/angular/pull/28689#pullrequestreview-224147241
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Apr 9, 2019https://github.com/angular/angular/pull/28689#event-2261345982
https://github.com/ocombe
ocombehttps://github.com/ocombe
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Apr 9, 2019https://github.com/angular/angular/pull/28689#event-2263909045
https://github.com/kara
karahttps://github.com/kara
Apr 9, 2019https://github.com/angular/angular/pull/28689#issuecomment-481397244
presubmithttp://test/OCL:242713975:BASE:242714971:1554837219843:3c6df3f6
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/129e4c73e221b727e89827e78daf3b585fbe0509..092e71b771add66174b876696e4429443e457c0a
129e4c7https://github.com/angular/angular/commit/129e4c73e221b727e89827e78daf3b585fbe0509
092e71bhttps://github.com/angular/angular/commit/092e71b771add66174b876696e4429443e457c0a
Compare https://github.com/angular/angular/compare/129e4c73e221b727e89827e78daf3b585fbe0509..092e71b771add66174b876696e4429443e457c0a
April 11, 2019 09:18https://github.com/angular/angular/pull/28689#event-2268588871
https://github.com/ocombe
feat(ivy): support i18n without closurehttps://github.com/angular/angular/pull/28689/commits/02a6546bd783f2ee2e11824c6a3ada36a647bd34
02a6546https://github.com/angular/angular/pull/28689/commits/02a6546bd783f2ee2e11824c6a3ada36a647bd34
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Apr 11, 2019 https://github.com/angular/angular/pull/28689#pullrequestreview-225593752
View reviewed changes https://github.com/angular/angular/pull/28689/files/02a6546bd783f2ee2e11824c6a3ada36a647bd34
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Apr 11, 2019https://github.com/angular/angular/pull/28689#issuecomment-482151998
http://test/OCL:243069482:BASE:243069609:1554994952547:fae7a7a0http://test/OCL:243069482:BASE:243069609:1554994952547:fae7a7a0
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Apr 16, 2019 https://github.com/angular/angular/pull/28689#ref-pullrequest-433858189
fix(core): use shakeable global definitions #29929 https://github.com/angular/angular/pull/29929
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/28689#issuecomment-531521116
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28689
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/28689/files/29445e6f6e875e1f932672abea69d8b13b4256da
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/28689/files/7217a6c5e4051130a092a6059ac4ec0bc124c5ba
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/28689/files/7aa1a763c07a86a44bc2607d0fd63389bfbf797b
https://github.com/mhevery
mhevery https://github.com/mhevery
https://github.com/angular/angular/pull/28689/files/3afbb982ffb7fecaa027a3f1b2ca470ebf75419f
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/28689/files/02a6546bd783f2ee2e11824c6a3ada36a647bd34
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/mhevery
mhevery https://github.com/mhevery
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/28689
https://github.com/ocombe
https://github.com/gregmagolan
https://github.com/AndrewKushnir
https://github.com/cexbrayat
https://github.com/kara
https://github.com/IgorMinar
https://github.com/petebacondarwin
https://github.com/mhevery
https://github.com/alxhub
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.