| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7eb67d08-dc89-d00a-5105-1273fd870aba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB68:369D8B:A1B1E:D5CCA:6B015DF6 |
| html-safe-nonce | 29484fdeb9741e24c19b20327d8bc3626741c07e496c95b2b3ff72ed37ff059a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjY4OjM2OUQ4QjpBMUIxRTpENUNDQTo2QjAxNURGNiIsInZpc2l0b3JfaWQiOiI3MTA0MTkyMjg1MjYwMjA5NjU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 035d5e5c5e8580f11cb4aeacfe938469cb864becc6d8a6f6c550608123d0a225 |
| hovercard-subject-tag | pull_request:251314637 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/28609/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7db86dc2e01ab0b3e98eb61b0ec8806817a604fec980884900d696a0d17d42f1/angular/angular/pull/28609 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7db86dc2e01ab0b3e98eb61b0ec8806817a604fec980884900d696a0d17d42f1/angular/angular/pull/28609 |
| og:image:alt | The setUpLocationSync function in @angular/router/upgrade didn't previously let you sync hash-based navigations. With this change, you can now pass an option to setUpLocationSync that will make... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasonaden |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/28609#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28609 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28609 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/28609 |
| Reload | https://github.com/angular/angular/pull/28609 |
| Reload | https://github.com/angular/angular/pull/28609 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| jasonaden | https://github.com/jasonaden |
| angular:master | https://github.com/angular/angular/tree/master |
| jasonaden:FW-241_location_sync_code | https://github.com/jasonaden/angular/tree/FW-241_location_sync_code |
| Conversation | https://github.com/angular/angular/pull/28609 |
| Commits2 (2) | https://github.com/angular/angular/pull/28609/commits |
| Checks | https://github.com/angular/angular/pull/28609/checks |
| Files changed | https://github.com/angular/angular/pull/28609/files |
| feat(router): add hash-based navigation option to setUpLocationSync | https://github.com/angular/angular/pull/28609#top |
| jasonaden | https://github.com/jasonaden |
| angular:master | https://github.com/angular/angular/tree/master |
| jasonaden:FW-241_location_sync_code | https://github.com/jasonaden/angular/tree/FW-241_location_sync_code |
|
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| Feb 8, 2019 | https://github.com/angular/angular/pull/28609#issue-407955292 |
| #24429 | https://github.com/angular/angular/issues/24429 |
| #21995 | https://github.com/angular/angular/issues/21995 |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| February 8, 2019 00:17 | https://github.com/angular/angular/pull/28609#event-2125918229 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Feb 8, 2019 | https://github.com/angular/angular/pull/28609#event-2125918479 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Feb 8, 2019
| https://github.com/angular/angular/pull/28609#pullrequestreview-201386169 |
|
View reviewed changes
| https://github.com/angular/angular/pull/28609/files |
| packages/router/upgrade/test/upgrade.spec.ts | https://github.com/angular/angular/pull/28609/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7 |
| IgorMinar | https://github.com/IgorMinar |
| Feb 8, 2019 | https://github.com/angular/angular/pull/28609#discussion_r254917963 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Feb 8, 2019
| https://github.com/angular/angular/pull/28609#pullrequestreview-201386700 |
|
View reviewed changes
| https://github.com/angular/angular/pull/28609/files |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/28609#pullrequestreview-201386700 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| force-pushed | https://github.com/angular/angular/compare/05940efa7a415dcfa532fda531c4790290348d68..7176dc3d0a32f20d1fe06d6d0dc94ee133cfaf43 |
| 05940ef | https://github.com/angular/angular/commit/05940efa7a415dcfa532fda531c4790290348d68 |
| 7176dc3 | https://github.com/angular/angular/commit/7176dc3d0a32f20d1fe06d6d0dc94ee133cfaf43 |
|
Compare
| https://github.com/angular/angular/compare/05940efa7a415dcfa532fda531c4790290348d68..7176dc3d0a32f20d1fe06d6d0dc94ee133cfaf43 |
| February 8, 2019 00:20 | https://github.com/angular/angular/pull/28609#event-2125927083 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
| Feb 8, 2019 | https://github.com/angular/angular/pull/28609#event-2128401789 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Feb 8, 2019 | https://github.com/angular/angular/pull/28609#event-2128401839 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| force-pushed | https://github.com/angular/angular/compare/7176dc3d0a32f20d1fe06d6d0dc94ee133cfaf43..515ae500cd6773818eeefaaf551aa11f9ba48294 |
| 7176dc3 | https://github.com/angular/angular/commit/7176dc3d0a32f20d1fe06d6d0dc94ee133cfaf43 |
| 515ae50 | https://github.com/angular/angular/commit/515ae500cd6773818eeefaaf551aa11f9ba48294 |
|
Compare
| https://github.com/angular/angular/compare/7176dc3d0a32f20d1fe06d6d0dc94ee133cfaf43..515ae500cd6773818eeefaaf551aa11f9ba48294 |
| February 13, 2019 01:11 | https://github.com/angular/angular/pull/28609#event-2135407368 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| Feb 14, 2019 | https://github.com/angular/angular/pull/28609#issuecomment-463711694 |
| Presubmit | http://test/OCL:233968494:BASE:233968512:1550164502126:69641ae6 |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28609#event-2150420508 |
| jasonaden | https://github.com/jasonaden |
| February 19, 2019 15:19 | https://github.com/angular/angular/pull/28609#commits-pushed-67c682c |
|
| https://github.com/jasonaden |
| feat(router): add hash-based navigation option to setUpLocationSync | https://github.com/angular/angular/pull/28609/commits/67c682c71c14533c4fa99f9b0bc8199547851d60 |
| 67c682c | https://github.com/angular/angular/pull/28609/commits/67c682c71c14533c4fa99f9b0bc8199547851d60 |
| angular#24429 | https://github.com/angular/angular/issues/24429 |
| angular#21995 | https://github.com/angular/angular/issues/21995 |
|
| https://github.com/jasonaden |
| fixup! feat(router): add hash-based navigation option to setUpLocatio… | https://github.com/angular/angular/pull/28609/commits/3a58bcc6973718131c8b59b03041eb1e01e00d74 |
| 3a58bcc | https://github.com/angular/angular/pull/28609/commits/3a58bcc6973718131c8b59b03041eb1e01e00d74 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| force-pushed | https://github.com/angular/angular/compare/515ae500cd6773818eeefaaf551aa11f9ba48294..3a58bcc6973718131c8b59b03041eb1e01e00d74 |
| 515ae50 | https://github.com/angular/angular/commit/515ae500cd6773818eeefaaf551aa11f9ba48294 |
| 3a58bcc | https://github.com/angular/angular/commit/3a58bcc6973718131c8b59b03041eb1e01e00d74 |
|
Compare
| https://github.com/angular/angular/compare/515ae500cd6773818eeefaaf551aa11f9ba48294..3a58bcc6973718131c8b59b03041eb1e01e00d74 |
| February 19, 2019 23:19 | https://github.com/angular/angular/pull/28609#event-2150421820 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Feb 19, 2019 | https://github.com/angular/angular/pull/28609#event-2150484515 |
| IgorMinar | https://github.com/IgorMinar |
|
Feb 20, 2019
| https://github.com/angular/angular/pull/28609#ref-commit-fc895ba |
|
| https://github.com/jasonaden |
|
| https://github.com/IgorMinar |
| feat(router): add hash-based navigation option to setUpLocationSync ( | https://github.com/angular/angular/commit/fc895ba1893d08813f931c8794c7db97782f1c36 |
| #… | https://github.com/angular/angular/pull/28609 |
| fc895ba | https://github.com/angular/angular/commit/fc895ba1893d08813f931c8794c7db97782f1c36 |
| …28609 | https://github.com/angular/angular/pull/28609 |
| #24429 | https://github.com/angular/angular/issues/24429 |
| #21995 | https://github.com/angular/angular/issues/21995 |
| #28609 | https://github.com/angular/angular/pull/28609 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| 71d0eeb | https://github.com/angular/angular/commit/71d0eeb966843d372068bf69489da278ff7969fb |
| Feb 20, 2019 | https://github.com/angular/angular/pull/28609#event-2150520661 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Feb 20, 2019
| https://github.com/angular/angular/pull/28609#pullrequestreview-205710959 |
|
View reviewed changes
| https://github.com/angular/angular/pull/28609/files/3a58bcc6973718131c8b59b03041eb1e01e00d74 |
| packages/router/upgrade/src/upgrade.ts | https://github.com/angular/angular/pull/28609/files/3a58bcc6973718131c8b59b03041eb1e01e00d74#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
| gkalpak | https://github.com/gkalpak |
| Feb 20, 2019 | https://github.com/angular/angular/pull/28609#discussion_r258443765 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Feb 20, 2019
| https://github.com/angular/angular/pull/28609#pullrequestreview-205711246 |
|
View reviewed changes
| https://github.com/angular/angular/pull/28609/files/3a58bcc6973718131c8b59b03041eb1e01e00d74 |
| packages/router/upgrade/src/upgrade.ts | https://github.com/angular/angular/pull/28609/files/3a58bcc6973718131c8b59b03041eb1e01e00d74#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4 |
| gkalpak | https://github.com/gkalpak |
| Feb 20, 2019 | https://github.com/angular/angular/pull/28609#discussion_r258444010 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
| IgorMinar | https://github.com/IgorMinar |
|
Feb 20, 2019
| https://github.com/angular/angular/pull/28609#ref-commit-843fc7d |
|
| https://github.com/IgorMinar |
| Revert "feat(router): add hash-based navigation option to setUpLocati… | https://github.com/angular/angular/commit/843fc7df9f4e9841f8e566f6f62136c07a432a53 |
| 843fc7d | https://github.com/angular/angular/commit/843fc7df9f4e9841f8e566f6f62136c07a432a53 |
| #28609 | https://github.com/angular/angular/pull/28609 |
| fc895ba | https://github.com/angular/angular/commit/fc895ba1893d08813f931c8794c7db97782f1c36 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
Feb 26, 2019
| https://github.com/angular/angular/pull/28609#ref-issue-293963468 |
|
Add location sync code for hash-based navigation from AngularJS
#21995
| https://github.com/angular/angular/issues/21995 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/28609#issuecomment-531499878 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/28609#event-2634256388 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28609 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/28609/files/3a58bcc6973718131c8b59b03041eb1e01e00d74 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/28609/files/05940efa7a415dcfa532fda531c4790290348d68 |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
Some location change events are no longer after router upgrade
| https://github.com/angular/angular/issues/24429 |
| Please reload this page | https://github.com/angular/angular/pull/28609 |
|
| https://github.com/jasonaden |
|
| https://github.com/IgorMinar |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |