René's URL Explorer Experiment


Title: fix(ivy): sanitize external i18n ids before generating const names by AndrewKushnir · Pull Request #28522 · angular/angular · GitHub

Open Graph Title: fix(ivy): sanitize external i18n ids before generating const names by AndrewKushnir · Pull Request #28522 · angular/angular

X Title: fix(ivy): sanitize external i18n ids before generating const names by AndrewKushnir · Pull Request #28522 · angular/angular

Description: Prior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were causing issues while executing generated code. This commit adds sanitization to i18n ids used to generate i18n-related consts. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: Prior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were causing issues wh...

X Description: Prior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were causing issues wh...

Opengraph URL: https://github.com/angular/angular/pull/28522

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9cada87f-bc12-ea2c-d918-34026376025d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAED4:19AA62:169BAB1:1CBD2E9:6B01368D
html-safe-nonce7583a56d284bf8c255c1f76ca5fdd964656da91a3827ae6480e3349c9f96b275
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUQ0OjE5QUE2MjoxNjlCQUIxOjFDQkQyRTk6NkIwMTM2OEQiLCJ2aXNpdG9yX2lkIjoiMTkwNjMxNjkxNTM4Nzc0MTgzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac627d9557b6ec85cdd107cb3a49c4562cafe17507a3e5c9a074c479051e5c4b94
hovercard-subject-tagpull_request:250157778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/28522/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altPrior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were causing issues wh...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/28522/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28522%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28522%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/28522/files
Reloadhttps://github.com/angular/angular/pull/28522/files
Reloadhttps://github.com/angular/angular/pull/28522/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:i18n_const_name_sanitizationhttps://github.com/AndrewKushnir/angular/tree/i18n_const_name_sanitization
Conversation 2 https://github.com/angular/angular/pull/28522
Commits 2 https://github.com/angular/angular/pull/28522/commits
Checks 0 https://github.com/angular/angular/pull/28522/checks
Files changed https://github.com/angular/angular/pull/28522/files
Please reload this pagehttps://github.com/angular/angular/pull/28522/files
fix(ivy): sanitize external i18n ids before generating const names https://github.com/angular/angular/pull/28522/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/28522/files
db63be5 fix(ivy): sanitize external i18n ids before generating const names AndrewKushnir Jan 12, 2019 https://github.com/angular/angular/pull/28522/commits/db63be59b9e9af758b36e4bb54e4fcc60a573d61
9d73260 fixup! fix(ivy): sanitize external i18n ids before generating const n… AndrewKushnir Feb 4, 2019 https://github.com/angular/angular/pull/28522/commits/9d732605ac48f5895767f7342a8ff7564a9bc823
Clear filters https://github.com/angular/angular/pull/28522/files
Please reload this pagehttps://github.com/angular/angular/pull/28522/files
Please reload this pagehttps://github.com/angular/angular/pull/28522/files
r3_view_compiler_i18n_spec.ts https://github.com/angular/angular/pull/28522/files#diff-7495cab50a7476c35b95a324c75e8dc0acc63211aa56d3b5ae70b95bab0f0e1e
template.ts https://github.com/angular/angular/pull/28522/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
packages/compiler-cli/test/compliance/r3_view_compiler_i18n_spec.tshttps://github.com/angular/angular/pull/28522/files#diff-7495cab50a7476c35b95a324c75e8dc0acc63211aa56d3b5ae70b95bab0f0e1e
View file https://github.com/AndrewKushnir/angular/blob/9d732605ac48f5895767f7342a8ff7564a9bc823/packages/compiler-cli/test/compliance/r3_view_compiler_i18n_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28522/{{ revealButtonHref }}
https://github.com/angular/angular/pull/28522/files#diff-7495cab50a7476c35b95a324c75e8dc0acc63211aa56d3b5ae70b95bab0f0e1e
https://github.com/angular/angular/pull/28522/files#diff-7495cab50a7476c35b95a324c75e8dc0acc63211aa56d3b5ae70b95bab0f0e1e
https://github.com/angular/angular/pull/28522/files#diff-7495cab50a7476c35b95a324c75e8dc0acc63211aa56d3b5ae70b95bab0f0e1e
https://github.com/angular/angular/pull/28522/files#diff-7495cab50a7476c35b95a324c75e8dc0acc63211aa56d3b5ae70b95bab0f0e1e
packages/compiler/src/render3/view/template.tshttps://github.com/angular/angular/pull/28522/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
View file https://github.com/AndrewKushnir/angular/blob/9d732605ac48f5895767f7342a8ff7564a9bc823/packages/compiler/src/render3/view/template.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28522/{{ revealButtonHref }}
https://github.com/angular/angular/pull/28522/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/28522/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.