René's URL Explorer Experiment


Title: fix(ivy): sanitize external i18n ids before generating const names by AndrewKushnir · Pull Request #28522 · angular/angular · GitHub

Open Graph Title: fix(ivy): sanitize external i18n ids before generating const names by AndrewKushnir · Pull Request #28522 · angular/angular

X Title: fix(ivy): sanitize external i18n ids before generating const names by AndrewKushnir · Pull Request #28522 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Prior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were causing issues wh...

X Description: Prior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were causing issues wh...

Opengraph URL: https://github.com/angular/angular/pull/28522

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:caaf673d-ad97-62e4-6b77-8fed170a84bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88C0:2D2F2F:16F4170:1D692E4:6B0128F6
html-safe-noncedb48def86c67c923624257005e90fac20306c2562ee6b3decdf0828fd295667d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEMwOjJEMkYyRjoxNkY0MTcwOjFENjkyRTQ6NkIwMTI4RjYiLCJ2aXNpdG9yX2lkIjoiMjI1MDM0NDIwMzgxOTIzMTQ3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca4d18e371e6b1a67c6a03f8db21ba38839ca4c0bb39d347b84f40568046eb28e
hovercard-subject-tagpull_request:250157778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/28522/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0384af79b849411e3a62946c33283d5725af5ac5205b9ab17ef23cbd9c87609e/angular/angular/pull/28522
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0384af79b849411e3a62946c33283d5725af5ac5205b9ab17ef23cbd9c87609e/angular/angular/pull/28522
og:image:altPrior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were causing issues wh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/28522#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28522
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28522
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/28522
Reloadhttps://github.com/angular/angular/pull/28522
Reloadhttps://github.com/angular/angular/pull/28522
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:i18n_const_name_sanitizationhttps://github.com/AndrewKushnir/angular/tree/i18n_const_name_sanitization
Conversationhttps://github.com/angular/angular/pull/28522
Commits2 (2)https://github.com/angular/angular/pull/28522/commits
Checkshttps://github.com/angular/angular/pull/28522/checks
Files changedhttps://github.com/angular/angular/pull/28522/files
fix(ivy): sanitize external i18n ids before generating const nameshttps://github.com/angular/angular/pull/28522#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:i18n_const_name_sanitizationhttps://github.com/AndrewKushnir/angular/tree/i18n_const_name_sanitization
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 4, 2019https://github.com/angular/angular/pull/28522#issue-406466305
Please reload this pagehttps://github.com/angular/angular/pull/28522
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Feb 4, 2019https://github.com/angular/angular/pull/28522#event-2116531159
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
ocombehttps://github.com/ocombe
February 4, 2019 18:46https://github.com/angular/angular/pull/28522#event-2116531189
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Feb 4, 2019https://github.com/angular/angular/pull/28522#event-2116531265
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 4, 2019https://github.com/angular/angular/pull/28522#event-2116531345
https://github.com/ocombe
ocombehttps://github.com/ocombe
Feb 5, 2019 https://github.com/angular/angular/pull/28522#pullrequestreview-200083814
View reviewed changes https://github.com/angular/angular/pull/28522/files
AndrewKushnirhttps://github.com/AndrewKushnir
February 5, 2019 12:27https://github.com/angular/angular/pull/28522#commits-pushed-db63be5
https://github.com/AndrewKushnir
fix(ivy): sanitize external i18n ids before generating const nameshttps://github.com/angular/angular/pull/28522/commits/db63be59b9e9af758b36e4bb54e4fcc60a573d61
https://github.com/angular/angular/commit/db63be59b9e9af758b36e4bb54e4fcc60a573d61#comments
db63be5https://github.com/angular/angular/pull/28522/commits/db63be59b9e9af758b36e4bb54e4fcc60a573d61
https://github.com/AndrewKushnir
fixup! fix(ivy): sanitize external i18n ids before generating const n…https://github.com/angular/angular/pull/28522/commits/9d732605ac48f5895767f7342a8ff7564a9bc823
9d73260https://github.com/angular/angular/pull/28522/commits/9d732605ac48f5895767f7342a8ff7564a9bc823
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/b1d956c26dd6a9c69985e3ed24b822272d0b6602..9d732605ac48f5895767f7342a8ff7564a9bc823
b1d956chttps://github.com/angular/angular/commit/b1d956c26dd6a9c69985e3ed24b822272d0b6602
9d73260https://github.com/angular/angular/commit/9d732605ac48f5895767f7342a8ff7564a9bc823
Compare https://github.com/angular/angular/compare/b1d956c26dd6a9c69985e3ed24b822272d0b6602..9d732605ac48f5895767f7342a8ff7564a9bc823
February 5, 2019 20:27https://github.com/angular/angular/pull/28522#event-2119573312
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 5, 2019https://github.com/angular/angular/pull/28522#issuecomment-460817669
Please reload this pagehttps://github.com/angular/angular/pull/28522
Presubmithttps://test.corp.google.com/ui#id=OCL:232550967:BASE:232568495:1549408678050:660b6250
Please reload this pagehttps://github.com/angular/angular/pull/28522
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Feb 5, 2019 https://github.com/angular/angular/pull/28522#pullrequestreview-200321780
View reviewed changes https://github.com/angular/angular/pull/28522/files/9d732605ac48f5895767f7342a8ff7564a9bc823
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Feb 6, 2019https://github.com/angular/angular/pull/28522#event-2120007152
https://github.com/matsko
matskohttps://github.com/matsko
3f73dfahttps://github.com/angular/angular/commit/3f73dfa151dade9ab45599de71e20cbf283092b6
Feb 6, 2019https://github.com/angular/angular/pull/28522#event-2120286140
https://github.com/cexbrayat
cexbrayathttps://github.com/cexbrayat
Feb 6, 2019 https://github.com/angular/angular/pull/28522#ref-issue-398326006
ivy: i18n messages identifiers have dots in their name #28080 https://github.com/angular/angular/issues/28080
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/28522#issuecomment-531490572
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/28522
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/28522#event-2634201958
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28522
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/28522/files/9d732605ac48f5895767f7342a8ff7564a9bc823
https://github.com/ocombe
ocombe https://github.com/ocombe
https://github.com/angular/angular/pull/28522/files/b1d956c26dd6a9c69985e3ed24b822272d0b6602
Please reload this pagehttps://github.com/angular/angular/pull/28522
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/28522
https://github.com/AndrewKushnir
https://github.com/alfaproject
https://github.com/ocombe
https://github.com/alxhub
https://github.com/Jclove93
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.