René's URL Explorer Experiment


Title: feat(docs-infra): add debouncing in storing scroll position by wKoza · Pull Request #28368 · angular/angular · GitHub

Open Graph Title: feat(docs-infra): add debouncing in storing scroll position by wKoza · Pull Request #28368 · angular/angular

X Title: feat(docs-infra): add debouncing in storing scroll position by wKoza · Pull Request #28368 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #28332 There is no debouncing when we store the scroll Position; Chrome seems not happy with that: We have a message in the console after a while: Throttling history state changes to prevent the browser from hanging. FYI : https://bugs.chromium.org/p/chromium/issues/detail?id=786211 https://codereview.chromium.org/2972073002/#ps1 // TODO(crbug.com/394296): This is not the long-term fix to IPC flooding that we // need. However, it does mitigate the immediate concern of \|pushState\| DoS // (assuming the renderer has not been compromised). bool History::IsHostFloodingPushState(const String& hostname) const { const int kHostPushStateLimit = 50; const HostLimit& current = host_limits.at(hostname); if (current.first > kHostPushStateLimit) { const double kHostPushStateLimitResetSeconds = 10.0; double now = MonotonicallyIncreasingTime(); if (now - current.second > kHostPushStateLimitResetSeconds) { host_limits.Set(hostname, HostLimit{0, now}); } return true; } host_limits.Set(hostname, HostLimit{current.first + 1, current.second}); return false; } What is the new behavior? There is now a debouncing before we store the scroll Position; Remove unnecessary(?) try/catch block Avoid a race-condition with navigating forward/back and immediately reloading Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/28368

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a7d499b3-9f40-ce76-4e9c-5a3d45b67627
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84EE:24A0A:DA6043:112AF91:6B013640
html-safe-nonce3e871f6e0652b45bb4f05b760cda66914214caee5eee9a77dc6fa3fd29546450
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEVFOjI0QTBBOkRBNjA0MzoxMTJBRjkxOjZCMDEzNjQwIiwidmlzaXRvcl9pZCI6IjQwMDg2MzQyNDA2MjY0MDY5NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca70132e18c91e42921c924ba72330e69736b9d306832537dc34457060ba22e0e
hovercard-subject-tagpull_request:247704628
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/28368/files
twitter:imagehttps://avatars.githubusercontent.com/u/11403260?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11403260?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/28368/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28368%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F28368%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/28368/files
Reloadhttps://github.com/angular/angular/pull/28368/files
Reloadhttps://github.com/angular/angular/pull/28368/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
wKozahttps://github.com/wKoza
angular:masterhttps://github.com/angular/angular/tree/master
wKoza:improve_save_scrollhttps://github.com/wKoza/angular/tree/improve_save_scroll
Conversation 44 https://github.com/angular/angular/pull/28368
Commits 4 https://github.com/angular/angular/pull/28368/commits
Checks 0 https://github.com/angular/angular/pull/28368/checks
Files changed https://github.com/angular/angular/pull/28368/files
Please reload this pagehttps://github.com/angular/angular/pull/28368/files
feat(docs-infra): add debouncing in storing scroll position https://github.com/angular/angular/pull/28368/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/28368/files
0f8ce69 feat(docs-infra): add debouncing in storing scroll position wKoza Jan 25, 2019 https://github.com/angular/angular/pull/28368/commits/0f8ce69ea4bb9c56f63bfe3275322f31f2e3e2fd
843667a fix(docs-infra): remove the try catch in the test of the browser's ca… wKoza Jan 25, 2019 https://github.com/angular/angular/pull/28368/commits/843667a1280fe2b9faa2108ff2e7ea4349d507a9
b0677eb fix(docs-infra): avoid a race-condition with navigating forward/back … wKoza Jan 26, 2019 https://github.com/angular/angular/pull/28368/commits/b0677ebc8452ac0953a46f3b63b1e8f1a8b054f0
69401ef fixup! feat(docs-infra): add debouncing in storing scroll position wKoza Feb 5, 2019 https://github.com/angular/angular/pull/28368/commits/69401ef076945e7607cbe1231a5271d8ef624d14
Clear filters https://github.com/angular/angular/pull/28368/files
Please reload this pagehttps://github.com/angular/angular/pull/28368/files
Please reload this pagehttps://github.com/angular/angular/pull/28368/files
app.component.spec.ts https://github.com/angular/angular/pull/28368/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
app.component.ts https://github.com/angular/angular/pull/28368/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce
scroll.service.spec.ts https://github.com/angular/angular/pull/28368/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
scroll.service.ts https://github.com/angular/angular/pull/28368/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
aio/src/app/app.component.spec.tshttps://github.com/angular/angular/pull/28368/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
View file https://github.com/wKoza/angular/blob/69401ef076945e7607cbe1231a5271d8ef624d14/aio/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28368/{{ revealButtonHref }}
https://github.com/angular/angular/pull/28368/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/28368/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
aio/src/app/app.component.tshttps://github.com/angular/angular/pull/28368/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce
View file https://github.com/wKoza/angular/blob/69401ef076945e7607cbe1231a5271d8ef624d14/aio/src/app/app.component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28368/{{ revealButtonHref }}
https://github.com/angular/angular/pull/28368/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce
https://github.com/angular/angular/pull/28368/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce
aio/src/app/shared/scroll.service.spec.tshttps://github.com/angular/angular/pull/28368/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
View file https://github.com/wKoza/angular/blob/69401ef076945e7607cbe1231a5271d8ef624d14/aio/src/app/shared/scroll.service.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28368/{{ revealButtonHref }}
https://github.com/angular/angular/pull/28368/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
https://github.com/angular/angular/pull/28368/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
Please reload this pagehttps://github.com/angular/angular/pull/28368/files
https://github.com/angular/angular/pull/28368/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc
aio/src/app/shared/scroll.service.tshttps://github.com/angular/angular/pull/28368/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
View file https://github.com/wKoza/angular/blob/69401ef076945e7607cbe1231a5271d8ef624d14/aio/src/app/shared/scroll.service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/28368/{{ revealButtonHref }}
https://github.com/angular/angular/pull/28368/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/28368/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/28368/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
wKozahttps://github.com/wKoza
Jan 25, 2019https://github.com/angular/angular/pull/28368/files#r251132434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/28368/files
https://github.com/angular/angular/pull/28368/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com/angular/angular/pull/28368/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.