René's URL Explorer Experiment


Title: refactor: use isObservable provided by rxjs 6.1+ · Pull Request #27668 · angular/angular · GitHub

Open Graph Title: refactor: use isObservable provided by rxjs 6.1+ · Pull Request #27668 · angular/angular

X Title: refactor: use isObservable provided by rxjs 6.1+ · Pull Request #27668 · angular/angular

Description: Refactor common, core, forms, router to use the isObservable method from rxjs 6.1+. Remove the isObservable method from core. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) - removes custom method, removing tests Docs have been added / updated (for bug fixes / features) - removed docs for custom isObservable method, removed method PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: rxjs isObservable also checks list and typeof Observable (additional on top of removed method) What is the current behavior? isObservable is implemented internally Issue Number: N/A What is the new behavior? isObservable is imported from rxjs Does this PR introduce a breaking change? Yes No - I don't believe so Other information Here is the TODO Opening a feature request to find more information and request that isPromise gets the same treatment.

Open Graph Description: Refactor common, core, forms, router to use the isObservable method from rxjs 6.1+. Remove the isObservable method from core. PR Checklist Please check if your PR fulfills the following requirement...

X Description: Refactor common, core, forms, router to use the isObservable method from rxjs 6.1+. Remove the isObservable method from core. PR Checklist Please check if your PR fulfills the following requirement...

Opengraph URL: https://github.com/angular/angular/pull/27668

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c6991334-8fe2-c5b7-2efc-c8d571fbbbbe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD910:1352CE:479564:5DAACF:6B01751D
html-safe-nonce83e791ecf74d0ffdf9a5f4220863f71dadeb7d9b24e7f6abd82fd4510265c758
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTEwOjEzNTJDRTo0Nzk1NjQ6NURBQUNGOjZCMDE3NTFEIiwidmlzaXRvcl9pZCI6IjUwODk1MDU4OTkzMTYzNDQwOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0bbf473c78d9c9d5310bd519d385d05e97f487967a5226733eab756296bccfea
hovercard-subject-tagpull_request:238615927
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/27668/files
twitter:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
og:image:altRefactor common, core, forms, router to use the isObservable method from rxjs 6.1+. Remove the isObservable method from core. PR Checklist Please check if your PR fulfills the following requirement...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/27668/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F27668%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F27668%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/27668/files
Reloadhttps://github.com/angular/angular/pull/27668/files
Reloadhttps://github.com/angular/angular/pull/27668/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ghosthttps://github.com/ghost
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 25 https://github.com/angular/angular/pull/27668
Commits 1 https://github.com/angular/angular/pull/27668/commits
Checks 0 https://github.com/angular/angular/pull/27668/checks
Files changed https://github.com/angular/angular/pull/27668/files
Please reload this pagehttps://github.com/angular/angular/pull/27668/files
refactor: use isObservable provided by rxjs 6.1+ https://github.com/angular/angular/pull/27668/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/27668/files
ae99471 refactor(core): use isObservable provided by rxjs 6.1+ Dec 14, 2018 https://github.com/angular/angular/pull/27668/commits/ae99471e4335b0d17d21fb727e08aca2a391cd8a
Clear filters https://github.com/angular/angular/pull/27668/files
Please reload this pagehttps://github.com/angular/angular/pull/27668/files
Please reload this pagehttps://github.com/angular/angular/pull/27668/files
esm2015.js https://github.com/angular/angular/pull/27668/files#diff-2030a160a839b6c080f8c13d981a3da5761900bd85305185cc07ab545ca9e13d
async_pipe.ts https://github.com/angular/angular/pull/27668/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
core_private_export.ts https://github.com/angular/angular/pull/27668/files#diff-2b5852df25d6ad975ee77aa156106f45e8b17465fd64a0569ef0ed49e3b3a3f0
listener.ts https://github.com/angular/angular/pull/27668/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
BUILD.bazel https://github.com/angular/angular/pull/27668/files#diff-422f83f2e024ef2f3b29010fcb0ea30e3923513695011a56d66401afc781ff3d
lang.ts https://github.com/angular/angular/pull/27668/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
provider.ts https://github.com/angular/angular/pull/27668/files#diff-8f2c2c69cbad5a3d236c02ddc38ed62a5084779c755451815f00bc215fe9a407
lang_spec.ts https://github.com/angular/angular/pull/27668/files#diff-bd407e2399cb7669a960d25c1babdbe660e93ac505e5b6aac00cc5e747cfe656
BUILD.bazel https://github.com/angular/angular/pull/27668/files#diff-4a22c002f368b1e4a166c410f71266dfc03a8fa2e42f73fc241635ac723e72e4
provider_spec.ts https://github.com/angular/angular/pull/27668/files#diff-2813eb0de321576706502f5b1df5918c99908e7b31084ca5d44489101c7ec0bc
validators.ts https://github.com/angular/angular/pull/27668/files#diff-9b7158180baa4cab9fa2e451531c658358a253e496809f3e305e1c15866e711c
collection.ts https://github.com/angular/angular/pull/27668/files#diff-05162dce4e70ffe62d0d0021c3b1bdc02cd49a911a0a874c2adc27a139c8c2a8
integration/side-effects/snapshots/common/esm2015.jshttps://github.com/angular/angular/pull/27668/files#diff-2030a160a839b6c080f8c13d981a3da5761900bd85305185cc07ab545ca9e13d
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/integration/side-effects/snapshots/common/esm2015.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
packages/common/src/pipes/async_pipe.tshttps://github.com/angular/angular/pull/27668/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/common/src/pipes/async_pipe.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/27668/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/27668/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/27668/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
packages/core/src/core_private_export.tshttps://github.com/angular/angular/pull/27668/files#diff-2b5852df25d6ad975ee77aa156106f45e8b17465fd64a0569ef0ed49e3b3a3f0
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/src/core_private_export.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-2b5852df25d6ad975ee77aa156106f45e8b17465fd64a0569ef0ed49e3b3a3f0
packages/core/src/render3/instructions/listener.tshttps://github.com/angular/angular/pull/27668/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/src/render3/instructions/listener.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
https://github.com/angular/angular/pull/27668/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
packages/core/src/util/BUILD.bazelhttps://github.com/angular/angular/pull/27668/files#diff-422f83f2e024ef2f3b29010fcb0ea30e3923513695011a56d66401afc781ff3d
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/src/util/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-422f83f2e024ef2f3b29010fcb0ea30e3923513695011a56d66401afc781ff3d
packages/core/src/util/lang.tshttps://github.com/angular/angular/pull/27668/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/src/util/lang.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
https://github.com/angular/angular/pull/27668/files#diff-9b26deccefd60a31b4bc9b7c5623ddcdc450e297dfac2c4ad4f81d89c528a239
packages/core/src/view/provider.tshttps://github.com/angular/angular/pull/27668/files#diff-8f2c2c69cbad5a3d236c02ddc38ed62a5084779c755451815f00bc215fe9a407
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/src/view/provider.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-8f2c2c69cbad5a3d236c02ddc38ed62a5084779c755451815f00bc215fe9a407
https://github.com/angular/angular/pull/27668/files#diff-8f2c2c69cbad5a3d236c02ddc38ed62a5084779c755451815f00bc215fe9a407
packages/core/test/util/lang_spec.tshttps://github.com/angular/angular/pull/27668/files#diff-bd407e2399cb7669a960d25c1babdbe660e93ac505e5b6aac00cc5e747cfe656
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/test/util/lang_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-bd407e2399cb7669a960d25c1babdbe660e93ac505e5b6aac00cc5e747cfe656
packages/core/test/view/BUILD.bazelhttps://github.com/angular/angular/pull/27668/files#diff-4a22c002f368b1e4a166c410f71266dfc03a8fa2e42f73fc241635ac723e72e4
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/test/view/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-4a22c002f368b1e4a166c410f71266dfc03a8fa2e42f73fc241635ac723e72e4
https://github.com/angular/angular/pull/27668/files#diff-4a22c002f368b1e4a166c410f71266dfc03a8fa2e42f73fc241635ac723e72e4
packages/core/test/view/provider_spec.tshttps://github.com/angular/angular/pull/27668/files#diff-2813eb0de321576706502f5b1df5918c99908e7b31084ca5d44489101c7ec0bc
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/core/test/view/provider_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-2813eb0de321576706502f5b1df5918c99908e7b31084ca5d44489101c7ec0bc
https://github.com/angular/angular/pull/27668/files#diff-2813eb0de321576706502f5b1df5918c99908e7b31084ca5d44489101c7ec0bc
https://github.com/angular/angular/pull/27668/files#diff-2813eb0de321576706502f5b1df5918c99908e7b31084ca5d44489101c7ec0bc
https://github.com/angular/angular/pull/27668/files#diff-2813eb0de321576706502f5b1df5918c99908e7b31084ca5d44489101c7ec0bc
packages/forms/src/validators.tshttps://github.com/angular/angular/pull/27668/files#diff-9b7158180baa4cab9fa2e451531c658358a253e496809f3e305e1c15866e711c
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/forms/src/validators.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-9b7158180baa4cab9fa2e451531c658358a253e496809f3e305e1c15866e711c
https://github.com/angular/angular/pull/27668/files#diff-9b7158180baa4cab9fa2e451531c658358a253e496809f3e305e1c15866e711c
packages/router/src/utils/collection.tshttps://github.com/angular/angular/pull/27668/files#diff-05162dce4e70ffe62d0d0021c3b1bdc02cd49a911a0a874c2adc27a139c8c2a8
View file https://github.com/angular/angular/blob/ae99471e4335b0d17d21fb727e08aca2a391cd8a/packages/router/src/utils/collection.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/27668/{{ revealButtonHref }}
https://github.com/angular/angular/pull/27668/files#diff-05162dce4e70ffe62d0d0021c3b1bdc02cd49a911a0a874c2adc27a139c8c2a8
https://github.com/angular/angular/pull/27668/files#diff-05162dce4e70ffe62d0d0021c3b1bdc02cd49a911a0a874c2adc27a139c8c2a8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.